- 23 Nov, 2018 40 commits
-
-
Rune Lillesveen authored
linux-chromeos-rel currently fails this test. TBR=amistry@chromium.org Bug: 908071 Change-Id: Iff70ff9c3cc4eb455b48f4effaa3befc441d52b4 Reviewed-on: https://chromium-review.googlesource.com/c/1349345Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610609}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38ec294c9aeb..c7c809224d90 Created with: gclient setdep -r src-internal@c7c809224d90 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If21f887196f59b011e76955a84feae53c98cb857 Reviewed-on: https://chromium-review.googlesource.com/c/1349530Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610608}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2ecd5f54..01b0845a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6025e28e8c94a6e54abb1edccf768496a997fd14 Reviewed-on: https://chromium-review.googlesource.com/c/1349490Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610607}
-
Kush Sinha authored
Also add a note about AccountManager::UpsertToken being idempotent. Bug: 904128 Bug: 820046 Change-Id: Ie9cc135edf2afad2d9da3c13df5fbc6fc822c4ad Reviewed-on: https://chromium-review.googlesource.com/c/1349224Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#610606}
-
Matthew Cary authored
Small fix to correct usage of --manual-libname. Change-Id: Idba891ed7e193a42bd355812972f9c649876f214 Reviewed-on: https://chromium-review.googlesource.com/c/1349263Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#610605}
-
Antonio Gomes authored
BUG=907483 Change-Id: Id6b76a8b0d89d4ecb18e1253e6919ab37666b009 Reviewed-on: https://chromium-review.googlesource.com/c/1349590Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#610604}
-
Jonas Olsson authored
Intent to Implement and Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/lxHPNYoaEU8/0JFwF0ipCQAJ Bug: chromium:823144 Change-Id: Ia849f44d1c8898da0fcb8341c8ff56de4de2d815 Reviewed-on: https://chromium-review.googlesource.com/c/1292560 Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610603}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4ed4737007d8..43e8ebcaf284 git log 4ed4737007d8..43e8ebcaf284 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 perezju@chromium.org [soundwave] Use /timeseries2 to fetch data on -i option 2018-11-23 perezju@chromium.org [soundwave] On finalization terminate pool, don't close. Created with: gclient setdep -r src/third_party/catapult@43e8ebcaf284 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900218,chromium:907885 TBR=sullivan@chromium.org Change-Id: Id2475cd9a73b69a2231b508deb72467107836bd6 Reviewed-on: https://chromium-review.googlesource.com/c/1349434Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610602}
-
Leszek Swirski authored
This is a reland of 7c10d9bb. We just need to add SlowTest entries for the failing tests (already done for default) Original change's description: > Revert virtual test-suite for streaming-preload. > > Causes too many timeout issues for WebKit Linux Trusty MSAN. > > This reverts the virtual suite part of [1]. > > [1] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa > > TBR=leszeks@chromium.org > > Bug: 908060 > Change-Id: I50111b8a5dc93a29078a0e9f77feefc1a960bedd > Reviewed-on: https://chromium-review.googlesource.com/c/1349222 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610589} TBR=leszeks@chromium.org,futhark@chromium.org Change-Id: Id7486a144dcf5a93c5c2521d36dec62bc91e34f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908060 Reviewed-on: https://chromium-review.googlesource.com/c/1349266Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#610601}
-
Greg Thompson authored
BUG=907979 Change-Id: I8922218a0488eee539a5f3814de3dee9c58e31e0 Reviewed-on: https://chromium-review.googlesource.com/c/1349339 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#610600}
-
Mathias Carlen authored
Before this patch, we used the chrome custom tab activity instead of the ChromeActivity base activity. This will prevent us to introduce Autofill Assistant other flavors than CCT. This patch reverts to ChromeActivity. The one caveat is that CCT's finish() does a little more cleanup compared to ChromeActivity, but the behavior for the cases we tested is the same. Bug: 806868 Change-Id: I77e99419738f41f0dbaaa5cbb3bb0f64f8c9a37c Reviewed-on: https://chromium-review.googlesource.com/c/1348114 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610599}
-
Lukasz Suder authored
Comparing just title is fragile (e.g. different languages), therefore we allow specifing the mid inside parameters. Bug: 806868 Change-Id: Ie5790beb6cb06bc4c124ae7a969c2263a77fc2cf Reviewed-on: https://chromium-review.googlesource.com/c/1349335 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
-
Dave Tapuska authored
maxActions is defined in the IDL as a 32 bit integer, return it as such. BUG=879657 Change-Id: If389a010dc5b098095b95674ef017742e787da52 Reviewed-on: https://chromium-review.googlesource.com/c/1348867Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610597}
-
Nikita Podguzov authored
Add support for External Data referenced by Device Policy. Use the new support to implement the DeviceNativePrinters policy. Add browser test verifying external data cache is cleaned up after policy was changed or removed. Bug: 807068 Change-Id: Ib98778a438e929a78214d1d9ab066a41a6bdcf09 Reviewed-on: https://chromium-review.googlesource.com/c/1335592 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#610596}
-
Ross McIlroy authored
BUG=v8:7290,v8:8238 Change-Id: I4e44d97dfde85b471ed4e6b38f4e32374462de95 Reviewed-on: https://chromium-review.googlesource.com/c/1349342Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#610595}
-
Daniel Bratell authored
In some (non default) jumbo configurations, strike.cc and legacy_strike_database.cc compile in the same translation unit and then some constants clash. Assuming LegacyStrikeDatabase will soon go away, just give its constants a bit longer names. Bug: 884817 Change-Id: I1dc6d8b6499d3c6195a56423236198a02c32f3f0 Reviewed-on: https://chromium-review.googlesource.com/c/1348471 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#610594}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f2ffeec22d1..b357e54dd5b2 git log 5f2ffeec22d1..b357e54dd5b2 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 crodbro@webrtc.org Add field trial config to disable pacer emergency stops. 2018-11-23 nisse@webrtc.org Delete unused method NetEq::PacketBufferStatistics Created with: gclient setdep -r src/third_party/webrtc@b357e54dd5b2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ieeed6f4e6266cbd13ef650aa146a743beabb6046 Reviewed-on: https://chromium-review.googlesource.com/c/1349433Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e92c674abcb9..246e02474676 git log e92c674abcb9..246e02474676 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 treehugger-gerrit@google.com Merge "Fix GCC build" 2018-11-23 hjd@google.com traced_probes: Fixes to run_ftrace_proto_gen Created with: gclient setdep -r src/third_party/perfetto@246e02474676 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia46ab0bde1ef9122bedda8a9effda21411511877 Reviewed-on: https://chromium-review.googlesource.com/c/1349432Reviewed-by:
-
Marc Treib authored
https://crrev.com/c/1343087 rewrote that function, and inadvertently removed a null check that turns out to actually be necessary. Bug: 908055 Change-Id: Ibaaa6fc27cebb4c1af0f03661ee143ef468f59ae Reviewed-on: https://chromium-review.googlesource.com/c/1349220 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610591}
-
Javier Ernesto Flores Robles authored
Bug: 908063 Change-Id: I838f89b608682cea4e8c83c7d00271550eef9132 Reviewed-on: https://chromium-review.googlesource.com/c/1349317Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#610590}
-
Rune Lillesveen authored
Causes too many timeout issues for WebKit Linux Trusty MSAN. This reverts the virtual suite part of [1]. [1] https://crrev.com/7c10d9bbc2c168bc6fd889c523ab8d7e6d48abaa TBR=leszeks@chromium.org Bug: 908060 Change-Id: I50111b8a5dc93a29078a0e9f77feefc1a960bedd Reviewed-on: https://chromium-review.googlesource.com/c/1349222Reviewed-by:
-
Juan Antonio Navarro Perez authored
Android One bots are no longer running system health stories, so it's now fine to remove these. NOTRY=true TBR=nednguyen@google.com Bug: 898790 Change-Id: I52518a983545383ca50cc9e995eaaf1623ff4df0 Reviewed-on: https://chromium-review.googlesource.com/c/1349341Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#610588}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9ff75e5f. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I8eb7f84307bcb6aba0c85dcbd4559081d38a0562 Reviewed-on: https://chromium-review.googlesource.com/c/1349491 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610587}
-
Stephane Zermatten authored
This is a reland of c19f615e Original change's description: > [Autofill Assistant] Attempt to recover pre-interrupt state. > > When an interrupt script is run, it can modify anything, which makes the > main script with allow_interrupt=true hard to write. This change propose > to reset some state automatically after an interrupt to make this > easier. > > It recovers the status message and attempts to set a reasonable scroll > position. It sets it to either the element WaitForDom was waiting for, > for a successful WaitForDom. For an unsuccessful WaitForDom, it scrolls > to the last element focused on (if it still exists.) > > Change-Id: Ie9c0022eebc10e0711c82d83b943e0de152af1fd > Reviewed-on: https://chromium-review.googlesource.com/c/1346451 > Commit-Queue: Stephane Zermatten <szermatt@chromium.org> > Reviewed-by: Mathias Carlen <mcarlen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610412} Change-Id: If45ba47d26f29102388e35d3454c5d8f48911944 Reviewed-on: https://chromium-review.googlesource.com/c/1349212Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610586}
-
Peter E Conn authored
This includes two small UX changes - one a word change and one disabling the persistent notification. TWAs will still be behind a flag (which is on by default). Bug: 908052 Change-Id: I3ddb16bc425a437d9fed215e4285c5eba2d20ba0 Reviewed-on: https://chromium-review.googlesource.com/c/1349337Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#610585}
-
Dan Elphick authored
Bug: v8:7279, v8:8238 Change-Id: I0dc237e75557470d38d670cefe760f19378a5740 Reviewed-on: https://chromium-review.googlesource.com/c/1349338Reviewed-by:
-
Peter Boström authored
Bug: None Change-Id: Ida04d468cb03943b7f3ae9539059a5fffe4beed3 Reviewed-on: https://chromium-review.googlesource.com/c/1346298Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610583}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2da0d123402a..e92c674abcb9 git log 2da0d123402a..e92c674abcb9 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 hjd@google.com Fix merged perfetto trace 2018-11-22 treehugger-gerrit@google.com Merge "SockSend: remove extraneous msg_controllen assignment + micro nit fixups." 2018-11-22 taylori@google.com Add generic ftrace event 2018-11-21 treehugger-gerrit@google.com Merge "Collect ftrace protos into one file per group" 2018-11-21 fmayer@google.com Print PID in parent process. Created with: gclient setdep -r src/third_party/perfetto@e92c674abcb9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:117471443 TBR=perfetto-bugs@google.com Change-Id: Icbe137084b670295623061db598b4a99c677ef56 Reviewed-on: https://chromium-review.googlesource.com/c/1348835Reviewed-by:
-
Antonio Gomes authored
Similarly to [1], this CL replaces the Use of OAuth2TokenService, OAuth2TokenService::Consumer and SigninManager APIs with the corresponding IdentityManager counterparts. The unittests could not be only minimally adapted, and converted on a follow up pass, given that CL needed to replace the uses of FakeProfileOAuth2TokenService with IdentityTestEnvironment upfront. [1] https://crrev.com/c/1348670 BUG=907526 Change-Id: I59c2a49d20341ddadff15a28c7ad81e3056161e6 Reviewed-on: https://chromium-review.googlesource.com/c/1348671 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610581}
-
Rune Lillesveen authored
Almost all have been reported as flaky. Disable all to avoid having reports coming in from whichever subtest was not reported yet. Caused a lot of red jobs on the Fuchsia x64 bot. TBR=wez@chromium.org Bug: 907804 Change-Id: I2fb4da79bf1e4251e14900ef4cabb890b7b3380d Reviewed-on: https://chromium-review.googlesource.com/c/1349315Reviewed-by:
-
Morten Stenshorne authored
Looks like something got wrong in https://chromium-review.googlesource.com/c/chromium/src/+/1335007 TBR=wangxianzhu@chromium.org Bug: 906591 Change-Id: I9d0f19d74dc209994aa6ba335b92effee7abf685 Reviewed-on: https://chromium-review.googlesource.com/c/1349254Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#610579}
-
Boris Sazonov authored
This CL reodrers members and renames some fields in SigninManager without any behavioral changes. Bug: None Change-Id: I408ef5cf78d712d212fec342c9b8fc028771207d Reviewed-on: https://chromium-review.googlesource.com/c/1348037Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#610578}
-
Vadym Doroshenko authored
Before this CL on saving manual fallback: 1.User keystroke happen 2.FormData received in PasswordManager for manual fallback 3.Corresponding NewPasswordFormManager (NPFM) is found 4.NPFM is cloned. 5.The FormData is passed to the cloned NPFM. 6.The cloned NPFM is sent to UI The problem with that approach that PasswordManager has no information about user input, which might be used for offering save prompt. The similar logic is implemented in the renderer (where it's called Save on provisional load start). But because of the site isolation the renderer path will disappear soon. But we can do everything from browser process, just by swaping steps 4 and 5, namely to pass FormData to NPFM and then to clone. It's implemented in this CL. As result PasswordManager always has the last user input and can propose saving when the password form is disappeared after navigation (that's basically the same as now but with the renderer path). Along the way SetSubmittedFormIfIsManaged renamed to ProvisionallySaveIfIsManaged since now it's called on each typing not only on submit. Bug: 842643, 831123 Change-Id: If47c5cb3aa5e411818c49e359cd10732a0131ce3 Reviewed-on: https://chromium-review.googlesource.com/c/1348060 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#610577}
-
Stephane Zermatten authored
This change updates the protocol used to control the PromptAction to make it more powerful and more in-line with the current protocol: - the suggestion and element existence results are merged into one list of choice. - the string result is replaced by an opaque server_payload result, which allows the server to include whatever data it wants. To make that work, this changes forwards the data proto as an opaque byte array between layers instead of a single UTF8 string that was used for both message and result. Bug: 1343266 Change-Id: I601c31504bd231ef9904bced92fc350a939b6f9d Reviewed-on: https://chromium-review.googlesource.com/c/1346461 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
-
Mikel Astiz authored
In order to avoid future issues like the one fixed recently in https://chromium-review.googlesource.com/c/1348090, let's improve type safety by adopting net::HttpStatusCode wherever possible. This affects mostly server-related code (LoopbackServer and FakeServer). Other layers are harder to change because URLFetcher itself handles ints rather than enums. Variable names have been updated accordingly. Bug: 774180 Change-Id: Ic65a8efde4038ce56bbd2dedebad8a7c890e1197 Reviewed-on: https://chromium-review.googlesource.com/c/1349310Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610575}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/282ab96433a0..38ec294c9aeb Created with: gclient setdep -r src-internal@38ec294c9aeb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id80404d94b0e37ca0a60d0db43e8334bb25eca5c Reviewed-on: https://chromium-review.googlesource.com/c/1349430Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f40150d87487..5f2ffeec22d1 git log f40150d87487..5f2ffeec22d1 --date=short --no-merges --format='%ad %ae %s' 2018-11-23 saza@webrtc.org Clean up deprecated APM stats Created with: gclient setdep -r src/third_party/webrtc@5f2ffeec22d1 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2c6d38315f4266543554f134dff200834408cccc Reviewed-on: https://chromium-review.googlesource.com/c/1349429Reviewed-by:
-
Eric Seckler authored
The temp tracing file is deleted in an AsyncTask, so poll for it to complete instead of directly asserting the file deletion. TBR=twellington@chromium.org Bug: 907913 Change-Id: I5c31ed9b0154756ce711bcaea0b166173a0a196f Reviewed-on: https://chromium-review.googlesource.com/c/1349256Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#610572}
-
Mohamed Amir Yosef authored
This reverts commit ead171ec. Reason for revert: Test is still flaky. Original change's description: > [Sync] Re-enable a flaky testUploadMovedBookmark() test > > The test > org.chromium.chrome.browser.sync.BookmarksTest#testUploadMovedBookmark > has been disabled for long time due to > flakiness. > > This CL does the following: > 1- Adds an assert() that's missing from the test start up. > 2- Enables the test. > > The plan is to enable it again to get measurements for how long it > takes to fail and pass to rule out a time-out problem. > > The flakiness dashboard has been replaced with a newer one since the > reporting of the attached bug. > > TBR=mastiz@chromium.org > > Bug: 823484 > Change-Id: I827ff84ad953c56f01619b4aa07643714d0ffc6f > Reviewed-on: https://chromium-review.googlesource.com/c/1348116 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610449} TBR=treib@chromium.org,mastiz@chromium.org,mamir@chromium.org Change-Id: I0d56f7d5f7590e9c15abbd4392ebfd75c987ca6c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 823484 Reviewed-on: https://chromium-review.googlesource.com/c/1349333Reviewed-by:
-
Mugdha Lakhani authored
This change updates the text of the warning that shows up on Android when multiple downloads are attempted without user interaction. This is to shorten the message, align it with other similar warning messages on Android, and also align it with the warning text on Desktop. Bug: 906628 Change-Id: Ie7e46ee8fa0251268b8db63322becf24b07207a0 Reviewed-on: https://chromium-review.googlesource.com/c/1341842Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#610570}
-
