- 29 Sep, 2017 17 commits
-
-
Devlin Cronin authored
SimpleFeature has a collection of criteria to determine if a context or extension has access to the feature, but frequently only a few are used. Use base::Optional<> for these rather than a std::unique_ptr<> (which requires heap allocation) or defaults (which require reserving an "invalid" value). This also lets us remove the SimpleFeature::UNSPECIFIED_LOCATION enum. Bug: None Change-Id: If3f417be60aca2a974abd0273e3fd339004db5ff Reviewed-on: https://chromium-review.googlesource.com/685285 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505234}
-
mark a. foltz authored
This reverts commit 27c33249. Reason for revert: Need to revert https://chromium-review.googlesource.com/c/chromium/src/+/656597 and https://chromium-review.googlesource.com/673093 which this patch depends on. Original change's description: > Fix ozone Linux build > > This CL fixes the ozone Linux build after r504590. > > TBR=tommi@chromium.org > CC=mfoltz@chromium.org > > Change-Id: Ice6b7e1f5858c43bd1d9388ef84ee179e2268a32 > Reviewed-on: https://chromium-review.googlesource.com/688155 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504738} TBR=tommi@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I89257302c00b903a61bfd8e483dcff61b3256113 Reviewed-on: https://chromium-review.googlesource.com/691310Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#505233}
-
Yue Li authored
Check whether the user is primary when setup the search page in CrOS settings. Remove the voice interaction entry and change the title if the user is not primary. BUG=b/66919596 Change-Id: I1b38de178830862ebca9c56160ddab595640c844 Reviewed-on: https://chromium-review.googlesource.com/689965Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#505232}
-
Jeremy Roman authored
IsGenerated and Get both do lookups in the same map. We can just Get the result and see if it's empty. The result is a StringPiece, so examining it isn't expensive in the absent case. Change-Id: If42d6dc7c384a64e7716fe771d1cc5758dd18cfc Reviewed-on: https://chromium-review.googlesource.com/678183Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505231}
-
Dan Elphick authored
Creates a new download::Client, BackgroundFetchDownloadClient, which forwards calls to the BackgroundFetchDelegateImpl. Bug: 758562 Change-Id: I8fa30334b41713b1e1d9952448c521ae547bfc2d Reviewed-on: https://chromium-review.googlesource.com/663718 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
John Mellor <johnme@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#505230}
-
Erik Luo authored
TextPrompt and its subclasses are all single-line prompts. Since none require multiline, we can preventDefault on Enter at the base and remove several preventDefault calls. Bug: none Change-Id: I42c08c10052746954c4698975ca72383f3fc25ec Reviewed-on: https://chromium-review.googlesource.com/683436Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#505229}
-
Igor Eremeev authored
R=ekaramad@chromium.org,lfg@chromium.org BUG=628704 Change-Id: I88b95a335e8f97ef5076329a49b52d482fe297f4 Reviewed-on: https://chromium-review.googlesource.com/690348Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505228}
-
kristipark authored
Refreshes the IDB tree and table data if IDB is modified. Bug: 729793 Change-Id: I806e44ea6b5db884a2ab8ce9279745e023ac2732 Reviewed-on: https://chromium-review.googlesource.com/658486 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Michael Nordman <michaeln@chromium.org> Cr-Commit-Position: refs/heads/master@{#505227}
-
Bo Liu authored
Bug: 711253 Change-Id: I21b7af034c8284a9b752b06e7784ea653351f27b Reviewed-on: https://chromium-review.googlesource.com/691218Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#505226}
-
Peter Wen authored
When pak.info files are concatenated whenever pak files are merged, they need to have a consistent format so that the concatenated file does not have merged lines. BUG=723672 Change-Id: Ic45f62d0320fe9b167793694fc13feec76e336ec Reviewed-on: https://chromium-review.googlesource.com/690317 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#505225}
-
Daniele Castagna authored
wayland_client_perftests doens't build for cros without explicitly including 'memory' header for unique_ptr. Bug: Change-Id: I74b8bbe07e2fd8b0b52bee2bacb49e445d9a46a9 Reviewed-on: https://chromium-review.googlesource.com/691334 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505224}
-
Devlin Cronin authored
Introduce a NativeRendererMessagingService to handle extension message passing with native bindings enabled. Add tests for the same. To start, only handle port-based messages (i.e., runtime.connect); subsequent patches will address runtime.sendMessage et al. The new service is not yet being used, since it is not fully functional and would break bindings tests. Bug: 653596 Change-Id: Ibcf1b06552e6097d2494ad3704b8a15bc3c32b7e Reviewed-on: https://chromium-review.googlesource.com/669862Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505223}
-
Becca Hughes authored
Add a feature flag for the redesigned modern media controls and reshuffle the existing resources. BUG=757768 Change-Id: If4626b285f15ab30168eeb54a4a83e9c1fc08708 Reviewed-on: https://chromium-review.googlesource.com/625937 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dimitri Glazkov <dglazkov@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#505222}
-
Will Harris authored
This is a precursor for enabling a load of new compile-time warnings for sandbox/win. Bug: Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: Ia25413826c1a186cd6b680522ac93409fb01ddea Reviewed-on: https://chromium-review.googlesource.com/683240 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#505221}
-
Mustafa Emre Acer authored
net::android::GetIsCaptivePortal API returns the captive portal status on Android. Use this API to determine whether to show a captive portal interstitial in addition to the captive portal certificate list. Bug: 642993 Change-Id: I8cdeaed47ea7e198a7589a3573f96b2093cd4fad Reviewed-on: https://chromium-review.googlesource.com/664342Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#505220}
-
Ken Rockot authored
Applies mojom bindings-generation-time message ID scrambling to all mojom targets by default. Changes the generator's salt flag to take a filename, and uses some GN and LASTCHANGE magic to ensure that the salt file is updated on each build revision. This behavior can be disabled in specific mojom GN targets by setting |scramble_message_ids| to |false|, which is done here for ARC mojoms to avoid compatibility issues between Chrome and the ARC container. BUG=673417 Change-Id: I4263a4b90400a09fed8286b362108f13376b88c5 Reviewed-on: https://chromium-review.googlesource.com/685457 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#505219}
-
rbpotter authored
Bug: None Change-Id: I5e6f56c34f41cabedade893ccff46d3ed1deda7b Reviewed-on: https://chromium-review.googlesource.com/691146Reviewed-by:
-
- 28 Sep, 2017 23 commits
-
-
Alexis Hetu authored
This test is also flaky on Linux (dbg): virtual/threaded/transitions/transition-end-event-transform.html TBR=kbr@chromium.org Bug: 757955 Change-Id: Iceed2eb7ec013dc396314b754ec4b0885f03876d Reviewed-on: https://chromium-review.googlesource.com/691061Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505217}
-
Matthew Jones authored
This change removes the png asset for the Chrome Home promo and replaces it with a vector asset. BUG=767738 Change-Id: I1b0d07427e2b73e3a4609df27ae3c1083221c198 Reviewed-on: https://chromium-review.googlesource.com/691215Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#505216}
-
Miriam Gershenson authored
This CL removes all the old DNS.Resolve* and AsyncDNS.Resolve* histograms and replaces them with a new set. The new Net.DNS.Resolve* histograms measure timing and success/failure at the Job layer, and each type of Task gets its own set to measure Task layer timing and success/failure. Bug: 769320 Change-Id: I0b0df897310a474fd11022f932724c8d40789090 Reviewed-on: https://chromium-review.googlesource.com/687836 Commit-Queue: Miriam Gershenson <mgersh@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#505215}
-
Wenzhao Zang authored
Currently the placeholder for obscured text is defaulted to be '*' except for Mac. However for Chrome OS lock screen we must use bullet as placeholder. Added a setter to customize the password replacement char. Bug: 719015 Change-Id: Ic874a29f68d530aa479cf9852265fe8c07d64003 Reviewed-on: https://chromium-review.googlesource.com/683598Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#505214}
-
Yuzhu Shen authored
DownloadContentTest.FetchErrorResponseBodyResumption BUG=769993 TBR=xingliu@chromium.org Change-Id: I9a807cb9107133526d38db3f4dc9e549630616a9 Reviewed-on: https://chromium-review.googlesource.com/691298Reviewed-by:
-
Nathan Bruer authored
* Fixed bug where network preview would not render JSON if it was fetched and and had an error code. * Fixed bug where network preview would try to render as HTML agressively if requested via XHR. R=pfeldman,eostroukhov BUG=765286,767393,763921 Change-Id: I9a160e50241e406456623469738b0694800ae586 Reviewed-on: https://chromium-review.googlesource.com/687890Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#505212}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/70abcb06..5edc0327 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I2d9df8b68942b5b97fb24e863ab9fea7e395a6ea Reviewed-on: https://chromium-review.googlesource.com/690807Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#505211}
-
James Cook authored
For go/mustash we have to remove in-process ash to chrome calls. This was used to decide if ash should handle the Ctrl-Shift-N shortcut, which might be disabled in guest sessions or via enterprise policy. Ash now always consumes Ctrl-Shift-N (except in guest sessions) and defers the decision about whether to open a window to the browser code. Bug: 665064 Test: added to ash_unittests, browser_tests, manual test of Ctrl-Shift-N in guest sessions on device Change-Id: If1ec062402eafc7785e483c7eee3809282a9767e Reviewed-on: https://chromium-review.googlesource.com/690623Reviewed-by:
-
Lei Zhang authored
Also fix potential leaks by sticking with modern base::Value APIs and unique_ptrs. BUG=543015 Change-Id: I0f5ca7423b118faef43c51ada9db2a01a228c0dd Reviewed-on: https://chromium-review.googlesource.com/691138Reviewed-by:
-
Sean Kau authored
It's possible that we have to setup a printer before ZeroconfPrinterDetector has finished its scan. Notably, when a printer is pre-selected in the PrintPreview dialog. To avoid installing printers with uris we can't resolve, resolve the IP in configurer. As a bonus, we now deselect the printer if it's not immedeately usable. Bug: 769469 Change-Id: I96e07edd9a2eaf199f093408bbb6b8cf583fe851 Reviewed-on: https://chromium-review.googlesource.com/688030Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#505208}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/79eab23d8f83..58418a24debb $ git log 79eab23d8..58418a24d --date=short --no-merges --format='%ad %ae %s' 2017-09-28 rharrison Convert LZW decompressor to use vector instead of static array Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I44f35cf8cbb96ca1a63e4d963cea893e26dccbca Reviewed-on: https://chromium-review.googlesource.com/690895 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505207}
-
Michael Giuffrida authored
Classes will use ExtensionRegistrar to enable and disable extensions, as well as add, remove, reload, and terminate them (later CLs). Currently Chrome's ExtensionService does this, among many other things. A standalone class for this is preferred because: * Code outside //chrome uses similar steps to run extensions, so we should share this code in //extensions * ExtensionService already does too much and is very complex This CL adds EnableExtension() and DisableExtension() to ExtensionRegistrar. ExtensionService still does some Chrome-specific work, but later we'll factor that out into a delegate. Later CLs will add the other extension lifecycle methods, so eventually ExtensionRegistrar is the only class allowed to change the ExtensionRegistry (thus the name). We'll also update calls to ExtensionService methods to use ExtensionRegistrar directly when it makes sense. Design doc: https://goo.gl/trZKep (Google-internal). Bug: 762642 Test: extensions_unittests: ExtensionRegistrarTest Change-Id: I2910a76f873122fbc405b7cc76c766b00a8b216f Reviewed-on: https://chromium-review.googlesource.com/671206 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
-
Brett Wilson authored
Previously the boundary check was incorrect when detecting items were being deleted from the front of a circular_deque. This caused it to fall through to the slow case where all items were shifted over, breaking the promise of amoritized O(1) time. Since this is an optimization (the existing code was correct, just slower than necessary), there are no unit tests for this. Bug: 769812 Change-Id: I8d78be8185741baaca5f2e36413f615102fd68db Reviewed-on: https://chromium-review.googlesource.com/690976 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#505205}
-
Nate Fischer authored
No change to production logic. Since colors are internally represented as integers for Safe Browsing tests, they appear in logs as negative numbers, which doesn't obviously correlate to the RGB values. This adds a helper method (colorToString) to compare string values instead of integer values, so that failed asserts are more readable. Change-Id: Idc075645cf8fd65e4ad4175f2eeef577d69aa1a0 Reviewed-on: https://chromium-review.googlesource.com/685817Reviewed-by:
-
Varun Khaneja authored
Bug: 767888 Change-Id: Ib78c85028834b58510ad3f52189afcf0aa9fe30b Reviewed-on: https://chromium-review.googlesource.com/691074Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#505203}
-
Luigi Semenzato authored
Chrome OS feedback reports often have missing sections, but it is difficult to understand why because errors in fetching those sections are logged in the chrome user logs, but those logs may be connected before the failures occur. This change forces the chrome user logs to be collected after all the other logs. BUG=chromium:753398 TEST=enabled feedbacks by adding these gn args: TEST=is_official_build=true is_chrome_branded=true TEST=then sent a report, and verified that it arrived with all files. Change-Id: Ib08c3bfa5b89dd3afd050abaf52bcf231a5ba79d Reviewed-on: https://chromium-review.googlesource.com/683336 Commit-Queue: Luigi Semenzato <semenzato@chromium.org> Reviewed-by:Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#505202}
-
Sammie Quon authored
Previously this was disabled because a change made immersive mode the default for windows in tablet mode. This creates an extra widget whose parent is also default_container(), which messed up some of the indexes used in this test. This cl allows this test to run in mash again. Test: WorkspaceLayoutManagerBackdropTest.BackdropForSplitScreenTest Bug: 764577 Change-Id: Ic36b6252ad543843ab0d71060605674426cf7437 Reviewed-on: https://chromium-review.googlesource.com/688799Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#505201}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/42e93b6cf5e0a5c958b6b59cf4842b3dc275561a..e9c7b1c8ae85e5625e9d24d9e20ccedeaaeb0d0a BUG=none Change-Id: I9ecae8f64a063214c536dcb150c687db31357d5e Reviewed-on: https://chromium-review.googlesource.com/690398 Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#505200}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/097900648b0b..8b059bd946d9 $ git log 097900648..8b059bd94 --date=short --no-merges --format='%ad %ae %s' 2017-09-28 egdaniel Revert "Update GrBitmapTextureMaker for handling mipped requests" 2017-09-28 geofflang Always read half-float textures as GL_HALF_FLOAT in ES3. 2017-09-28 herb Reorganize blur filter to insert new implementation 2017-09-28 scroggo Avoid uninitialized memory in readByteArrayAsData 2017-09-28 jvanverth Miscellaneous dynamic atlas fixes. 2017-09-28 egdaniel Update GrBitmapTextureMaker for handling mipped requests 2017-09-28 csmartdalton Remove tolerance form SkClassifyCubic 2017-09-28 csmartdalton CCPR: Handle very large paths 2017-09-28 csmartdalton Add svg support to pathfinder tool 2017-09-27 mtklein Move context types into STAGE() macros. 2017-09-28 cblume Remove unused param to SkGIFFrameContext ctor 2017-09-28 brianosman Revert "Revert "Revert "Make threaded proxy generation MDB-friendly, and defer instantiation""" 2017-09-27 mtklein Always zero vectors in start_pipeline(). 2017-09-28 benjaminwagner Fix job name in PRESUBMIT.py. 2017-09-28 brianosman Revert "Revert "Make threaded proxy generation MDB-friendly, and defer instantiation"" 2017-09-28 mtklein Also mask t itself in mask_2pt_conical_degenerates. Created with: roll-dep src/third_party/skia BUG=765953 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Idc039c79f9de9af429654c315f8742fb4e1e4013 Reviewed-on: https://chromium-review.googlesource.com/691076Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#505199}
-
F#m authored
This change prepares the display stack to associate multiple touch input devices with a given display. It updates the display preferences to persist this associations and calibration data. Adds and updates tests This patch now preserves the legacy data for touch calibration. The patch deprecates the legacy methods while still allowing the system to use any data that has been stored via the legacy system. This allows devices that cannot update their touch calibration data to the new model to still function as expected without any external input. BUG=599985 COMPONENT=Display, Display Manager, Touch Calibrator, Preference Change-Id: If9a0af74a35e5ca723c8e6be29518cb1520bb5ef Reviewed-on: https://chromium-review.googlesource.com/669980Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=dgozman@chromium.org Bug: 666525 Change-Id: I280a42f5038e26cefd16f01dc656ba96b7b96828 Reviewed-on: https://chromium-review.googlesource.com/689120Reviewed-by:
-
Daria Yakovleva authored
Bug: 739713 Change-Id: I394a40bf1044fde1656796efa94af0702ddf808d Reviewed-on: https://chromium-review.googlesource.com/678730 Commit-Queue: Daria Iakovleva <yakovleva@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#505196}
-
James Cook authored
There's only one mode (split desktops). The uninitialized state isn't needed anymore. It was added a long time ago as an optimization to avoid looking up flag values and those flags no longer exist. Bug: none Test: unit_tests, browser_tests, manually test teleporting windows between user sessions and verify avatar icons appear in the frames Change-Id: Icc660ca2af047b39066ae501a5c6dc6a28f7aa8f Reviewed-on: https://chromium-review.googlesource.com/687986Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
