GitLab

Previously, it would persist logs in uncompressed form. 
This CL changes the code to compress logs before they're 
saved. A new pair of prefs is introduced for storing 
these logs, while reading from the old pref is still 
maintained to not lose old logs. 

Additionally, this makes the metrics log discard limit 
(currently 50k) be checked against the compressed size 
rather than the uncompressed size. 

Simplifies the format used to store logs, now simply 
storing the compressed log bytes and corresponding hash 
for each log. The size and checksum fields are removed. 
(Size was redundant while the checksum is not no longer 
necessary now that we store the log hash.) 

Deletes some tests that inspected the actual pref 
values are removed, in favor of tests that check that 
serializing and de-serializing works as expected. 

Finally, also introduces GzipUncompress() that is 
needed for tests that inspect log manager logs. 

BUG=382076
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/318203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276429 0039d316-1c4b-4281-b951-d872f2087c98

This adds a unit test that would fail after landing
the https://codereview.chromium.org/287193003 CL without any further
changes, documenting one regression it caused.

R=brianderson, enne
BUG=376649,374287

Review URL: https://codereview.chromium.org/321193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276428 0039d316-1c4b-4281-b951-d872f2087c98

This appears to be causing the Google Chrome Win bot to have a compiler failure.
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/24886

> Enable building and output-ing of browser_tests.exe for official Windows builds.
> 
> BUG=379986
> 
> Review URL: https://codereview.chromium.org/323163003

TBR=anandc@chromium.org

Review URL: https://codereview.chromium.org/327273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347425,378621

Review URL: https://codereview.chromium.org/318353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276422 0039d316-1c4b-4281-b951-d872f2087c98

* and replace it with ui::GetScaleForScaleFactor
* Minor simplification of if blocks in FaviconService

BUG=372212
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/326143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276421 0039d316-1c4b-4281-b951-d872f2087c98

Update API tests so they don't assume service_path == GUID

BUG=381786

TBR=mef (updated test expectations in components/wifi/fake_wifi_service.cc)

Review URL: https://codereview.chromium.org/320063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276420 0039d316-1c4b-4281-b951-d872f2087c98

Removed the App Info header from the Create Shortcuts dialog for Apps,
as requested by UI, since it is always clear which app the shortcuts
are being created for. The info still appears when creating shortcuts for
bookmark (URL) apps.

BUG=NONE

Review URL: https://codereview.chromium.org/307873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276419 0039d316-1c4b-4281-b951-d872f2087c98

This is dead code as the Blink bits were removed in
http://src.chromium.org/viewvc/blink?view=revision&revision=156126

Review URL: https://codereview.chromium.org/326823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276417 0039d316-1c4b-4281-b951-d872f2087c98

The old organization was an attached and unattached section. With the hint text of when it was last attached this is unnecessary. The suggestions section now has all galleries that the app didn't start with permission for.

BUG=359704

Review URL: https://codereview.chromium.org/321443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276415 0039d316-1c4b-4281-b951-d872f2087c98

This puts the existing malware & phishing text into the new security interstitial layout. Since it's not polished enough yet, this CL keeps it behind a flag.

Down the line, I'm going to want to make a new c/b/resources/security_interstitial/ folder and move all of the related SSL & SB files into there. But it doesn't make sense to do that yet, until we deprecate the older versions.

BUG=381260

Review URL: https://codereview.chromium.org/319193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276414 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/323163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276413 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382120

Review URL: https://codereview.chromium.org/324083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276412 0039d316-1c4b-4281-b951-d872f2087c98

Specifically:
IViewManagerInit::Connect->EmbedRoot
IViewManager::Connect->Embed

R=ben@chromium.org

Review URL: https://codereview.chromium.org/328873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276411 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies a lot of code.

BUG=315312

Review URL: https://codereview.chromium.org/326433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276410 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/322923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276409 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368721
TBR=davidben@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/332433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276408 0039d316-1c4b-4281-b951-d872f2087c98

This policy when set will prevent the renderer process from making Win32K.sys calls via user32/gdi32 on
Windows 8 and beyond.

The following intercepts are needed for getting basic renderer functionality.
1. gdi32!GdiDllInitialize:
2. gdi32!GetStockObject.
3. user32!RegisterClassW.

The above functions are called during renderer process initialization. We intercept these APIS by
EAT patching the corresponding dlls and return fake success values from those.

The intercepts live in the process_mitigations_win32k_interception.cc/.h files. The rest of the changes
are plumbing with the sandbox policy framework.

While basic renderers work well now on Windows 8, pepper flash does not as it sends an IPC to the renderer
to creating the transport DIB. Justin is aware of this problem and thinks we can workaround this.

BUG=365160

Added gdi and user32 interceptors for the win32k lockdown project.

Review URL: https://codereview.chromium.org/318603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276407 0039d316-1c4b-4281-b951-d872f2087c98

This function will be componentized and so cannot reference g_browser_process.
google_util::AppendGoogleLocaleToURL() will be handled in followup work.

BUG=373203

Review URL: https://codereview.chromium.org/327833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276406 0039d316-1c4b-4281-b951-d872f2087c98

Necessarily added support for mocking StreamListenSocket::GetLocalAddress.
Also cleaned up the int-to-string conversion in DevToolsHttpHandlerImpl.

BUG=382682

Review URL: https://codereview.chromium.org/319593013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276405 0039d316-1c4b-4281-b951-d872f2087c98

- No need to use scoped_ptr.get() in conditionals.
- Check return value from SharedMemory::GiveToProcess().
- Remove a NOTREACHED(), as memory sharing can fail.

Review URL: https://codereview.chromium.org/322173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276404 0039d316-1c4b-4281-b951-d872f2087c98

This takes into account test retries, and only looks
at the final result.

BUG=381733
R=sky@chromium.org

Review URL: https://codereview.chromium.org/316903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276403 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276397 0039d316-1c4b-4281-b951-d872f2087c98

R=rch@chromium.org
BUG=none
TEST=net_unittests --gtest_filter=*Balsa*

Review URL: https://codereview.chromium.org/312003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276394 0039d316-1c4b-4281-b951-d872f2087c98

Honor the first argument of mount() when mount html5fs
filesystem. This allows us to mount just part of an
html5fs fileystem.

Also, fix and re-enable the rmdir/unlink/remove tests for 
html5fs and add more error checking to that parameter 
parsing in Init().

R=binji

Review URL: https://codereview.chromium.org/320983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276393 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380825

Review URL: https://codereview.chromium.org/323293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276392 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/319183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276391 0039d316-1c4b-4281-b951-d872f2087c98

This makes it possible to see the internal state of the time source for
debugging purposes.

BUG=371223

Review URL: https://codereview.chromium.org/307773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276390 0039d316-1c4b-4281-b951-d872f2087c98

jam says this is obsolete/unused

Also breaks chrome->appcache_interfaces.h dependency

BUG=338338

Review URL: https://codereview.chromium.org/327823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276389 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379986

Review URL: https://codereview.chromium.org/323163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276388 0039d316-1c4b-4281-b951-d872f2087c98

Revert of RenderTextHarfBuzz: Decide run direction by BiDi embedding level (https://codereview.chromium.org/326123003/)

Reason for revert:
Memory leak: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/3570/steps/ui_unittests/logs/HarfBuzz_RunDirection

Original issue's description:
> RenderTextHarfBuzz: Decide run direction by BiDi embedding level
> 
> BUG=382178
> NOTRY=true
> R=msw
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276379

TBR=msw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=382178

Review URL: https://codereview.chromium.org/324413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276387 0039d316-1c4b-4281-b951-d872f2087c98

ActionRunner instead.

Rename parameter to ExecuteJavaScript (both in action_runner.py and
web_contents.py) from expr/expression to statement.

BUG=361809

Review URL: https://codereview.chromium.org/328663007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276386 0039d316-1c4b-4281-b951-d872f2087c98

The Launch test failed on mac 10.7 tests:
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%283%29/builds/24632.

> [Mac] Add interactive App Shim test.
> 
> This test creates shims in the user data dir and actually starts them up and
> expects them to connect to the IPC socket.
> 
> BUG=168080
> 
> Review URL: https://codereview.chromium.org/316493002

TBR=jackhou@chromium.org

Review URL: https://codereview.chromium.org/325123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276385 0039d316-1c4b-4281-b951-d872f2087c98

Upon registration of new components, we reset the timer, as if the
component were registered upfront.

BUG=379880

Review URL: https://codereview.chromium.org/325073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276384 0039d316-1c4b-4281-b951-d872f2087c98

This extra call to communicate was added by mistake. Remove it and add a
test.

Review URL: https://codereview.chromium.org/328553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276383 0039d316-1c4b-4281-b951-d872f2087c98

Resource added in 
https://codereview.chromium.org/322903004/

BUG=363644

Review URL: https://codereview.chromium.org/326813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276382 0039d316-1c4b-4281-b951-d872f2087c98

Turns out the number of contexts in the gaia page can be more than 15, so we need this.

Also fix a bug in cros_test_case where browser_options were not being properly set by the test.

BUG=361862
TEST=testIframe
NOTRY=True

Review URL: https://codereview.chromium.org/214963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276380 0039d316-1c4b-4281-b951-d872f2087c98

BUG=382178
NOTRY=true
R=msw

Review URL: https://codereview.chromium.org/326123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276379 0039d316-1c4b-4281-b951-d872f2087c98

The correct place for this adjustment seems to be in BeginFrame (or maybe
AdjustedBeginImplFrameDeadline?) but definately not in the
SyntheticBeginFrameSource.

Currently the code does;
  base::TimeDelta parent_draw_time =
      output_surface_->capabilities().adjust_deadline_for_parent
          ? BeginFrameArgs::DefaultDeadlineAdjustment()
          : base::TimeDelta();
  client_->SetEstimatedParentDrawTime(parent_draw_time);

BUG=345459

Review URL: https://codereview.chromium.org/328603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276378 0039d316-1c4b-4281-b951-d872f2087c98

For the apk specific java files, we now run proguard on the jar instead of the classes.

BUG=375324,359249

Review URL: https://codereview.chromium.org/322443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276377 0039d316-1c4b-4281-b951-d872f2087c98

LegacyFrameProcessor reported decode error if ChunkDemuxerStream
(really, if SourceBufferStream)::Append() returned false. This could be
for a variety of reasons, mostly sanity checking the timestamps.
The new FrameProcessor ignored the ChunkDemuxerStream::Append() result
and assumed success, hiding potential issues. This change makes
FrameProcessor report decode error if CDS::Append() fails.

R=acolwell@chromium.org
TEST=no media_unittest or MSE layout test regression locally on linux

Review URL: https://codereview.chromium.org/324243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276375 0039d316-1c4b-4281-b951-d872f2087c98