- 07 Feb, 2019 40 commits
-
-
Dominik Röttsches authored
Preparation for introducing a separate singleton class that builds the font unique name lookup table. These font file related methods will be used by both. No functional changes. Bug: 889864 Change-Id: Id06dc705036483f1c9972c6e66ce34c6920295be Reviewed-on: https://chromium-review.googlesource.com/c/1458296 Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#630040}
-
Andrew Xu authored
Implement a new UI feature: hiding the drag handle of app list in tablet mode if there is no activatable window. The main strategy is listed as following: (1) OnWindowDestroyed event should be listened to. Considering about the situation that closing the browser window through shelf while home launcher is visible. Hence we need to observe all windows from MRU list in app list code, which is pretty much what MruWindowTracker does. So the app list controller should observe MruWindowTracker and hide/show the drag handle when a window is closed. (2) When the gesture makes the app list show, the home launcher gesture handler should notify the app list controller when animation ends. The latter checks MRU window list then hides/shows the handle. Test: ash_unittests Bug: 923089 Change-Id: I9d9d60e705326cfe2ff90c59da2cccb18db87942 Reviewed-on: https://chromium-review.googlesource.com/c/1445111 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#630039}
-
Peng Huang authored
For Vulkan, the CL will use the format from driver instead of hard coding. This CL also replaces the deprecated Vulkan enum VK_COLORSPACE_SRGB_NONLINEAR_KHR. Change-Id: I061eccad85f12fbfe57273e1e945b89f268ebcd0 Reviewed-on: https://chromium-review.googlesource.com/c/1456224Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#630038}
-
Sahel Sharify authored
When the fling controller generates GSU and GSE events, it uses the positions of GFS and GFC events. This cl properly populates the positions in widget of GFS and GFC events that are generated in RWHI. This fix is enough to address crbug.com/769390 where scrolling stops after deletion of the DOM element and rehittesting fails due to GSUs having (0,0) coordinates. In the following cl both position_in_widget and position_in_screen of autoscroll GFS and GFCs will get populated in the browser process using the coordinates of mouse middle click and mouse move events: [WIP] https://chromium-review.googlesource.com/c/chromium/src/+/1239174 Bug: 769390 Test: AutoscrollBrowserTest.GSUGSEValidPositionInWidget Change-Id: Ib5e12fa57b5246e5cb1ae349d3081a98863eca31 Reviewed-on: https://chromium-review.googlesource.com/c/1452505Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#630037}
-
Alex Clarke authored
Store enough state inside immediate_incoming_queue_lock_ to allow ImmediateTasksTimeBudgetThrottling to know whether or not we need to schedule a DoWork. In addition we ensure that posting a task to a disabled queue with a TaskQueue::Observer doesn't schedule a DoWork (the observer may well schedule a DoWork itself however). This patch will let us simplify: https://chromium-review.googlesource.com/c/chromium/src/+/1436044/ Bug: 897751 Change-Id: I5f426fabf39acffb891bd53a2b0bf5b828ae22bf Reviewed-on: https://chromium-review.googlesource.com/c/1452162Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#630036}
-
Stephen McGruer authored
This reverts commit cd74eba0. Reason for revert: Speculative revert due to DCHECK failures in linux-chromeos-dbg Bug: 929785 Original change's description: > Declare Chrome OS Account Manager for field trial testing > > Bug: 816954 > Change-Id: I4ee640075af0948cbb8b5bfcc127123348cad98b > Reviewed-on: https://chromium-review.googlesource.com/c/1426779 > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629940} TBR=isherman@chromium.org,sinhak@chromium.org Change-Id: I3d89e1e798164bc774c084e867e7cbd969487063 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 816954 Reviewed-on: https://chromium-review.googlesource.com/c/1459326Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#630035}
-
Elly Fong-Jones authored
This change removes a bunch of flags from flag-metadata that have already been deleted from other source files. Bug: None Change-Id: I0d4dad01a01dc175d1003e68c25745bc674d85f6 Reviewed-on: https://chromium-review.googlesource.com/c/1458677 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#630034}
-
Xiaohan Wang authored
Currently when DecryptingDemuxerStream is selected, we only have "video_dds = true" in MediaLog, which isn't obvious for readers. This CL adds an explicit log event to make it clear. Unit test is not updated because it's not trivial to set when we expect this to be logged. For example, even with encrypted stream and a valid Decryptor, we don't expect this log when decoder initialization failed. Test: Manually tested. See note above. Change-Id: If2149cd73c51916f1aa55e6f073ed2f73d65f28a Reviewed-on: https://chromium-review.googlesource.com/c/1457432Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#630033}
-
bsheedy authored
Increases the amount of time between polling for scroll quiescence to 500 ms to ensure that the scroll actually started and actually finished (as opposed to being temporarily frozen due to scroll jank). Scrolling was taking longer to start on Vega than on smartphones, which was flakily causing the wait for scroll quiescence to finish before the scroll actually started. Bug: 876946 Change-Id: I5d77be8c224bedc7ed6e0d96204307c93366cb0f Reviewed-on: https://chromium-review.googlesource.com/c/1456209Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#630032}
-
Dominik Röttsches authored
Preparation for introducing a separate singleton class that builds the font unique name lookup table. The UMA methods will be used by both, so they need to be in a separate file. No functional changes. Bug: 889864 Change-Id: Ib8dcdda2a13323db185b65f13dc26222d05d9532 Reviewed-on: https://chromium-review.googlesource.com/c/1456008 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#630031}
-
Doug Arnett authored
Bug: 929411 Change-Id: I4e25536f1ca51a5c8fbea87d8bd85e60b3fa99e5 Reviewed-on: https://chromium-review.googlesource.com/c/1457414Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#630030}
-
Raphael Kubo da Costa authored
This fixes the GCC build: ../../base/containers/any_internal.h: In member function ‘constexpr void base::internal::AnyInternal::operator=(base::internal::AnyInternal&&)’: ../../base/containers/any_internal.h:42:10: error: call to non-‘constexpr’ function ‘void base::internal::AnyInternal::reset()’ reset(); ~~~~~^~ reset() itself is not constexpr, and it is not clear if it should be given it calls |delete_fn_ptr|. Bug: 819294, 906125 Change-Id: I7760c62213db0e59a82e5210988ee469b5006090 Reviewed-on: https://chromium-review.googlesource.com/c/1458096 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#630029}
-
Caleb Rouleau authored
NOTRY=True TBR=charliea@chromium.org Bug: 928796 Change-Id: I20e82d18cd4ceb9f02630ae04e3a8223dc9372b7 Reviewed-on: https://chromium-review.googlesource.com/c/1459318Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#630028}
-
Alex Gaynor authored
Change-Id: I8409f764a93d69d5dc0d8ee2575558fe83a68033 Reviewed-on: https://chromium-review.googlesource.com/c/1458688Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#630027}
-
François Beaufort authored
Following https://github.com/WICG/picture-in-picture/issues/116, it would be great to allow video to enter Picture-in-Picture without user activation if there's already a visible PiP window in the context of the document, in other words if `document.pictureInPictureElement` is set. Bug: 928697 Change-Id: I2c191368d8dd1bd6ddade719399d0679ef410575 Reviewed-on: https://chromium-review.googlesource.com/c/1454360 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#630026}
-
Nico Weber authored
No behavior change. Bug: 926235 Change-Id: I731ae4f33079088d62b0748c99663fb9c5667fff Reviewed-on: https://chromium-review.googlesource.com/c/1458680 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#630025}
-
Vlad Tsyrklevich authored
Changing use_gwp_asan to true on macOS wires in the call to gwp_asan::EnableForMalloc in chrome/ Bug: 912286 Change-Id: Ic8d57464ba9d1c8cd81a79f02ec53ab2ed616c74 Reviewed-on: https://chromium-review.googlesource.com/c/1457227 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#630024}
-
John Budorick authored
Bug: 790137, 790148 Change-Id: I887131fdd09852a8b400f797096971ce1fde1a76 Reviewed-on: https://chromium-review.googlesource.com/c/1457817 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#630023}
-
bsheedy authored
Fixes a race condition in VrBrowserWebInputEditingTest#testSelectTag on Vega (and probably other fast devices) where the click meant for the modal dialog could happen so fast that it registered on the web contents instead of the dialog, causing the dialog to be dismissed. Bug: 876946 Change-Id: I043e19d49ce02e76de4b2447619f365e8dc90244 Reviewed-on: https://chromium-review.googlesource.com/c/1456940Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#630022}
-
Andrew Grieve authored
These are needed by supersize. Also makes a couple minor optimizations: * Track .jar.info rather than .jar in merge_jar_info_files.py * Make create_final_jar_info() a dep of the final android_apk group(), rather than a dep of the create_apk() target. Bug: 873714 Change-Id: I0ff452cbd19d07d6ee0a44c9b7def4e2c728ec3f Reviewed-on: https://chromium-review.googlesource.com/c/1457430 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#630021}
-
Lei Zhang authored
Change-Id: I4ce13d9ed00da78a8a715e0e45847fc1cfb3fe4e Reviewed-on: https://chromium-review.googlesource.com/c/1457924Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#630020}
-
Nicolas Pena authored
This CL changes the security check for ElementTiming from same-origin to TAO, which requires plumbing the OriginalTimingAllowOrigin attribute for the case of 304 responses. It also removes bubbling to be consistent with ResourceTiming. Some tests are fixed to properly use cross-origins within external/wpt, and a cross-origin resource with TAO wildcard test is added. More TAO tests will be added in a followup. Bug: 928425, 879270 Change-Id: I4df40818823e3db9851fbc9586a0bda9c1adcfec Reviewed-on: https://chromium-review.googlesource.com/c/1453074 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#630019}
-
Travis Skare authored
PDF, Image (png/jpeg/gif), and video (mp4) Change-Id: I8e97b3dc376a599cb2900f5a31c8d5cfa1999623 Reviewed-on: https://chromium-review.googlesource.com/c/1457421Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#630018}
-
Andrew Grieve authored
These will be used by bots & diagnose_bloat.py for measuring binary size. Also updates related code in apk_operations.py: * Makes --output-apks required for build-bundle-apks * Adds --minimal for build-bundle-apks * Logs bundletool commands when in verbose mode Bug: 873714 Change-Id: I6fb4bcc366110cacfd8e1b772db4ea1e00f81cc9 Reviewed-on: https://chromium-review.googlesource.com/c/1456223Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#630017}
-
Vladimir Levin authored
This patch ensures that clusterfuzz doesn't hit the web_test CHECK that is ensuring we have accelerated compositing active. This can happen if we're navigating and trying to capture pixels at the same time. However, the pixel capture code would do a composite which in turn makes sure this check "becomes true" by setting up a root layer. So, it seems to be safe to just remove the CHECK. R=lukasza@chromium.org, danakj@chromium.org Bug: 919174 Change-Id: Ib5725c91b0cd827f8bfaf0e2266ad12de313f592 Reviewed-on: https://chromium-review.googlesource.com/c/1452781Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: vmpstr <vmpstr@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630016}
-
Xida Chen authored
At touch sequence start, the white listed touch action may not have value under certain corner cases, which is similar to the case when a touch start is ack from the main thread (that the main thread touch action may not have value). In this case, we explicitly set the white listed touch action to Auto. Unit tests are added to ensure correctness. Bug: 904648 Change-Id: I9140f1f0625ab9b4f8c30765cd10324605b8db40 Reviewed-on: https://chromium-review.googlesource.com/c/1454089 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#630015}
-
Xiaohan Wang authored
Currently we only support converting TimeDelta to/from Value, where 2 of the 3 references actually intend to store Time instead of TimeDelta. This CL adds functions to help convert Time to/from Value directly. Also update CreateTimeDeltaValue() and GetValueAsTimeDelta() to use FromMicroseconds() and InMicroseconds() instead of FromInternalValue() and ToInternalValue() which are deprecated. Bug: 917527,928787 Change-Id: Icb0543031ab4f526cfe835d52e85c28efba66863 Reviewed-on: https://chromium-review.googlesource.com/c/1449326Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#630014}
-
Klaus Weidner authored
This is in preparation for serving versioned test pages for cross-version testing. For local serving, the extra '../' will be ignored by the server. Bug: 923149 Change-Id: Ieb23b397d331de6babc41c94132d1b924cec956d Reviewed-on: https://chromium-review.googlesource.com/c/1455305Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#630013}
-
Antonio Gomes authored
There are no more users outside of the IdentityTestEnvironmentProfileAdaptor class. This CL folds FakeSigninManagerForTesting into (and the helper classes) the adaptor. BUG=926948 Change-Id: I8d57947660eab6f217ba1f6cddf9b1baf64f1cc5 Reviewed-on: https://chromium-review.googlesource.com/c/1456516Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#630012}
-
Lei Zhang authored
It only has one non-test caller, and that caller always passes in a valid |use_stale| parameter. Update the unit tests to pass in the parameter as well. After that, change it from an out parameter to the return value. Change-Id: Ia7862d74363b052c18ed9f37d4253c5f515f1d5f Reviewed-on: https://chromium-review.googlesource.com/c/1456987Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#630011}
-
Brandon Jones authored
Bug: 922187 Change-Id: I7f8837f9d32672d33a4143d51c30f6997f0cd180 Reviewed-on: https://chromium-review.googlesource.com/c/1455618Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brandon Jones <bajones@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#630010}
-
Christopher Thompson authored
Specify the relevant metrics cthomp reviews in the OWNERS file, on the same line so that `git cl owners` and similar tools will include it. Change-Id: I37769bd88edadf77dce56f23da0002eef0546b73 Reviewed-on: https://chromium-review.googlesource.com/c/1453082 Auto-Submit: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#630009}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ide4eafad476339e8993f95e7c28b052dc69cead3 Reviewed-on: https://chromium-review.googlesource.com/c/1458423Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630008}
-
Natalie Chouinard authored
Connect Java and native sides of JNI bridge for Get- and SetTokenMappings methods. Bug: 923581 Change-Id: Ia800003a41a1daba5da776183ed5942dde7d9018 Reviewed-on: https://chromium-review.googlesource.com/c/1455109Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#630007}
-
Chris Mumford authored
Switches chromeos::assistant::ChromiumHttpConnection from using //net directly to using the network service (SimpleURLLoader). Bug: 913757 Change-Id: If89b2eb49f66a0279d9b23c1533c15166c322110 Reviewed-on: https://chromium-review.googlesource.com/c/1380541Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#630006}
-
Harley Li authored
In Applocation>Cache Storage, to preview a cached response, DevTools needs to call requestCachedResponse() to the backend to fetch it. Originally, DevTools is unable to fetch cached responses for requests that have headers, and this is because in DevTools's beckend, the field 'headers' of mojom::blink::FetchAPIRequest remains unfilled. This patch fixes the issue by filling this field. Bug: 890359 Change-Id: I599cc1393d5c02baa7d7f90fc22fd379b1745090 Reviewed-on: https://chromium-review.googlesource.com/c/1455272Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#630005}
-
Mario Bianucci authored
Mask execution closely follows background execution, which results in the size of the mask being reduced to the exact size requested, rather than filling out the dest_rect in BackgroundImageGeography::SetNoRepeatX and ::SetNoRepeatY. This CL puts the mask in the correct location, then when we are creating the shader in image.cc, if the mask doesn't fill out the dest_rect, decal tilemode is used to fill the rest with transparency, which allows the mask to fill the full area. Regarding the change to the fast/backgrounds/mask-composite.html test: This change results in the original test failing, displaying the same thing that it displays when using source-out. Based on my understanding of how the 'copy' Porter-Duff keyword works, I believe this is correct and that the test previously had an incorrect baseline because of this bug. My understanding is that, if mask-composite is 'copy', then regardless of the number of masks, only the first one will be displayed. The PD definition of copy is that only the source mask is displayed, and since this would be applied starting from the last two masks listed, moving up to the first two, the end result is that only the first mask is displayed. And, since this matches what happens when mask-composite:source-out is used (and matches Edge and Firefox using 'subtract'), I just changed it to a likely more commonly used keyword. Bug: 917067 Change-Id: Ic9174ea67d92abe6b78acf9b7f2640796d30d249 Reviewed-on: https://chromium-review.googlesource.com/c/1447261 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#630004}
-
Jordan Taylor authored
web_tests/animations/animationworklet/worklet-animation-local-time-after-duration.html -> web_tests/external/wpt/animation-worklet/worklet-animation-local-time-after-duration.https.html web_tests/animations/animationworklet/worklet-animation-local-time-before-start.html -> web_tests/external/wpt/animation-worklet/worklet-animation-local-time-before-start.http Bug: 915352 Change-Id: Ic24945fc071ebc9aada2cf925fcb07b111d23a99 Reviewed-on: https://chromium-review.googlesource.com/c/1446566Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#630003}
-
Ramin Halavati authored
|ObfuscatedFileUtilDelegate| and |ObfuscatedFileUtilMemoryDelegate| are added to support in-memory file system for incognito mode and |ObfuscatedFileUtil| is updated to choose the appropriate delegate based on being incognito or not. To avoid making the CL large, only the skeleton of the |ObfuscatedFileUtilMemoryDelegate| is added in this CL and the actual implementation will be added in a next one. The change is part of the following design doc: https://docs.google.com/document/d/17NV1cGSIEG2i5qm2QU4EzDMKRoyVEbNNq-Re-JhwSB0 Bug: 93417 Change-Id: I47353c656ab70ab6c98c8e06c9e0c3a03319d012 Reviewed-on: https://chromium-review.googlesource.com/c/1452176Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#630002}
-
Toni Barzic authored
Web UI lock screen is not used anymore. BUG=929466 Change-Id: I0984b3f6ccc7bb148784a56d7522393e9ef77a24 Reviewed-on: https://chromium-review.googlesource.com/c/1457656Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#630001}
-