GitLab

I needed to change the behaviour of Future.Then() to implement this.

BUG=306341
R=yoz@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/438403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287633 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400561
TEST=Add a Sleep(1000) before this section of the test: fails before this CL, succeeds now.

Review URL: https://codereview.chromium.org/442853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287632 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/445513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287631 0039d316-1c4b-4281-b951-d872f2087c98

The Poly1305 NEON code became live again with the BoringSSL switch. This
change disables it again in Chromium because of some broken phones.

We should really read /proc/cpuinfo and selectively disable, but this
change is simple and keeps the status-quo for now.

BUG=341598

Review URL: https://codereview.chromium.org/443523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287630 0039d316-1c4b-4281-b951-d872f2087c98

These product IDs have been assigned under the Google vendor ID for
this project.

BUG=396682

Review URL: https://codereview.chromium.org/436213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287629 0039d316-1c4b-4281-b951-d872f2087c98

R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/418093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287628 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Fix flakiness of DesktopDragDropClientAuraX11Tests (https://codereview.chromium.org/431973006/)

Reason for revert:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Builder/builds/11578/steps/compile/logs/stdio#error1

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ui/views/widget/desktop_aura/views.desktop_drag_drop_client_aurax11.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD -DCR_CLANG_REVISION=214024 -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DVIEWS_IMPLEMENTATION -DGL_GLEXT_PROTOTYPES -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_PICTURE_CLONE -DSK_SUPPORT_LEGACY_GETDEVICE -DSK_IGNORE_ETC1_SUPPORT -DSK_IGNORE_GPU_DITHER -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DUSE_NSS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DLEAK_SANITIZER -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen -I../../third_party/wtl/include -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -Igen/ui/resources -Igen/ui/strings '-I../../third_party/libc++/trunk/include' '-I../../third_party/libc++abi/trunk/include' -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load -Xclang /b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -B/b/build/slave/Linux_ASan_LSan_Builder/build/src/third_party/binutils/Linux_x64/Release/bin -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64 -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address -fsanitize=leak -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -funwind-tables -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -nostdinc++  -c ../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc -o obj/ui/views/widget/desktop_aura/views.desktop_drag_drop_client_aurax11.o
In file included from ../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:5:
../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h:166:8:error: no type named 'vector' in namespace 'std'
  std::vector< ::Atom> GetOfferedDragOperations();
  ~~~~~^
../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h:166:14:error: expected member name or ';' after declaration specifiers
  std::vector< ::Atom> GetOfferedDragOperations();
  ~~~~~~~~~~~^
../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:316:32:error: no member named 'GetOfferedDragOperations' in 'views::DesktopDragDropClientAuraX11'
    actions_ = source_client_->GetOfferedDragOperations();
               ~~~~~~~~~~~~~~  ^
../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:614:34:error: use of undeclared identifier 'GetOfferedDragOperations'
  std::vector< ::Atom> actions = GetOfferedDragOperations();
                                 ^
../../ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc:924:52:error: out-of-line definition of 'GetOfferedDragOperations' does not match any declaration in 'views::DesktopDragDropClientAuraX11'
std::vector< ::Atom> DesktopDragDropClientAuraX11::GetOfferedDragOperations() {
                                                   ^~~~~~~~~~~~~~~~~~~~~~~~


Original issue's description:
> Fix flakiness of DesktopDragDropClientAuraX11Tests
> 
> I suspect that the flakiness was caused by X11WholeScreenMoveLoop::RunMoveLoop()
> sometimes failing. This CL fixes this potential source of flakiness by using
> a stub move loop in tests.
> 
> BUG=396468
> TEST=None
> TBR=erg
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287622

TBR=erg@chromium.org,pkotwicz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=396468

Review URL: https://codereview.chromium.org/443773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287627 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Moving coordinate conversion methods from ash/wm to ui/wm. (https://codereview.chromium.org/425363002/)

Reason for revert:
Build break.

../../ash/display/mouse_cursor_event_filter_ozone.cc:21:7:error: no member named 'ConvertPointToScreen' in namespace 'ash::wm'
  wm::ConvertPointToScreen(target, &point_in_screen);
  ~~~~^
../../ash/display/mouse_cursor_event_filter_ozone.cc:45:7:error: no member named 'ConvertPointFromScreen' in namespace 'ash::wm'
  wm::ConvertPointFromScreen(root_at_point, &point_in_root);
  ~~~~^
../../ash/display/mouse_cursor_event_filter_ozone.cc:86:7:error: no member named 'ConvertPointFromScreen' in namespace 'ash::wm'
  wm::ConvertPointFromScreen(dst_root, &point_in_dst_screen);
  ~~~~^


Original issue's description:
> Moving coordinate conversion methods from ash/wm to ui/wm.
> 
> Moving ConvertPointToScreen and ConvertPointFromScreen from ash::wm into
> aura::Window. The suggestion to do this was made here:
> https://codereview.chromium.org/420603011/diff/1/athena/wm/coordinate_conversion.h
> 
> BUG=NONE
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287609

TBR=oshima@chromium.org,ben@chromium.org,sky@chromium.org,mfomitchev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/445703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287626 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387879
TEST=MaximizeModeController.CloseLidWhileInMaximizeMode
TEST=MaximizeModeController.WasLidOpenedRecently
TEST=MaximizeModeController.HingeAnglesWithLidClosed
TEST=MaximizeModeController.StableHingeAnglesWithLidOpened
TEST=MaximizeModeController.UnstableHingeAnglesWhenLidRecentlyOpened
TEST=MaximizeModeController.UnstableHingAnglesWithLidOpened

Review URL: https://codereview.chromium.org/412013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287625 0039d316-1c4b-4281-b951-d872f2087c98

Experiment is no longer running and is in many ways obsolete. Removing the code.

BUG=None
TEST=manual

Review URL: https://codereview.chromium.org/437803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287624 0039d316-1c4b-4281-b951-d872f2087c98

This change moves all non-API classes to
sync/internal_api/public/attachments/ so that the various sync
sub-components may depend on sync/api/attachments without risking a
cyclic dependency.

Remove unused variables and includes from
attachment_service_proxy_unittest.cc.

Remove an unnecessary forward declaration from
attachment_service_proxy.h.

TBR=nkostylev@chromium.org,pam@chromium.org,bengr@chromium.org,brettw@chromium.org,miket@chromium.org,pkotwicz@chromium.org,msw@chromium.org

Review URL: https://codereview.chromium.org/436373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287623 0039d316-1c4b-4281-b951-d872f2087c98

I suspect that the flakiness was caused by X11WholeScreenMoveLoop::RunMoveLoop()
sometimes failing. This CL fixes this potential source of flakiness by using
a stub move loop in tests.

BUG=396468
TEST=None
TBR=erg

Review URL: https://codereview.chromium.org/431973006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50968,51153,58561,58574,370210
NOTRY=true
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/447623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287621 0039d316-1c4b-4281-b951-d872f2087c98

Now that hit-testing for views (crbug.com/388838) and
event-targeting for views (crbug.com/391845) use
ViewTargeterDelegate to define custom behaviour for
these operations (instead of the now-obsolete
approach of subclassing ViewTargeter itself), we
should not be calling into EventTargeter for this
purpose. Changes in this CL:

* Finding the target of a scroll event is now
  performed correctly by using the logic in
  ViewTargeterDelegate and its overrides.

* The dead code
  ViewTargeter::SubtreeCanAcceptEvent(),
  ViewTargeter::EventLocationInsideBounds(),
  and ViewTargeter::BoundsForEvent() have been
  removed along with their corresponding tests.

* The class-level documentation for ViewTargeter
  and ViewTargeterDelegate has been updated
  to clarify the purpose of these classes.

BUG=395387,370579
TEST=ViewTargeterTest.*

Review URL: https://codereview.chromium.org/426443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400892
R=robliao@chromium.org
TBR=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/442983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287619 0039d316-1c4b-4281-b951-d872f2087c98

BUG=385396
NOTRY=true
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/446693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287618 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/445723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399835

Review URL: https://codereview.chromium.org/427713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287614 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/429693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287613 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Revert of Telemetry: Last ditch effort to dump symbols on tab crashes if none are found (https://codereview.chromium.org/318123002/)"

This reverts https://codereview.chromium.org/320693002/

The original regression this caused (PageRunnerTests.testHandlingOfCrashedTab in telemetry_unittests) does not seem to be happening anymore (locally or on trybots), but please revert and let me know if it happens on the main waterfall.

TBR=tonyg,dtu
BUG=

Review URL: https://codereview.chromium.org/444453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287612 0039d316-1c4b-4281-b951-d872f2087c98

As of https://src.chromium.org/viewvc/blink?view=rev&revision=179240, Blink
no longer implements the behaviour that corresponds to this change.  Everything
is handled blink-side, so remove this support.

Review URL: https://codereview.chromium.org/438733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287611 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, the local NTP resources and the C++ code related to serving it (skipping over search and instant stuff).

BUG=None

Review URL: https://codereview.chromium.org/444593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287610 0039d316-1c4b-4281-b951-d872f2087c98

Moving ConvertPointToScreen and ConvertPointFromScreen from ash::wm into
aura::Window. The suggestion to do this was made here:
https://codereview.chromium.org/420603011/diff/1/athena/wm/coordinate_conversion.h

BUG=NONE

Review URL: https://codereview.chromium.org/425363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287609 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Modify data_reduction_proxy_header to support tamper detection logic. (https://codereview.chromium.org/387353003/)

Reason for revert:
Causes DataReductionProxyHeadersTest.GetDataReductionProxyHeaderWithFingerprintRemoved to timeout on the bots.

TBR=bengr1@chromium.org, tonyg@chromium.org, bolian@chromium.org, yfriedman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=381907

Original issue's description:
> 1. Adds action-parsing functionality for data reduction proxy header.
> 
> 2. Adds a couple of functions to return different fingerprint value for tamper detection.
> 
> 3. Adds a function to remove Chrome-Proxy header's fingerprint from its header values, and return the rest of header values.
> 
> 4. Changes HasDataReductionProxyViaHeader to also tell 
> whether data reduction proxy Via header occurs at the last 
> or not.
> 
> 
> BUG=381907
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287561

Review URL: https://codereview.chromium.org/444723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287608 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389084,396399

Review URL: https://codereview.chromium.org/437143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287607 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Appears to have destabilized RenderFrameHostManagerTest.AllowTargetedNavigationsAfterSwap

Original issue's description:
> Start using RenderFrameProxyHost objects.
> 
> Instantiate RenderFrameProxyHost objects for remote frames when using
> --site-per-process.
> 
> BUG=357747, 399709, 399775, 400594
> TBR=kenrb, creis, kalman
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287557

TBR=kenrb@chromium.org,creis@chromium.org,kalman@chromium.org,nick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357747, 399709, 399775, 400594

Review URL: https://codereview.chromium.org/438393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287605 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/446663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287603 0039d316-1c4b-4281-b951-d872f2087c98

Touching or clicking on the background page while in overview mode will now
dismiss it.

BUG=364507

TEST=TBA

Review URL: https://codereview.chromium.org/435023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287601 0039d316-1c4b-4281-b951-d872f2087c98

Design Doc: https://docs.google.com/a/chromium.org/document/d/1oQwmj3AU4QYhTyGrYEGr6zaZhHUfx-wqUgEcQGbUU-U/edit#

BUG=372607

Review URL: https://codereview.chromium.org/435293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287600 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/445573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287598 0039d316-1c4b-4281-b951-d872f2087c98

Add method getAllHeaders to get HttpUrlRequest response headers. It handles multiple headers with the same name.
For compatibility with HttpUrlConnection it includes Http status line as value for NULL key.

BUG=390267

Review URL: https://codereview.chromium.org/423163007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394756

Review URL: https://codereview.chromium.org/437353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287596 0039d316-1c4b-4281-b951-d872f2087c98

We no longer sample output and energy_consumption_mwh is the canonical final
metric. This didn't show up on the unittesting bots because they don't run
10.9 where we can measure power.

BUG=400606

Review URL: https://codereview.chromium.org/446593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400734

Review URL: https://codereview.chromium.org/440783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287593 0039d316-1c4b-4281-b951-d872f2087c98

Previously the code would dismiss at most one error dialog before or
after running a test. This now loops until no error dialogs are shown.

This should reduce the instance of INJECTION_EVENT failures, but won't
cure them completely.

BUG=399870

Review URL: https://codereview.chromium.org/445503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287592 0039d316-1c4b-4281-b951-d872f2087c98

Add EM_X86_64 and support for x86_64 relocations.

BUG=369133

Review URL: https://codereview.chromium.org/346583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287591 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287590 0039d316-1c4b-4281-b951-d872f2087c98

This test has been quite flaky on MacOS 10.6 Sync tests.

BUG=400806
TBR=rlarocque

Review URL: https://codereview.chromium.org/441053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287588 0039d316-1c4b-4281-b951-d872f2087c98