- 21 Jul, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This is a reland of ee99ff7f Original change's description: > [base] Prepare //net for base::string16 switch > > This change prepares //net for the switch of base::string16 to > std::u16string on all platforms. This was achieved by making > net_unittests compile on Windows after the switch was made. > > Furthermore, it fixes small issues in //base and //sql. > > Bug: 911896 > Change-Id: I11fd80998e9f5e954a87870533685a3f77fa42d9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303431 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790126} TBR=wfh Bug: 911896 Change-Id: Ibbd6cb6695b40149971186f05ffb6b859acd68f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309689 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#790444}
-
chrome://settings/content/cookieschrome://settings/cookiessauski authored
Recently the chrome://settings/content/cookies URL has been deprecated in favor of the chrome://settings/cookies URL. This CL adds a redirection mechanism to ensure existing direct links continue to function. Bug: 1103539 Change-Id: I5fcb354106b50848fa9a0d84fc0403568b42bab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289773 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#790443}
-
Justin Cohen authored
Speculative fix for some full screen PDF tests. Change-Id: I5a96eb529e457c61701b6cfe08fc65888438b58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310191 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790442}
-
Brandon Walderman authored
This change implements the Set Storage Access command for TestDriver in Blink and content_shell: https://privacycg.github.io/storage-access/#automation This is needed to support more in-depth WPT tests for the Storage Access API. The current WPT tests for this feature cover basic IDL behavior, but are not able to verify that the requestStorageAccess API itself is functional because the browser must first be put into a state where third-party cookies are blocked. A new set_storage_access method has been added to testdriver.js. It functions similarly to the existing set_permission method. This calls a Blink-internal method that forwards the passed in arguments to the content shell via Mojo. A new WebTestStorageAccessManager class in the content shell converts the arguments into ContentSettingsPatterns and passes these settings to the CookieManager. The WebTestStorageAccessManager also enables third-party cookie blocking so that these rules will take effect. Bug: 1096803 Change-Id: I635687e7d00cf95fa2cf54fb86e1f65a0fe85f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253280Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Brandon Walderman <brwalder@microsoft.com> Cr-Commit-Position: refs/heads/master@{#790441}
-
Katie Dektar authored
This reverts commit eb6596e7. Reason for revert: Suspected to have broken compile on Android: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/13404? Original change's description: > Refactor DisplayCutoutController to prepare for componentization. > > DisplayCutoutController is split into DisplayCutoutController > (destined for //components) and DisplayCutoutTabHelper (which stays > in //chrome). Relocation/reuse will occur in a follow up CL. > > TBR=dtrainor@chromium.org > Bug: 1095714 > > Change-Id: Ie119069ae4756baf73acc23d655665fce1d4c035 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296888 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790402} TBR=dtrainor@chromium.org,estade@chromium.org,beccahughes@chromium.org Change-Id: I9821d88e9e06163aae93800ae84ed21fb32ac180 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1095714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310131Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#790440}
-
David Grogan authored
Flex uses image preferred widths as flex-basis. When an image has max-height:blah%, that can affect its preferred width. FlexNG wasn't passing the percent resolution height to legacy for this calculation, and the % max-height was being treated as auto. ComputeMinAndMaxContentContribution was already doing this for replaced elements, so piggy-back on that code. Bug: 1107604 Change-Id: Icecb312ce8aee22cad6e4b1925aab77ecbd3c2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309048Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#790439}
-
Rijubrata Bhaumik authored
We added support for multiple scan invocations on the same Reader in this CL https://chromium-review.googlesource.com/c/chromium/src/+/2145263 Since Origin Trials feedback was to remove Filtering, spec : https://github.com/w3c/web-nfc/pull/565 WIP CL : https://chromium-review.googlesource.com/c/chromium/src/+/2225770/ we tried to reason if in a world without filtering, multiple scans on the same Reader is needed at all. The present thinking is to simply reject scan promise when there's already an ongoing scan. Spec discussions: https://github.com/w3c/web-nfc/issues/592 Bug: 520391 Change-Id: Ic50873ddc30351cec6656ac7b030394dc9fa18ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297559 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#790438}
-
Ben Wagner authored
These should be added to a 'public' variable, but Skia does not yet export enough '*_public' variables to make a complete 'public' list. These files should in the meantime be added to 'sources' so that the build and 'analyze' steps are aware of them. Change-Id: Ia3a8920d803c2e27593af99932b1350d31cea886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300272Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Auto-Submit: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790437}
-
Wei-Yin Chen (陳威尹) authored
This is a reland of ed8ef709 Original change's description: > Amend dom-distiller script for bug ID handling > > "None" would be ignored, and add space after ",". > > Bug: None > Change-Id: I85167f2e9ba0cea7affd754825fd34e817568bd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304337 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789569} Bug: None Change-Id: I2d77fa208af77bf18e2e0626d69f420e620a9995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305055Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790436}
-
Lei Zhang authored
It is easier to understand vs. base::DeleteFile(path, true). Bug: 1009837 Change-Id: I97c80413b319b070d1e95a96a6acbae0bd086d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285916Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Edward Lesmes authored
Bug: 1107663 Change-Id: Iddb187ca9ecf5d390189142669c03ad5568e81fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309134Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#790434}
-
Wei-Yin Chen (陳威尹) authored
This is a reland of 033b5754 Original change's description: > Use code review in DOM distiller dist repo > > Before this CL, this script builds DOM distiller, pushes the compiled > artifacts to the dom-distiller/dist repo, and generates a local commit > for rolling. The local commit needs to be uploaded as a CL. > > In order to avoid pushing without reviewing, we want to generate a CL > in the dom-distiller/dist repo instead of directly pushing to it. > > When reviewing the CL in the dom-distiller/dist repo, the reviewer > needs to run update_domdistiller_js.sh in validation mode to make sure > the artifacts in the CL are identical to local output. > > Bug: None > Change-Id: Ia29c1686106c3516f341e4d826aca69842ac5668 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304338 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789575} Bug: None Change-Id: I361ece06de4fc744b06a46f6924abaec20bf81de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304995Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a7bd9cbfeffa..8fbd57f0d966 2020-07-21 vapier@chromium.org licensing: add analogix-anx3429-firmware to Google-TOS list 2020-07-21 jiancai@google.com toolchain: create unique names for clang crash diagnoses 2020-07-21 khwon@chromium.org build-ap: switch to coreboot from coreboot-zork 2020-07-21 vapier@chromium.org locking: move chatty lines to debug 2020-07-21 tcwang@google.com toolchain: Use temp bucket for unvetted artifacts on branches 2020-07-20 briannorris@chromium.org vm: drop deprecated -usbdevice If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2c0c808e4000d508929e643358445a4cf717416f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309985Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790432}
-
Peter Marshall authored
Change-Id: Ia29fc63cbae53d5f4cdcbb9d644682a138431c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309693 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#790431}
-
Clemens Arbesser authored
This bridges the gap between legacy UserData and the new UserModel. For now, only additional values can be requested, but this can be easily extended to apply to the selected card/profile etc. as well. All values requested in this manner will be client-side only and never leave the device. Bug: b/145043394 Change-Id: Iaf3fe8af7a24418eabe36393b5428752a1d20aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308417Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#790430}
-
Sammie Quon authored
It used to start a new animation if the power button was pressed in the middle of a power menu animation. It's really hard to see without slow animations, but some users have noticed. Fixes this by using IMMEDIATE_ANIMATE_TO_TARGET to animate from the current opacity to the target. Also avoids recreating the contents of the widget on each press. Test: manual Change-Id: I2361e431cae9bb74a37b29354b6b0825e81ca4ac Fixed: 832975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297746Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#790429}
-
Mohamed Heikal authored
A collection of bugfixes for creating R.java in java_library_impl targets: - test libraries support. - apk under test R.java shadowing bugfix. - always generate onResourcesLoaded like package resources did. - Fix issue where R.java is not generated for the apk package name. - Change webAPK manifest package name (remove .new because it is a java keyword). Reason for reland: Fixed build issue with webAPKs. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2302919 This reverts commit 1895ffb4 Bug: 1073476 Change-Id: Ic095091eb64db32d1653e219f507463de59cacf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307809 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#790428}
-
Andre Le authored
BUG=1105851 Change-Id: Id07b79538a69b9bbdd5b0033e1d60c5e94d20b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303052Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#790427}
-
Devlin Cronin authored
Move //c/c/extensions/manifest_handlers/extension_action_handler.[h|cc] to //extensions/common/manifest_handlers/, since it has no //chrome dependencies. This is a pure move; there are no functional changes. Bug: 1073590 Change-Id: I329a7a7901a90ad972173ed999de250fbdb4fcba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259517Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790426}
-
Benoit Lize authored
Modulo operations are very slow, replace it with a subtraction and a bitmask operation. Bug: 998048 Change-Id: Iff08febd395c7735c416ced4914e32fcf4d9f81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309696 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#790425}
-
Scott Violet authored
This makes it so that ShouldUpdateHistory() returns false for same document navigations to the same url without a user gesture. A common use of this history.replaceState(), which we don't really want logged to history as it's not really what the user thinks of as a navigation. BUG=1103495 TEST=HistoryBrowserTest.ReplaceStateSamePageIsNotRecorded Change-Id: Iafc0c7b93298940eb76cd1ca93ba7ffe3b2d32df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305236 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#790424}
-
Michael Crouse authored
This change creates the mojom interface and a LiteVideoHint struct to pass the information from the browser render frame host to the render frame agent to be used for throttling media request. These messages are sent once per frame and only from the browser to the renderer. This change also makes the MaxThrottlingDelay finch controllable and passed via LiteVideoHint from the browser. This will make switching to controlling per origin via Cacao easier in the future. A future change will enable a message to be returned with the result of throttling requests for metrics and updating the user blocklist. Bug: 1082553, 1106013 Change-Id: I7019dbf6e9cb934b3c9276073d1de2662709c20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300931Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#790423}
-
Scott Violet authored
Prior to this patch targeting would potentially consider the parent. This is problematic as if there is a suitable child, then preferring the parent likely means targeting a container view, which generally doesn't do anything with events. Considering the parent for distance to center is also problematic in so far it means touches on the center of a parent are preferred over a touch on a child, even though the center is slightly off. TEST=none BUG=1085694 Change-Id: I8e65bddf2a48bef514094fb29c8aed2dbbc46176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295439Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#790422}
-
Olivier Robin authored
As AddCount is not exposed in macros, use directly histograms functions. As only one report is received every 24 hours, not caching the histogram should not be an issue. This is still behind a flag and only enabled on canary. Bug: 1017434 Change-Id: I47680e10ec5030b1d6e68c845a5cbb1ae91f92f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283742Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790421}
-
arthursonzogni authored
All of this is put behind a flag disabled by default. This is mostly based on the initial prototype: https://chromium-review.googlesource.com/c/chromium/src/+/2223934/24 Define, plumb and use the "report-type" for COOP access reporting. COOP access reporting: [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 [5/N] this patch. Bug: chromium:1090273 Change-Id: I5e51b3da6a20c85c073ea1fd84ea74557760a42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309433 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
-
Haiyang Pan authored
This reverts commit 8e827fbf. Reason for revert: org.chromium.chrome.features.start_surface.StartSurfaceTest#testShow_SingleAsTabSwitcher__Instant_Return is flaky in android-marshmallow-arm64-rel CQ builders: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVylAELEgVGbGFrZSKIAWNocm9taXVtQGNocm9tZV9wdWJsaWNfdGVzdF9hcGtAb3JnLmNocm9taXVtLmNocm9tZS5mZWF0dXJlcy5zdGFydF9zdXJmYWNlLlN0YXJ0U3VyZmFjZVRlc3QjdGVzdFNob3dfU2luZ2xlQXNUYWJTd2l0Y2hlcl9fSW5zdGFudF9SZXR1cm4M And in the following CI builders since this CL, starting at https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1539 https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/1299 Original change's description: > [Instant Start] Make more StartSurface tests work in Instant Start. > > Bug: 1103838, 1092642, 1076274 > Change-Id: I6bf58ef38c834ce15fae04f0743f646fcb98970f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290755 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Xi Han <hanxi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790119} TBR=hanxi@chromium.org,wychen@chromium.org Change-Id: I6770e34e23c6b5c3d3d2b94642113677b38b8b8b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103838 Bug: 1092642 Bug: 1076274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309752Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#790419}
-
Dave Tapuska authored
Since this structure is used in both the browser & renderer it should move into common. This will make it cleaner to typemap this value in a later CL. BUG=1097816 Change-Id: I08bbe4bc357727c3c2401159868ac1744f3527ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303356 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
-
Benoit Lize authored
This was already attempted in the past, but had to be reverted due to failures on macOS (see crbug.com/890752). This is because pages decommit is not synchronous on macOS, but it is on other platorms. The revert actually cost more performance than was necessary, as it affected all platforms, and also newly allocated pages, which are guaranteed to be zeroed on all operating systems. As a consequence, allocating a large ArrayBuffer for instance can be pretty slow (and even crash), since the memory is expliclty zeroed at the allocation site. This CL adds the simplest fix: - Newly allocated pages are never needlessly zeroed - Recommitted ones are only zeroed on macOS The expected impact is: - Faster large allocations (and perhaps less crashy, at least on systems such as Linux/Android with overcommit), including ArrayBuffers. - Faster allocations of zeroed memory on !macOS systems. Bug: 864462, 890752, 998048 Change-Id: I4e3d7d8d63ecea41923db3b9ae8613719df7c712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308419Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#790417}
-
Matthias Körber authored
Tools to build patterns for parsing autofill types from named capture groups. Bug: 1099202 Change-Id: I2bf6f1e3ed0e767c897830732adc6b508cbf99db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302172 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#790416}
-
Matthias Körber authored
expressions. This utility class lazily builds the patterns, compiles and caches enumerated regular expressions that are used for parsing and matching. The justification for this is that it becomes unnecessary to repeatedly rebuild patterns and pass them around the code. Further, a future integration of a component updater to change the patterns behind on of the expressions becomes minimally invasive. Change-Id: Icb7082e504603b43358a6d84f853e7b5336c3cad Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299632 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
-
Ben Goldberger authored
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/2196817 Bug: 1079458 Change-Id: I22dc45f0399b3978e494ab20b66ef5126ccea580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231906 Auto-Submit: Ben Goldberger <benwgold@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL renames some account picker bottom sheet tests to make all test names consistent and put the if branch in the account picker view binder in to the nest to make the view binding if branches more consistent. Bug: 1106442 Change-Id: I33b84a7bca0513ce443b63c3bcd2895031de003b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308418 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790413}
-
chrome://internals/web-appAlan Cutter authored
This code path forgot to early exit from the function. Bug: 1104250 Change-Id: I16cdbfeaa8028998014476f590ebe6067eff1c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308438 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#790412}
-
Julian Mentasti-Meza authored
Generates a PDF of the webView and invokes the callback with the NSData of the PDF or nil if a PDF couldn't be generated. The WebState calls the WebController that will invoke WKWebViewUtility's CreateFullPagePDF with the current webView. The callback is passed though at each step. Bug: 1103777 Change-Id: I3b83082937849e2851f6ceb1954b91cc0bc242ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295784 Commit-Queue: Julian Mentasti-Meza <jmentasti@google.com> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#790411}
-
Andrew Grieve authored
This reverts commit 57deecbb. Reason for reland: Suppressed cast lint warning Reverted in: 339e6581. > Original change's description: > > Android: Updates to warnings-as-errors when building > > > > * Delete java_warnings_as_errors > > * Use treat_warnings_as_errors for android rules > > * warnings-as-errors is now default true for debug builds > > * Add --warnings-as-errors to proguard.py, dex.py, bytecode_processor.py > > so that these warnings can all be turned off locally. > > * Made build_utils.CheckOutput fail by default when stderr or stdout is > > printed. This should prevent build logs from creaping in. > > * Added "you should use treat_warnings_as_errors=false" into error > > message when builds fail due to warnings. TBR=wnwen@chromium.org,dpranke@google.com,agrieve@chromium.org,andruud@chromium.org Bug: 1029357 Change-Id: I56c1349c6e823737aa8a59a8e961e5a518667ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308868 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Edward Lesmes authored
Bug: 949535 Change-Id: I725ec313f78b7551839c6fd3454bb3f7edeab07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309033Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
-
Marc Treib authored
- Remove unnecessary indentation - Use "show-on-attach" attribute instead of custom code - s/Tap/Click/ Inspired by comments on crrev.com/c/2288850 Bug: none Change-Id: If0bc7fb58e2d0a41fa272cf90feb014ad859d739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309430Reviewed-by:
-
kylechar authored
Change SkiaRenderer to use similar logic to GLRenderer on context loss where the loss is considered a synthetic loss unless it was triggered by the GL robustness extension. Synthetic loss doesn't trigger GPU process restart. Bug: 1091787 Change-Id: Ie3613dff69f9a0e8816d17f344ff690b297153de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302924 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790407}
-
Darwin Huang authored
Removed unused versioning support in ClipboardInternal. This allowed for multiple ClipboardData items on a clipboard stack, but the stack size was limited to 1, and no logic existed to exercise use of any stack items except the top item on the stack. Therefore, this essentially amounted to extra logic that wasn't actually needed or used. Versioning support has been available since at least 2012, when https://crrev.com/10829341 first introduced this file as a "sketch of a clipboard implementation for linux_aura". Change-Id: I7615a97bdd4ef038b0684c75536d2417d746bffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309549 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Mehrdad Hessar authored
Bug: 1099030 Change-Id: Ibab49ba7816720c3abcba35dafd09be553788bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309140Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mehrdad Hessar <mehrdadh@google.com> Cr-Commit-Position: refs/heads/master@{#790405}
-
