GitLab

This is the last step in factoring compute_interfaces_info:
EventInterfaces.in is a simple auxiliary file that's largely unrelated to
bindings.
Splitting it out means compute_interfaces_info now purely computes interfaces
info!
This means we can reuse it without needing dummy files (e.g., in r-b-t and in
gyp), and also simplifies its code.

We can actually simplify both scripts (and r-b-t) further,
but this is a conservative CL, just splitting it out.

BUG=341748
R=haraken

Review URL: https://codereview.chromium.org/185303008

git-svn-id: svn://svn.chromium.org/blink/trunk@168499 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Move testRunner.startSpeechInput/setValueForUser to internals (https://codereview.chromium.org/176953009/)

Reason for revert:
Broke the Android compile:
  http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28dbg%29/builds/25493/steps/compile/logs/stdio

Android does not enable speech input, and the methods called are guarded behind the ENABLE_INPUT_SPEECH compile-time flag. The testing code in Internals.cpp should also be guarded with the same flag.

Original issue's description:
> Move testRunner.startSpeechInput/setValueForUser to internals
> 
> Now TestRunner is being moved from CppBoundClass to gin::Wrappable,
> where it is not appropriate to use WebElements directly. This CL moves
> some functions which treats WebElement* from testRunner to internals.
> (To be exact, this CL only copies some functions, but I'll remove those ones
> in testRunner later.)
> 
> BUG=331301
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168495

TBR=haraken@chromium.org,hajimehoshi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=331301

Review URL: https://codereview.chromium.org/187903004

git-svn-id: svn://svn.chromium.org/blink/trunk@168498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This follows the spec change on https://www.w3.org/Bugs/Public/show_bug.cgi?id=24905
where the fetch origin is given by the master document, not the referring document.
This matches what CSP in imports is doing: Using master's CSP directive to regulate
all the imports.

In implemntation, it just set ResourceLoaderOptions::m_securityOrigin in
FetchRequest::setCrossOriginAccessControl() because HTMLImportsController
happened to pass the master' origin already.
(That was wrong but wasn't covered by the test.)

This change doesn't affect other FetchRequest client because in other callsite,
m_securityOrigin is same as one that is used when it is absent.

TEST=cors-same-origin.html
BUG=348671
R=abarth@chromium.org, dglazkov@chromium.org

Review URL: https://codereview.chromium.org/186803005

git-svn-id: svn://svn.chromium.org/blink/trunk@168497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=loislo

Review URL: https://codereview.chromium.org/180783018

git-svn-id: svn://svn.chromium.org/blink/trunk@168496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now TestRunner is being moved from CppBoundClass to gin::Wrappable,
where it is not appropriate to use WebElements directly. This CL moves
some functions which treats WebElement* from testRunner to internals.
(To be exact, this CL only copies some functions, but I'll remove those ones
in testRunner later.)

BUG=331301

Review URL: https://codereview.chromium.org/176953009

git-svn-id: svn://svn.chromium.org/blink/trunk@168495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#the-datatransfer-interface

The spec uses DataTransfer and both Firefox and IE agrees.

BUG=348580
R=ch.dumez@samsung.com, tkent@chromium.org

Review URL: https://codereview.chromium.org/183743013

git-svn-id: svn://svn.chromium.org/blink/trunk@168494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Move all RefPtr's to CSSValue to oilpan transition types, except for the one in CSSCursorImageValue. (https://codereview.chromium.org/184313004/)

Reason for revert:
It seems to break some of our layout tests.

Original issue's description:
> Move all RefPtr's to CSSValue to oilpan transition types, except for the one in CSSCursorImageValue.
> 
> This change gets rid of all but one RefPtr to CSSValue. I have introduced a few persistents core/animation/..., core/css/StylePropertySet, and ElementStyleResources. I plan to attack the one in CSSCursorImageValue subsequently, and then change CSSValue from RefCountedGarbageCollected to GarbageCollectedFinalized.
> 
> R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
> BUG=341815
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168466

TBR=ager@chromium.org,erik.corry@gmail.com,haraken@chromium.org,oilpan-reviews@chromium.org,tkent@chromium.org,vegorov@chromium.org,zerny@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=341815

Review URL: https://codereview.chromium.org/184853009

git-svn-id: svn://svn.chromium.org/blink/trunk@168492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test was loading an image but didn't wait for the image
to fully load to get all the invalidations generated. The
extra 2 invalidations come from the image (92 x 100)
and its container (402 x 100).

The fix involves allowing our invalidation harness to
run asynchronously. While touching the code, removed
some unneeded window-prefix.

BUG=313447
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/184213004

git-svn-id: svn://svn.chromium.org/blink/trunk@168491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The method HitTestResult::isMisspelled() assumed that renderer would
always be present in the right-clicked editable item. This is not the case
when right-clicking on an item in an editable combobox created by jQuery
Searchable DropDown Plugin (http://jsearchdropdown.sf.net).

This patch changes HitTestResult::isMisspelled() to check if the renderer
is present. If there's no renderer, then the method returns false (there
shouldn't be spellcheck related items in the context menu).

Manual test 1: Click on the drop-down on http://jsearchdropdown.sf.net and
right-click on any of the items. The page should not crash.

Manual test 2: Run the following script and right-click anywhere on the
page. The page should not crash.

<html>
<head>
<script>
window.onload = function() {
  var element = document.getElementsByTagName('html')[0];
  document.adoptNode(element);
  var newElement = document.createElementNS('http://www.w3.org/2000/svg', 'title');
  document.appendChild(newElement);
  document.execCommand('SelectAll', false)
  document.designMode = 'on';
};
</script>
</head>
</html>

TEST=LayoutTests/editing/spelling/right-click-no-renderer-crash.html
BUG=304165

Review URL: https://codereview.chromium.org/26168008

git-svn-id: svn://svn.chromium.org/blink/trunk@168490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's useful.

R=hartmanng@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/176963018

git-svn-id: svn://svn.chromium.org/blink/trunk@168489 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We used have a shared super class called CanvasRenderingContext for
CanvasRenderingContext2D and WebGLRenderingContext. This does not
match the spec and it does not match Firefox or IE.

This removes the web exposed idl file for CanvasRenderingContext. The
method that used to return a CanvasRenderingContext now return a
(CanvasRenderingContext2D or WebGLRenderingContext) instead.

This also allows us to remove the custom bindings that was needed for
CanvasRenderingContext

This is a web exposed visible change. CanvasRenderingContext was
discoverable by walking the prototype chain. It was never exposed as a
named property of Window.

BUG=348012
R=ch.dumez@samsung.com, kbr@chromium.org, tkent@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=2cda866

Review URL: https://codereview.chromium.org/177983005

git-svn-id: svn://svn.chromium.org/blink/trunk@168488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken@chromium.org, wibling@chromium.org
TBR=betravis@adobe.com, haraken@chromium.org, wibling@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/184293008

git-svn-id: svn://svn.chromium.org/blink/trunk@168487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Remove support for legacy WebKit Notifications (https://codereview.chromium.org/184733002/)

Reason for revert:
Broke interactive_ui_tests and browser_tests, as pointed out by cbiesinger.

http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/35005

Original issue's description:
> Remove support for legacy WebKit Notifications
> 
> This patch removes support for the legacy WebKit notifications from Blink,
> per the following Intent to Remove thread:
> 
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8vqyfHa8_dw
> 
> BUG=348019
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168471

TBR=atwilson@chromium.org,jochen@chromium.org,abarth@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=348019

Review URL: https://codereview.chromium.org/187323005

git-svn-id: svn://svn.chromium.org/blink/trunk@168486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=349015
R=mvanouwerkerk@chromium.org

Review URL: https://codereview.chromium.org/183683018

git-svn-id: svn://svn.chromium.org/blink/trunk@168485 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=349392
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/183763036

git-svn-id: svn://svn.chromium.org/blink/trunk@168484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=loislo@chromium.org

Review URL: https://codereview.chromium.org/187473005

git-svn-id: svn://svn.chromium.org/blink/trunk@168483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebInputEventFactory::gestureEvent was added a long time ago but is
not currently used.  Remove the existing unused code and update the
function to support creating GesturePinchUpdate events from Cocoa
NSEventTypeMagnify events.

BUG=289887

Review URL: https://codereview.chromium.org/184983003

git-svn-id: svn://svn.chromium.org/blink/trunk@168482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Caused assertion failures on debug GPU bots. See Issue 344393 for details.

> WebGL: Transfer ownership of WebGraphicsContext3D from WebGLRenderingContext to DrawingBuffer.
> 
> Currently, the lifecycle of DrawingBuffer is different from it of
> WebGraphicsContext3D, so there is so many checks if the context is valid.
> This complexity is not necessary because DrawingBuffer does not own any
> objects when the context is lost or impossible to be created.
> 
> To be clear the lifecycle, this CL makes DrawingBuffer take ownership of WebGraphicsContext3D.
> 
> The DrawingBuffer creation or resize can fail if the memory is not enough. This
> logic is preserved.
> In detail,
> 1. If it occurs during WebGLRenderingContext creation, we give up creating
> WebGLRenderingContext.
> 2. If it occurs during restoration of lost context, we will try again.
> 3. If it occurs during resizing DrawingBuffer, we slightly ignore, because we
> can reuse different size FBO in this case.
> 
> In addition, this CL fixes two bugs.
> 1. maybeRestoreContext() pretends to success to restore although creating FBO in
> DrawingBuffer fails. As mentioned earlier, we will try again.
> 2. WebGLRenderingContext calls DrawingBuffer::reset() twice during creation,
> because the constructor of DrawingBuffer internally calls reset().
> 
> BUG=344393
> 
> Review URL: https://codereview.chromium.org/163773007

TBR=dongseong.hwang@intel.com

Review URL: https://codereview.chromium.org/184343005

git-svn-id: svn://svn.chromium.org/blink/trunk@168481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No behavioral changes, architecture only:
  - padding rows are moved back to the datagrid
  - children access are made through Node.allChildren()
  - minor cosmetic changes

BUG=255363
R=yurys@chromium.org

Review URL: https://codereview.chromium.org/187703002

git-svn-id: svn://svn.chromium.org/blink/trunk@168480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL moves most of the implementation out of RenderSVGModelObject and
into SVGSVGElement (which is the only client). Some notes:

* use the consolidated SVGGraphicsElement::computeCTM() (which is
  accumulating localCoordinateSpaceTransform()s and not
  localToParentTransform()s like the old getElementCTM() did <- root
  cause for the zooming bug)
* only force a layout update once, at the entry point, instead of on each
  getElementCTM() call.
* detect the stopping element on the fly, instead of an additional upfront
  ancestor crawl.
* transforms are now correctly computed relative to the target <svg>
  element instead of the nearest viewport.

BUG=155277
R=pdr@chromium.org,schenney@chromium.org,fs@opera.com,rob.buis@samsung.com

Review URL: https://codereview.chromium.org/185333004

git-svn-id: svn://svn.chromium.org/blink/trunk@168479 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test scenarios:
http://www.rbyers.net/eventTest.html - scrolling the page or div (has a wheel handler but doesn't call preventDefault)
Loading https://twitter.com/pwnall

BUG=343132

Review URL: https://codereview.chromium.org/180803012

git-svn-id: svn://svn.chromium.org/blink/trunk@168478 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a shape and box are supplied for a shape-property, the order they
are input should be preserved in output from the CSSOM. This patch parses
the shape and box values as a CSSValueList to preserve that ordering,
and removes the need for BasicShapes to have a sizing box.

BUG=322165

Review URL: https://codereview.chromium.org/144143005

git-svn-id: svn://svn.chromium.org/blink/trunk@168477 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add FontStretch enum and field to FontDescription and FontTraitsMask.
This is the first step towards supporting the CSS font-stretch
property.

TEST=Source/platform/fonts/FontDescriptionTest.cpp
BUG=347765
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/183813005

git-svn-id: svn://svn.chromium.org/blink/trunk@168476 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When resetting the animated property value for animations that is applied
as a CSS property always create a new property, or additive animations
will accumulate incorrectly to the underlying value.

BUG=349052

Review URL: https://codereview.chromium.org/183973023

git-svn-id: svn://svn.chromium.org/blink/trunk@168475 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaControls::create returns null if any of these would be null.

BUG=341813
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/182383006

git-svn-id: svn://svn.chromium.org/blink/trunk@168474 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixed position elements are clipped by CSS clip ancestors,
which may be between the fixed position element and its
containingBlock. So clippingAncestor needs to walk up the
ancestors of a fixed positioned element manually instead
of using containingBlock directly.

I believe this only applies to fixed position elements.
Other elements can use containingBlock because an absolutely
positioned ancestor will never get skipped in the
containingBlock traversal and CSS clip only applies to
absolutely positioned elements.

BUG=347172

Review URL: https://codereview.chromium.org/179833006

git-svn-id: svn://svn.chromium.org/blink/trunk@168473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It will improve performance when POD types are copied, by providing
a missing implementation of VectorCopier and using it in
two places which were previously always taking the "new" allocation
path even though they could have used VectorCopier and used
memcpy for POD types.

NOTRY=true

Review URL: https://codereview.chromium.org/178313002

git-svn-id: svn://svn.chromium.org/blink/trunk@168472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes support for the legacy WebKit notifications from Blink,
per the following Intent to Remove thread:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8vqyfHa8_dw

BUG=348019

Review URL: https://codereview.chromium.org/184733002

git-svn-id: svn://svn.chromium.org/blink/trunk@168471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mostly just remove code: net -190 lines
(also group type classes together, and replace some None with False)

Further simplification is possible, as we no longer need classes for
enums and unions; will do in followup, b/c more involved.

BUG=345137
TBR=haraken

Review URL: https://codereview.chromium.org/185303013

git-svn-id: svn://svn.chromium.org/blink/trunk@168470 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves InspectorStyleSheet::ensureSourceData to
ParsedStyleSheet.

BUG=

Review URL: https://codereview.chromium.org/183763029

git-svn-id: svn://svn.chromium.org/blink/trunk@168469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes some dead code from InspectorStyleSheet.

TBR=apavlov
BUG=

Review URL: https://codereview.chromium.org/186823002

git-svn-id: svn://svn.chromium.org/blink/trunk@168468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This leads to double finalization.

NOTRY=true

Review URL: https://codereview.chromium.org/180273022

git-svn-id: svn://svn.chromium.org/blink/trunk@168467 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move all RefPtr's to CSSValue to oilpan transition types, except for the one in CSSCursorImageValue.

This change gets rid of all but one RefPtr to CSSValue. I have introduced a few persistents core/animation/..., core/css/StylePropertySet, and ElementStyleResources. I plan to attack the one in CSSCursorImageValue subsequently, and then change CSSValue from RefCountedGarbageCollected to GarbageCollectedFinalized.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815
NOTRY=true

Review URL: https://codereview.chromium.org/184313004

git-svn-id: svn://svn.chromium.org/blink/trunk@168466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As part of the review of https://codereview.chromium.org/171383002/
it was requested that the required static strings for the media features and types will be generated as part of the build system.
This CL implements that request.

BUG=

Review URL: https://codereview.chromium.org/185533012

git-svn-id: svn://svn.chromium.org/blink/trunk@168465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The code in platform/drm contains minimal functionality now and can
be removed.

BUG=224791
TEST=EME content tests pass

Review URL: https://codereview.chromium.org/186093003

git-svn-id: svn://svn.chromium.org/blink/trunk@168464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=erik.corry@gmail.com, haraken@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/187483006

git-svn-id: svn://svn.chromium.org/blink/trunk@168463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ScriptPromise::ScriptPromise(v8::Handle<v8::Value>, v8::Isolate*) expects
that the first parameter is a Promise object, but no one checks that.
This CL fixes that.

Rename ScriptPromise::ScriptPromise(ScriptValue) to ScriptPromise::cast to
avoid the confusion caused by the diferrent behaviors with a non-Promise parameter.

BUG=347047

Review URL: https://codereview.chromium.org/181173002

git-svn-id: svn://svn.chromium.org/blink/trunk@168462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method has two logical parts: Advancing the text position and
checking for termination, and computing the metrics for the current
character.
Split this method to better show this. The latter part is put into a
new method, computeMetricsForCurrentCharacter, while the former part is
open-coded in SVGTextMetricsBuilder::measureTextRenderer.
The advance{Simple,Complex}Text methods are renamed to
computeMetricsForCurrentCharacter{Simple,Complex}.

With this change, it becomes easier to see that
SVGTextMetricsBuilder::m_currentMetrics can be trivially removed in favor
of returning it from computeMetricsForCurrentCharacter, and storing it on
the stack in SVGTextMetricsBuilder::measureTextRenderer.
The same is true for SVGTextMetricsBuilder::m_complexStartToCurrentMetrics,
which can be made local to computeMetricsForCurrentCharacterComplex.

Review URL: https://codereview.chromium.org/184103024

git-svn-id: svn://svn.chromium.org/blink/trunk@168461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This moves the File API and its objects to Oilpan using transition
types.

R=haraken@chromium.org,tkent@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/176853004

git-svn-id: svn://svn.chromium.org/blink/trunk@168460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Don't trace the RefPtr for the CSSCursorImageValue workaround. It is trace via the RefCountedGarbageCollected persistent.

We are correctly hitting an UNREACHABLE when tracing a RefPtr with
enable_oilpan=1 on the bots.

R=haraken@chromium.org, wibling@chromium.org, oilpan-reviews@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/177413009

git-svn-id: svn://svn.chromium.org/blink/trunk@168459 bbb929c8-8fbe-4397-9dbb-9b2b20218538