- 14 Nov, 2017 40 commits
-
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/9b9010d87517..74c8436f2c34 $ git log 9b9010d87..74c8436f2 --date=short --no-merges --format='%ad %ae %s' 2017-11-14 angle-deps-roller Roll skia/third_party/externals/angle2/ ff7aac5e4..f4f293eff (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I78b2cad79c7b8cbaff88b1e1d9f1807352eb8a7b Reviewed-on: https://chromium-review.googlesource.com/768648Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516245}
-
Stuart Langley authored
This CL removes the WTF type traits they were just forwarding through to the std:: equivalents. I kept the test code so we can be sure that the traits are what we expect them to be across different compilers and different platforms. Bug: 579462 Change-Id: Ia7ec17e1289d130dbafe13f6796acfa079a73805 Reviewed-on: https://chromium-review.googlesource.com/768100Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#516244}
-
Luciano Pacheco authored
Fix missing include for <memory> and some for <utility> as pointed by lint. CL 10 of 10. After all 10 CLs are merged, I'll remove WTF::MakeUnique. Bug: 755727 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id7021e32bc2c366ec35cdc31074cd7e3a04405ef Reviewed-on: https://chromium-review.googlesource.com/768597Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516243}
-
Colin Blundell authored
In several parts of the implementation of the chrome.identity.getAuthToken() extension API, it can launch a signin flow. This signin flow gets launched in response to discovering that the user isn't signed in or in response to an error occurring that indicates that the user needs to reauthenticate. However, the policies on launching the signin flow are flawed in ways that negatively impact users: (1) Several parts of the flow do not gate the number of times that they launch a signin UI. This can result in the browser becoming unusable if there are bugs that result in the flow looping without user intervention (see crbug.com/772122). (2) The implementation launches a signin UI even in cases where the user's refresh token is in a valid state, i.e., when the error is not one that can be fixed by the user reauthenticating. This is unnecessarily intrusive to the user. This CL solidies and unifies all of these policies into one: - Start a signin flow at most once and only if the user's refresh token is not in a valid state. This is a behavioral change that eliminates the possibility of hammering the user with login pages and avoids asking the user to reauth if we don't think that the problem is due to reauth. This CL also adds several tests that fail without the policy changes made in the CL. Note that this change *is* a behavioral change. To test that this change has not broken the common case of the user needing to reauth due to their refresh token being in a bad state, do the following: - Install an extension with the identity API in its manifest. - Sign in to Chrome. - Go to accounts.google.com and revoke your refresh token for Chrome there. - Ensure that your account in Chrome goes into an error state (verify that a red exclamation point appears in the top right by your account name). - Go to chrome://extensions, enable developer mode, and inspect the background page of the above app. At the JS console that that brings up, execute: chrome.identity.getAuthToken({interactive: true}, (token) => {console.log(token);} ) - Verify that a signin prompt then opens. - Sign in to Chrome. - Verify that at the JS console referenced above a token gets printed. Bug: 772122 Change-Id: I779134f706ca1e693612ae3352a5c5dd0a3e468f Reviewed-on: https://chromium-review.googlesource.com/758647Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#516242}
-
Lei Zhang authored
Change-Id: Ic7a5c9dda06f2556f2d4ea572394ae93d0372164 Reviewed-on: https://chromium-review.googlesource.com/768323Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#516241}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2eea3727..4e1cd28a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I53aef59301dab84cfd4e4085b95962bfa6bfd801 Reviewed-on: https://chromium-review.googlesource.com/768489Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#516240}
-
Yoshifumi Inoue authored
This patch introduces |CanUseInlineBox()| as a preparation to add |DCHECK(CanUseInlineBox())| to functions using |InlineBox| for marker of progress of LayoutNG project. To release LayoutNG, we should not hit these |DCHECK()|. Following patch will utilize |CanUseInlineBox()| into layout/ and editing/. The patch[1] is a sample of utilization. [1] http://crrev.com/c/763188 [LayoutNG] Utilize DCHECK(CanUseInlineBox()) in core/layout/ Bug: 591099, 707656 Change-Id: Id71c39ae8520ab18fd1b8b8f3e18a66e8a7d567c Reviewed-on: https://chromium-review.googlesource.com/768572Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#516239}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bf7e8d8a5001..a0e6b95cbb47 $ git log bf7e8d8a5..a0e6b95cb --date=short --no-merges --format='%ad %ae %s' 2017-11-13 iannucci [led] Roll led to latest version. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I02d88474b5dd600bd7e582f5f1a74b1edbd40bfb Reviewed-on: https://chromium-review.googlesource.com/768523Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516238}
-
Luciano Pacheco authored
Add missing <memory> and some other std headers as pointed by lint. CL 6 of 10. Bug: 755727 Change-Id: I0781468ccceb4b6bb22ced01290918cec241a1fb Reviewed-on: https://chromium-review.googlesource.com/768510Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516237}
-
Luciano Pacheco authored
Add include <memory> where needed according to lint. Bug: 755727 Change-Id: I4d0e52593f789fc4c23112d8dc178f21c766907c Reviewed-on: https://chromium-review.googlesource.com/765610Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516236}
-
Takashi SAKAMOTO authored
virtual/layout_ng/fast/block/float/intruding-float-add-in-sibling-block-on-static-position.html virtual/layout_ng/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2.html virtual/layout_ng/fast/block/float/overhanging-float-add-in-static-position-block.html virtual/layout_ng/fast/block/float/overhanging-float-add-in-static-position-block2.html virtual/layout_ng/fast/block/float/overhanging-float-remove-from-absolute-position-block.html virtual/layout_ng/fast/block/float/overhanging-float-remove-from-absolute-position-block2.html BUG=635619 TBR=dgozman Change-Id: I74707ebf7aa96f9cc911dffd2a7de4d9c2aa6ddd Reviewed-on: https://chromium-review.googlesource.com/768607 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#516235}
-
Han Leon authored
BUG=783563 Change-Id: Ia722365d7c893829366caa80116176dcde4015f5 Reviewed-on: https://chromium-review.googlesource.com/765294Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#516234}
-
Olivier Robin authored
This reverts commit 0cd65fc5. Reason for revert: breaks official builds Original change's description: > Reland "Generate frameworks in target_gen_dir instead of root_build_dir." > > This reverts commit d16c535e. > > Bug: > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I978fde2edb396307d896a2027beb04457e5f1972 > Reviewed-on: https://chromium-review.googlesource.com/758809 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516077} TBR=sdefresne@chromium.org,liaoyuke@chromium.org Change-Id: Ib18cb06cd301b9e1d9067c834f8a8cce41e779fc No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/768687Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#516233}
-
Christopher Lam authored
This CL fixes an issue where Desktop PWAs would show their URLs before the page had loaded due to the implementation of NavigationEntry::GetTitleForDisplay(). This has been fixed by adding a GetTitle() to HostedAppBrowserController which uses NavigationEntry::GetTitle() instead. Bug: 784226 Change-Id: I7bb8bf32026cf2b623ecaa2aa278a73fe23b6250 Reviewed-on: https://chromium-review.googlesource.com/765560 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#516232}
-
tzik authored
This contains: - Replace base::Callback with base::RepeatingCallback in //gin - Replace custom tuple index handling with std::index_sequence - Remove no longer needed specialization for empty binding Change-Id: I866578017f79aca4979e6f4665292cdae5df3f69 Reviewed-on: https://chromium-review.googlesource.com/760376Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#516231}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/36f34243334f..ff7aac5e4f5d $ git log 36f342433..ff7aac5e4 --date=short --no-merges --format='%ad %ae %s' 2017-11-13 jmadill Re-land "Export angle::PlatformMethods." Created with: roll-dep src/third_party/angle BUG=778918 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2356b9e91c2950edfe3dc88097ad654b99373f34 Reviewed-on: https://chromium-review.googlesource.com/768573Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516230}
-
Tarun Bansal authored
TBR: dougarnett@chromium.org Bug: 784714 Change-Id: I973dba3d3b58b25fddc2e826d2452cb97492db18 Reviewed-on: https://chromium-review.googlesource.com/768579Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#516229}
-
Kenichi Ishibashi authored
This CL adds "use_component_callbacks" field trial parameter (true by default). When it is true, NearOomMonitor uses Android's onLowMemory() to detect near-OOM situation instead of userland heuristics. Bug: 776665 Change-Id: I905e254acfb280d40d90218124ebe0bc605d9679 Reviewed-on: https://chromium-review.googlesource.com/762690 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#516228}
-
Luciano Pacheco authored
modules/websockets/ and modules/serviceworkers/ Fix missing include for <memory> and some for <utility> as pointed by lint. CL 9 of 10. Bug: 755727 Change-Id: Iadc120e5f4f54767966414bc6169facafdf14e80 Reviewed-on: https://chromium-review.googlesource.com/768593Reviewed-by:
Chris Watkins <watk@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516227}
-
Luciano Pacheco authored
modules/webaudio/ Fix missing include for <memory> and some for <utility> as pointed by lint. CL 8 of 10. Bug: 755727 Change-Id: I93d47fc6ad2e8cd63f41ae61f167253cbb8ae461 Reviewed-on: https://chromium-review.googlesource.com/768325Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516226}
-
Luciano Pacheco authored
CL 5 of 10. Fix lint about missing include <utility>. Bug: 755727 Change-Id: I7fe773d7b56896e2780e246adede2725aa3ec21f Reviewed-on: https://chromium-review.googlesource.com/768253Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516225}
-
Keishi Hattori authored
UpdateLifecycleToCompositingCleanPlusScrolling may call UnregisterPopupOpeningObserver, so RegisterPopupOpeningObserver needs to be called before it. Bug: 782896 Change-Id: I277e40edac248698486773436e8f38535b40864c Reviewed-on: https://chromium-review.googlesource.com/760436Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#516224}
-
Darren Shen authored
This patch adds the 'values' attribute to CSSMathSum/Product/Min/Max. 'values' is a CSSNumericArray, which is an array of CSSNumericValues representing the arguments to the CSSMathValue. We make the variadic CSSMathValues inherit from a new class CSSMathVariadic so that all the boilerplate with working with multiple arguments are in one place. Note that CSSNumericArray is not spec'd, but we based the implementation off https://github.com/w3c/css-houdini-drafts/issues/486 Spec: https://drafts.css-houdini.org/css-typed-om-1/#complex-numeric Bug: 776173 Change-Id: I1079b31993ecb02f31c2fe93ebf31c548fa6025c Reviewed-on: https://chromium-review.googlesource.com/762887Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#516223}
-
Jungshik Shin authored
On a timezone change, existing renderer processes are notified of the change, but the zygote process is not notified, which leads a new tab on Linux to hold on to the old timezone after a timezone change. To fix that, this CL passes the current timezone id (Olson) to the zygote process and lets it reset the ICU timezone before forking. Bug: 612010 Test: See comment 16 in the bug Change-Id: I0962e3d8c29ad5494fc3f9cd4f9d1d62588b7003 Reviewed-on: https://chromium-review.googlesource.com/764036 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Julien Tinnes <jln@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#516222}
-
Koji Ishii authored
Following bot results are included. 2098 2100 2101 2106 2108 2110 2112 2115 Did not run de-flake because the last CL was full-deflake, and currently bots look like a bit flaky. TBR=eae@chromium.org NOTRY=true Bug: 591099 Change-Id: I37b87d8ce98b9eb499361ceb07cb6491e5c0359d Reviewed-on: https://chromium-review.googlesource.com/768189 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#516221}
-
Christopher Lam authored
This CL adds implementations for the 3 hosted app menu commands: - Open Site Settings - Copy URL - Open in Chrome Bug: 762401 Change-Id: Ia9ac52999dfcb2ab1ad2408862843e417bb988fd Reviewed-on: https://chromium-review.googlesource.com/746047Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#516220}
-
John Abd-El-Malek authored
I renabled it in 516204 but it fails sometimes. TBR=yzshen@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia86356b8a663e3aff98770ab58edaddae1a047a0 Reviewed-on: https://chromium-review.googlesource.com/768576Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#516219}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/34842fa..12192b9 BUG=765469, 768969, 769989, 772651 TEST=bots TBR=zmo@chromium.org, kainino@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I180314943cb6427b916790f5ae5bf295c87330ea Reviewed-on: https://chromium-review.googlesource.com/764818 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#516218}
-
Peter Collingbourne authored
This is required in order to provide a definition of the __cxa_demangle symbol. Without this we will fail to demangle symbols at runtime if the runtime is packaged into an apk and that apk's native library statically links against the C++ runtime library. Because this change increases the unstripped size of the runtimes significantly, this change also switches us to using eu-strip to strip packaged binaries; the regular strip command fails to strip non-x86 binaries. Bug: 469376 Change-Id: Ic6428127f719f18b82c15cfee91d40b526b4f139 Reviewed-on: https://chromium-review.googlesource.com/765211Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#516217}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/430ee07db34f..9b9010d87517 $ git log 430ee07db..9b9010d87 --date=short --no-merges --format='%ad %ae %s' 2017-11-14 angle-deps-roller Roll skia/third_party/externals/angle2/ 8d6af086d..ff7aac5e4 (2 commits) Created with: roll-dep src/third_party/skia BUG=778918 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I8cf2b8f8a2e029949ddc8105ea012a84718ff4e8 Reviewed-on: https://chromium-review.googlesource.com/768322Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516216}
-
Luciano Pacheco authored
Those include aren't in use on .h nor on .cpp so they should be removed to avoid having bigger builds. Fix lint for include order on Canvas2DLayerBridge.h Bug: 398455 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iad4fded8a142af171d77242e2c5169b7b65cf239 Reviewed-on: https://chromium-review.googlesource.com/768098Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516215}
-
Luciano Pacheco authored
Files on directories core/html, core/paint and core/workers. CL 4 of 10. Bug: 755727 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I45d4e2ae2852bdd7e3b5b59b2db6da3a05bf4807 Reviewed-on: https://chromium-review.googlesource.com/768251Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#516214}
-
Hidehiko Abe authored
Rewrite RemoveConfiguration test family with fake. Then, all tests using gmock in this file is migrated to use fake implementation. Remove the test fixture, too. BUG=234463 TEST=Ran bots. Change-Id: Ife107fd14c63972a7fbacde576a14087e8ec0d88 Reviewed-on: https://chromium-review.googlesource.com/763832 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#516213}
-
Nathan Bruer authored
If a file is being created using IsolatedFileSystem the UISourceCode should not receive checkContentUpdated triggers if the content has not fully been written yet. R=lushnikov Bug=None Change-Id: I1e7df5f8a187b507c5939d78b378be8938cf4d0b Reviewed-on: https://chromium-review.googlesource.com/759227Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#516212}
-
Aleks Totic authored
They are needed to resolve overconstrained constraints per spec. Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I6766fe17603148212b22d2c1f6f23fc9e9b46bb6 Reviewed-on: https://chromium-review.googlesource.com/762177Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#516211}
-
Kenneth Russell authored
New conformance test being added in https://github.com/KhronosGroup/WebGL/pull/2542 . BUG=778770 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I09332c8df9baa651ebfc0d4b6a94bb1f1e308faa Reviewed-on: https://chromium-review.googlesource.com/765060Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#516210}
-
Peter Collingbourne authored
Bug: Change-Id: Idd0a088588836ddccb0d61ea6ac122ab82a70849 Reviewed-on: https://chromium-review.googlesource.com/768514Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#516209}
-
Lei Zhang authored
Change-Id: Ia62931759703731919feac5456f3f62b8d0340a4 Reviewed-on: https://chromium-review.googlesource.com/764992 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#516208}
-
Hidehiko Abe authored
BUG=739622 TEST=Build/Ran bots. Change-Id: If3d1b71f7509c836005daa723b5a8f010bc8746a Reviewed-on: https://chromium-review.googlesource.com/766807Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#516207}
-
Marti Wong authored
This CL is to fix the bug in new iOS bookmarks: when all bookmarks of the current folder are removed using the "Edit" dialog in edit mode, it failed to exit the edit mode. Egtest is modified to make sure this bug will not happen again. Bug: 781783 Change-Id: I83684d043914e55ac4599c789ab01df137b8aa46 Reviewed-on: https://chromium-review.googlesource.com/762695Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#516206}
-