- 30 Jun, 2020 40 commits
-
-
Jinsuk Kim authored
SideSlideLayout is a frame layout enclosing the arrow widget/glow UI used in gesture navigation. It gets detached from view hierarchy after use. There is a bug not detaching the layout if navigation UI is cancelled/not triggered. This CL makes sure the layout is detached so unnecessary views won't stay in the hierarchy when not in use. Added tests to verify the behavior. Bug: 1100717 Change-Id: I129ec5fe84d14023532bf5e0dd6a110ea84e354d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274498 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#783887}
-
Colin Blundell authored
This class will be reused by Weblayer. //chrome deps have been cleaned in a preceding CL, so the componentization is straightforward. We will put the ConfirmInfoBar C++ object in the infobars namespace in a followup. Bug: 1099169 Change-Id: I38de225f93bfc5545febc9ce9061259cf1b9f8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270566 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#783886}
-
Danila Kuzmin authored
R=raleksandrov@google.com Bug: 1091773 Change-Id: If3a6bd2cae355f93c6a5ac6e018a75faccab4cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254145 Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#783885}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/40ecf2e45a09..80e508e0d096 2020-06-30 aerotwist@chromium.org Changes use of language in third_party README If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I226b1b93043750ab9257144baac0576f6b1664ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275641Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783884}
-
charleszhao authored
Change-Id: I0ec0f5116d7f4b798e325043b5792a6e85fc3618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275743Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Auto-Submit: Charles . <charleszhao@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#783883}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c783abd3776d..14ac9d015283 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1071247 Tbr: drott@google.com Change-Id: I39d650d589169980f6bb66d6c0af44141ad5a195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783882}
-
Nazerke authored
Bug: 1072370 Change-Id: I1b3c08277001dc5baf245d0aa2bc142a1b887e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247737Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#783881}
-
Dominik Röttsches authored
Bug: 1100785 Change-Id: Iac36fb2abe96adf37923c794d1536ea3808e94d0 Tbr: masonfreed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274129 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#783880}
-
Kenichi Ishibashi authored
This is a follow-up CL of crrev.com/c/2269985. We can move around the ownership of URLResponseHeadPtr instead of copying it. Bug: 1055677 Change-Id: I36f4368776dc49bfb831277a53791f19a5b1f598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274822 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783879}
-
Wojciech Dzierżanowski authored
This is done in preparation for further work in issue 1091203. No functionality is changed as `is_remote` was always false outside of tests. Bug: 1091203 Change-Id: Ia32c07c628e2aa92bd6e5ae1676207d3df8050f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256203 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#783878}
-
Jia authored
No client will be affected by the change of SearchParams because it's not being explicitly set by them. Bug: 1090132 Change-Id: I996ce993f166f6ea069c27f754bd64ce034e44e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269411 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#783877}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7993f34db4ae..774cd1b212a4 2020-06-30 timvp@google.com Vulkan: Only transform SPIR-V once 2020-06-30 syoussefi@chromium.org Skip failing test on NVIDIA Shield 2020-06-30 syoussefi@chromium.org Add a test for copying from one mip to another If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1100613 Tbr: ianelliott@google.com Test: Test: CQ Change-Id: I8bddb25c93d7a0e6e19339f999a65f0c82402a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274686Reviewed-by:
-
Yutaka Hirano authored
- platform/mac-mac10.13/.../require-corp-about-blank-expected.txt is redundant - it's same as the base expectation. - platform/mac-mac10.14/.../require-corp-about-blank-expected.txt is wrong - the test always fails on the platform (and the failures are suppressed by TestExpectations). - wpt/html/coep/require-corp-about-blank.html always fails because COEP is only effective on secure contexts (https://github.com/whatwg/html/issues/4930). Rename it to wpt/html/coep/require-corp-about-blank.https.html - wpt/html/coep/require-corp-about-srcdoc.html always fails because COEP is only effective on secure contexts (https://github.com/whatwg/html/issues/4930). Rename it to wpt/html/coep/require-corp-about-srcdoc.https.html - Remove redundant TestExpectations entries. Bug: 1086065, 626703 Change-Id: I5573dd4446f482acdde828404e0a88893897ce09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274133 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Jia authored
This cl contains the following 1. A new enum for the backend type. 2. Extended API (C++ and mojom) so that clients can select the backend type. 3. Additional histogram metrics. Bug: 1090132 Change-Id: I1d6ae9f0704abf629f1c973c9d1d67db55d11b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269631 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
-
nancylingwang@google.com authored
For web apps icon, only modify the effects for uncompressed icon, because for compressed icons, we still need apply those icon effects. For Arc apps, when the standard icon flag is enable, call ArcAppIcon to generate the adaptive icon for both the compressed and uncompressed icon, so that AppService can generate the standard compressed and uncompressed icons. BUG=1083331 Change-Id: Icf6381ea8de96bfdc176d4df687403b72691f426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272659 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#783873}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I9d65f67b71a5ffd79a61e2ae099b234fa4cdf576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275851Reviewed-by:
-
Nektarios Paisios authored
Harmonized word boundaries exposed through accessibility APIs with the words produced by cursor navigation When using a screen reader and the user is moving by word throughout a webpage, both in editable and in non-editable content, the assistive software should announce either the word the user's cursor moved over or the word to the right of the cursor, depending on platform, and using accessibility APIs exposed by Chromium. To navigate in editable content the user uses Chromium's word navigation functionality, such as Ctrl+Left/Right arrow or Option-Left/Right arrow. In non-editable content, the user relies on screen reader shortcuts, which in turn rely on the same accessibility APIs. The bug is caused by the fact that commands such as Ctrl+Left/Right do not use the same word boundaries as the accessibility APIs. This patch harmonizes the two sets of boundaries. To do this, I used and was guided by the following: 1. ICU's word break iterator whose rules are found at http://userguide.icu-project.org/boundaryanalysis and http://www.unicode.org/reports/tr29/#Word_Boundaries 2. Idiosyncrasies of the Blink editing code which are based on established platform behavior that Chromium needs to replicate. //third_party/blink/renderer/core/editing/selection_adjuster.cc StartOfWordPosition, EndOfWordPosition. //third_party/blink/renderer/core/editing/visible_units_word.cc StartOfWordPositionInternal, EndOfWordPositionInternal, NextWordPositionInternal, PreviousWordPositionInternal. AX-Relnotes: Screen reader reads the correct word when moving forward or backward by word and there are punctuation marks or line breaks in the text. R=aleventhal@chromium.org, dmazzoni@chromium.org, chrishtr@chromium.org Change-Id: I2915fb4243f74f33c31508c4fc3c9e49a57209f6 Bug: 1028830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237930 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#783871}
-
Sylvain Defresne authored
It is sometime useful to have different build directories (e.g. to allow switching the version of the SDK used). Add a way to customize the build directory to setup-gn.py Bug: 619921 Change-Id: I4cd07a2978bfdee46fbce63d3257076c5e86a885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270324 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#783870}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a805a6702fe6..40ecf2e45a09 2020-06-30 alexrudenko@chromium.org Fix stylelint-config-standard issues in elements/stylesSidebarPane.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I883f7c63ac71cfbe061ba9a903ec8c23918bc1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275635Reviewed-by:
-
Yutaka Hirano authored
The flakiness has been fixed by https://github.com/web-platform-tests/wpt/commit/30252c8f1cc8f2a440d99d9388f871b3ae75297a. Bug: 1013523 Change-Id: I08bd3e7b6ba19eeade1af685838b59d6237f2405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274499 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Illia Klimov authored
This patch fixes a bug that adds an empty space instead of notifications permission in site settings. Reproducible only on Android 7.1 and less. Bug: 1099645 Change-Id: I8d283b186ce562a1598ce72ff431863d45c77197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273103 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783867}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a1163749fd80..722e769803e8 2020-06-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 80ff4391..2c0b70ba (783693:783820) 2020-06-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 51d47a5b..80ff4391 (783422:783693) 2020-06-29 philipp.hancke@googlemail.com sdp: remove old workaround 2020-06-29 sprang@webrtc.org Removes locking in TransportFeedbackProxy. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I07a5d1cb283cc06183efd5c5e367d96f7100caf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274690Reviewed-by:
-
Hitoshi Yoshida authored
Bug: 1100774, 1100783, 1100786 Change-Id: I0836d580d0668c45844c7630a769658ec81b6286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274971 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#783865}
-
Aya ElAttar authored
Added browsertests to test that the login screen warnings for the managed-guest sessions are controlled via ManagedGuestSessionPrivacyWarningsEnabled policy, which was added by this CL crrev.com/c/2254605. Bug: 1099648 Change-Id: I18b7d0b15ca13182ff62b3bc23d3378aa59ced3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270458 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#783864}
-
wutao authored
This patch adds a ChromeOS Settings subpage to select the personal albums of Google Photos and categories of Art gallery. A list of checkboxes of available albums and Art categories is shown in this Settings page. If no album or Art category is selected, server will return default photos. ss: https://screenshot.googleplex.com/HDEeiGq1xmb Bug: b/158630641 Test: manual Change-Id: Ia520f090d42d0caa8956c88e2cef07b6b31eec6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246218 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#783863}
-
Miyoung Shin authored
This CL converts PrerenderHostMsg_PrefetchFinished to FrameHost Mojo message and removes the unused PrerenderMessageFilter. Bug: 798712 Change-Id: I72721a011ebfb9951f4e7c01a96e09139f3c5e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256116 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
-
Noel Gordon authored
Dispatch drag test events in different phases (like a browser) - simulate using an idle callback request Check the event dispatch result in each event phase - fail if any of these dispatch calls fail Use source and target for variables and concepts - drag drop is spec-ed in terms of sources and targets Don't send a dragEnd event if we are skipping the drop event - this to match what a browser would do in this case Update the Closure markup and comments - skipDrop is no longer optional (so we can go async) No change in behavior: existing transfer tests transferDragAndDrop and transferDragAndHover should work as before. Bug: 1062902 Change-Id: Ia65b517ae5854f8abd92fe908a457ec72497b156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274125Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#783861}
-
sauski authored
Connected the previously created Safe Browsing generated preference to the production settings code. The settings-radio-group element is also extended to allow for not immediately setting the associated pref to support the Safe Browsing disabled dialog. This change also obviates the Safe Browsing proxy/handler, as well as some logic to support the previous Safe Browsing use of the collapse-radio-button element. These have been removed as part of this CL. Bug: 1096471 Change-Id: Iccd24602c4a7bf020ba6a78ed0bb00f2021dba48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270137 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#783860}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03ad609d3178..c783abd3776d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC peria@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: peria@google.com Change-Id: I082ca231d46adb7b36478c364530e8edb591d721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275626Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eb1a9106b40b..359d16da1108 2020-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 20768107 to 277fb4f3 (412 revisions) 2020-06-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 69c011ef35f1 to 06462adde69b (13 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1091259,chromium:1094869 Tbr: ethannicholas@google.com Test: Test: Test: CQ Change-Id: Ie05c83b6abcb82906f99aa11944019662a4b63de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275627Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593475028-63728bbaf9d72e013a403087ba2956d3e5f5a26b.profdata to chrome-mac-master-1593496775-686b801b00e226d40d93326669dcabc4de9f2009.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I845719fe6f2db7b38d39ce749374d8f9afd42d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275629Reviewed-by:
-
Colin Blundell authored
This class will be reused by WebLayer. The componentization is straightforward. Bug: 1099169 Change-Id: I1da79b401d9dcb87e3048f35b37eccd5c6880f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272321 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Colin Blundell authored
In preparation for componentization of this class for sharing with WebLayer, this CL cleans it of //chrome dependencies. We do so by introducing a simple ChromeConfirmInfoBar convenience subclass that glues ConfirmInfobar to //chrome, which will then enable ConfirmInfobar itself to be componentized and reused by WebLayer. Note that any //chrome-level subclasses of ChromeConfirmInfoBar could still easily be componentized if desired in the future by simply changing them to subclass from ConfirmInfoBar directly and take in the needed additional parameters in *their* constructors for supplying by the embedder. Bug: 1099169 Change-Id: I20b57b37eec57ed9932c6a3610f64e3860ac2900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272323 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
David Jean authored
Bug: 1096035,1076852 Change-Id: I386b8127fd0aed588226b6068553e086a7bba18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273158Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#783854}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fd4435373db6..a805a6702fe6 2020-06-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I34fb1337668d30a0d6b187d43edc2908037519d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275628Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0c55cdde36c8..6bd8e303c90e 2020-06-30 tsepez@chromium.org Pass cppgc::Heap into xfa layout layer. 2020-06-29 thestig@chromium.org Initialize CFWL_WidgetMgr::Item in the header. 2020-06-29 thestig@chromium.org Initialize CXFA_Graphics::TInfo in the header. 2020-06-29 thestig@chromium.org Initialize various nullptrs where declared. 2020-06-29 thestig@chromium.org Clean up Gouraud / Mesh shading code. 2020-06-29 thestig@chromium.org Add a pixel test with a free-form Gouraud-shaded triangle mesh. 2020-06-29 thestig@chromium.org Fix regression in CFX_SkiaDeviceDriver::PaintStroke(). 2020-06-29 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from 91fa1462a88f to a2a7e05eb765 (74 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099990 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1e5200fd31c987155d975d6583a265a14b445246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275150Reviewed-by:
-
Trent Apted authored
There's a strict set of flags that aren't yet applied across test code. This extends the flags to utility files used in tests (but not yet the browsertest.js files themselves). Fixes the problems. And makes those flags readily available to other system apps. Bug: 1100755 Change-Id: Ib1dbb094bbfc5d3f42fe7d7dab19f9200449c09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275364Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#783851}
-
Rahul Singh authored
based system This CL adds code to migrate shortcuts menu data (shortcut_infos, downloaded_shortcuts_menu_icons_sizes, and on-disk shortcuts menu icons) from the old Extensions based system to the new WebApps based system. In web_app_migration_manager.cc this CL adds code that reads shortcuts menu data from bookmark_app_registrar and writes it to a WebApp object. Using new structures added in web_app.proto and code added in WebAppDatabase the WebApp is then written to the local LevelDB. We then read WebApp entries from the LevelDB store and add them to the WebAppRegistrar to conclude the migration. Testing: Added tests in web_app_migration_manager_browsertest.cc to exercise the shortcuts menu migration code. Bug: 1069316, 1069312 Change-Id: I9d642495d655828d23b08116b63560aa273d0500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269550 Commit-Queue: Rahul Singh <rahsin@microsoft.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#783850}
-
Koji Ishii authored
crbug.com/1100070 says this is needed to enable FragmentItem on test bots. Bug: 1100070 Change-Id: If0aa58bcc95fd4fbb6338f89c207cbfc31da3251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274620Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#783849}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ia87cc42876a65e7bdc72a3dc5a9663e310197444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274966Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783848}
-
