- 10 May, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65043e3e..6e959bcf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1bdef14bc90a2428eb0634f2a9e49937b8911cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605603Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658470}
-
Jeevan Shikaram authored
This CL hides the Notifications view button from the Main View, and makes the app list fully expanded. Bug: 948936 Change-Id: I4dece86b79bf1ca9211dc47188fe46026653f661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601018 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#658469}
-
Luciano Pacheco authored
This reverts commit ffcd9342. Reason for revert: <INSERT REASONING HERE> Original change's description: > [Reland] Change ActionsController to only update DOM when displaying a menu > > Previously ActionsController would calculate the additional actions for > Drive (share, create-shortcut, etc) and FSP [1] like change directory, > selection changed, and metadata updated. When these events arrive in > FilesApp, they update the <command> and <cr-menu> DOM state. > > However, that can cause flickering in visible menus and also flakes in > browser tests based on menus, since these events can happen while the > menu is displayed for an entry or set of entries (selection) or affect > entries other than those associated with the menu. > > This CL changes ActionsController to store state in an internal map, > rather than in the DOM, and to only update the menu DOM state when a > user-action shows the menu. > > Change CommandHandler to set the visibility for Drive actions/commands > synchronously to avoid flickering the size of the menu - it still can > flicker the disabled state and pinned check-mark, but these are softer > to human eyes than the change in size. > > Change ToolbarController to update its refresh button disabled state. > The button relied on FileManagerCommands to update the |refresh| state > command, which was not correct because the refresh button always acts > on the current directory, whereas the command was being evaluated for > different entries. > > Change Action models and derived classes to have a |getEntries| method > so that ActionsController can get the entries that it is acting upon > to invalidate the state prior to executation. > > Change ActionsSubMenu.setActionsModel to forward the target element, > so the <command> can be updated to the correct target element. > > [1] > https://developer.chrome.com/apps/fileSystemProvider#event-onGetActionsRequested > > Bug: 889153, 875446, 961244 > Change-Id: I059f4516f0b64426a7570a88d8eff7e48b435454 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605383 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658458} TBR=noel@chromium.org,lucmult@chromium.org Change-Id: I67d21f2794ed17279b52f4c4fc90f80936abe881 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889153, 875446, 961244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605662Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#658468}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ba57a5dc. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|"" a06bcc90 "WebXR: Rename requestSession parameter variables to match use" eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" faed29aa "[EventTiming] Remove unneeded prefix from WPT tests" 9d5bc5ec "Portals: Add support for frame-src CSP directive." d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iecc0cc57ee346dad6b0d4563b36a57eb71b99223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604057Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658467}
-
Eric Willigers authored
Values like "x proximity" are serialized as "x" in the computed value. If no strictness value is specified, proximity is assumed. Spec: https: //drafts.csswg.org/css-scroll-snap-1/#scroll-snap-type Change-Id: Ic0e0b73b62b17740452562d1aac0a52915db9fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605243Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#658466}
-
Marina Ciocea authored
This change is needed for switching ConfirmInfoBar to using StyledLabel instead of Label in a follow up CL. Bug: 927949 Change-Id: I4cc9b4a23af85be716c4c48148e59a6aaddf5af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599462 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#658465}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/006b29556dad..980d615e7e5d git log 006b29556dad..980d615e7e5d --date=short --no-merges --format='%ad %ae %s' 2019-05-10 tikuta@chromium.org [bootstrap/win] Upgrade Python to 2.7.13. Created with: gclient setdep -r src/third_party/depot_tools@980d615e7e5d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:741001 TBR=agable@chromium.org Change-Id: I6c9283cd734067778028104c4da4c8e9992cb797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605351Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658464}
-
Marina Ciocea authored
The default behavior remains the same, with InfoBarView having a close button. This change is needed for implementing the tab sharing infobar (see bug). Bug: 927949 Change-Id: I795c868508148b5a8a1647768474b0d1dc89cd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599689 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
-
Jeevan Shikaram authored
Change fake backend apps to have descriptive titles to allow for better testing. Bug: 906508 Change-Id: I749d2d7e0f25771cfbed462d6778deb12b8afb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601017 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e3cde57769c2..4135885cfde9 Created with: gclient setdep -r src-internal@4135885cfde9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=dvadym@google.com,noel@google.com,jbroman@google.com,xialinyan@google.com Change-Id: I101cb4f46278b1b1d106ac6db56a5b8dcb587114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604188Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658461}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1bc7731e4c72..0b8234b45e2e git log 1bc7731e4c72..0b8234b45e2e --date=short --no-merges --format='%ad %ae %s' 2019-05-10 swiftshader.regress@gmail.com Regres: Update test lists @ 1bc7731e Created with: gclient setdep -r src/third_party/swiftshader@0b8234b45e2e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Ib797143066fbb1342bda91c01f693783450cd066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605350Reviewed-by:
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Id50f49662f363c9f55d80dc901a34b7ca3c114e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600948 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#658459}
-
Luciano Pacheco authored
Previously ActionsController would calculate the additional actions for Drive (share, create-shortcut, etc) and FSP [1] like change directory, selection changed, and metadata updated. When these events arrive in FilesApp, they update the <command> and <cr-menu> DOM state. However, that can cause flickering in visible menus and also flakes in browser tests based on menus, since these events can happen while the menu is displayed for an entry or set of entries (selection) or affect entries other than those associated with the menu. This CL changes ActionsController to store state in an internal map, rather than in the DOM, and to only update the menu DOM state when a user-action shows the menu. Change CommandHandler to set the visibility for Drive actions/commands synchronously to avoid flickering the size of the menu - it still can flicker the disabled state and pinned check-mark, but these are softer to human eyes than the change in size. Change ToolbarController to update its refresh button disabled state. The button relied on FileManagerCommands to update the |refresh| state command, which was not correct because the refresh button always acts on the current directory, whereas the command was being evaluated for different entries. Change Action models and derived classes to have a |getEntries| method so that ActionsController can get the entries that it is acting upon to invalidate the state prior to executation. Change ActionsSubMenu.setActionsModel to forward the target element, so the <command> can be updated to the correct target element. [1] https://developer.chrome.com/apps/fileSystemProvider#event-onGetActionsRequested Bug: 889153, 875446, 961244 Change-Id: I059f4516f0b64426a7570a88d8eff7e48b435454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605383Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#658458}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I952fe2ad0c0e12f10e0a64ef2bee0406b541ff3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599808 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c11e3156af22..04aa79d0edfc git log c11e3156af22..04aa79d0edfc --date=short --no-merges --format='%ad %ae %s' 2019-05-10 johnkslang@users.noreply.github.com Merge pull request #1765 from KhronosGroup/update-knowngood-tools-SPIR-V_1.4 Created with: gclient setdep -r src/third_party/glslang/src@04aa79d0edfc The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I9f1fbc5137df10819c9dc8ff653ee5ce96a44603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605465Reviewed-by:
-
Alice Boxhall authored
This reverts commit f9d8f7f6. Reason for revert: Apologies, this test seems to be timing out: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8913896950441933072/+/steps/browser_tests/0/logs/Deterministic_failure:_TimeToFirstPresentRecorderTest.VerifyTimeCalculated__status_TIMEOUT_/0 Original change's description: > chromeos: removes time_to_first_present.mojom > > And instead has ash directly access the startup time. > > BUG=958213 > TEST=covered by tests > TBR=tsepez@chromium.org > > Change-Id: I146c27edef79ff8fb69ca7cdd7f230ad77f040a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602854 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658315} TBR=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org Change-Id: I272066f1adc2866821a5195dca1907a6f077069a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605255Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#658455}
-
Christopher Lam authored
Bug: 938695 Change-Id: I90600729c8a356632fe2de593cade87b52c4195c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510622Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#658454}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/776694cdad40..7b08d381fd67 git log 776694cdad40..7b08d381fd67 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 syoussefi@chromium.org Vulkan: Enable EXT_frag_depth 2019-05-10 syoussefi@chromium.org Vulkan: Support flat and centroid qualifiers 2019-05-10 syoussefi@chromium.org Vulkan: fix qualifier erase for unused vertex attributes 2019-05-10 syoussefi@chromium.org Vulkan: Implement EXT_draw_buffers Created with: gclient setdep -r src/third_party/angle@7b08d381fd67 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: Icf26c4cdc0bfa505b8da6e8a7c5bbe070e12cffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605468Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2bca3f229ed9..e3cde57769c2 Created with: gclient setdep -r src-internal@e3cde57769c2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:790670,chromium:790668,chromium:790666,chromium:790664 TBR=dvadym@google.com,noel@google.com,jbroman@google.com,xialinyan@google.com Change-Id: I22645d6af0ee8a4f3857eacc062a5fa7197c3da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605467Reviewed-by:
-
Findit authored
This reverts commit 09566165. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 658294 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzA5NTY2MTY1YmU4YTY3NzEyMDc5MDUwY2I1NTBiZmQ1ODJmOGJjZTYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/33285 Sample Failed Step: interactive_ui_tests Original change's description: > Reland "cros: Add tablet <-> clamshell performance test." > > This is a reland of 963bfd6e > > Could not reproduce locally with the new changes. Suspected causes for > flakiness before. > 1) Rounding down because of int means we never waited for browser to > startup. > 2) Disabling animations too early means the creation of the browser window > has an animation which may have interfered with the tablet window animation. > > Original change's description: > > cros: Add tablet <-> clamshell performance test. > > > > Test: interactive_ui_tests TabletModeTransitionTest.EnterExit > > Bug: 953896 > > Change-Id: Ie2332df2bea2f7d2a63b39d8b390fcf4b28999f8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580583 > > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#656911} > > Bug: 953896 > Change-Id: I214d12fc24f16423f323c87fa7a182eebb0ee745 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598784 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Mitsuru Oshima (slow - gardening) <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658294} Change-Id: Ifb2881aab63d47033d3e209832d4a0c356250720 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605604 Cr-Commit-Position: refs/heads/master@{#658451}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4145bd87de45..006b29556dad git log 4145bd87de45..006b29556dad --date=short --no-merges --format='%ad %ae %s' 2019-05-10 tandrii@chromium.org [lucicfg] Bump lucicfg version v1.7.2 -> v1.7.4. Created with: gclient setdep -r src/third_party/depot_tools@006b29556dad The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:959098 TBR=agable@chromium.org Change-Id: Ib5c56e7132550258b49c442f097909ef265b86c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605466Reviewed-by:
-
alanlxl authored
Add page handler (backend) for chrome://machine-learning-internals, including mojo interface and c++ implementation. Add a stub html page for it. Bug: 924738 Change-Id: I4f715cf81761e043bab93390b09cc76bd720a70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556959 Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
-
Wei Li authored
Metadata macros are used for both header files and source files. Splitting them up can reduce the macro exposure. Similarly, the types used by metadata ad property should be split so that property related types and definitions including all type conversions are only included in the source files, not the header files, to reduce the possible circular dependencies. BUG=938501 Change-Id: Id6bfcbcee48a0f0d7d43c47d824013dba657ad51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601420 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#658448}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a7414797..65043e3e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I94ec22b77af182111f4a020ec8f18b0b92aba8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604185Reviewed-by:
-
Jeevan Shikaram authored
Add a section called "Apps" in the settings page, above the Play store section. Add a link to App Management under the "Apps" section. https://bugs.chromium.org/p/chromium/issues/detail?id=949400#c5 Bug: 949400 Change-Id: Iad37b44ba227605061c72ee845a116579afde450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593193 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#658446}
-
Johannes Henkel authored
I'm calling it Bytes. I think this is handy for stashing the v8 session state, which is a json string right now. I understand this causes some copying. Could be refined later, what I like about it is that it keeps it simple and avoids encoding headaches. === This PR can be submitted independently. The way I want to put it to work is like so; the blink web tests pass with things patched together: https://chromium-review.googlesource.com/c/chromium/src/+/1604463 This change in V8 is a prerequisite: https://chromium-review.googlesource.com/c/v8/v8/+/1598254 The way to put it to use is this change: I patched things together and ran the blink web tests with this stuff. Change-Id: Ibe76d7a252f80d9a128575603b3d6ebe967b4269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588171 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#658445}
-
Anand K. Mistry authored
If the zip archive contains encrypted files, the archiver will keep asking the user for a passphrase every time a file is opened, until the user enters the correct passphrase. Since files can be opened in many unexpected situations (i.e. quick view, thumbnailing, etc), the dialog will be opened repeatedly if the user keeps canceling. To stop this, use a heuristic where if the user has canceled the dialog more than N times, stop asking for a passphrase. If the user then later wishes to access an encrypted file, they need to unmount/remount the archive. This isn't perfect behaviour, but a good compromise between nagging the user constantly, and never asking again. BUG=944181 Change-Id: I97d8948bb4686c363e4ec68778423f5a275a43fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598901Reviewed-by:
-
Noel Gordon authored
Perhaps due to recent changea and reverts on issue 626703. Mark tests as [ Timeout Pass Failure ] since there persistent recent failures have new features attached - they red about half the chromium waterfall bots. external/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch.html external/wpt/pointerevents/pointerevent_touch-action-none-css_touch.html TBR=lanwei@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 606367, 626703 Change-Id: Id0ca4f9841e8eff95230cbcc827ae69a3e14639a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605580 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I2e03313aa5fe0f49063f8cc8144c29dd819d480d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599822 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
-
Asanka Herath authored
This CL introduces a NetLog event source for HttpAuthController to use. Followup CLs will start to use this log in place of scattered VLOGs. The general model for logging in the HTTP authentication stack will be: * HttpAuthController doesn't have a usable NetLog on construction. * Each of HttpAuthController's public entry points (MaybeGenerateAuthToken() and HandleAuthChallenge()) take a NetLogWithSource parameter identifying the caller. The HttpAuthController uses it to construct a bound NetLog if one doesn't already exist for the controller. Upon construction of this log, the controller logs a HTTP_AUTH_CONTROLLER BEGIN event. * Upon destruction of HttpAuthController, the controller logs a HTTP_AUTH_CONTROLLER END event if |net_log_| has a valid source (i.e. one of the two public entry points were invoked with a non-null NetLogWithSource). * All HttpAuthHandlers that the controller constructs are presented with the controller's log. Thus, by the end of its life, the |net_log_| for the HttpAuthController will contain all the events from the first time one of the entry points were invoked, all the way to the end, including events logged by the handlers. If the controller doesn't encounter any authentication challenges during its lifetime -- which is the case if the controller was constructed just to check if there's a possibility of there being credentials that can be used to perform preemptive authentication -- no logging occurs. The HttpAuthController is stateful in terms of authentication challenge selection, handler selection, and identity selection. Having all these events on the same log allows for easy tracking of this state throughout the lifetime of the controller even if it is shuffled between owners. Bug: 884313 Doc: https://docs.google.com/document/d/1GgwVfHcPpL_v2EMKN5BJQWJalCUMwlJIGeRZQb1uc40 Change-Id: I3afeb31af76db090e1b65e1d67ae2879b53bbe7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1537283 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#658441}
-
Yutaka Hirano authored
The data was used in https://github.com/whatwg/fetch/issues/251, but we don't need it any more. Bug: 602925 Change-Id: I529e30057e9ce9265a1eda4edf424cffde76034d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602534 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#658440}
-
Mehran Mahmoudi authored
This creates the TouchlessPreferences activity which adds a number of customizations to the Preferences activity. It also fixes a bug that caused ActivityNotFoundException in release builds. Previous CL that was reverted because of this bug: crrev.com/c/1593393 Bug: 953905,953903,953897,951591 Change-Id: I405418431124fda34e5475c2fc459577651b1a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603032Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#658439}
-
Noel Gordon authored
This reverts commit e36181d3. Seems thios cause al internal chrome builders to fail with a compile error. https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/mac-google-rel https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/win-google-rel https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-google-rel [9689/40525] ACTION //chrome/browser/resources/downloads:flattened_resources_grit(//build/toolchain/linux:clang_x64) FAILED: gen/chrome/browser/resources/downloads/flattened_resources_stamp.d.stamp gen/chrome/browser/resources/downloads/grit/downloads_resources.h gen/chrome/browser/resources/downloads/grit/downloads_resources_map.cc gen/chrome/browser/resources/downloads/grit/downloads_resources_map.h gen/chrome/browser/resources/downloads/downloads_resources.pak gen/chrome/browser/resources/downloads/downloads_resources.pak.info python ../../tools/grit/grit.py -i ../../chrome/browser/resources/downloads/downloads_resources.grd build -o gen/chrome/browser/resources/downloads --depdir . --depfile gen/chrome/browser/resources/downloads/flattened_resources_stamp.d --write-only-new=1 --depend-on-stamp -D _google_chrome -E CHROMIUM_BUILD=google_chrome -D desktop_linux -D toolkit_views -D use_aura -D use_nss_certs -D enable_app_list=false -D enable_arcore=false -D enable_background_mode=true -D enable_background_contents=true -D enable_extensions=true -D enable_hangout_services_extension=true -D enable_plugins=true -D enable_print_preview=true -D enable_printing=true -D enable_service_discovery=true -D enable_vr=true -D safe_browsing_mode=1 -D optimize_webui=true -E root_gen_dir=gen -f ../../tools/gritsettings/resource_ids --assert-file-list=obj/chrome/browser/resources/downloads/flattened_resources_expected_outputs.txt Error processing node <?xml version="1.0" encoding="UTF-8"?> <include file="${root_gen_dir}\chrome\browser\ui\webui\downloads\downloads.mojom-lite.js" name="IDR_DOWNLOADS_MOJO_LITE_JS" type="BINDATA" use_base_dir="false" /> Traceback (most recent call last): File "../../tools/grit/grit.py", line 15, in <module> sys.exit(grit.grit_runner.Main(sys.argv[1:])) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/grit_runner.py", line 256, in Main return toolobject.Run(options, args[1:]) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/tool/build.py", line 256, in Run self.Process() File "/b/s/w/ir/cache/builder/src/tools/grit/grit/tool/build.py", line 381, in Process self.ProcessNode(self.res, output, outfile) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/tool/build.py", line 315, in ProcessNode formatted = formatter(node, output_node.GetLanguage(), output_dir=base_dir) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/format/data_pack.py", line 83, in Format value = node.GetDataPackValue(lang, UTF8) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/node/include.py", line 102, in GetDataPackValue data = util.ReadFile(filename, util.BINARY) File "/b/s/w/ir/cache/builder/src/tools/grit/grit/util.py", line 206, in ReadFile with open(filename, mode) as f: IOError: [Errno 2] No such file or directory: u'../../out/Release/gen/chrome/browser/ui/webui/downloads/downloads.mojom-lite.js' Reverting to green the chomium tree. Original change's description: > Downloads Web UI: Add individual grd file > > Change downloads to use the same approach as settings, extensions, and > print preview: > (1) Use an individual grd file instead of browser_resources.grd > (2) Create unpak folder > > Bug: 715296 > Change-Id: Ifd0ce1c46e11ad80ee17fa8c5e55aab33543bfa1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598320 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658369} TBR=thestig@chromium.org,dpapad@chromium.org,rbpotter@chromium.org Change-Id: Icbb9245ea2e3e6014f729625d217aa7cdc009f6e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 715296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604390Reviewed-by:
-
Siddhartha S authored
BUG=925148 Change-Id: I794131b887408a9652cdd5e04a0354a224911b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601194 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#658437}
-
Mehran Mahmoudi authored
This adds SiteSettingsHelper which contains helper methods for showing site settings and determining whether site settings is available. Since this logic was previously part of PageInfoController, it was difficult for other classes to use it. A downstream CL that uses this class is included in the bug. Bug: 952947 Change-Id: Idcf10232631605d2e2cf7a108c9b26a18b580965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600436Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7b9b3dd3. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." a554ea37 "Reland "[EventTiming] Round instead of ceil the |duration|"" a06bcc90 "WebXR: Rename requestSession parameter variables to match use" eeafcaee "[sms] Introduce testing infrastructure and handle some corner cases." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" faed29aa "[EventTiming] Remove unneeded prefix from WPT tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I6c55c3a79f1935d093cb5978bb028fedae865b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605344Reviewed-by:
-
Kenichi Ishibashi authored
The previous instrumentation (crbug.com/c/1577322) was reverted due to a high crash rate. This CL re-adds the instrumentation with following changes. * Limit crash rate * Keep stack trace when a ServiceWorkerVersion becomes redundant and include the stack trace in crash reports Bug: 951571 Change-Id: I2ac51f5c8ae18ee1920da35cdc78baca58b5c1a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599060 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#658434}
-
Alice Boxhall authored
This reverts commit 28eb992f. Reason for revert: This test is failing on multiple builders: https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel Original change's description: > Add test to verify the opcodes generated by IMMEDIATE_CRASH(). > > Bug: 958675 > Change-Id: Ica6b5bab7849f227567d8016354a39383533799f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595585 > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658344} TBR=dcheng@chromium.org,thakis@chromium.org Change-Id: I84759f26168853183877c9943daf031611a19824 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605582Reviewed-by:
-
Madeleine Barowsky authored
A change in catapult will surface these timing data to rendering_metric: https://chromium-review.googlesource.com/c/catapult/+/1600403 Bug: 944756 Change-Id: I7c446d9d83e312046cffc519c572570167f48c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600836Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Auto-Submit: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#658432}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3e511440e774..1bc7731e4c72 git log 3e511440e774..1bc7731e4c72 --date=short --no-merges --format='%ad %ae %s' 2019-05-10 chrisforbes@google.com Check sampling support in vkGetPhysicalDeviceImageFormatProperties 2019-05-09 bclayton@google.com SpirvShader: Handle multiple entry points Created with: gclient setdep -r src/third_party/swiftshader@1bc7731e4c72 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/132341142 TBR=swiftshader-team+autoroll@google.com Change-Id: Ied152be0a491d984ca3e2ab0a8a63218198e7ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604484Reviewed-by:
-
