GitLab

Review URL: http://codereview.chromium.org/155249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20202 0039d316-1c4b-4281-b951-d872f2087c98

Next up is actually refactoring tests to use these and not the old_mocks version.  The biggest user is the PipelineImpl tests, which I'm currently refactoring anyway hence sending this out for review.

BUG=16008
TEST=FFmpegVideoDecoderTest should still pass

Review URL: http://codereview.chromium.org/149356

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20201 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/150216

Original description:
Move download item to its own view and a xib, paving the way for a custom
download item view. I didn't change the look of the download items yet. The
context menu is now in the download item xib as well.

BUG=14659,15098,14660
TEST=Download something. Everything should look like before (except for the
     smaller icon), but the context menu items should be disabled/enabled and
     checked/unchecked correctly.

Review URL: http://codereview.chromium.org/149276

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20200 0039d316-1c4b-4281-b951-d872f2087c98

only use the KWin hack when the custom frame is enabled.

This is still a bit buggy in KWin (toggling from custom frame -> system
decorations doesn't always re-attach system decorations), but it seems
like the best I can do.

Review URL: http://codereview.chromium.org/155248


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20199 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149362

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20198 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20197 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20196 0039d316-1c4b-4281-b951-d872f2087c98

Description from Thiago:

Converting the history::StarredEntry::Type to a type defined in BookmarkNode.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/155165

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20195 0039d316-1c4b-4281-b951-d872f2087c98

lightweight struct containing a description of a cursor that the
embedder should render.

WebCursor still exists.  Instead of WebCursor initializing from a
PlatformCursor, it now initializes from a WebCursorInfo.

TEST=none
BUG=10039
R=jam

Review URL: http://codereview.chromium.org/155172

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20194 0039d316-1c4b-4281-b951-d872f2087c98

Goal is to prevent someone from checking in new cross-platform code relying on this.

Review URL: http://codereview.chromium.org/149342

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20193 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20191 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15596
TEST=none

Review URL: http://codereview.chromium.org/155231

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=16209,16210
TEST=somewhat happier Mac UI valgrind bots
Review URL: http://codereview.chromium.org/155232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20189 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20188 0039d316-1c4b-4281-b951-d872f2087c98

window wrapper in the debugger agent.

Review URL: http://codereview.chromium.org/155179

TEST=none
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20187 0039d316-1c4b-4281-b951-d872f2087c98

This is only half of the bug fix. We also should match windows in that a drag held over a folder for more than a second or so shows the folder's contents and allows the user to continue the drag into the folder.

Also, it's kind of hard to use this new feature since the bookmark items float around when you are dragging out of the same bookmark bar you're dragging into, but the fix for that would be separate (and would require some design decisions).

BUG=14222
TEST=drag single or multiple bookmarks onto a bookmark bar folder

Review URL: http://codereview.chromium.org/149307

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20186 0039d316-1c4b-4281-b951-d872f2087c98

Firefox's plugins directory. 

This allows extensions to override the user's default plugin for a particular
mime type.

BUG=15943
TEST=none
R=mpcomplete

Patch by Collin Jackson

Review URL: http://codereview.chromium.org/149346

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20185 0039d316-1c4b-4281-b951-d872f2087c98

Implements unique client ID generation for Posix.

Client ID generation happens once-per-install of Chromium (...well, this is
mostly true, at least).  On Windows, the code currently uses some system library
code that generates a GUID.  We don't ACTUALLY need a GUID, something that's
quite random and in the same format will work.  Since we don't want to add a
dependency on libuuid for POSIX, I created a less-random-but-still-good-enough
version.

BUG=15418
TEST=none

Review URL: http://codereview.chromium.org/149343

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20184 0039d316-1c4b-4281-b951-d872f2087c98

Also fixing the ScopedComPtrVector unit test.
The problem with the test was that it expected AddRef to be called twice and Release() once when pushing a pointer to the vector.  However that only happens when a push causes a reallocation.  When there's no reallocation, there's only a single call to AddRef and no call to Release, causing the test to report failure.  The fix is to simply use std::list instead and fix the expected values.

TEST=Run *ScopedComPtr* unit tests.
BUG=none
Review URL: http://codereview.chromium.org/149345

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20183 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
http://crbug.com/16054

Review URL: http://codereview.chromium.org/149235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20182 0039d316-1c4b-4281-b951-d872f2087c98

things (and tests), no UI yet.

The model enforces that all pinned tabs occur at the beginning of the
model. For example, if there are no pinned tabs and you pin the 10th
tab, it is moved to the front of the tab strip. Similarly inserting a
tab before the last pinned tab implicitly pins it. Moving a pinned tab
beyond the set of pinned tabs implicitly unpins it.

I'll file a bug on this when the site allows me to.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155228

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20181 0039d316-1c4b-4281-b951-d872f2087c98

and most likely some page cyclers.

Review URL: http://codereview.chromium.org/155236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20180 0039d316-1c4b-4281-b951-d872f2087c98

The problem is scoped_ptr<ResourceRequestDetails> is used to delete an instance of ResourceRedirectDetails, however the base class's destructor is non-virtual, so ResourceRedirectDetails extra field (GURL new_url_) does not get torn down properly.

Note that the blame callstacks in the bug report appear unrelated, because std::string is doing some fancy refcounting under the hood. So as GURLs get passed around, they take over the GURL::spec's memory that got allocated earlier by the network stack.

BUG=http://crbug.com/10873
TEST=The "RedirectTest.*" ui tests when run on linux valgrind bots should show no leaks

Review URL: http://codereview.chromium.org/155204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20179 0039d316-1c4b-4281-b951-d872f2087c98

Create watchlist for media changes.  The regex is pretty permissive because the media files are scattered in multiple directories with the only commonality being the word "media". (eg chrome/renderer/media, third_party/media, or more annoyingly webkit/glue/resources/media_pause.png, and webkit/api/src/WebMediaPlayerClientImpl.cpp)

Review URL: http://codereview.chromium.org/149232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20178 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nsylvian
BUG=13901

Review URL: http://codereview.chromium.org/155229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20177 0039d316-1c4b-4281-b951-d872f2087c98

Shuffle the Mac valgind suppressions around a bit to match the other suppression file format. No actual changes to the suppressions except to get rid of a name duplication.

BUG=none
TEST=Mac valgrind bots should be unchanged.
Review URL: http://codereview.chromium.org/155225

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/149337

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20175 0039d316-1c4b-4281-b951-d872f2087c98

Since they have been ported to the browser tests framework, they are not required anymore.

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/155224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20174 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149305

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20173 0039d316-1c4b-4281-b951-d872f2087c98

temporary_glue.cc includes webview_impl.h, which brings in headers
that include wtf/Assertions.h.  However, it also brings in logging.h.
The workaround is to include wtf/Assertions.h in temporary_glue.cc
and then #undef LOG.  This effectively mimics what we do elsewhere
in glue.

TEST=none
BUG=none
R=brettw

Review URL: http://codereview.chromium.org/149339

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20172 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15906
TEST=chromium builds should have video enabled

Review URL: http://codereview.chromium.org/155107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20171 0039d316-1c4b-4281-b951-d872f2087c98

Correctly implementing GetPeerName() to point to TCPClientSocket::GetPeerName(). This is used by the SSL layer in Linux to resolve Peer Names, which caused a trap to be generated ( http://crbug/16166 )

BUG=16166
TEST=fix of the above BUG

Review URL: http://codereview.chromium.org/149242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20170 0039d316-1c4b-4281-b951-d872f2087c98

These 14 layout tests are passing consistently on build slaves.
TBR=scherkus

Review URL: http://codereview.chromium.org/149340

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20169 0039d316-1c4b-4281-b951-d872f2087c98

Fix the problem that the temp worker directory is not deleted if the http server process is still holding it.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155177

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20168 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/149335

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20165 0039d316-1c4b-4281-b951-d872f2087c98

passing off the data to gdk_pixbuf.  This is required in the theme
code for tinted bitmaps.

Review URL: http://codereview.chromium.org/150151


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20164 0039d316-1c4b-4281-b951-d872f2087c98

ffmpeg_video_decoder_unittest.cc is a much more comprehensive test!

BUG=16008
TEST=none

Review URL: http://codereview.chromium.org/155198

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20162 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/155199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20161 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20160 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/150086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20159 0039d316-1c4b-4281-b951-d872f2087c98