- 13 Aug, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium cc4cd897. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." 3364c233 "[css-properties-values-api] Reify values from attributeStyleMap.get." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22692 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources timvolodine@chromium.org: external/wpt/battery-status NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I1e2e1f2c301da8d05d4c5aad485ea3a6e7c44d18 Reviewed-on: https://chromium-review.googlesource.com/1172444 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582610}
-
Weidong Guo authored
Changes: This is a revert of go/cgcl/1103151 due to expected behavior change. Bug: 872354 Change-Id: I5d96b16b446a75c17a8e493e258dcc1588a3440b Reviewed-on: https://chromium-review.googlesource.com/1172073Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582609}
-
Gauthier Ambard authored
This CL modifies the URLLoader protocol to use OpenNewTabCommands instead of passing the arguments in the method. Follow-up from crrev.com/c/1127949. Bug: 843576 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I45635617a8e697ebccfc0c524f076176eacb5bb0 Reviewed-on: https://chromium-review.googlesource.com/1131511Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#582608}
-
Dominik Röttsches authored
SafeToBreakMissingRun was a Mac only failure, SafeToBreakArabicCommonLigatures were Mac and Android only failures, ShapeArabicWithContext was waiting for range shaping to be implemented, which had been fixed in the meantime for non-Mac.. Bug: 689155, 870712 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5ce017be3417ef24720cfb5a9818384ebd148b6c Reviewed-on: https://chromium-review.googlesource.com/1162177 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#582607}
-
Aldo Culquicondor authored
Having an undefined source triggers warnings in the logs. SOURCE_CLASS_POINTER is the minimal requirement for producing touch events, and it is general enough. Passing the source as an argument to `inject` was causing perf regressions. BUG=855626, 867438 Change-Id: I05458c9c98776a2af99b570aba5760adfd0381d5 Reviewed-on: https://chromium-review.googlesource.com/1167207 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#582606}
-
Rouslan Solomakhin authored
This is a speculative fix to flakiness in TwoClientPreferencesSyncTest.SingleClientEnabledEncryptionBothChanged_E2ETest. https://crrev.com/c/1152068 introduced AutofillJapanCityFieldMigrated as a syncable preference that starts out as "false" by default, but then is flipped to "true" upon the start of syncing of autofill profiles. The speculation is that a non-syncable preference should not interfere with a preferences sync test. Bug: 872614 Change-Id: I84cc91c8e11aeaba6a02ea178a5b38ebde97882a Reviewed-on: https://chromium-review.googlesource.com/1169309Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582605}
-
Chris Lu authored
Change-Id: Iccb6078d9dba025791424a6fe1c49e1cc98c7652 Reviewed-on: https://chromium-review.googlesource.com/1171787 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#582604}
-
Helen Li authored
This CL is split off rdsmith@'s CL at https://chromium-review.googlesource.com/c/chromium/src/+/925181 This CL only adds the logging code for events, but uses a null NetLog. A followup CL will modify the CookieStore constructor to pass in a non-null NetLog. Bug: 801910 Change-Id: Icd40aa206055c82a4e84ddb66c8547b69ec662ff Reviewed-on: https://chromium-review.googlesource.com/1170594Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#582603}
-
Robert Ogden authored
Moves choosing the color of text and separator of the Omnibox verbose status from LocationbarLayout to TDP based on the currently displayed page. Bug: 871839 Change-Id: I484cd402e6d7db863d3e5301451ed5f2b8db942d Reviewed-on: https://chromium-review.googlesource.com/1167983Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#582602}
-
Elad Alon authored
content::WebRtcEventLogger was created to allow code in content/ to reach WebRtcEventLogManager. Code in chrome/browser/ can, and should, access WebRtcEventLogManager directly. As a drive-by, add DCHECKs over WebRtcEventLogger being created and destroyed on the UI thread. Bug: 775415 Change-Id: Idb5109d2fdfc0ce0feeb6aa6655914f8ea4905cd Reviewed-on: https://chromium-review.googlesource.com/1172435Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#582601}
-
Mohamed Amir Yosef authored
This CL implements the functinality of not syncing managed bookmarks (e.g. installed by policy) Bug: 516866 Change-Id: Ibdcbb7593ad976670e883c115a847e6994951bae Reviewed-on: https://chromium-review.googlesource.com/1163241 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#582600}
-
Gauthier Ambard authored
Cleanup for the ActivityService. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7feb4acc2711172dfb9829c2b223e6f2c724fa33 Reviewed-on: https://chromium-review.googlesource.com/1172289 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#582599}
-
Fredrik Söderquist authored
The test has a red version of the reference painted under the actual test content. Because of how alpha/coverage often work (at least in software rasterizers), this can lead to the read bleeding through and thus affecting the comparison with the reference image. Disable the red reference shapes by adding a CSS rule. This way, if someone feels it's useful for debugging they can easily re-enable it. BUG=872697 Change-Id: Id47757c9dd112ead0db9c2dcd1adc74d5a52e55d Reviewed-on: https://chromium-review.googlesource.com/1172622Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582598}
-
Rouslan Solomakhin authored
This is a reland of 33a1a4b02fd1c7d7c623513274c24692d6602d8d Original change's description: > Add tests for JIT installable payment handlers. > > Bug: 872305 > Change-Id: I992e534ab0ca48affc14464c23af41a495209c58 > Reviewed-on: https://chromium-review.googlesource.com/1168084 > Reviewed-by: Ganggui Tang <gogerald@chromium.org> TBR=gogerald@chromium.org Bug: 872305 Change-Id: Icdf80a7bb92b53b85c09648bf483f1671fcfa662 Reviewed-on: https://chromium-review.googlesource.com/1172542Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582597}
-
Fernando Serboncini authored
This CL refactors the existing code path for uploading canvas element to a WebGL texture by generalizing it to work with CanvasRenderingContextHost, which is a common base class of HTMLCanvasElement and OffscreenCanvas BUG=753483 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6c1cf783774ff8f8edc4604c10056ba57b0b9ae7 Reviewed-on: https://chromium-review.googlesource.com/1154988Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582596}
-
Jérôme Lebel authored
This patch enables to open "Google Activity Controls"[1] and "Encryption"[2] from the Google services settings[3] [1]: https://drive.google.com/open?id=1VenMSZPfe-7cM9trtLJgIJvQopqpdDWk [2]: https://drive.google.com/open?id=1jrAQwjCcV3o_UnPjCasmisDPtmyWsE1u [3]: https://drive.google.com/open?id=15GJUEJrTAgsREZ5zHjf6xO0ivwLhil8Q Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I000c348334242e6274b0de7cbd59b0eee23dd521 Reviewed-on: https://chromium-review.googlesource.com/1169163 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Balazs Engedy authored
While the layout of both the button row and the |content_view|, showing the sheet-specific content, inside the |client_view| was correctly invalidated, the |client_view| was never re-laid-out, so the newly added controls were never sized and positioned. This visually resulted in missing controls in the content area as well as missing buttons on the bottom row in 99% of cases, the remaining 1% being when we got lucky and the height of the dialog changed as a result of the step transition, in which case resizing the Widget triggered a Layout of its view. Bug: 849323 Change-Id: Ie615d467ea9ab7f95d5af0a44181ab172409672b Reviewed-on: https://chromium-review.googlesource.com/1172441Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582594}
-
Peter Mayo authored
With --enable-blink-gen-property-trees we don't repaint invisible nodes on the compositor, so we don't need to animate it, and so the console output is not present, nor are other animated changes. This is arguably better, but was being tested for naively. This is a reland of 8e33e9d2a04d284b061e024103dd36ba07daa32d > Change-Id: I625f85710ec803eb5f3515a95d84b4cf7d6ac2d1 > Reviewed-on: https://chromium-review.googlesource.com/1162075 > Commit-Queue: Robert Flack <flackr@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> Bug: 855691 Change-Id: Idea876e956be546c1b35a0646de9260b9450592e Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1169932 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582593}
-
junweifu authored
Shape Detection runs on gpu process, so the Register in utility isn't necessary. BUG=646035 Change-Id: I3633650f2173ff566ce474f3b35e48658e99f785 Reviewed-on: https://chromium-review.googlesource.com/1170439Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Scott Violet authored
BUG=none TEST=none, comment only change Change-Id: Id7e78d9e36cacb125a030b9e1e9bfa17d5365e74 Reviewed-on: https://chromium-review.googlesource.com/1172724Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582591}
-
Gauthier Ambard authored
The FindInPage activity should only be shown when the FindInPage action is doing something. This CL adds a BOOL to know if the page can be searched. It is used to display the activity or not. Bug: 871260 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I514b67e4b7e0f00258c0c1a8310975394ac3468c Reviewed-on: https://chromium-review.googlesource.com/1172287 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL reworks the way autofill suggestions are communicated to the keyboard accessory. Instead of setting an additional view, they behave like all other actions. The old accessory adjusted its layout based on the website's layout. This was removed for now - the system-wide setting is used instead. Side effect: This seems to resolve most known crashes. Known issues: - chip elevation has no effect pre-Lollipop (TODO) Old bugs: - inconsistent state of scrollview most likely solved (--> no scrollview, no inconsistent state) - flaky tests passed 30/30 locally times but reenabling will happen separately (issue 854224, might still flake on bots) Demo video: https://drive.google.com/open?id=1aJbjtTZPP-hPZu2FYA_qHRHqaeHkfWCq Bug: 853772, 834976 Change-Id: I53ed7a18a72e72f72bae45906ac9bb5ee06992e3 Reviewed-on: https://chromium-review.googlesource.com/1170771Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582589}
-
Gauthier Ambard authored
This CL adds dynamic for the IdentityPicker, making sure that the name and email can spread on multiple lines and respond nicely when the font is increased. Bug: 872277 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iea05b977c7a6f6fe199c0e8d4e6325ac05936ef0 Reviewed-on: https://chromium-review.googlesource.com/1172423Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#582588}
-
Javier Ernesto Flores Robles authored
Marks LinkOfTextWithCalloutNone and LinkOfTextWithCalloutOverride as flaky. Bug: 873662,873660 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8a5b70864ad3a6436e64211b1df868d4c673e75e TBR: eugenebut@chromium.org Change-Id: I8a5b70864ad3a6436e64211b1df868d4c673e75e Reviewed-on: https://chromium-review.googlesource.com/1172684Reviewed-by:
-
Alex Clarke authored
Previous patch: https://chromium-review.googlesource.com/c/chromium/src/+/1080792 Our usage pattern is unfortunate for existing queues such as base::circular_deque. We tend to fill up an empty queue and then drain all those tasks until it's empty. This means the queue yo-yos in size which confuses the memory reclamation schemes of most queues. As an optimisation we introduce a deque specialised for TaskQueueManager's usage patterns. For performance (memory allocation isn't free) we don't automatically reclaim memory when the queue becomes empty. Instead we rely on the surrounding code periodically calling MaybeShrinkQueue, ideally when the queue is empty. We keep track of the maximum recent queue size and rate limit how often MaybeShrinkQueue actually shrinks the buffer to avoid unnecessary churn. This yields a nice win on our microbenchmark: Patch: us/run for 10000 delayed tasks with N queues 1 queue 4 queues 8 queues 32 queues 33448.166666666664 33215.75496688742 33484.34 34018.37414965987 33972.18243243243 33846.91891891892 34489.737931034484 34727.90277777778 33367.90666666667 33167.54304635762 33392.96 33906.89864864865 33392.13333333333 33107.17763157895 33340.18 33718.73825503356 37921.01515151515 39379.06299212598 38851.27906976744 39366.03125 38171.564885496184 37401.72388059701 37640.32330827068 37800.51127819549 34691.2275862069 34359.61643835616 34993.468531468534 35366.795774647886 35981.20863309353 35089.18881118881 38530.230769230766 39280.3515625 39262.8671875 36411.384057971016 33576.10067114094 33939.69594594595 37913.59848484849 38324.076335877864 38061.59848484849 39921.00793650794 Average 35812.1871 35430.24471 35636.02188 36204.63076 ToT: us/run for 10000 delayed tasks with N queues 1 queue 4 queues 8 queues 32 queues 40459.540322580644 40536.04838709677 38994.573643410855 38696.2 39422.149606299216 39299.5 37888.18939393939 37874.74436090225 38419.70229007633 38025.742424242424 37844.41353383459 38020.469696969696 35052.72027972028 38147.80303030303 35504.89361702128 34138.02721088436 37096.77777777778 34942.541666666664 37003.529411764706 37579.60447761194 38818.67441860465 38233.068702290075 37978.628787878784 37867.57142857143 38455.49618320611 37903.05303030303 38106.143939393936 38129.5 40609.33064516129 37721.75187969925 34656.441379310345 34294.33561643836 35273.704225352114 34646.324137931035 34335.643835616436 34311.82876712329 35821.41428571429 35362.035211267605 37522.27611940299 35429.281690140844 Average 37942.951 37481.78685 36983.47337 36634.15632 Percentage improvement 5.61570422 5.473437399 3.643388159 1.172472933 NB the reason the improvement goes down with the number of queues is because we're saving malloc overhead in the queue, but a constant number of tasks are posted across N queues. This means the more queues we have in this test, the less loaded the queues are individually. Change-Id: I975d7f864dc55715fb9f949ef65321da93e4cef4 Reviewed-on: https://chromium-review.googlesource.com/1169043Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#582586}
-
A Olsen authored
InstallAttributes and the "Chrome" Schema both have few deps and are needed in Chrome OS settings code, in code that should be servicified. See go/ash-settings-split. However, getting a useful instance of either class currently means depending on chrome/browser to get browser_process and all of its global services. This CL makes InstallAttributes and the Chrome Schema singletons that can also be obtained directly, and so removes one of the dependencies on chrome/browser from the Chrome OS settings code. Bug: 446937 Change-Id: If8b1d8e4e9851464278d4b3e25562bc0eea8a41c Reviewed-on: https://chromium-review.googlesource.com/1141947 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582585}
-
Gauthier Ambard authored
This CL adds a way to dismiss the IdentityChooser popup using the escape gesture. Bug: 872277 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia0b64c28787ed651596e936aa806ed42b94e50db Reviewed-on: https://chromium-review.googlesource.com/1172431Reviewed-by:
-
Patrik Höglund authored
Changes: Major changes All code has been reformatted to be consistent. A .clang-format file and format.sh script has been added that can be use to verify and enforce consistent formatting. An automated check on code formatting is now part of travis build. Other changes PR #409 - Compatibilty with LibreSSL PR #406 - Fix unprotect when pktlen < (2*mki_size + tag_len) PR #405 - Prevent potential double free PR #404 - Add back extern to global variables PR #403 - Set gcm IV directly with EVP_CipherInit_ex PR #401 - Fix memory access issue in srtp_get_session_keys() PR #398 - Fix memory access fixes when invalid profiles where used PR #391 - Return NULL when allocating memory of size zero PR #390 - Bitvector of length zero is not valid PR #385 - Treat warnings as errors on travis builds PR #388 - Moved externs from crypto_kernel into its own header PR #379 - Fixed several compiler warnings from Firefox builds PR #377 - Removed variable init code in rdbx which never gets used PR #381 - Added error in case the platform is not detected PR #376 - Add coverity scan to travis builds PR #374 - Add a big endian build on travis PR #373 - Fixed buffer size issue in test/srtp_driver.c PR #372 - Make rtp_decoder compile on MinGW PR #367 - Rename configure.in to configure.ac PR #365 - Replace calls to free() with srtp_crypto_free() PR #364 - Add valgrind to travis and fix leaks in tests PR #363 - Change smtp_crypto_alloc to initialize memory to zero PR #354 - Fix potential leak if cloning of stream fails PR #340 - Fix potential leak in srtp_add_stream() PR #323 - Fix running test in out of source builds Issue #316 - Remove VERSION file Bug: webrtc:9560 Change-Id: I83b5bd5bcaa01f1cb8b29dbfd24566b307a9a275 Reviewed-on: https://chromium-review.googlesource.com/1169813Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#582583}
-
Miguel Casas authored
This CL renames /image/canvas_resource/ in some method parameter names. This is prob a leftover of earlier times when CanvasResourceDispatcher used a StaticBitmapImage -- now it uses a CanvasResource. Bug: 839970 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0575eafd326738e8a52e5801e689b5280f3ff0ec Reviewed-on: https://chromium-review.googlesource.com/1167911Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#582582}
-
Elad Alon authored
Bug: 775415 Change-Id: Ic08dd3bb772eff7e6c6884e0191c25b441500f02 Reviewed-on: https://chromium-review.googlesource.com/1142157 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#582581}
-
Ryan Daum authored
This reverts commit 64356c22. Reason for revert: Downstream breakage on device. Original change's description: > [chromecast] Detect screen enter/exit and corner holds. > > - Adds detection and dispatch of screen entry/exit events. > - Adds detection of a finger press and hold in the corner. > - Better handling of multiple-finger events on the screen. > > Bug: internal b/112073644 > Bug: internal b/112314035 > Test: unit test and manual > Change-Id: Id2155f8e432428ee63f3457274f1507ce1edee53 > Reviewed-on: https://chromium-review.googlesource.com/1165795 > Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> > Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org> > Commit-Queue: Ryan Daum <rdaum@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582196} TBR=alexst@chromium.org,kpschoedel@chromium.org,rdaum@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/112073644, internal b/112314035 Change-Id: I8fc29ab7b2a7629803d1b45eff6b84bb582698c6 Reviewed-on: https://chromium-review.googlesource.com/1172562Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#582580}
-
Xida Chen authored
This reverts commit a0de839e. Reason for revert: As it is mentioned in crbug.com/869375: Know that these are not real crashes but being a top crash this may result in suppression of other crashes Original change's description: > [Debugging] Add instrumentation in TouchActionFilter > > From the stack trace of the current crash report, we are not able to > tell the gesture sequence, which makes it hard to debug. > > This CL adds a CrashKeyString in TouchActionFilter, and push necessary > events into that string. When it crashes, we should be able to retrieve > the gesture sequence from that crash key. > > Bug: 869375 > Change-Id: Ieb7cf0839e4a062c23ec48cbaca72bd641f28a30 > Reviewed-on: https://chromium-review.googlesource.com/1165586 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581676} TBR=dtapuska@chromium.org,xidachen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869375 Change-Id: I033b2b1bd646c1310593e612322e4bb2d5c503d2 Reviewed-on: https://chromium-review.googlesource.com/1172522Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582579}
-
Mohamed Amir Yosef authored
Favicon code has been removed intentionally to make earlier patches simpler and focused on the core skeleton of the processor. This CLs fills in the missing pieces when handling remote updates and processing local changes by adjusting the favicon code. Bug: 516866 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I955f011c687b3165956510a0245363bcea8d34ec Reviewed-on: https://chromium-review.googlesource.com/1052767 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Sam Zackrisson authored
- Adds a second (currently no-op) toggling of AEC2 and AECM, to allow for upstream changes in WebRTC (removing the EchoControlMobile API). - Localizes the creation of a webrtc::AudioProcessing::Config to avoid overwriting settings. Shortly, this will be the only way to toggle AECs in APM. Bug: webrtc:9535 Change-Id: I019408ec7e5b5e91afddfe854d607126ee065fdb Reviewed-on: https://chromium-review.googlesource.com/1152914Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Reviewed-by:
Per Kjellander <perkj@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#582577}
-
Fredrik Söderquist authored
external/wpt/svg/text/reftests/text-multiline-001.svg external/wpt/svg/text/reftests/text-multiline-002.svg external/wpt/svg/text/reftests/text-multiline-003.svg => crbug.com/366558 external/wpt/svg/text/reftests/text-inline-size-001.svg external/wpt/svg/text/reftests/text-inline-size-002.svg external/wpt/svg/text/reftests/text-inline-size-003.svg external/wpt/svg/text/reftests/text-inline-size-005.svg external/wpt/svg/text/reftests/text-inline-size-006.svg external/wpt/svg/text/reftests/text-inline-size-007.svg external/wpt/svg/text/reftests/text-inline-size-101.svg external/wpt/svg/text/reftests/text-inline-size-201.svg => crbug.com/366553 external/wpt/svg/painting/reftests/markers-orient-001.svg => crbug.com/872697 (pending testfix) TBR=schenney@chromium.org BUG=366553,366558,872697 Change-Id: Ib75f5c0cda767108745618ab508a6a8730e3b1b1 Reviewed-on: https://chromium-review.googlesource.com/1172430Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582576}
-
Javier Ernesto Flores Robles authored
Test is failing on non tablet iOS 10 devices and it is flaky on all iOS 11 ones. Bug: 873633,873632 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie95325a3256021a401c3f8055d5e71f6dc40a590 Reviewed-on: https://chromium-review.googlesource.com/1172358Reviewed-by:
-
Mugdha Lakhani authored
This will be required to implement match() and matchAll() on BackgroundFetchRegistration in a follow-up CL. Bug: 869918 Change-Id: I9ed88076488a035f313b9d16e0f41b3c168a0a09 Reviewed-on: https://chromium-review.googlesource.com/1169465Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#582574}
-
Ramin Halavati authored
Preferences related to unified consent are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I733657f359b34369fcef0559660cd14c74bfb181 Reviewed-on: https://chromium-review.googlesource.com/1172131Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#582573}
-
Michael Lippautz authored
- Move temporary visitor scope to test infrastructure - Factor out integration tests that are independent from visitors Bug: chromium:843903 Change-Id: I3850cc48fe1b9186691722f3241e9de27cd0a29e Reviewed-on: https://chromium-review.googlesource.com/1172294 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582572}
-
Ian Clelland authored
This just implements the infrastructure required for generating and sending reports with the Reporting API, and making them visible to ReportingObservers. Adding violation reporting to individual features will be handled in follow-up CLs. Bug: 867471 Change-Id: Iabfaebe00ae5a768d1b952a90aac1712aec5e158 Reviewed-on: https://chromium-review.googlesource.com/924475Reviewed-by:
-
