Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 23 Jul, 2018 6 commits
    • chrome-release-bot's avatar
      Updating trunk VERSION from 3500.0 to 3501.0 · 9785f283
      chrome-release-bot authored 
      # This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: I674947b92fc11e1aac2b4855d0a87fe1c8f7c9a2
Reviewed-on: https://chromium-review.googlesource.com/1146212Reviewed-by: default avatarchrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577104}
      9785f283
    • Xiaocheng Hu's avatar
      Stop including editing_behavior.h in editor.h · e3540f40
      Xiaocheng Hu authored 
      This patch removes a header inclusion for better build performance, and
clearer code dependency.

Bug: 866120
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8d3bb813807bbae08350f1b649043752a1198d42
Reviewed-on: https://chromium-review.googlesource.com/1145694
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577103}
      e3540f40
    • Stefan Zager's avatar
      Add class WebScrollbarThemeClient · 3f8543e5
      Stefan Zager authored 
      This is an abstraction to facilitate moving the bulk of platform/scroll
into core. WebScrollbarTheme provides a Mac-only API which is called
into from content, and affects the styling of all scrollbars. After
this patch, all of the other scrollbar and scrollbar theme code can move
out of platform.

BUG=823365
R=skobes@chromium.org,chrishtr@chromium.org
TBR=dgozman@chromium.org

Change-Id: I888e08676b5343156ae391c44b2084e90023de0f
Reviewed-on: https://chromium-review.googlesource.com/1141116
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: default avatarSteve Kobes <skobes@chromium.org>
Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577102}
      3f8543e5
    • Darren Shen's avatar
      [VK] Remove unused friend declaration in KeyboardController. · ffcb250e
      Darren Shen authored 
      In a previous patch, we removed KeyboardLayoutManager's dependency
on KeyboardController's SetContainerType. This means that the friend
declaration in KeyboardController is no longer needed.

TBR=blakeo@chromium.org

Bug: 845780
Change-Id: I56ea22d989dcefc3bc70d4ca054678fd52c5bef7
Reviewed-on: https://chromium-review.googlesource.com/1146139Reviewed-by: default avatarDarren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577101}
      ffcb250e
    • Timothy Loh's avatar
      Use a proper icon for Crostini package install notifications · 3b1c2723
      Timothy Loh authored 
      This CL adds a vector icon for use in notifications for Linux packages.
Using a vector icon allows this to get blue/red colours automatically
to match the notification title color.

Bug: 822464
Change-Id: Ie21f437b8c65aefb8d5be4732e864f826445d361
Reviewed-on: https://chromium-review.googlesource.com/1143046Reviewed-by: default avatarEvan Stade <estade@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577100}
      3b1c2723
    • Darren Shen's avatar
      [VK] Observe changes to keyboard window in KeyboardController. · 3099beca
      Darren Shen authored 
      There are two ways for the keyboard window bounds to change. Either
through KeyboardController or through JavaScript / the IME extension.
Notably, we always receive a JavaScript bound change when initializing
the keyboard UI.

To handle bounds changes from JavaScript, we use a LayoutManager
to intercept those changes and forward them to KeyboardController.
In production, the LayoutManager is installed by ash::Shell.
In unit tests however, we do not always have this setup because the
test may not be able to depend on ash. Unit tests that load the
keyboard will simulate the initial JavaScript bound change, but because
there's no layout manager, KeyboardController does not receive the
update and gets into a bad state.

The current workaround is to manually add a LayoutManager to the
root window in tests that need it. This is not ideal, as the correctness
of KeyboardController is silently dependent on the construction of
a LayoutManager [*].

To fix this, we observe bounds changes to the keyboard window in
KeyboardController. Then, KeyboardController will no longer need the
LayoutManager to notify bounds changes; it can observe them directly.

[*] We didn't have this problem before because we could install the
layout manager on the keyboard container, which was part of the
KeyboardController. Since we got rid of the keyboard container, we can
only install the layout manager on an ash container, which is
external to KeyboardController.

Bug: 845780
Change-Id: I053778f04ab3ccf4d13fcd79d05832f9238b21b5
Reviewed-on: https://chromium-review.googlesource.com/1133607Reviewed-by: default avatarYuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577099}
      3099beca
  3. 22 Jul, 2018 13 commits
  5. 21 Jul, 2018 21 commits