- 03 Aug, 2018 40 commits
-
-
Nasko Oskov authored
With error page isolation, navigations that result in a chrome error page (as opposed to HTTP errors such as 404) are isolated in their own process. This CL adds some validations at commit time to ensure that invariants we expect are enforced by the browser. It only includes some of the possible checks, as more investigations are needed to understand the behavior of HTTP layer errors. Bug: 866549 Change-Id: I8389629eb68213681983b37d1cfc945832e35ea7 Reviewed-on: https://chromium-review.googlesource.com/1160877 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580670}
-
Michael Spang authored
Make these polymorphic types so that we can provide a fake implementation of libgbm for test purposes. Bug: 869206 Test: ozone_unittests Change-Id: I773cdac62bade798fbcddac54a2d5557ce1da8ce Reviewed-on: https://chromium-review.googlesource.com/1162655 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#580669}
-
Sammie Quon authored
This requires deleting WindowSelectorItem::RoundedContainerView. screenshot: https://screenshot.googleplex.com/Gu5wG5LOPHY Test: manual, run WindowSelectorTests Bug: 839477 Change-Id: I933d0de5ba38a9c829d2266f945cc62fd2b5d7c9 Reviewed-on: https://chromium-review.googlesource.com/1161482 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#580668}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d54f5f5c763c..50eb4c44ad92 git log d54f5f5c763c..50eb4c44ad92 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 srte@webrtc.org Adds BBR field trial to CallTest. 2018-08-03 sakal@webrtc.org Fix remaining target name for AppRTCMobile_stubbed_video_io_test_apk. 2018-08-03 buildbot@webrtc.org Roll chromium_revision 06e87fb3..62642dd6 (580149:580526) 2018-08-03 oprypin@webrtc.org Remove Syzygy from deps 2018-08-03 oprypin@webrtc.org Fix gitignore pattern to never exclude sha1 files Created with: gclient setdep -r src/third_party/webrtc@50eb4c44ad92 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaf357cc4b58e9f9be30d6dd57fd3cbf51940b8d1 Reviewed-on: https://chromium-review.googlesource.com/1162386Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580667}
-
David Tseng authored
Bug: 869921, 854321,869955 Change-Id: I9d9ae5aa5c590cf0200e6953054dff1833fc7b76 Reviewed-on: https://chromium-review.googlesource.com/1161176 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#580666}
-
Robert Shield authored
Bug: 747557 Change-Id: I2997faa2de1cb384287afc5d4eb23c352b8ea7a5 Reviewed-on: https://chromium-review.googlesource.com/1157864Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580665}
-
Scott Violet authored
This code is no longer hit after the switch to ws2. BUG=none TEST=none Change-Id: I7ad3607d1db7f5d670c69e0bdcd386876ae2e942 Reviewed-on: https://chromium-review.googlesource.com/1162718Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580664}
-
Ehsan Karamad authored
The smooth-scroll animations are local frame root concepts. This move will avoid a nested OOPIF same process with a parent to use the same sequencer so their animations are independently scheduled. Bug: 865446 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic07c22eef5d7a6ec25fe51c32d3e22e056398522 Reviewed-on: https://chromium-review.googlesource.com/1159189 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#580663}
-
Shakti Sahu authored
This CL contains following changes : 1 - Moved the storage summary text out of toolbar into RecyclerView due to font size issues. 1 - Renamed StorageSummary to StorageSummaryProvider which will provide the updated storage info through a delegate. 2 - Added StorageCoordinator which will own the provider, model, view and viewbinder and create the storage summary view to be shown inside RecyclerView. 3 - StorageSummaryProvider will be observing offline items and update the storage info on Add/Removes. Updates are ignored due to high frequency of updates. Bug: 868547 Change-Id: I50a2f8c14d95b3f29aeec49fa34b08618b3bf3ba Reviewed-on: https://chromium-review.googlesource.com/1157868 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:Ted Choc <tedchoc@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#580662}
-
Quan Nguyen authored
This makes the views-login dialog more consistent with how the webui version looks. Change-Id: I1c931623ae9c8b6408debe315ab7cac8d4cac742 Reviewed-on: https://chromium-review.googlesource.com/1162745Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580661}
-
Roberto Carrillo authored
This reverts commit 22333d92. Reason for revert: suspected of breakage in 'generate_build_files': https://bugs.chromium.org/p/chromium/issues/detail?id=870827#c3 Original change's description: > Fix missing dependencies with RLZ target. > > chrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly. > > This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc > will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work. > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng > Change-Id: I85d78d25b1905c68524e0636cec3006102d17749 > Reviewed-on: https://chromium-review.googlesource.com/1161610 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580579} TBR=avi@chromium.org,jam@chromium.org Change-Id: I5bca5200d639f01dbba1ed582d9dccb3290cf0c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/1162211Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#580660}
-
Trent Apted authored
ShowInactive() is usually used to make a hidden window visible without having it also take key focus. It can also be used to raise an already-visible window higher in the window stacking order (also without taking focus). However, a quirk of AppKit is that calling orderWindow: will also trigger a Space switch to the desktop containing that window, if Chrome is the active application. Since we never want ShowInactive() to do that, and since child windows can not control their stacking order, skip the call to orderWindow for child windows, if the window is already visible. Bug: 866760 Change-Id: I984c2ce8b0cb1754ee68e0392524c64739253ab9 Reviewed-on: https://chromium-review.googlesource.com/1161701Reviewed-by:
-
Tessa Nijssen authored
Previously, each tab had its own SuggestedTextTouchBarController. Now, because of http://crrev/c/1151613, there is only one SuggestedTextTouchBarController per window. Because the controller does not maintain the state of each tab, as a user switches tabs, the controller needs to update its state to match the tab. When the controller's WebContents change, new suggestions should be generated for the selected text in the current tab. The methods -webContentsTextSelectionChanged:range: and -webContentsFinishedLoading were combined into a singular method, -updateTextSelection:range:, because they had very similar functionality. The parameters for -requestSuggestionsForText:inRange: were removed because they were always |text_| and |selectionRange_|. A new method was created, -webContentsChanged, to get a tab's current text and selected range and then call -updateTextSelection:range: with the proper parameters. When the controller gets a new pointer to a WebContents, the pointer may be null. To avoid calling WebContents::IsFocusedElementEditable() on a null pointer, a method -isTextfieldFocused was created to check that |webContents_| is not a null pointer and that an editable element is focused. A new SuggestedTextTouchBarControllerBrowserTest was written, SetWebContentsTest, to test that the SuggestedTextTouchBarController properly updates its current text selection based on the new WebContents. This CL is the same as http://crrev/c/1153728 with the following changes: - Browser tests for methods that are not restricted to MacOS 10.12.2+ were modified to also run on earlier versions of MacOS. The expected behavior for different MacOS versions is accounted for in the tests. - A call to UnfocusTextfield() was added to SetWebContentsTest to ensure that a later call to FocusTextfield() works as intended and focuses an editable element. Bug: 717553 Change-Id: Id061e392dd279e7a3cc9a34a023eb9bd97e52940 Reviewed-on: https://chromium-review.googlesource.com/1160929Reviewed-by:
-
Sammie Quon authored
Internal keyboard and touchpad events are previously locked when entering tablet mode and unlocked when leaving. Now, when we attach a mouse, it will exit tablet mode, but the keyboard should not stay locked as the keyboard will be facing downwards in the case of flip chromebook. The lock should instead be controlled by the hinges regardless if change in hinge causes tablet mode to change. Also rename EnterTabletMode to AttemptEnterTabletMode as it does not always enter. Test: ash_unittests TabletModeControllerTest.LeaveTabletModeWhenExternalMouseConnected Bug: 870757 Change-Id: I38a537871aa6a1e7cd94311308d421af3dfc2ad1 Reviewed-on: https://chromium-review.googlesource.com/1162512 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Adding a glFlush at the end of every batch of decoded commands in GLES2DecoderImpl::DoCommandsImpl eliminated this crash, but that is somewhat egregious and hacky. This adds a glFlush to every place where we switch virtual contexts, doing the flush both before and after the state restore (and also before switching away from a virtual context, just for good measure). If the crashes don't re-appear then we can leave it at this. We will eliminate virtual contexts when OOP-D and OOP-R are enabled. If this isn't sufficient to eliminate the crashes, then we can go back to doing a glFlush at the end of every GLES2DecoderImpl::DoCommandsImpl call, at least for merging to Chrome 69. Bug: 863817 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie8b4531ea800918eac42083ceecd5e65b9c02301 Reviewed-on: https://chromium-review.googlesource.com/1162516 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580656}
-
Ehsan Karamad authored
All GuestViews except for MimeHandlerViewGuest are now implemented based on cross-process frames. There is however a hadnful of browser tests which are not MimeHandlerViewTest but still use BrowserPlugin. This CL will 1- Change the MimeHandlerViewTest from parameteric to normal test. Essentially, the UseCrossProcessFramesForGuest flag is unrelated to the MimeHandlerViewGuest. There is a separate flag for that matter which is "MimeHandlerViewInCrossProcessFrame" and will be added eventually when the a first version of MimeHandlerViewGuest based on cross-process frames is implemented on ToT. 2- Move WebViewBrowserPluginSpecificTest.AcceptTouchEvents to MimeHandlerViewTest. This involves overhauling the test test is also modified to load MimeHandlerViewGuest instead of WebViewGuest. The short-term plan is to change all such (BrowserPluginSpecific) tests to become MimeHandlerViewBrowserPluginSpecificTest. The longer term goal is to remove all such tests when MimeHandlerViewInCrossProcessFrames is shipped. Bug: 659750, 533069, 330264 Change-Id: Icad9ddd1f2d1e6851b20f6c0d923dd2192b7dcec Reviewed-on: https://chromium-review.googlesource.com/1161745 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#580655}
-
Etienne Bergeron authored
R=oysteine@chromium.org Bug: 867931 Change-Id: I257c7b6e6220e9e00eecf3ab14b4cb6e19d55a1b Reviewed-on: https://chromium-review.googlesource.com/1162635Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#580654}
-
Sammie Quon authored
Test: compiles Bug: none Change-Id: I7651e96e727110205740e0884550d559f9078abd Reviewed-on: https://chromium-review.googlesource.com/1162582Reviewed-by:
-
Ryan Meier authored
Adds checks before modifying whether or not a tab uses extra padding to ensure that padding doesn't get changed while the tab is closing. Without these checks, tab titles would suddenly jump several pixels to the left near the end of the tab's closing animation. Found while reproducing/fixing Bug: 859321 Change-Id: Id7db4b160530535af520cdfaf99202aa863a019a Reviewed-on: https://chromium-review.googlesource.com/1162359 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#580652}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/27928c385ec6..d30f10814bd0 git log 27928c385ec6..d30f10814bd0 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 bsheedy@chromium.org Fix ReplaceSystemApp not granting permissions 2018-08-03 wangge@google.com Long Term Health Tool File Reorganization Created with: gclient setdep -r src/third_party/catapult@d30f10814bd0 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:870782,chromium:863390 TBR=sullivan@chromium.org Change-Id: I61cecf50cbb85a042494bab6182d719c6cb8b714 Reviewed-on: https://chromium-review.googlesource.com/1162387Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580651}
-
Fredrik Hubinette authored
apparently nothing breaks Bug: 649199 Change-Id: I728637ba8b7ffea50191014f07d9581d08eb33ed Reviewed-on: https://chromium-review.googlesource.com/1162431Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#580650}
-
Becca Hughes authored
Remove the AutoplayMutedVideos feature which is set based on the autoplay policy command line switch. This means it ignores if we have overridden the autoplay policy for the document. Instead we should perform this check in AutoplayPolicy which will have the final autoplay policy for the document. BUG=865548 Change-Id: Iddfb9d0b3fef3bfa6efc493876094eaf2f8f7799 Reviewed-on: https://chromium-review.googlesource.com/1157215Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#580649}
-
Alexander Alekseev authored
This CL delays startup sound playback until default sound output device has known type. Bug: 848485 Change-Id: I911e37afd34d28f142c46ef63b7b6345988d159b Reviewed-on: https://chromium-review.googlesource.com/1160143Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#580648}
-
Paul Jensen authored
Convert it to "new" (2012) NeworkChangeObserver. Bug: 754695 Change-Id: Ifc63ddff076da40fd1a18d052b73f03e778cbd56 Reviewed-on: https://chromium-review.googlesource.com/1161966Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580647}
-
Johannes Henkel authored
inspector_network_agent.cc: This is a behavior change, there are a fair number of fields here. E.g., previously, the extra headers would be preserved between disable() and enable(), now they're cleared out. inspector_page_agent.cc: Similarly, this is a behavior change. E.g., previously, setFontFamilies and setFontSizes settings would be preserved between disable() and enable(), now it's cleared out. Bug: 851762 Change-Id: I923a2d49ec92f395c5954116e115686517994a0f Reviewed-on: https://chromium-review.googlesource.com/1161175Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#580646}
-
Vladimir Levin authored
R=pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibe0b3837e5ffd0919d8162a46c48bb550f9e4780 Reviewed-on: https://chromium-review.googlesource.com/1162586Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580645}
-
Johannes Henkel authored
This is a refactoring except for kVirtualTimeTaskStarvationCount. Previously, the code called state_->setDouble(...VirtualTimeTaskStarvationCount, ...); but then read it as an int, so it basically wouldn't get saved. Now it's always an int. Bug: 851762 Change-Id: I288274ddddc44c910d89ef1fb8c1a6eacd54d8c5 Reviewed-on: https://chromium-review.googlesource.com/1161329 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Before: https://drive.google.com/open?id=1HZzgWAeGjTOREQzj-uBROCDvS-kBMwJL After: https://drive.google.com/open?id=1WTN_Bhjdwrhz1kMZAQDSbKTmc0YhZrb6 Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5b3d162b495a22d55cce42fd643a4c9d982e8c87 Reviewed-on: https://chromium-review.googlesource.com/1162158Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580643}
-
Theresa authored
Delete unused SuggsetionsMetrics methods and mark corresponding user actions as obsolete. BUG= Change-Id: I2c9d43d517ed03162dbe5fa051639a0cc342846a Reviewed-on: https://chromium-review.googlesource.com/1162316Reviewed-by:
-
Theresa authored
Don't record a histogram entry for NewTabPage.ActionAndroid2 or the Suggestions.Card.Tapped user action when a contextual suggestion is clicked. BUG=870424 Change-Id: I7d10c1b00628c83f4dbde2a4353707a483722656 Reviewed-on: https://chromium-review.googlesource.com/1162319Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#580641}
-
Manas Verma authored
Fixing this build fail: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/475 Bug: 855186 Change-Id: I49b743e6d699e47768ff8d47ea2ac63dcb1ee49f Reviewed-on: https://chromium-review.googlesource.com/1150445 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#580640}
-
Brian Sheedy authored
This reverts commit df2048be. Reason for revert: Causing gclient sync failures https://crbug.com/870845 Original change's description: > android: build: Use .pydeps file to store Python dependencies. > > ProTip: start by looking at the pythonic_action() definition > in internal_rules.gni to review changes in this CL. > > This CL tries to make "gn analyze" smarter by ensuring that > it knows about Python module dependencies, for any python > script under //build. > > At the moment, these dependencies are computed by > build_utils.WriteDepFile() automatically (unless the > add_pydeps=False argument is passed). This adds all imported > module paths to the generated .d file written by the script. > > Unfortunately, because this .d file is generated by the > actions, the corresponding Python sources are not part of > the target's inputs, known by GN at parse time, and thus do > not appear in "gn analyze" properly. > > This CL tries to solve the problem by adding a new template > named "action_with_pydeps", which acts as "action", but also > expects a foo.pydeps file for every foo.py invoked through > the 'script' scope variable. > > This '.pydeps' file is read directly at GN parse time and > added to the action's target inputs. > > These .pydeps contain the path of each imported module, one > per line, and are generated with build/print_python_deps.py > > Benchmarking shows no significant difference in the time > taken to perform a "gn gen out/Release" on a full Chrome > for Android checkout. > > + Add --inplace option to print_python_deps.py in order to > make its usage more human-friendly (the new mode cannot > become the default because PRESUBMIT.py depends on the > current behaviour). > > + Remove some --depfile options on a few Python scripts that > don't need it anymore (e.g. when their inputs and outputs > are now fully known by GN at parse time). > > + Remove uses of compute_inputs_for_analyze in rules.gni and > internal_rules.gni (as well as exec_script() calls to > print_python_deps.py). Note that the variable itself is still > needed for grit inputs, see tools/grit/grit_rule.gni for > details). > > BUG=NONE > R=agrieve@chromium.org > > Change-Id: I8d7c07ab93b032fdc0c7f9dbeb2173767f52eeff > Reviewed-on: https://chromium-review.googlesource.com/1131190 > Commit-Queue: David Turner <digit@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580545} TBR=digit@chromium.org,agrieve@chromium.org,estevenson@chromium.org Change-Id: I626eb8997c8808fc91aec9115287be34d17d493e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: NONE Reviewed-on: https://chromium-review.googlesource.com/1162522Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580639}
-
Melisa Carranza Z authored
Bug: b/111886441 Test: Successfully cast DRM content to an Android device with CMA audio enabled. Change-Id: Ica7ef53f25a5ff305a7726cebe4fca511a43502d Reviewed-on: https://chromium-review.googlesource.com/1152464Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Melisa Carranza Zúñiga <melisacz@google.com> Cr-Commit-Position: refs/heads/master@{#580638}
-
Jun Mukai authored
ui::CreateInputMethod is called implicitly within the Setup of AshTestBase (somewhere within ash::Shell::Init()), which conflicts with ui::SetUpInputMethodFactoryForTesting(). So the CHECK fails if TextInputTest runs along with other tests in exo (i.e. without gtest_filter flags). Actually SetUpInputMethodFactoryForTesting can be called for every tests in exo, so that is moved there. BUG=870690 TEST=exo_unittests succeed without --gtest_filter flag Change-Id: I9e9bb009b7b5af3715759ee29ac6c94f9614eecf Reviewed-on: https://chromium-review.googlesource.com/1162621Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#580637}
-
Sam Maier authored
Currently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. Looking at this code, I don't think we can escape the SERIAL_EXECUTOR here, since there appears to be non-thread-safe things happening in the AsyncTasks, and no guarantee they won't get scheduled at the same time. Bug: 869907 Change-Id: I7c1e1a74e48c2d2e774d71e04d89a83c02562e5b Reviewed-on: https://chromium-review.googlesource.com/1162662Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#580636}
-
Rohit Rao authored
This reverts commit 3b42f46a. Reason for revert: Crashing internal bots Test Case '-[GoogleServicesSettingsTestCase testOpeningServicesWhileSignedInAndConsentGiven]' started. 0803/040411.392060:FATAL:unified_consent_service.cc(155)] Check failed: identity_manager_->HasPrimaryAccount(). 0 ios_chrome_unified_consent_egtests 0x000000010d19df38 base::debug::StackTrace::StackTrace(unsigned long) + 72 1 ios_chrome_unified_consent_egtests 0x000000010d19df9d base::debug::StackTrace::StackTrace(unsigned long) + 29 2 ios_chrome_unified_consent_egtests 0x000000010ce8adac base::debug::StackTrace::StackTrace() + 28 3 ios_chrome_unified_consent_egtests 0x000000010ced068b logging::LogMessage::~LogMessage() + 315 4 ios_chrome_unified_consent_egtests 0x000000010cecf495 logging::LogMessage::~LogMessage() + 21 5 ios_chrome_unified_consent_egtests 0x000000011054785e unified_consent::UnifiedConsentService::OnUnifiedConsentGivenPrefChanged() + 638 Original change's description: > [iOS] Start unified consent service at startup > > Bug: 827072 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I2f2e14ceba73ebecbc9c0222ae87ea86e4f91a49 > Reviewed-on: https://chromium-review.googlesource.com/1159062 > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580485} TBR=msarda@chromium.org,sdefresne@chromium.org,jlebel@chromium.org Change-Id: I4d94ba1e7630c81f666d336882c17c993ac5ef02 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1162402Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#580635}
-
Miguel Casas authored
This CL adds TRACE_EVENT0() to some important CanvasResourceDispatcher methods: DispatchFrame{Sync}() and PrepareFrame(), which are now used more frequently, for lowLatency cases. Bug: 869161 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I66dfd2f47eaba0183d34c5e1f09f759d6f0fcf1b Reviewed-on: https://chromium-review.googlesource.com/1161974Reviewed-by:Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#580634}
-
Artur Khachatryan authored
Change-Id: I8998c03e69247f53bc183bac631b891eada88784 Reviewed-on: https://chromium-review.googlesource.com/1162623Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580633}
-
David Black authored
Per the spec, the query view should remain at the bottom of the UI container until the response is received. To accomplish this, this CL: - Adds active_query_view_ pointer. The lifetime of a query view is now: - pending_query_view_: created when query is pended. - committed_query_view_: pointer swapped when query is committed. - active_query_view_: pointer swapped when query response is received. A committed query that is aborted will not reach the "active" state when the motion spec is enabled. To prevent regression of current UI behavior, when the motion spec is disabled we immediately "activate" a query when it is committed. See bug for spec/demos. Bug: b:112114187 Change-Id: Icea7ebccc9f0a5aa554c88d969fa79000855b9db Reviewed-on: https://chromium-review.googlesource.com/1159826 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#580632}
-
Kurt Horimoto authored
This CL adds GridLayout.animatesItemUpdates, which can be used to disable animations from occurring when items are inserted or removed. This is done to prevent the interleving of the new tab insertion animation and the tab presentation animation. Bug: 864982 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7867fc475a6d399a8ecbe45df456fd6082f6d8eb Reviewed-on: https://chromium-review.googlesource.com/1161560Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580631}
-
