- 21 Jan, 2021 40 commits
-
-
Ramin Halavati authored
"Profile.EphemeralGuest.Signin" metric is recorded when user signs in to or signs out from a GAIA account in an ephemeral Guest profile. Bug: 1167474, 1148695 Change-Id: Ib0aa6660c2663083b740a6c393243a0058be78c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632694 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#845705}
-
manukh authored
Drive responses have noticeable latency. To avoid matches switching styling between drive-like (e.g. 'Title - Date - Owner - Google Docs') and non-drive-like (e.g. 'Title - URL'), the provider caches previous matches and returns them synchronously before the async matches from the backend are ready. Cached docs that no longer match the input, should not be displayed; e.g. the match 'doc x' should not be displayed for input 'doc y' even though it may be cached from the previous input 'doc '. Therefore, cached matches previously had their scores set to 0; if still relevant, they will inherit a non-0 score from a duplicate history or bookmark match; otherwise, they'll keep a score of 0 and be hidden. This had 2 problems that resulted in matches either appearing & disappearing or swapping places during the sync (on keystroke) and async (on backend response) phases: 1) There isn't always a duplicate match to inherit a score from. 2) Ranking per history/bookmark scoring could differ from the ranking per the max of the history/bookmark & document scoring. To address the above 2 issues, cached matches no longer have their scores set to 0 during the async phase. To preserve the original intent, cached matches will continue to have their scores set to 0 during the sync phase. Also groups the code controlling whether to run the document provider into |IsDocumentProviderAllowed()|, should have no effect. Also updates doc |stripped_destination_url| to use |AutocompleteMatch::GURLToStrippedGURL()| (which invokes |DocumentProvider::GetURLForDeduping()|) instead of calling the latter directly. The former resorts to a generic striped URL computation if the latter doc-specific computation doesn't succeed. This ensures a non-empty |stripped_destination_url| which avoids overriding cache entries. Change-Id: I7f8b5c4935df40c0c8a937725f4fb99d93bdd637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634131 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#845704}
-
Mihai Sardarescu authored
Per https://bugs.chromium.org/p/chromium/issues/detail?id=1166192#c10, the product decision was to always show the profile picker on start-up instead of restoring the session. This CL shows the profile picker even instead of restoring the session. Note: The user has a choice to never show the profile picker on start-up (and restore their session) - they just have to select "Don't show on start-up" on the profile picker UI. Bug: 1166192 Change-Id: I853a227abfff7f7fe7f24c07c4166ef553d4b75c Fixed: 1166192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629268Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#845703}
-
Collin Baker authored
Both TabRestoreService and SessionService support tab groups, but restoring a window after a browser restart did not restore groups. This was because the code translating SessionService entries to TabRestoreService entries did not copy over group data. Adds the necessary code to restore groups correctly. This allows, for example, restoring a recent window with groups after a browser crash. Fixed: 1168751 Change-Id: I6510ab036caa1450f904ea7e1209885acf08682d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641334Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#845702}
-
Nick Diego Yamane authored
The drag-and-drop origin surface may get suddenly destroyed, when it is a xdg-popup, eg. dragging bookmarks bar's menu item in Chrome, which currently leads to crashes in WaylandDataDragController. This CL fixes it as well as adds unit tests to prevent future similar regressions. R=msisov@igalia.com, tonikitoo@igalia.com Bug: 1143707 Test: Covered by ozone_unittests --ozone-platform=wayland Change-Id: I1bac3032c428d3456bf644b35f869ec6ff5122e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635449 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#845701}
-
Michael Savigny authored
This change ( https://chromium-review.googlesource.com/c/chromium/src/+/2633051) requires the libstc++ library under third_party/llvm-build/Release+Asserts to be uploaded, and explicitly set to be included in remote action uploads. Bug: 1169195 Change-Id: Ib7f8427d7bbb42db96d6cb907d0518d2696f2859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642860Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#845700}
-
Dave Tapuska authored
Use gfx::Size/gfx::Rect respectively. BUG=738465 Change-Id: Iaa3ac722f8477f49c5f9bdae678f617d04ba06ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639312Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#845699}
-
Aaron Leventhal authored
Anonymous layout objects do not need their own AXObject. Creating them causes parent computation errors. For example, the layout hierarchy used for ruby, and for table CSS, can contain additional layout objects that are not reached during the normal AXObject tree building process, which uses the DOM. The cleanest fix is to simply no longer create these objects. Note: although these were previously being created, in GetOrCreate(LayoutObject*). they were not part of the AX hierarchy. Bug: 1138028 Change-Id: Ibb5b99907ad8c45e0a0bd9aa7f44df0ac74f9224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633425 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#845698}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee9fbcba..4e306939 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7ed08aeb5581470024bfbaecdbf808fa987e5cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643020Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845697}
-
Ben Mason authored
Change-Id: I712a3fe59be4f72d6033d745931f99d0c2ea32ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642878 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845696}
-
Ehsan Kia authored
This CL cleans up and submits a script originally written by engedy@chromium.org with a few speed and convenience improvements: - use multi-threading to reduce runtime from ~45m to ~8m - add flags for controlling a few options - automatically run the config formatter - reduce the number of false positives - make the script py2 (since chromium is still on py2) Bug: 1053702 Change-Id: Ie5d211d0374f5db6352677821e27defa415c7d11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637405Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ehsan Kia <ehsankia@google.com> Cr-Commit-Position: refs/heads/master@{#845695}
-
Garrett Beaty authored
Change-Id: Iec3d74ae1c0e78de49df7a89b3f12402d40ecc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641335 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#845694}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30152edff696..1890f38f2471 2021-01-21 leese@chromium.org Deduplicate memory tabs by backing store 2021-01-21 andoli@chromium.org [module.json extensions] settings views 2021-01-21 petermarshall@chromium.org [surveys] Move SurveyLink component into ui/components If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112738,chromium:1134103,chromium:1163802,chromium:1169143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie909efd2a11e7730319e1704a25a63e9fd79e9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845693}
-
Reilly Grant authored
This directory has been fully converted to choose between Once and Repeating for all callback types and calls to base::Bind(). Bug: 1007654 Change-Id: I9fd5a20aea036e0e5f6e93a7eed325b8c2a7cc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641159 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845692}
-
Nick Burris authored
* Records SecurePaymentConfirmation.Funnel.AuthenticationDialog metric based on the user action performed on the dialog. * Adds test coverage of the metric to the existing dialog view test. Bug: 1163574 Change-Id: If1fac8ec81225c3227fff1f84f1f97eefe1914fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639140Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#845691}
-
Regan Hsu authored
If after sending the phone status to the phone, and CrOS does not receive a response from the phone that updates the phone status model, resend the phone status after waiting 2 secs, then 4 sec, then 8 sec, etc until the phone status model is populated or the connection status is no longer connected. Bug: 1166844 Change-Id: Icf456c941a48704119af2beb3c5a694b2e39b2ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639307 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#845690}
-
Ben Kelly authored
This CL factors out the code to write an entry's metadata into its own method. This is in preparation for a later CL that will need to rewrite the metadata with an updated value. Bug: 1143526 Change-Id: I887bbd5f631e41c19c1e863c04d531764de807c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634124 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#845689}
-
Maksim Moskvitin authored
Bug: 1152279 Change-Id: I7c0855e4d362934d7273ca44973dd5e0cce62cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640538Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#845688}
-
Marc Treib authored
Sync.URLFetchTimedOut is extended by 6 months. I also updated the description to point out a (small) caveat with the numbers. Sync.SessionTabs is marked as obsolete. Bug: 1160835 Change-Id: If5fd2501742197aa0c09fa1794b828705277a03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640035Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#845687}
-
Eugene But authored
Replace eugenebut who is leaving the team with kazinova Change-Id: I26cc79efbd932c73866ffbd509381c6472a571a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639146Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Maria Kazinova <kazinova@google.com> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845686}
-
Stefan Zager authored
When a site-isolated iframe moves to a new process, we need to ensure that the browser sends it an initial set of properties that are generated by the parent frame, even if those properties have not changed. Previously, we redundantly re-sent the properties every time frame rects for the iframe changed. With this patch, we send the initial properties only once, after the first time VisualProperties is sent to the frame. This is a follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/2628746 Bug: 1135714 Change-Id: I72e2f30d12525ab3f8cfb97a178b5185a9f6ca13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640893Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#845685}
-
Dan McArdle authored
Change-Id: I34aefab0097426efd47a07062e5a448530c66a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626510 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#845684}
-
Hidehiko Abe authored
crrev.com/c/2617229 enabled libaom, and Lacros was the target, too. However, it couldn't be built for the device. TBR=jzern@chromium.org BUG=1169028 TEST=Built lacros and ran on a device. Change-Id: I0cfda8eddaa778cda72e1fa0b6965b4b84a996f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642045Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#845683}
-
Takuto Ikuta authored
Bug: 1127205 Change-Id: I1c9aab15909f49b163563b17ef9d2888546b7081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642636 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#845682}
-
Katie Dektar authored
Bug: 994384 Change-Id: Ie106d0ba2362f58caaae8669bde7af1ca3f6e53e AX-Relnotes: Fixes crash Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638929 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Auto-Submit: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#845681}
-
Austin Sullivan authored
GetDatabaseNames was refactored to use GetDatabaseInfo here [1]. GetDatabaseNames was formerly special-cased to not create the database if one didn't exist, but this was lost in the refactor. [1] https://crrev.com/c/2557571 Bug: 1163336 Change-Id: I61f1fb0e6ab60c00143ca1471690bf869119aaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622988Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/master@{#845680}
-
Thomas Lukaszewicz authored
This CL adds RenderProcessHost sharing support for WebUI URLs of the form chrome://foo.bar/. This is achieved through an update to ComputeSiteInfo() that allows WebUIType to continue to be differentiated via SiteURL but allows sharing of a RenderProcessHost via ensuring the LockURL is based on the WebUI URLs TLD (chrome://bar/ in the example above). RPHI::GetExistingProcessHost() has been updated to skip selection of the spare RenderProcessHost as this will have been considered in the previous call to MaybeTakeSpareRenderProcessHost(). This skip replaces a DCHECK that ensured that the spare RenderProcessHost was not selected as a suitable renderer. Updates to ChromeContentBrowserClient have been made to add support for process sharing between WebUIs with the "top-chrome" TLD. Bug: 1162282 Change-Id: I6b8c07b3bdb6f790ca79e43eded7142ceface290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628027 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#845679}
-
Maksim Moskvitin authored
Note: |connection_| in BrailleControllerImpl never reset and CreateBrlapiConnectionFunction never returns nullptr, thus OnceCallback can be used. Bug: 1152279 Change-Id: I3a7044c7b4143698fb363aa5a4a694156754a0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640537Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#845678}
-
Michael Lippautz authored
Funnel MaybeValid() through a trait instead of imposing an API on the receiver. This allows us to avoid implementing a MaybeValid() API on Persistents in the Oilpan library. Bug: 1056170 Change-Id: I05f2497a6a10a8324980e5b82b4c40c785af8331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642680 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845677}
-
Evan Stade authored
Bug: 1161031 Change-Id: I87886fe6c86580299474fafab76a70eaf74964fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639940Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#845676}
-
Yashar Dabiran authored
This CL adds a new metric that records the number back navigations to a Google search result page in a search session. This is part of efforts to record metrics for CSN stage 1. See go/csn-design for more details on the project. Change-Id: Ida5ac7358764a8c13da5aea8890957f77c6e2a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616325Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Yashar Dabiran <yashard@chromium.org> Cr-Commit-Position: refs/heads/master@{#845675}
-
Wan-Teh Chang authored
Change-Id: I9c2cca98c3d48bc0e948ddddf67622277a459c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638545Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#845674}
-
Gavin Williams authored
This change also removes the progress bar and cancel print button in print notifications. These are permanently handled by print job management app now. Fixed: 1165993 Change-Id: I408093add0618f2bd0b9994c41d96feb262a00d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626111 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#845673}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 134c4eda. With Chromium commits locally applied on WPT: 898dcda5 "Move CSPEE to the NavigationRequest." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I7e3f074814ec9a6d5b1022938992121e0f4f7880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642307Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845672}
-
Matthew Denton authored
The ReconnectsAfterURLLoaderFactoryDisconnection test checks that there have been at most two requests after the URLLoaderFactory disconnects and reconnects, but it should have been checking for at least two requests. Bug: 1168193 Change-Id: I7c816e433a10e043e70dc1032519b8795253dd3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641141 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845671}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.101. R=hypan@google.com Bug: 1041619 Change-Id: I9a62d5ac6f4dc2d6a741571192442fa79b493327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641114 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#845670}
-
Alexander Surkov authored
Bug: 1136957 Change-Id: I8840cc3a469c55fbde6a7f78e1ce5158f5afa4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637716 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#845669}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b349f3ea9c0..79b1b0af2eb9 2021-01-21 fmayer@google.com Add .cache to gitignore. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I445ce914f1b5fbcad6887ececa1c940489f0a762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642810Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845668}
-
Alex Ilin authored
This reverts commit e23f231d. Reason for revert: crash https://crbug.com/1169047 that was caused by the original version of this CL was fixed Original change's description: > Revert "[profiles] Don't show a profile being created in the picker and menu" > > This reverts commit e2de939b. > > Reason for revert: causes crash https://crbug.com/1169047 > > Original change's description: > > [profiles] Don't show a profile being created in the picker and menu > > > > This CL leverages the already existing kIsOmittedFromProfileListKey > > preference in ProfileAttributesEntry to mark profiles that shouldn't > > be shown to the user. > > > > kIsOmittedFromProfileListKey was created for profiles in the middle of > > being set up as new legacy supervised users. The preference was dead > > because it was never set to true. This CL revives it and adds additional > > checks to profile_picker_handler.cc and profile_menu_view.cc to not > > display omitted profiles. > > > > Bug: 1126913, 1166809 > > Change-Id: Ieb05f31d8951f2971201351bead7c108eb874473 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632752 > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#845372} > > TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I5133c4502f02b68c4e707fa7c86072bdabce4ff2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1126913 > Bug: 1166809 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642328 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845616} TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 1126913 Bug: 1166809 Change-Id: I8aba3d3ffef4e01a51228d449e7e0bac24b8f7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642329Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845667}
-
Sylvain Defresne authored
This function is useful to check whether the device supports having multiple scenes (which has impact on core behaviour of the application and not just on the UI). Move it besides other multi-window related functions. Fix compilation when targeting iOS x86 platform caused by the inclusion of partition_alloc header in base/memory/checked_ptr.h even when user_partition_alloc is disabled (which is always the case on iOS). Bug: none Change-Id: I31f7abb6479438176ed72467ddf9811624001911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640455 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#845666}
-