- 01 Sep, 2020 40 commits
-
-
Daniel Classon authored
Adds deep links to the Date Time page and Time Zone subpage. Also adds a focus method to settings-radio-group to help with deep linking. Bug: 1084154 Change-Id: I53cfc17e386ce6799dff95a5d7afccfe7a847f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382960 Commit-Queue: Daniel Classon <dclasson@google.com> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#803362}
-
Minggang Wang authored
Currently, the worker thread calls the Terminate() of the child threads during executing PrepareForShutdownOnWorkerThread(). This patch removes the explicit calling, because the nested workers are observers of the terminating worker's worker global scope, the child threads will get terminated when notified with ContextDestroyed(). Change-Id: I7b9fd424c5b954b31ff83b1027608e5e24c04bbd Bug: 1104847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377580Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#803361}
-
Xinghui Lu authored
This is a follow up CL for https://crrev.com/c/2359749. It is for pure refactoring. The plan for this two-sided patch is: 1) Add the new class under feedback/ and AppHooks method upstream with no reference. 2) Extend the new class downstream and add the new AppHooks method. 3) Update upstream references to point to the new AppHooks method. 4) Cleanup. This CL is for step 1). Step 2) will be done in https://crrev.com/i/3227761 once this CL is landed. Bug: 1117343 Change-Id: I312f3459360fa5e1b78f6e301b052a36bed2e9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364581Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803360}
-
Yulun Wu authored
This CL adds light mode for login shelf buttons, text, icons, and wallpaper. Bug: 1110757 Change-Id: I1057aa89bf777f3f35564d7876256f9381059e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363799Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803359}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7b69a44c8b1c..9e02f4716a1e 2020-08-31 deadbeef@webrtc.org Fix destruction order of PortAllocator and PacketSocketFactory. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaff60306d3724cb402b96af01e9960a73d88d032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803358}
-
Gang Wu authored
This reverts commit 78a7ace4. Reason for revert: This CL make PhotoPickerDialogTest flaky https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.components.browser_ui.photo_picker.PhotoPickerDialogTest%23* Original change's description: > Remove ApplicationStatus usage from PhotoPicker. > > ApplicationStatus only works in //chrome. See crbug.com/470582 > > Bug: 1110930 > Change-Id: I71a6a5701aa40434588830cfcc6dee8ff6f5143a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378633 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803247} TBR=finnur@chromium.org,dtrainor@chromium.org,estade@chromium.org Change-Id: I78eaf08ba277d516584ae75d38ce64909ba36bff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387196Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803357}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e1e6f2940c25..59d28532a179 2020-08-31 jdarpinian@chromium.org Fix GL_EXT_texture_compression_s3tc_srgb on macOS 2020-08-31 m.maiya@samsung.com Vulkan: Optimize atomic counter buffer offset calculations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I48f674818122da58bb223f71a26ec51697c4ed80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386666Reviewed-by:
-
Devlin Cronin authored
InfoBarDelegate::infobar_ was uninitialized during construction - which is bad for delegates that try to access InfoBarDelegate::infobar(). Properly initialize it to nullptr. Bug: None Change-Id: I8f52e02fbca1486f7c60c8f2791cd7e8c464d5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387118 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#803355}
-
Kenichi Ishibashi authored
GetNew{Registration,Version,Resource}Id() are async now. Remove outdated comments. Bug: N/A Change-Id: I329d7a4de8949a7493d0751c24701b2a56ad0ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386677Reviewed-by: -
Lukasz Anforowicz authored
This CL adds extra crash keys logged when a DumpWithoutCrashing happens while handling a network::ResourceRequest: one for |resource_type| and one for |load_flags|. This extra crash keys should help ensure that the expected values are seen in the most common cases of DwoC seen in https://crbug.com/1056949. See also the "Callstack and request properties corresponding to the most frequent DwoC" section in a (Google internal) doc here: https://docs.google.com/document/d/1Q8UxpBLyv0SorQKLvY8M5npvyMroMlo9i6ZpUMol9aY/edit#heading=h.hquty15bu38n Bug: 1056949 Change-Id: I765a1baac9e756747a54cf5b60cab54c63b520fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386417 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#803353}
-
Jonathan Ross authored
Update GpuMemoryAblationExperiment to have more fine grained controls for setting the size of each ablation. Rather than there being 3 hard coded sizes, the multiplier for the size is read in. With setup to parse Finch parameters, and additional command line flag for use with running experiments outside of Finch trials. Bug: 908462 Change-Id: Ie6e03809f788334d15d20ba1756f94640d84bd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360572Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#803352}
-
Joel Hockey authored
The combination of loading html-imports.min.js but also having the renderer parse and load imports for file:// URLs, causes polymer to fail to load in FileManagerUITests. Adding a check for toast.shadowRoot and creating one if required fixes the test (crrev.com/c/2373967/15). Bug: 1111393 Change-Id: I79decc2a58192598b57f7c485073edaea3a87e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386681Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#803351}
-
nancylingwang authored
For the adaptive icon, there are 2 files opened for each icons, so when there are many apps installed, many files are opened to load the image, which might cause the system crash: Too many open files This CL modifies the code to reduce the unnecessary icon loading, and reduce the duplicated open files: 1. For OnIntentFiltersUpdated, we don't need to update the icon to reload the icon. 2. Modify the background image source in ArcAppIcon to set the null host, because ArcAppIcon::Source checks the host and call LoadForScaleFactor to read icon files. Since that has been done by the foreground image, we don't need to do it for the background image again. b:166430206 Change-Id: Iecc76ca8e02bc5ef2230f99553abb8fb4a00362c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386435 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#803350}
-
Haiyang Pan authored
This reverts commit 564da6d9. Reason for revert: Very likely the cause of crbug.com/1122472 See the analysis in crbug.com/1123677#c4 for detail Original change's description: > Make ContentCapture ready for experiment > > Currently the triggering of ContentCapture is unpredictable, it is > hard for us to get the unbiased result for the UserActivatedDelay > experiment. > > This patch adds an ExperimentContentCaptureConsumer which triggers > the ContentCapture independently and is enabled by default. > > The allow list check is moved to consumer if the experiment > is enabled. > > As ContentCapture is potentially used for all Android versions, > we plan to run the experiment for all of them. > > This mechanism will also be used for future experiments. > > This patch hasn't supported multiple consumers yet. > > Test: Added new tests and pass the existing tests > > Bug: 1114819, 1119663 > Change-Id: I72e0b991767329caec37080caae2d5c2a9068eaf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368104 > Commit-Queue: Tao Bai <michaelbai@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801672} TBR=michaelbai@chromium.org,wangxianzhu@chromium.org,dtrainor@chromium.org,changwan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1114819 Bug: 1119663 Bug: 1122472 Change-Id: Ife98d73f4e77062606f18adb0ba12e9baaf4f6c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386578Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#803349}
-
Gang Wu authored
This reverts commit e5b906d1. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1134 Original change's description: > Don't show default undo bar for closure in TabGridDialog > > This CL prevents default undo closure snack bar from showing when a > closure happens within TabGridDialog. We use the visibility of > TabGridDialog as a proxy to decide whether a closure happens in dialog. > This is the step2 in https://docs.google.com/document/d/1OOlOVYtcFXE--8TMdcFAqAMqcsRyEsvJr0vzsNCR_F4/edit?usp=sharing. > > Bug: 1119899 > Change-Id: Ibdfe53847af25921f32436d80a5868b97340a524 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369469 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803203} TBR=yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org Change-Id: Ie98c1246828bc48c3569184c2565338d54f67629 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386374Reviewed-by:
-
Kuo Jen Wei authored
CCA has 3 kinds of property currently undefined to closure compiler: 1. Properties set by external browsing context. 2. Properties defined in dataset. 3. properties defined under * type. This CL use bracket property accessors to access these properties for avoiding being caught in closure compiler strict mode check. Bug: 1122444 Test: tast run <DUT> "camera.CCAUI*" Change-Id: I8f57adc6ca536629377af4976bb45515b4efc2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383590 Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#803347}
-
Gang Wu authored
This reverts commit 3c8430ae. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1133 Original change's description: > Batch BottomSheetControllerTests > > This patch batches all the tests in BottomSheetControllerTest. > Consequently, some new methods to reset the sheet's state were added > to the test support classes and BlankCTATabInitialState was updated to > support any subclass of ChromeActivity. > > Bug: 1122163 > Change-Id: I3fbb73431eff206010d93d8c5e26e4942b84adb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377664 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803156} TBR=mthiesse@chromium.org,mdjones@chromium.org Change-Id: I41a36c86f34d947b69e00a92109f56f0bfcda760 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1122163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386500Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/473462adb6b1..ed15af5c4eed 2020-08-31 bpastene@chromium.org gclient: Don't try opening pseudo-terminal pipes when running hooks. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1122671 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ide32db2ba64b52f31792412aaf913fb349871735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386661Reviewed-by:
-
Ilya Sherman authored
https://crrev.com/c/2366154 landed in parallel with https://crrev.com/c/2380889, and the two collided. This CL fixes the collision. R=sweilun@chromium.org Bug: 758782 Change-Id: I10a1b4770877e1394a642a34bdbf9212c1d5a838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387135 Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#803344}
-
John Williams authored
Bug: 1095764, b/159154368 Change-Id: I36829467e3a6477499c76ae0b15e110acba00c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346911Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#803343}
-
K. Moon authored
Triggers process-wide initialization of PDFium when an instance of chrome_pdf::PdfViewWebPlugin is initialized for the first time. PDFium will be shut down when all plugin instances have been destroyed. Also renames IsSDKInitializedViaPepper() to IsSDKInitializedViaPlugin(), in order to reflect that the SDK may be initialized by either the Pepper or Pepper-free plugin. Fixed: 1123552 Change-Id: I00ce39779edfe61726b6a55240300ece1aa8527c Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386597 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#803342}
-
Gavin Williams authored
This change adds a check to see if a user's Google Drive directory is mounted on Chrome OS. If Drive is not mounted then we don't show the Save to Drive option in the dropdown. Reasons why Drive could not be mounted (callback would return false) include: Drive is disabled by the user, disabled by enterprise policy, or is in a crashing state. Also remove "isDriveMounted" as a print preview handler message callback because this data is now sent back with the initial settings. Bug: 1112416 Change-Id: I26acf17a41cb178f99c630b2daf43d02ae08134d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382204 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#803341}
-
Shimi Zhang authored
In some OEM Android framework clipboard service code, there are strict mode violations, which makes the calling thread/process to crash. We need to suppress the crash by disabling strict mode. Bug: 1123727, 1113428 Change-Id: Iee30100c0ae41fee1856a7b5d8c43e1a28132959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386662Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#803340}
-
Matt Menke authored
StringPieces all the way through the MIME sniffing code. This CL only updates net/ consumers to use the overloads, which are all test-only code. I'll update consumers and remove the old methods in another CL. Bug: 1123179 Change-Id: I04328913fa1c7bfd9049fa7aaae6a8a538cbe8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382896 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#803339}
-
Glen Robertson authored
Fixes a `gn check` failure. Split out from crrev.com/c/2383400 Bug: 898837 Change-Id: I5dcc0ff5d00bfa04c241a07fc62c63c502a1ad74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384691 Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#803338}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/77fb6d1812df..1eb42f5ea752 2020-08-31 jleconte@google.com Monorail links are missing project in chart tooltip. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: sadrul@google.com Change-Id: I65471b51127bef995827df65ab841ebe073abc76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384525Reviewed-by:
-
Zach Trudo authored
StorageModule::ReportSuccess needs to pass the sequencing information to storage_->Confirm instead of logging an error. Bug: chromium:1078512 Change-Id: Iddd157e4ec09ee6ec881f2b29f813bfa1b1bbf41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368319 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#803336}
-
Devlin Cronin authored
Remove test logic that checks for whether the ExtensionsToolbarMenu feature is enabled. Since the feature has launched, these branches are no longer necessary or useful. This CL should have no functional behavior change. Bug: 1100412 Change-Id: I892b3c9565d28784e72937d10e94cad0f72f0c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385898 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#803335}
-
Jonathan Freed authored
for the feed. Bug: 1123044 Change-Id: I7d0e11ddf0dd91efbc45889c38d41b80a1fef82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380745 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#803334}
-
Darren Shen authored
This reverts commit 7456a5e0. Reason for revert: Suspecting as cause of crbug.com/1123758. Original change's description: > Add names to tuple-parameterized tests > > Test names can only contain alphanumeric characters, plus underscores. > testing::PrintToStringParamName() stringifies tuples using characters > that aren't valid for test names. > > Add a similar function which joins each element using underscores. This > will generate valid names for test parameterization, provided each > element of the tuple can be written using valid characters. > > Bug: 1092945, 1117587 > Change-Id: I868b1d4040a93bdbf763dbb45b94ff15f181dd18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376882 > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803182} TBR=kylechar@chromium.org,sgilhuly@chromium.org Change-Id: I7ef3a845df745a1b7cdd4fe09ba24e76abb26138 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1092945 Bug: 1117587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387036Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#803333}
-
Aleks Totic authored
New implementation of the row layout algorithm. Interesting bit is an extra layout required to get the correct baseline when cells have percentage block size descendants. Also updated NGTableConstraintSpaceData, an oversight from previous CL. Bug: 958381 Change-Id: I32c1b5295167e8c53fe551bddc8c141e911430a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376480Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#803332}
-
Yngve N. Pettersen authored
chrome_public_apk_or_module_tmpl template instantiation for an Android target Change-Id: Ie38eaabdcf6a5bc17e39f76cfc06545a3c5f8398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385397 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#803331}
-
Dale Curtis authored
The layout and encoding of parameters in SmDm is different than the mdcv; so we must use a different parsing. R=cassew Bug: 1123430 Change-Id: Ic4cc05a5b9a1ac9d90a81f69ae94150956c04435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386118 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Will Cassella <cassew@google.com> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#803330}
-
Hui Yingst authored
This CL adds a new private method GetDocumentAttachments() in OutOfProcessInstance, which generates a pp::VarArray for the PDF's attachment information. The CL also updates the description for PDFEngine::GetBookmarks(). Bug: 177188 Change-Id: I3afa174e2e75a53d9479c345e81686bb1d51c578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335763Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I03ea90054fbb63d59c0de5ad8d318cfd153259c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385876Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#803328}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/81de439281e9..7b69a44c8b1c 2020-08-31 deadbeef@webrtc.org Fix ABA problem when iterating epoll events. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia5b36f515e3ede0da071dc5c8cd3c6b42ee3b4ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386955Reviewed-by:
-
Zhuoyu Qian authored
This CL renames Web IDL |NoInterfaceObject| to |LegacyNoInterfaceObject| to make its usage more clear. Bug: 1072773 Change-Id: I41c604c3c9d1d6777717a4c32cd1294cad7f8ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368622Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#803326}
-
Vincent Boisselle authored
We have a use case where we need our custom ViewRectProvider to call notifyRectHidden() when the rectangle that represents the anchor reaches a certain position, which dismisses the IPH. Bug: 1085601 Change-Id: I687df3a1a24cf0e045b9ff39d127a60efbcc3802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212971Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#803325}
-
Tal Pressman authored
The interfaces are still empty and don't do anything. Bug: 1111231 Change-Id: I778d365eaaaf53cf8e9855bc131f1cebc69d4f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374186Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#803324}
-
nancylingwang authored
The test case includes restarting ARC. However, the ARC apps are not removed from AppService AppRegistryCache, so when the ARC is restarted, the previous icon loading requests before ARC restart might affect the icon loading account. Modify the tests, when the ARC restart, remove the ARC apps saved in AppService AppRegistryCache, which is the consistent operation as running on Chromebook. Also add waiting icon loading operation after StartApp, because the icon loading operation might be slow. BUG=1115830 Change-Id: Icc7acdb49ca41232712b141db93e41645a2f1287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379432 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
