- 10 Sep, 2018 40 commits
-
-
Scott Chen authored
This CL moves the extension-view-manager to a shared location to be used by other WebUIs. The immediate use case is for a new welcome page; see linked bug for details. Bug: 874146 Change-Id: Ieb168e61cf6ae02e04d624c92a131e9ec38fcdae Reviewed-on: https://chromium-review.googlesource.com/1157241Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590091}
-
Moe Ahmadi authored
The root cause was that item of type ItemTypeSavedPasswords was not being properly formatter in |-collectionView:cellForItemAtIndexPath:| Also sets the detail text of the item at the time of creation, and not only when the preference changes. Bug: 882583 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I68a3d8660e520a99ec59b3fc48fb2f78dc59b5fe Reviewed-on: https://chromium-review.googlesource.com/1217503Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#590090}
-
Antonio Gomes authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates chromeos::chromeos::AttestationCAClient and the respective unittests away from URLFetcher. BUG=773295,879782 Change-Id: I9ccdad3a73108ad3e3e7ab4f148b93048433b3bd Reviewed-on: https://chromium-review.googlesource.com/1202223 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590089}
-
Kai Ninomiya authored
Bug: 881144 Change-Id: Idc5292cecf9a3d4dbc101a9c44c47bd3db62dab6 Reviewed-on: https://chromium-review.googlesource.com/1208941Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#590088}
-
Quan Nguyen authored
Previously we prevented the login bubbles from overlapping into the shelf. This had some annoying side effects like obscuring the password field. This CL removes that part of the widget repositioning logic. A future CL will address the potential case of login bubbles going off screen on the bottom. Need to clarify the correct UX for this case. Bug: 880224, 875787 Change-Id: Iea42cd612e9b0c57516fdc9681843182fa8d268b Reviewed-on: https://chromium-review.googlesource.com/1217742Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590087}
-
Min Chen authored
changes in this cl, - Do not change the shelf's visibility if drag on the shelf that has been set to always shown. - Gesture drag on the shelf should not change its auto-hide behavior. Since we can only change it through the context menu of shelf now. - Fixed the failed related ShelfLayoutManagerTest*. Bug: 880682, 881154 Change-Id: I2187c4636b1bbb5ca59149e33dbcbb8c664863b1 Reviewed-on: https://chromium-review.googlesource.com/1214049Reviewed-by:
-
Xiaohui Chen authored
When Views are invisible by opacity 0 but still have visibility true, screenreader would still be able to read it. We need to explicitly set their visibility to false. Bug: b:113731925 Test: locally build and not able to navigate to these elements with Test: screen reader Change-Id: Ibb1b111844dbd6021c267ef594777614cf127189 Reviewed-on: https://chromium-review.googlesource.com/1212342Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#590085}
-
Quan Nguyen authored
Bug: 879542 Change-Id: I3712f517ab3ee5f78eede3922335ac5e240b9816 Reviewed-on: https://chromium-review.googlesource.com/1217342Reviewed-by:
-
David Black authored
This reverts commit 9bc4c7ef. Reason for revert: CL fixed UI jank but regressed accessibility. Will re-implement with another approach. Original change's description: > Fix UI jank caused by visibility change. > > Previously, when animating the footer view and/or its children, we > modified visibility so as not to receive focus/accessibility events on > hidden views. > > Unfortunately, changing the visibility of the footer view has a side > effect of freeing up space for UiElementContainerView. When this > happens, there is a bit of UI jank when the UiElementContainerView > takes that available space when really that space should permanently be > reserved for the footer. This becomes more obvious in a follow up CL in > which we add a shadow above the footer. > > Now, we don't modify view visibility. Instead, we update focus behavior > as appropriate before animations start and after they end. > > See bug for repro steps. > > Bug: b:113871610 > Change-Id: Ic8aa509c722ace44675a3ab7c7e0453c0aa4a352 > Reviewed-on: https://chromium-review.googlesource.com/1197906 > Commit-Queue: David Black <dmblack@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588926} TBR=xiaohuic@chromium.org,dmblack@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:113871610 Change-Id: I81f93ff5b641fab87e9b00fffc1c6c428ff44388 Reviewed-on: https://chromium-review.googlesource.com/1216812Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#590083}
-
wutao authored
This patch flips the flag of Continue Reading to default on. Bug: 882602, 843839 Test: manual. Change-Id: Idaebea1a12926d1a64482b06af3644e55fc01b4a Reviewed-on: https://chromium-review.googlesource.com/1217593Reviewed-by:
-
Chris Palmer authored
Also embellish the PA API a bit to make accessing the new zero-fill functionality more usable. There are likely additional call sites that can make use of this functionality. Bug: 864462 Change-Id: I8881c5774b6083b210f5160d4b4f2ac345f2467e Reviewed-on: https://chromium-review.googlesource.com/1212443 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590081}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b2d711673390..cf64a04acdf3 git log b2d711673390..cf64a04acdf3 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 phoglund@webrtc.org Bump tryserver mac versions and xcode versions. 2018-09-10 mbonadei@webrtc.org Refactor initialization of GetRealTimeClock singleton. 2018-09-10 srte@webrtc.org Adds initial data window field trial to GoogCC. 2018-09-10 henrik.lundin@webrtc.org NetEq tools: Fixing an issue with measuring the simulation time 2018-09-10 aleloi@webrtc.org Added flags for the adaptive analog AGC in audioproc_f. Created with: gclient setdep -r src/third_party/webrtc@cf64a04acdf3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4a7573ec8ab7da1f4c2404187a965ace673b0590 Reviewed-on: https://chromium-review.googlesource.com/1217153Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590080}
-
Victor Costan authored
This CL only handles the files in //remoting. The files in //net were tackled in https://crrev.com/c/1188959. Parallel CLs will tackle other directories. net::IOBuffer is (thread-safe) ref-counted. Asides from improving the ability to reason about instance ownership locally, creating instances via base::MakeRefCounted makes it possible to use 1-based ref-counting in the future (see base/memory/ref_counted.h). This CL is mechanical, to avoid introducing any behavior changes. The difficult cases will be tackled by follow-up CLs. The following transformations were performed. * new IOBufferType(args) => base::MakeRefCounted<IOBufferType>(args) * new IOBufferType => base::MakeRefCounted<IOBufferType>() * scoped_refptr x(base::MakeRefCounted<IOBufferType>(args)) => scoped_refptr x = base::MakeRefCounted<IOBufferType>(args) * scoped_refptr<IOBufferType>(base::MakeRefCounted<IOBufferType>(args)) => base::MakeRefCounted<IOBufferType>(args) * In comments: creates a new IOBufferType => creates an IOBufferType (so it wouldn't trigger future searches for "new BufferType") * Instantiated static members in HttpResponseBodyDrainer, HttpNetworkTransaction, HttpProxyClientSocket, WritersTest, UDPSocketTest, TestDelegate, UDPSocketPerfTest (needed to fix linker errors) * arraysize -> base::size (where needed to pass presubmit checks) * git cl format Change-Id: I4feed626ef76c0da3934748ea063ce317ce2ce86 Reviewed-on: https://chromium-review.googlesource.com/1200571Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590079}
-
liberato@chromium.org authored
This makes D3D11VideoDecoder use the visible rect from the H264 decoder when constructing a VideoFrame. Change-Id: Ic8a3095a86bb9282a6d1fcf06aed1cf6aeef60d7 Reviewed-on: https://chromium-review.googlesource.com/1217354Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#590078}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/77a15654a753..03c80a36415d git log 77a15654a753..03c80a36415d --date=short --no-merges --format='%ad %ae %s' 2018-09-10 benjhayden@chromium.org Add scalar-span for v2spa Created with: gclient setdep -r src/third_party/catapult@03c80a36415d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I10cddb8fe7c7773d73152b86fa15cc760c6f09e5 Reviewed-on: https://chromium-review.googlesource.com/1216869Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590077}
-
Victor Costan authored
This CL only handles the difficult cases in //remoting. The easy cases were tackled by mechanical CLs, such as https://crrev.com/c/1188959 for //net. Parallel CLs will tackle other difficult cases. net::IOBuffer is (thread-safe) ref-counted. Asides from improving the ability to reason about instance ownership locally, creating instances via base::MakeRefCounted makes it possible to use 1-based ref-counting in the future (see base/memory/ref_counted.h). This CL replaces raw IOBuffer pointers with scoped_refptr<net::IOBuffer> in some APIs. Local inspection of the impacted implementations should reveal that no extra reference churn was introduced. Change-Id: I59940c49e6635540a4a42840919ff114b3a1941f Reviewed-on: https://chromium-review.googlesource.com/1215463Reviewed-by:
-
Victor Costan authored
This CL only handles a difficult case in //jingle. The easy cases were tackled by mechanical CLs, such as https://crrev.com/c/1188959 for //net. Parallel CLs will tackle other difficult cases. ability to reason about instance ownership locally, creating instances via base::MakeRefCounted makes it possible to use 1-based ref-counting in the future (see base/memory/ref_counted.h). net: :IOBuffer is (thread-safe) ref-counted. Asides from improving the Change-Id: I06317e9410389b226fbe7818c8d7138d5bb79050 Reviewed-on: https://chromium-review.googlesource.com/1215464Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#590075}
-
Pedro Amaral authored
Bug: 876051 Change-Id: I7826a815732a64d4b728be2f6b8565c5259f974c Reviewed-on: https://chromium-review.googlesource.com/1217585 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#590074}
-
Ojan Vafai authored
This reverts commit 0962c66c. Reason for revert: This test also fails on some mac bots, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15266 Original change's description: > Implement crash report prototype (behind flag) > > This patch implements crash reporting, as detailed in the > reporting spec: https://w3c.github.io/reporting/#crash-report > > Change-Id: I209880150193910a0947608e6b08a6eeea29206c > Reviewed-on: https://chromium-review.googlesource.com/1174965 > Commit-Queue: Paul Meyer <paulmeyer@chromium.org> > Reviewed-by: Nick Carter <nick@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589941} TBR=avi@chromium.org,nick@chromium.org,paulmeyer@chromium.org Change-Id: I52ea9472a94c7c5eaa13e29dcd3569e0db3c8280 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1217513Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#590073}
-
Jani Hautakangas authored
Refactor base/ime components and dependencies for ozone plaform integration to avoid cyclic dependencies. - Groups ui/base/ime common types into their own GN component (ime_types) to break a dependency cycle that ozone ime context integration would cause on ChromeOS. - Groups some of ui/base/ime/linux interfaces into their own GN component (ime_linux) to break a dependency cycle that ozone ime context integration would cause on ChromeOS. - Move chromeos source files under is_chromeos flag to avoid depending them when chromeos is not used, but ime is needed (kudos to msisov@igalia.com). Bug: 791920 Change-Id: I0b1668564dde22c6e2b05ee1323ebbe4a1343475 Reviewed-on: https://chromium-review.googlesource.com/1193871 Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590072}
-
khmel@chromium.org authored
This reverts commit 37385434. (Test flakiness fixed) When app is pinned, icon image is loaded via controller using loader owner by chrome launcher controller. Once new ARC app window appears in the system, it's icon is loaded asynchronously. In this flow, default app icon is applied first and then, once real image is loaded final icon is set. Each update of ARC window icon is reflected on shelf. That means default app icon appear on the shelf for a moment and in most cases this is very noticeable. This CL prevents setting default app in favor of final app icon and default icon is set only as a fallback when final icon could not be loaded. TEST=Manual BUG=882048 BUG=882043 Bug: b:114246197 TBR=xiyuan@chromium.org,jdonnelly@chromium.org,khmel@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic2015afe42b4b3aacd05a307350e643a6967d3e8 Reviewed-on: https://chromium-review.googlesource.com/1216721 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590071}
-
Varun Khaneja authored
Bug: 754341 Change-Id: Ib8dcfcba25ea2f563365fca13f79873499639c52 Reviewed-on: https://chromium-review.googlesource.com/1211979Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#590070}
-
Bailey Berro authored
Currently, we wait until the first batch of shares is returned from host discovery before attempting to Mount a share so that name resolution can be performed. This change switches to using the GatherSharesInNetwork method that takes a HostDiscoveryResponse callback so that the delay is shortened. Bug: chromium:757625 Change-Id: I22cf5fd48bdcc633fa4d7f2f08b1e6f7e10af764 Reviewed-on: https://chromium-review.googlesource.com/1211947 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590069}
-
Weilun Shi authored
Add button should be hidden when there are max number of most visited tiles. Bug: 881091 Change-Id: I40d33e533691885204f1fd813ce077fb060678d9 Reviewed-on: https://chromium-review.googlesource.com/1214180 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#590068}
-
Aiden Benner authored
e.g. public int x = 0; public boolean x = false; - Adds errorprone rule that will detect when fields are initialized to default values (results in larger class sizes and can't be optimized away see https://issuetracker.google.com/issues/37124982) - Refactor current redundant initializations - Fix cases where classes were being generated with redundant initializations TBR=agrieve Bug: 878853 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: Ia76a02ea73a55f2fa66b4ef6461ac985eba574bb Reviewed-on: https://chromium-review.googlesource.com/1209547 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:agrieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590067}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d91f0adca280..11bc3991530d git log d91f0adca280..11bc3991530d --date=short --no-merges --format='%ad %ae %s' 2018-09-10 nodir@google.com [bot_update] add ignore_input_commit parameter Created with: gclient setdep -r src/third_party/depot_tools@11bc3991530d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:882094 TBR=agable@chromium.org Change-Id: I189dbf46abcf77ef9ad2fb1362d82c03777f67a2 Reviewed-on: https://chromium-review.googlesource.com/1216868Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#590066}
-
Luna Lu authored
Design doc: https://docs.google.com/document/d/1yh_-ayeaFV0EjuR51U641zbrPAB0Baqj6UrC9bT9iqQ/edit#heading=h.y7amr11fn0tb This CL implements "intrinsicSize" attribute to SVGImageElement. This attribute has been added to HTMLImageElement and HTMLVideoElement. The value of "intrinsicSize" overrides the intrinsic size: 1. When no width and height is specified, the value of "intrinsicSize" specifies the <svg:image> element's layout size. 2. When one dimension is specified, the value of "intrinsicSize" is used as an aspect ratio to determine the other dimension. 3. If both width and height are specified, "intrinsicSize" has no effect. Bug: 874629 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9023d6cf7a818c983155efc12505f1d6fd18de43 Reviewed-on: https://chromium-review.googlesource.com/1210544Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#590065}
-
Eugene But authored
Experiment results were collected in M69. Bug: 853774 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I44d71ec5a620b8ac5b9673161dbf9172cfc67fdf Reviewed-on: https://chromium-review.googlesource.com/1213268Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590064}
-
Alex Moshchuk authored
Previously isolated origins were stored in a set. This resulted in large overheads when URLs needed to be checked against isolated origins, since the set had to be walked through linearly, running a fairly slow comparison function (IsolatedOriginUtil::DoesOriginMatchIsolatedOrigin()) on each isolated origin, and this lookup turned out to be fairly common. This CL reorganizes the underlying data structure into a map keyed by site URLs. For example, if we add {https://foo.com, https://bar.foo.com, https://www.bar.com} as isolated origins, the map will look like this: https://foo.com -> { https://foo.com, https://bar.foo.com } https://bar.com -> { https://www.bar.com } When checking a URL against isolated origins, we now can just look up the map using the URL's site and then look for the most specific isolated origins as before. The site can be found in O(log n) time, and the corresponding list of origins to search using DoesOriginMatchIsolatedOrigin() changes from O(n) to O(originsPerSite), which is expected to be ~1. Bug: 877653 Change-Id: I41667f94cea7f1f8e5b53fa23443d83cfbb3c0ed Reviewed-on: https://chromium-review.googlesource.com/1208942 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#590063}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/bfe62e18d24f..bbe6b81a6c31 $ git log bfe62e18d..bbe6b81a6 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 dalecurtis Update patches file for new ffmpeg fixes. 2018-09-07 dalecurtis avformat/utils: Don't calculate duration using AV_NOPTS_VALUE for start_time. 2018-08-30 dalecurtis avformat/mov: Error on too large stsd entry counts. 2018-08-22 liberato Fetch upstream and check for upstream commit. Created with: roll-dep src/third_party/ffmpeg BUG=879852, 826648 TBR=tguilbert Change-Id: Ibdec4e7e2ffd3d7d61bdefa71f09814d699bba5b Reviewed-on: https://chromium-review.googlesource.com/1217040Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#590062}
-
Wez authored
Quitting the RunLoop with QuitCurrent*Deprecated() triggers the DCHECK against mixing the deprecated quit APIs with use of QuitClosure. Use the GpuServiceImpl::ExitProcess() helper to quit the process gracefully, instead. Also removes the |is_exiting_| flag in favour of checking whether |exit_callback_| is set, and adds a DCHECK for a non-null |exit_callback| being passed at construction. Bug: 882068 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id8a87e4648fbac3283f41ce2f80cf03a153227ab Reviewed-on: https://chromium-review.googlesource.com/1214750 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#590061}
-
Steve Anton authored
Adds unit tests for the RTCIceTransport Blink bindings that use a mock IceTransportAdapter. These exercise the RTCIceTransport bindings along with the IceTransportProxy and IceTransportHost. Bug: 864871 Change-Id: I2b857979bf201f67f9db631b6f35a3e8bebef547 Reviewed-on: https://chromium-review.googlesource.com/1206173 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#590060}
-
Xida Chen authored
In chrome VR or virtual keyboard case, we can get GestureScrollBegin without GestureTapDown, and that |scrolling_touch_action_| may have no value. In this case, we set it to Auto to prevent crash. This was done in a previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1195649 However, there was a small mistake in the previous CL. That is, the |scrolling_touch_action_| could have been set when the browser receives the ACK for the touch start from the main thread. In this case, we should not set it to Auto. Bug: 880701 Change-Id: I250bb7a09840f16665cfcf5826236cad99b533c5 Reviewed-on: https://chromium-review.googlesource.com/1213502Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590059}
-
Tommy Steimel authored
This CL adds an isConnected check in the overlay play button's click positioning check to prevent a crash when trying to access the layout data after it's been removed. Bug: 870490, 881772 Change-Id: Ic005ae9d3acc2945ed67645bfe98a237c89e38f0 Reviewed-on: https://chromium-review.googlesource.com/1217065Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#590058}
-
Yuwei Huang authored
This CL fixes a bug that crashes the latest M70 Android client when it lauches. URLRequestContextGetter's constructor creates a ProxyChangeListener, which requires an Android looper on the current thread. The C++ network thread doesn't create any looper, so it must be created on the UI thread which has alooper. Note that this class is used (and required to be used) on the network thread afterwards. Bug: 882072 Change-Id: I0cf610d3dccf087f040b49995d3022a1ba4de0e9 Reviewed-on: https://chromium-review.googlesource.com/1217363Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#590057}
-
Eugene But authored
Removed references to unsupported iOS 9. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I1cea95523f85ee82b614a959eab5fc5c7bc01ea0 Reviewed-on: https://chromium-review.googlesource.com/1217353Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#590056}
-
Mike West authored
Bug: 882107 Change-Id: I380e01b2663a926c9e5eb7d4ac9f3e433dc869e9 Reviewed-on: https://chromium-review.googlesource.com/1213082Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#590055}
-
W. James MacLean authored
This issue may be fixed by recent changes, but even if it isn't, it would be nice to have some fresh data on it. Bug: 823578 Change-Id: I2568fad71686c658fbe9e26ffe1dfdcb09ff3891 Reviewed-on: https://chromium-review.googlesource.com/1217402Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#590054}
-
Jeffrey Cohen authored
Instead of COMPANY_NAME returning an empty string when disabled, this CL enable/disables the filling of COMPANY_NAME within the fill logic. Bug: 864612 Change-Id: I9437e45a056d110d4e3c36ac92f8ac01338b8344 Reviewed-on: https://chromium-review.googlesource.com/1205106 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#590053}
-
Tien-Ren Chen authored
The PaintChunkToCcLayer algorithm was originally designed for SPv2 compositor, and it was expected the layerization algorithm should never assign a chunk to a excessively clipped layer, thus the DCHECK. Later this algorithm was adopted in SPv175 to be used with the SPv1 compositor. There is a known bug that in certain corner case we can fail to escape clip, and the bug is difficult to fix in the legacy architecture. The DCHECK is expected to be a "soft" one that we have a fail-safe path to recover in a sane way. This CL converts the DCHECK to a DLOG in SPv1 mode, and it should still trap in SPv2 mode. In addition, it reverts a workaround to a nullptr bug in the fail-safe path, and add a test for the fail-safe. BUG=881788,853357 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4606acf4885f3344bb45a901bb2e8e46dbcda49a Reviewed-on: https://chromium-review.googlesource.com/1213952Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#590052}
-
