GitLab

We shouldn't crash when the response headers map is null.

BUG=394173

Review URL: https://codereview.chromium.org/392113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285517 0039d316-1c4b-4281-b951-d872f2087c98

This CL allows apps to customize their appearance in the per-app window list
in the Ash shelf by changing their favicon. Each app window will use the 
favicon if it exists, falling back to the current behavior of a downscaled
app icon if it doesn't.

BUG=390907

Review URL: https://codereview.chromium.org/411543009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285516 0039d316-1c4b-4281-b951-d872f2087c98

Exclude USE_AURA specific code with preprocessor blocks.
Related to https://codereview.chromium.org/413303003/
(both are needed for a clean build on ToT@285384)

BUG=395507
TEST=NONE
R=sky@chromium.org

Review URL: https://codereview.chromium.org/418223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285515 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a per-view flex property to BoxLayout. The flex property functions
similarly to the CSS flexbox concept of flex, using the child view's preferred
size as the flex basis and then adding or removing space within each flexed
so that all views fit within the parent.

This CL also removes MAIN_AXIS_ALIGNMENT_FILL as it is superceded by
SetDefaultFlex().

BUG=386475

Review URL: https://codereview.chromium.org/360213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285514 0039d316-1c4b-4281-b951-d872f2087c98

This software package will need to be uploaded to the test hardware.
Python can easily run code out of a zip file. The package hash is saved
to verify integrity and as a versioning mechanism to allow tests to
ensure that they are running against a device with the expected software
version.

BUG=396682
R=rockot@chromium.org,rpaquay@chromium.org,kalman@chromium.org

Review URL: https://codereview.chromium.org/414833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285513 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395787

Review URL: https://codereview.chromium.org/399893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285512 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397426
TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/414223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285510 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285509 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
this is still flaking. more info in bug

TBR=palmer
NOTRY=true

Original issue's description:
> Reenable UpdateDynamicPKPMaxAge0 test.
> 
> BUG=375538
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281863

Review URL: https://codereview.chromium.org/412353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285508 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13507: (noelallen) Reapply patch which was reverted due to conflict.
r13508: (dschuff) PNaCl Driver: do not generate temp file names beyond Windows'
MAX_PATH limit
r13509: (jvoung) Add a flag to pnacl-finalize that allows users to keep
function names.
r13510: (dschuff) Disable flaky sandboxed translator tests on mac
r13511: (dschuff) Update revision for PNaCl r13466->r13509
r13512: (ncbray) Fix untrusted.gypi and build_nexe.py
r13513: (noelallen) Cleanup bionic build script.
r13514: (dyen) Added initial pass of nacl_irt_code_data_alloc.
r13515: (sbc) Use custom exception class for errors in package_version.
r13516: (hidehiko) Non-SFI mode: SCONS_NONSFI_TC clean up.
r13517: (hidehiko) Non-SFI Mode: Refactoring. Provide non-SFI version of
nacl_irt_query_core.
r13518: (binji) Revert "Non-SFI mode: SCONS_NONSFI_TC clean up."
r13519: (bradnelson) Make the trybots fail early if 'git cl try' is mistakenly
used.
r13520: (bradnelson) Make build_nexe.py rebuild when script itself has changed.
r13521: (noelallen) Updates GN dep, and cleans up some toolchain prep
definitions to make it easier to debug what's going on.
r13523: (teravest) Add embedder interface for fatal log messages.
r13524: (bradnelson) Passing --config-name to build_nexe.py for all arches.
r13525: (teravest) Create a sel_ldr_launcher_base target.
r13526: (teravest) Revert "Add embedder interface for fatal log messages."

R=ncbray@chromium.org
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build

CC: native-client-reviews@googlegroups.com, binji@chromium.org, bradnelson@google.com, dschuff@chromium.org, dyen@chromium.org, hidehiko@chromium.org, jvoung@google.com, ncbray@chromium.org, noelallen@google.com, sbc@chromium.org, teravest@chromium.org

Review URL: https://codereview.chromium.org/418213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285507 0039d316-1c4b-4281-b951-d872f2087c98

There's an issue with adding some of the tilings, since the scales
collide (or are not valid otherwise), which is causing some DCHECKs
to be triggered.

This just shuffles the scales, as well as make the layer smaller so
that we don't create massive amounts of textures (which is pretty slow
even on my desktop).

R=reveman, jbedley

Review URL: https://codereview.chromium.org/413243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285506 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285505 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/57493ba62a7ec6a6038e64afa891b3c98a7cc15d..0925a5784c8424e3f9d75dbf4612ada12dc37131

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/418183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285504 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/411253011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285503 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw@chromium.org
BUG=393046,354261

Review URL: https://codereview.chromium.org/412423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285502 0039d316-1c4b-4281-b951-d872f2087c98

* Correct spelling in several places.
* Add handling of the error during onMountCompleted event so that the
  volume shows up in UI and users can format it.

BUG=396531

Review URL: https://codereview.chromium.org/409353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285501 0039d316-1c4b-4281-b951-d872f2087c98

Attempt to fix the flakiness by making sure the server handler doesn't exit
before the client closes.

BUG=389084
R=jgraettinger,yhirano

Review URL: https://codereview.chromium.org/410383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285500 0039d316-1c4b-4281-b951-d872f2087c98

This patch puts in a heuristic that earlies out from analysis when
we have more than one draw op. The intent here is that in most cases,
if we see more than one draw operation, then analysis is likely not
to be solid.

It also removes HasText from analysis canvas, since the only
remaining use for this was a previous early out heuristic.

BUG=397198
R=enne

Review URL: https://codereview.chromium.org/418093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285499 0039d316-1c4b-4281-b951-d872f2087c98

Upstream added SSL_get0_certificate_types while we added
SSL_get_client_certificate_types in parallel. Switch to upstream's API.

BUG=388000

Review URL: https://codereview.chromium.org/415853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285498 0039d316-1c4b-4281-b951-d872f2087c98

Sync with one in the LayoutTests directory to include the code to
wait for a close frame from the client.

BUG=396399
R=jgraettinger,ricea

Review URL: https://codereview.chromium.org/415953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285497 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://codereview.chromium.org/415423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285496 0039d316-1c4b-4281-b951-d872f2087c98

Different orderings of notifications could previously trip up the finder.
They don't now.

BUG=397229
R=shess@chromium.org

Review URL: https://codereview.chromium.org/418103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285495 0039d316-1c4b-4281-b951-d872f2087c98

Based on the NSS implementation and loosely on the original OpenSSL code at
https://chromium.googlesource.com/chromiumos/platform/shill/+/master/shims/crypto_util.cc

BUG=393023

Review URL: https://codereview.chromium.org/396463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285494 0039d316-1c4b-4281-b951-d872f2087c98

The drive status is shown in Files.app now.
We can remove the status from the ash try.

BUG=379979
TEST=None

Review URL: https://codereview.chromium.org/410333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285493 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390624
TEST=Load the sample manifest from the bug, comment #9. It should fail to load.

Review URL: https://codereview.chromium.org/416263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396398

Review URL: https://codereview.chromium.org/411793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285491 0039d316-1c4b-4281-b951-d872f2087c98

* Breaks major steps out into functions
* Adds additional tests
* Adds support for command line flags defined in benchmarks
* Calls the PageTest RunPage directly, rather than kinda sorta reimplementing parts ourselves
* Fixes running benchmarks with record_wpr.py (crbug.com/378064)
* Page sets are referenced via class name on the command line, rather than by filename.

Other minor changes:
* Output will be different for failed pages at the end, using the default results PrintSummary() rather than a separate implementation (in this case GTestTestResults).

BUG=378064,367292

Review URL: https://codereview.chromium.org/374793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285490 0039d316-1c4b-4281-b951-d872f2087c98

Is also in chrome_browser_extensions_chromeos_sources.

BUG=354261

Review URL: https://codereview.chromium.org/420623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285489 0039d316-1c4b-4281-b951-d872f2087c98

We should allow, the read back while view is active and hold
the frame till, readback gets processed. Dont process a
readback request when the view is hidden.

BUG=376769

Review URL: https://codereview.chromium.org/418853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285488 0039d316-1c4b-4281-b951-d872f2087c98

This prevents an empty Voice section from being shown.

BUG=395509

Review URL: https://codereview.chromium.org/418693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285487 0039d316-1c4b-4281-b951-d872f2087c98

This changes the logic in the AVFoundation support check to always respect
the force-qtkit flag.

Note: This CL was only tested on OS X 10.9, and should be verified on 10.6.

BUG=396767,396764

Review URL: https://codereview.chromium.org/411983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285486 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285485 0039d316-1c4b-4281-b951-d872f2087c98

See https://webrtc-codereview.appspot.com/13059004/ for the relevant change (and revision number).

BUG=397313
NOTRY=true

Review URL: https://codereview.chromium.org/415363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334889

Review URL: https://codereview.chromium.org/398043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285483 0039d316-1c4b-4281-b951-d872f2087c98

The extensions module should not be listening to Chrome notifications.
Move the observation to ChromeProcessManagerDelegate.

BUG=396083
TEST=browser_tests ProcessManager* and unit_tests ProcessManager*

Review URL: https://codereview.chromium.org/415933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285482 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349655

TEST=Find a windows xp sp2 machine, install chrome, go to twitter.com, verify the message looks right

Review URL: https://codereview.chromium.org/336273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285481 0039d316-1c4b-4281-b951-d872f2087c98

Tests failed on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32148

> Log the certificate subjects from the server certificate sent via QUIC.
> 
> Review URL: https://codereview.chromium.org/418723002

TBR=rch@chromium.org

Review URL: https://codereview.chromium.org/415333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285480 0039d316-1c4b-4281-b951-d872f2087c98

In a lot of filters in media code, Stop() has been folded into the dtor.
This model doesn't apply directly to DataSource because DataSource::Stop()
is called by the FFmpegDemuxer, but the DataSource is owned by
WebMediaPlayerImpl.

TBR=gbillock@chromium.org
BUG=349211
TEST=All existing tests pass.

Review URL: https://codereview.chromium.org/413243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285479 0039d316-1c4b-4281-b951-d872f2087c98

This should help Linux users trigger this unintentionally less often.

BUG=397359
TEST=On Linux, you should be able to drag your mouse at least 130 px away from the scrollbar before it snaps back.

Review URL: https://codereview.chromium.org/417053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285478 0039d316-1c4b-4281-b951-d872f2087c98