- 13 May, 2019 40 commits
-
-
Sebastien Marchand authored
ps1 is a simple file move and rename. ps2 updates the content of the file (to rename the class etc). ps3-4: Rename the file once more (to disk_site_data_store) and update the name of the functions to use Store instead of Database. ps6: The name is not site_data_store. Bug: 961336 Change-Id: I9d94973e980f7a27fcb508237f8905fb7300cf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602599 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#659090}
-
Jacques Newman authored
* Introduces the concept of "in the tree" vs "ignored" in Blink without changing the actual behavior. No ignored nodes are sent to the browser accessibility tree. * Adds new function IsIgnoredPassThrough, for use when an object is ignored, but should be passed through to the browser-side anyways. This will be used to allow different types of ignored nodes to pass through, instead of all at once. * Refactors browser-side code to walk only the unignored tree. Bug:651614 Change-Id: Idbd85949a8505f8a03a08e3e002bb893619d6757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535171 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#659089}
-
Xiyuan Xia authored
Bug: 958212 Change-Id: Ia09c8202887642a7eed6aa4d253ab77fee29f4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606680 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659088}
-
Ben Kelly authored
The LegacyCacheStorageCache must be kept alive as long as there are any outstanding disk_cache Entry objects associated with it. This is for two reasons: 1) If a partial write has occurred, then removing the cache will cause any outstanding runnables to be discarded destroying the ScopedEntryPtr. The ScopedEntryPtr will cleanly close the entry causing it to remain in a truncated state. 2) A second LegacyCacheStorageCache object could be created immedately after and open a new backend that stomps on our existing Entry objects. This CL solves the problem by making LegacyCacheStorageCache hold a handle reference to itself whenever its performing a public operation. This will in turn cause the owning LegacyCacheStorage to keep the cache object alive. Bug: 961752 Change-Id: Icf333341d51c4acd0688626977690d73408c43ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606200 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659087}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dab21c6a91a6..2ebf5239782b git log dab21c6a91a6..2ebf5239782b --date=short --no-merges --format='%ad %ae %s' 2019-05-13 ilnik@webrtc.org Reland "Copy video frames metadata between encoded and plain frames in one place" Created with: gclient setdep -r src/third_party/webrtc@2ebf5239782b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3199cef668c550feaa557c827dc1452dd0d7330a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610250Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659086}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac5a8cf07ac9..02f2aec13451 Created with: gclient setdep -r src-internal@02f2aec13451 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: Ib15a4b88b5fdf01622bae598d5bcfac5afa5580a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610248Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659085}
-
Katie D authored
This keeps users from accidentally disabling automatic clicks and therefore locking themselves out of their device by making it so that they need a physical click to re-enable the feature. Dialog is shown when disabling from the accessibility menu in the tray and from the settings WebUI page. Bug: 960526 Change-Id: I681c8bfc1b668e6b290b33d889355b2a6f43500a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601468Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#659084}
-
Zentaro Kavanagh authored
- Forward declare where possible - Remove unused includes - Reorder includes BUG=None TEST=Compiles Change-Id: If353aa7666ffe85255a69102e0ecbcbc6793ffb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606635Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#659083}
-
rajendrant authored
It requires some delay for the XHR request to be populated in PLM. The total pagesize can also be 3-4 KB since favicon.ico could get included after the delay, so GreaterEqual 3KB was used. Bug: 961967 Change-Id: Ic23f93e6d276288a8be71684200b705b982e7c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607621Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#659082}
-
Julien Isorce authored
Useful to specify the color space of the captured data when passing it to the VideoCaptureDevice client. Previsouly it was assuming sRGB for RGB-like formats which resulted in wrong colors rendering. Bug: 945468, 959901, 959919, 959962, 959953, 945468, 959988, 959992 Change-Id: Ic5ef4f0050618dfe3d2d35fac880d710fa122c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590619 Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659081}
-
Edin Kadric authored
Screenshot attached in bug. Bug: 962332 Change-Id: I3fb769d29f5749137409364a429b4e5607dd57a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608803Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b3f6654a5402..9b86955c65aa git log b3f6654a5402..9b86955c65aa --date=short --no-merges --format='%ad %ae %s' 2019-05-13 herb@google.com Add thread safety annotations for SkMutex 2019-05-13 robertphillips@google.com Alter createTestingOnlyBackendTexture methods 2019-05-13 csmartdalton@google.com ccpr: Clip path octo bounds by the scissor 2019-05-13 bsalomon@google.com Add color space and type conversion support to asyncReadPixels Created with: gclient setdep -r src/third_party/skia@9b86955c65aa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I8e26af88b17e4ebb119beae96804450b3d689853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610290Reviewed-by:
-
Michael Thiessen authored
We need all Activities running in NoTouch mode to use the UI coordinator to support dialog actions, etc. So this moves ownership of the TouchlessUiCoordinator into ChromeActivity, and restricts the touchless URL bar and tooltips to NoTouchActivity. #issue 962059, presubmit is broken. NOPRESUBMIT=true Bug: 961734 Change-Id: Ib8fb701c4bb981726428a7f81a55fc9fc15bccf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606570Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#659078}
-
David Dorwin authored
https://crrev.com/c/1387151 added a test to webvr/ that checks for "xr". The WebVR API is obsolete, and only "vr" was used with it. This CL copies the test for "xr" to the webxr/ tests and changes the webvr/ test to check for "vr". Change-Id: I0481afc1ad0c1445bf744c1b99307e482f2315af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600152Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659077}
-
Takuto Ikuta authored
This CL reduced total include for ip_address_space.mojom-blink-forward.h from 0.72MB to 0.22MB. Bug: 862064 Change-Id: I2371e1513a194ecd0275590522522f30983c0527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609737 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#659076}
-
Takuto Ikuta authored
This CL reduced total include for ip_address_space.mojom-blink-forward.h from 0.72MB to 0.66MB. Bug: 862064 Change-Id: I2f7278db9f06158d63a1345cf503d6cf5819f484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609617 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Toni Barzic authored
The test updates shutdown policy, and waits for the login shelf UI to get updated from the state before the policy was changed. It then verifies that the shutdown/restart button visibility has been updated. This is racy if login shelf state can change for any reason different than shutdown policy value - which started happening since the test was updated to properly set-up enrollment, OOBE complete state. The login UI lands on login screen with GAIA dialog, instead of welcome screen, and GAIA UI is trying to update guest login button visibility. This fixes the test to wait for the shutdown button visibility to change. It observes login shelf UI updates until it detects that the shutdown button has the desired visibility state. Does the smae for lock test, even though that one does not seem flaky for now. Change-Id: I4b61c17c2ef750b9850bbbe68ea406b15197ec81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608525Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#659074}
-
Yeol Park authored
In order to better convey property object ownership, changed CreateSecondaryUiButton() to return std::unique_ptr. Bug: 948287 Change-Id: I4a496050e03705ccfee063b852ef35f5c61761e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598902Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#659073}
-
Toni Barzic authored
GetDisplayNearestWindow returns a temp object, so we should not use a reference to it's return value. Change-Id: Ia81b1d1a74e7e3513bf29504d8e824e28f2b116b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608523 Auto-Submit: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Brian White authored
b/131237867 Change-Id: Iaeb41b0256ae366243f2ab0ab653ef6bb6566bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585939 Auto-Submit: Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#659071}
-
Dominic Mazzoni authored
The Get Image Descriptions from Google feature provides a computer-generated description for unlabeled images on the web. Importantly, when there's an unlabeled link that contains a single image, it's supposed to apply the same automatic description to the link, too - because some screen readers only pay attention to the accessible name of the link. There was a bug when the image was absolute-positioned - that caused the link to have zero width and height, which made it ineligible for annotation. The fix is to only consider the size of the image when deciding whether a node is eligible for annotation, rather than the size of the link. Bug: 962370 Change-Id: I1a8d845666d2a508e17466da75bce0c88cd1d3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608922 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#659070}
-
Tarun Bansal authored
Record WiFi signal strength as an UMA metric. The next CL will do the plumbing to use it for adjusting the network quality. Skipping presubmit because of crbug 962059. NOPRESUBMIT=true Change-Id: I439cc6561fd2f368537cd567dcf7d3551449073d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551953 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#659069}
-
Oleg Davydov authored
Changed it to IDS_POLICY_SOURCE_DEVICE_LOCAL_ACCOUNT_OVERRIDE as overrides exist both in public sessions and kiosk modes. This is a follow up of CL 1602727, where we've changed corresponding option of PolicySource enum. Change-Id: I7ea0d422025fd182a8497b62dc7df13588cdbd6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604271 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 956858 Change-Id: Id0b36488deeede4b6114f1e2cbe3df49a5fd6b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605385Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#659067}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a19080a956b5..a7a375565cdb git log a19080a956b5..a7a375565cdb --date=short --no-merges --format='%ad %ae %s' 2019-05-13 chrisforbes@google.com Wire up NoPerspective to interpolation Created with: gclient setdep -r src/third_party/swiftshader@a7a375565cdb The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I3ca828e2d79d3ee9864a2aa45a1e89d98bf8e5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610282Reviewed-by:
-
Dan Harrington authored
And prevent it from being downloaded later. Note that I manually tested that this does work. Change-Id: I3b445f1a5fe8fa675ac9c7addc96b29eb8da12ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536606 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#659065}
-
Xiyuan Xia authored
- Get sign-in screen and user PrefService from SessionControllerClient instead of mojom::PrefConnector. - Add a TestPrefServiceProvider to create and own various PrefServices to outlive TestSessionControllerClient; - Move Shell:: RegisterSignin/UserProfilePrefs to ash_prefs.h in public/cpp and call them from browser prefs to register as part of the browser; - Remove RegisterForeignPref for user prefs in ash/* code since they are now part of the browser user prefs; Bug: 958212 Change-Id: Ic4d9f951e5fd2f255c5274906115fc4aeb2dcc41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603325 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Robbie Gibson authored
After talking to the designers, they want this image on the leading edge of the popup instead of the trailing edge. Bug: 962436 Change-Id: Ib9a041360c4c7ffc1637700aa7cb471a8c8084cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609777 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#659063}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0379d8cfeac1..dab21c6a91a6 git log 0379d8cfeac1..dab21c6a91a6 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 srte@webrtc.org Fix for crash in frame matcher on short runs. 2019-05-13 peah@webrtc.org AEC3: Remove unused code Created with: gclient setdep -r src/third_party/webrtc@dab21c6a91a6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1ce03aaa95c714323cc33e619586c3180d59b076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610284Reviewed-by:
-
smut authored
To ensure it gets the right number of cores when migrated to builderless. A no-op now, since builder:android-marshmallow-arm64-rel currently implies cores:16. Bug: 956776 Change-Id: I785938a91a7cf493ece0b0579cc9d8f106f673ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606637 Auto-Submit: smut <smut@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#659061}
-
Sidney San Martín authored
Change-Id: I9ab020f86ff2781a6651ac82aae60c59b497e6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607440 Auto-Submit: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#659060}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5864997e8422..ac5a8cf07ac9 Created with: gclient setdep -r src-internal@ac5a8cf07ac9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: Ic43fa9a8a3dc8f174c5a45bea035b500c0cdc4c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610277Reviewed-by:
-
Caleb Raitto authored
See crrev.com/c/1590404 for context -- the goal is to fix leak checking in ASAN trybots, which are used to run LSAN. Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. Bug: 949811 Change-Id: I76399f12142dc09ee23f40498b20d629e7500c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599880Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659058}
-
Roman Sorokin authored
Follow-up to CL:1564085 Bug: 934224 Change-Id: I8291ed461528d6f31ee5167289740296fea29cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583779Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659057}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e247b5b70db9..f1e3609c24ce git log e247b5b70db9..f1e3609c24ce --date=short --no-merges --format='%ad %ae %s' 2019-05-13 thakis@chromium.org angle: Stop setting secondary_source. Created with: gclient setdep -r src/third_party/angle@f1e3609c24ce The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947060 TBR=syoussefi@google.com Change-Id: Iab188e181f9879f748410478711d70ac2a096026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610153Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/617d801ff762..b3f6654a5402 git log 617d801ff762..b3f6654a5402 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 egdaniel@google.com Remove mutex in GrVkSemaphore Created with: gclient setdep -r src/third_party/skia@b3f6654a5402 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Ia86f40c798d47a8f46b7d4401e4c061144558940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610155Reviewed-by:
-
Richard Knoll authored
When opening the inline reply text view by clicking on the "Reply" button, we get a LocatedEvent to start the ripple effect from. When this is triggered via key press, after focusing the button, the event is not a LocatedEvent and we hit a CHECK. This fix shows the default ripple instead if we activate via keyboard. Bug: 961233 Change-Id: I1f6488f9ce240b9c2cec07ff7342faa75781635a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602507Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#659054}
-
Sylvain Defresne authored
Change the API to receive a base::Value instead of the deprecated class base::DictionaryValue (the implementation already check the type of the passed value so does not assume base::Dictionary type). Change the API to receive the base::Value by reference instead of pointer as there is only one caller and it already check that the pointer is non-null before calling NTPCatalog::create. Use the base::Value::Find{String,List}Key methods instead of the base::FindKeyOfType method as it reduce the complexity of the implementation. Bug: 646113 Change-Id: Icc3a484619786d5afcf0733ef01c07904635d481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609780 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Justin DeWitt <dewittj@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#659053}
-
Richard Townsend authored
This reverts commit 82b6a7c1. Reason for revert: Breaks the build for Windows on Arm. Original change's description: > Sort Win SDK versions by version sorting rules > > This should have no practical effect on current data but version > numbers need to be sorted so that 1.12 is higher than 1.9 and > the current code didn't do that. > > Change-Id: Ie993d2c103b6f16453c8b03336484c3b05a0097b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605980 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Daniel Bratell <bratell@opera.com> > Cr-Commit-Position: refs/heads/master@{#659016} TBR=bratell@opera.com,brucedawson@chromium.org Change-Id: I126df32184965a97fd3397db61c1ecde1c2681e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609787 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#659052}
-
Randy Rossi authored
Eliminating more duplicate chromecast code by moving automation_internal_custom_bindings.* and automation_ax_tree_wrapper.* into /extensions/renderer Patch Set 1 is baseline for moved/deleted files Bug: 837773 Test: Chrome official build + samus ChromeOS build, ran ChromeVox Change-Id: I0ea12a800528cfc9c22ad1356765a330b9622e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593792Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659051}
-
