- 28 Jun, 2019 40 commits
-
-
John Emau authored
By disabling the following rules we can expect tests to run ~4 seconds faster. Tested with https://crrev.com/c/1635874. Disabled slow rules: - color-contrast - image-redundant-alt Disabled rules with bugs: - aria-required-children, see: https://github.com/dequelabs/axe-core/issues/1444 Disabled low value rules: - meta-refresh - blink - audio-caption - object-alt - video-caption - video-description - radiogroup - marquee - html-has-lang - html-lang-valid - meta-viewport-large - meta-viewport - valid-lang Any test may override this list to re-enable rules on specific UI. Bug: 963183 Change-Id: I9094360c73c45168df4ac99aea0d659103950eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638125 Commit-Queue: John Emau <johnemau@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#673389}
-
Sky Malice authored
Bug: 976829 Change-Id: If287af7835e5d17fc0e9f16bbc4f99a104e5f36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681401 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#673388}
-
Cliff Smolinsky authored
This change fixes multiple accessibilty issues with the certificate viewer dialog, primarily with regards to screenreader support: - The "Field Value" is never read in any way. This change makes it a tab stop so that it can be read that way. It also adds aria-live so that when the selected certificate field changes the updated field value is read as well. - The individual <tab>s in a <tabs> section are not individual tab stops which makes it more difficult to understand what happens with a screen reader. This also means that nothing is read when the selection changes. This change makes the individual tabs tab stops, ensures the tab is focused when it becomes selected, and sets the aria-selected property to ensure selection state is read properly. - The three different fields of information on the details tab (two trees and the field value) were not labeled appropriately so while the content was read it wasn't clear what the information represented. This change adds proper labeling. - When an item in a tree was read, its level in the tree was always off- by-one. This change fixes that by properly labeling the root of the tree as a tree instead of a group. - The gray color used for information text on the general tab didn't meet contrast requirements so this change make the text a little darker. - Additional changes to add appropriate role and aria-* properties to various elements for proper identification. Bug: 971843 Change-Id: I677a01fa785900c66939d3b5263c6e5914fc8482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651513Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#673387}
-
Dominik Röttsches authored
Since font scanning is now an asynchronous, BEST_EFFORT priority task, we should trigger it at startup so it may already be ready when a renderer requests it. Previously, it was a synchronous task, triggered by when a renderer requested the lookup table for the first time. Triggering it at startup matches the approach we take on Windows 7 and 8. Bug: 973394 Change-Id: I2e890058c538ed157217e98d1f4a0bdba639a602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681760Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#673386}
-
Eugene But authored
On iOS 13 "Always Translate French" item is not visible due to a real bug in the options menu. This CL relaxes matching requirement for iOS 13 to make the test pass. The real fix will be landed separately and this workaround will be removed. Bug: 979079 Change-Id: Icfbd6a39f1ca7ff93fdc7dbad59414004232503b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679637Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#673385}
-
Sylvain Defresne authored
Since AccessTokenCallback is only run once, document this by changing the type to base::OnceCallback (since the type base::Callback is deprecated). Bug: 714018 Change-Id: Ic276e1fbd14400320eb1bbc670f5b39130c9987e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681584 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#673384}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I8b3065a4ad2d482f59dbea83c7828df19c31a264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660396 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#673383}
-
Andrey Kosyakov authored
Use Fetch domain instead. Change-Id: I4f85f0f909def198cffe9cc47f8dca9f3d173db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678387Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#673382}
-
Dave Tapuska authored
The lifecycle state is currently communicated back to the DocumentResource coordinator. The instantiation of that class is tied to the browser's resource coordinator instance. So the browser has no notion of frame being frozen at the content level. This change adds such communication. The source of freezing comes from two sources, the renderer and the browser. The browser may also request a page to be frozen however it may not take effect until a later time like the load event firing. BUG=957597 Change-Id: I64bd263643edd8afadecb5ab063008a238c2042c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676233Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#673381}
-
Bailey Berro authored
This change switches [add|edit|reconfigure]CupsPrinter to resolving a promise when successful and rejecting a promise on failure. Additionally, errors are shown inline rather than on the parent page. Bug: Change-Id: Ia9dc5cf609425d73a4d2f8c7bacfb9f7e635fd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674405Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#673380}
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit b7a9a779 ("Notification scheduler: Add two new service APIs"): ../../chrome/browser/notifications/scheduler/internal/scheduler_utils.cc:75:18: error: no matching function for call to 'lower_bound' auto right = lower_bound(impressions.rbegin(), impressions.rend(), ^~~~~~~~~~~ ../../../../../../usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_algobase.h:984:5: note: candidate function template not viable: requires 3 arguments, but 4 were provided lower_bound(_ForwardIterator __first, _ForwardIterator __last, ^ ../../chrome/browser/notifications/scheduler/internal/scheduler_utils.cc:80:17: error: use of undeclared identifier 'upper_bound' auto left = upper_bound(impressions.rbegin(), impressions.rend(), ^ Bug: 957519 Change-Id: Id73ae91a738237ed9d3940f424e4f9d60332a862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681765 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#673379}
-
Natalie Chouinard authored
The Preference activity's onOptionsItemSelected override currently forwards these method calls to the corresponding preference fragment first for Framework PreferenceFragments. This CL replicates this behavior for preference screens that have been migrated to the Support Library PreferenceFragmentCompat. Bug: 978431 Change-Id: Ib0afd9e6987f586a8caf58cfb18a46cef49717c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679379Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#673378}
-
Natalie Chouinard authored
The Tracing category preferences were incorrectly styled with excess padding on some Android versions. This CL fixes that issue by picking up the PreferenceManager's styling for programatically created preferences. Bug: 979127 Change-Id: Iab3bc8f9958946aed85861d12e27d0c20dac0630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680976Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#673377}
-
chrome://password-manager-internalsDominic Battre authored
This removes some old code that is not necessary anymore. Bug: 599454 Change-Id: Ia7e95342cb4913a4938606e875f0773c3a651ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681708 Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#673376}
-
Minggang Wang authored
History: ======== * Initial commit : https://chromium-review.googlesource.com/1100830 * Revert : https://chromium-review.googlesource.com/1129659 * Take over : https://chromium-review.googlesource.com/1172290 * Reland (this) : https://chromium-review.googlesource.com/1587249 Cause of revert: Several flaky tests became much more flaky. Fix done in between the revert and the reland: * https://chromium-review.googlesource.com/1133261 * https://chromium-review.googlesource.com/1133170 * https://chromium-review.googlesource.com/1135003 * https://chromium-review.googlesource.com/1185094 * https://chromium-review.googlesource.com/1252141 * https://chromium-review.googlesource.com/1261520 Another change made in this reland CL to eliminate the previous flaky tests is to bind the mojo::URLLoaderClient interface before calling URLLoaderClient::OnStartLoadingResponseBody in NavigationBodyLoader. Because when NavigationImmediateResponse is enabled, reading the data from data pipe starts at once which will postpone the method calls from the remote side if it hasn't been bound. In addition, support for the Network service has been added. Original description: ===================== When a navigation occurs, the mojo::URLLoaderClient interface is first bound to the content::NavigationURLLoaderImpl in the browser process. When the browser knows in which renderer process the navigation will commit, the interface is bound to the content::URLLoaderClientImpl in the renderer process to continue the navigation. The switching from one to another happens when mojo::URLLoaderClient::OnReceiveResponse() is called. This is described here: https://goo.gl/Rrrc7n After the mojo::URLLoaderClient interface is unbound in the browser process and bound again in the renderer process, it takes some amount of time to receive URLLoader::OnStartLoadingResponseBody(). It may be worth sending the data pipe with RenderFrameHostImpl::CommitNavigation() and give it to the renderer process immediatly instead of waiting for it. It would allow the Renderer process to get the main resource's data earlier, especially when the renderer process is busy. Note: It doesn't look like there are any strong reasons to make URLLoaderClient::OnReceiveResponse(response_head) and URLLoaderClient::OnStartLoadingResponseBody(response_body) separate messages, maybe at some point, they could be merged into: URLLoaderClient::OnReceiveResponse(response_head, response_body) This CL makes the switch to happen in URLLoaderClient::OnStartLoadingResponseBody(). The data pipe is transmitted in CommitNavigation(). This is enabled/disabled using the NavigationImmediateResponse experiment The goal is to look for performance improvement or regressions on Canary. BUG=831155 Change-Id: I179e09dbc19c76796bba5bcfef92866fd4b23dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587249 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#673375}
-
Rakesh Soma authored
Bug: 976406 Change-Id: I27a9d0fc59cdb32279e431007c28c6bf38f3f307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677769 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#673374}
-
Becca Hughes authored
In some cases we do not get a size for favicons. In that case we should assume they are the default size so we can use them. BUG=979232 Change-Id: I2c09d826cdde436d4c3273f5f371c2aa2943c189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680611Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#673373}
-
Sean Gilhuly authored
The test compositing/reflections/reflection-on-composited.html is consistently failing on the Linux FYI SkiaRenderer Vulkan bot, so disable it. TBR=rjkroege@chromium.org Change-Id: I02e9ad769f113557ddf1d2ce3e05b04a420e50c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681930Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#673372}
-
Lucas Tenório authored
This change is just removing the interface and any whitelist and BUILD dependencies to it. Most of the code related to this feature has already been deleted, so this is mostly a cleanup. Bug: 977566 Change-Id: I597d628090920f07f0f6647b4c979ec79d78e7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679014Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#673371}
-
Xianzhu Wang authored
This reverts commit ea5c2a2c. Reason for revert: Checking the parent transform to check if a fix-pos element is contained by LayoutView is not reliable. Original change's description: > Fix TransformNode::IsAffectedByOuterViewportBoundsDelta() > > Don't set the flag in the following cases: > 1. The fixed element is contained by an ancestor below the LayoutView; > 2. The fixed element is not in the main frame. > > Bug: 978774 > Change-Id: I430dc968c0d016ac9bee4f4934508703a3b90645 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680938 > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#673239} TBR=wangxianzhu@chromium.org,bokan@chromium.org,pdr@chromium.org Change-Id: I120ced5c25468a81e0d9ec227073597dce7bb2c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 978774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680734Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#673370}
-
Shakti Sahu authored
With this change, 1 - User paused downloads will show PAUSED, no matter whether they are in-progress or interrupted. 2 - Auto-resumable downloads (network interrupts) will show PENDING 3 - Interrupted downloads in final state (invalid resume mode) will show FAILED 4 - Downloads that have surpassed auto-retry limit will show PAUSED to give user a chance to resume. 5 - All other interrupted downloads will show INTERRUPTED Added some tests for these. Change-Id: I46098e5916bb453056510a2811af1f6f49b6e49c Bug: 978227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680419 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#673369}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5d13106e..b8c9b171 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I457423a0d9b25b6a8d832bab9ed35a6332c4b634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681780Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673368}
-
Alexandre Frechette authored
When choosing a new UI language, enable it and put it at the top of the accept languages list. That way the accept languages list reflects the user's language preferences. Bug: 972033 Change-Id: I5bbee2f569f3a0d5941ebb161bcae751b3c41001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665650 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#673367}
-
Lutz Justen authored
Adds support for KerberosRememberPasswordEnabled and KerberosAddAccountsAllowed policies. Both are enabled by default. If KerberosAddAccountsAllowed is disabled, all unmanaged accounts are erased, the 'Add account' button (in the Kerberos accounts settings page) is disabled and a management indicator is shown. If KerberosRememberPasswordEnabled is disabled, all stored passwords for unmanaged accounts are erased, the 'Remember password' checkbox (when adding an account) is disabled and a management indicator is shown. BUG=chromium:952239 TEST=Enable KerberosEnabled policy, add a managed account with KerberosAccounts policy, go to chrome:settings/kerberosAccounts, add an account and remember the password, change KerberosRememberPasswordEnabled policy to false, reload policy and chrome:settings/kerberosAccounts page (does not auto-update), click 'Refresh Now' on the manually added account, make sure that the password field is empty and the 'Remember password' checkbox is unchecked and disabled, disable KerberosAddAccountsAllowed policy, reload policy, go to chrome:settings/kerberosAccounts, make sure that the manually added account got removed and the 'Add account' button got disabled. Change-Id: Ia9c0d5d31a655981972850b872e7c57ab5a4a7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674548 Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#673366}
-
David Bokan authored
We ignore the scale limits to prevent pages from overriding a user's ability to zoom into content. However, the minimum-scale is less important since a poorly set limit would mainly just prevent the user from getting an overview of the page. Pages often use the minimum-scale to ensure the intended layout of the page isn't shrunken beyond the viewport size so without this change many page layouts appear broken on load. Bug: 929709 Change-Id: I220dd0f5df912921e9876e0005452a7a4e9f1adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680688 Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#673365}
-
Mohamed Amir Yosef authored
Before this CL: The ModelTypeWorker were unconditionally setting the title in the BookmarkSpecifics, if the SyncEntity.name isn't empty. However, the production server sets the name to "tombstone" for tombstones and hence the worker would actually set the title in the specifics. As a result the specifics are never empty. Empty specifics are used further in the pipeline to identify remote deletions, and hence remote deletions are always ignored. After this CL: The ModelTypeWorker would only assign the title for non-tombstones. Bug: 979150 Change-Id: I9ec80efbba95c2163403b3564adb1ae2bade3dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681890 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#673364}
-
jonross authored
Suppress compositing/reflections/reflection-on-composited.html TBR=backer@chromium.org Test: vulkan_swift_shader_blink_web_tests Bug: 979652 Change-Id: I862e5fd53e2ce63096287c9e26713a5002d0c635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681877Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#673363}
-
Tim Volodine authored
Records the custom response status code for the intercepted requests where input stream is null. The data is recorded only when the status codes and reason phrases are actually valid. This is recorded regardless of whether the network service is enabled or disabled. The UMA is useful to see if there is any significant usage for this type of interception. This type of interception has been originally mentioned in crbug.com/965608, where it results in behavior different to the old (non-network service) code path. Also see crbug.com/974273 for more details. BUG=974273,965608 Change-Id: I5a36757621b0b6227c10fae862749f85f8b0e4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660657Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#673362}
-
Lutz Justen authored
For managed Kerberos accounts, this CL - adds a management indicator next to an account in the accounts list, - adds a management indicator on the advanced configuration dialog - disables the option to remove the account and - disables the text area to edit the configuration. Also renames a JS field from 'hasRememberedPassword' to 'passwordWasRemembered' in order to reflect the field in the proto. BUG=chromium:974145 TEST=./testing/xvfb.py out/Release/browser_tests --gtest_filter=CrSettingsPeoplePageKerberosAccountsTest.All Enable KerberosEnabled policy, add managed accounts via KerberosAccounts policy, open chrome:settings/kerberosAccounts, make sure that the all the things advertised above are true. Change-Id: I6386657c98dfc028081c1fef26b7f14e8e8b43fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674085 Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#673361}
-
Aran Gilman authored
Specifically, this CL does the following: * Return DarkModeClassification instead of bool from ShouldInvertColor(). This makes the interface for color classification more similar to that for image classification. * Create a separate file for DarkModeColorClassifier tests. This encourages more thorough testing of individual classifiers. * Make DarkModeClassification an enum class and remove "DarkMode" from the individual values' names. * Add ElementRole enum to DarkModeFilter. This sets up planned changes for handling elements differently depending on the "role" within the page. There was actually a bug in the old code where most text drawing methods did not use the new text inversion check. This should now be fixed. Bug: 968340 Change-Id: Ide6e26182f70bb2679ca0d20e295b0402559df38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679480Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#673360}
-
Aran Gilman authored
Bug: 971068 Change-Id: I20cdf28af8b98d5475ca38d35c8a9fd7cff04044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680945Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#673359}
-
Mohammad Refaat authored
TabSwitcher's protocol dismissWithNewTabAnimationToModel method used to return Tab. The return value was never used by any caller. and doesn't seem to be needed. Bug: 911733 Change-Id: Ie0f86362905c9015ad725d4fc19b99f553f3ae90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680894 Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#673358}
-
Lutz Justen authored
Adds the ability to disable settings-textarea elements. Disabled text areas are aria-disabled, unfocused and are not reachable by tabbing. BUG=chromium:974145 TEST=browser_tests --gtest_filter=CrSettingsTextareaTest.* Change-Id: I085c2a045e4d5432cc23d9b21da582fc9255c742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676633 Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#673357}
-
Rayan Kanso authored
Bug: 973844 Change-Id: I9d5c64c163abb6bfd81df16ab77fb7b4c9d56d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678181Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#673356}
-
Mihai Sardarescu authored
This CL removes a bit of dead code from LoginUIService::DisplayLoginResult(). Bug: NONE Change-Id: Ia303e5776fa61186854abb22db24df724648017f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682028Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#673355}
-
Lutz Justen authored
Changes FakeKerberosClient's internal storage from a map to a vector, so the order in which accounts are added is preserved. Also remembers whether the login password was used. BUG=chromium:952240 TEST=Manually tested on Linux desktop Change-Id: Icfb576e3f54f97cdb849b41ea6dd8fa49b3101ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674084 Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#673354}
-
Lutz Justen authored
Adds a notification triggered by a signal from the Kerberos credentials manager when the active Kerberos ticket expires. Upon clicking the ticket, the reauthentication flow is started. In practice, this should happen every few weeks if the Kerberos ticket lifetime and renewal lifetime are set properly on the KDC, e.g. 24 h lifetime + 14 days renewal lifetime. BUG=chromium:952245 TEST=None Change-Id: I0bb9965a0598571208f20c9ab53750ded2f6769a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667304Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#673353}
-
Tanmoy Mollik authored
Enable UnifiedConsent for ArticleSnippetsTest and update goldens for personalized sign-in promos. Bug: 936986 Change-Id: Ia058e6c2a18a5c49c13b019522ecc09067df5082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679754Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#673352}
-
Maksim Moskvitin authored
NigoriSyncBridge now respects custom_passphrase_derivation_method and custom_passphrase_scrypt_salt fields and supports decryption with keys derived using SCRYPT method. If the remote update contains an unsupported key derivation method (or SCRYPT, while kSyncForceDisableScryptForCustomPassphrase is enabled), the bridge reports ModelError (which means sync becomes inactive). This CL doesn't support migration, which fills custom_passphrase_derivation_method for old CUSTOM_PASSPHRASE users, but fills it if user just enabled CUSTOM_PASSPHRASE. The complete migration code will be added in follow-up CLs. Bug: 922900 Change-Id: I87bacd54d8b22b9f53868161e1196398bb966661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676710 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#673351}
-
Philip Rogers authored
Bug: 979389, 979380, 979367 Change-Id: I69039de5179152c3ab4a021243f50ebad3050401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682008Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#673350}
-