Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 23 Jul, 2018 37 commits
  3. 22 Jul, 2018 3 commits
    • Darren Shen's avatar
      [VK] Don't show emoji menu item in context menu for certain input types. · b1b8ac5a
      Darren Shen authored 
      We shouldn't show the emoji menu item in the render view context menu
for "number", "tel" and "other" (dates, time, checkboxes etc.) input
types.

We deliberately implement this as a blacklist (don't show for these
input types) instead of a whitelist (only show for these input types),
since not being able to enter emoji when you should be able to is much
more frustrating than having an extraneous emoji item.

Note that this permits emoji on "password" fields, but apparently that
could be a thing.

Bug: 865199
Change-Id: I7b2b977f435cee0c4f98c357187b45d90a08ecfc
Reviewed-on: https://chromium-review.googlesource.com/1142851Reviewed-by: default avatarScott Violet <sky@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarDarren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577098}
      b1b8ac5a
    • Kai Koehne's avatar
      Remove incomplete logic to detect AMD K2 CPU's · c37f2d0f
      Kai Koehne authored 
      The check for cpu.family() == 15 will also trigger for newer
ThreadRipper CPU's, resulting in a DCHECK on debug builds and
potentially suboptimal behavior in release builds. To fix this,
the check would have to take the extFamily() and maybe model()
into account, but I couldn't find the correct values for the
AMD K2 CPU's anywhere.

Anyhow, it is unclear whether newer Windows versions are still
affected by the original problem. The commit that introduced the
original check - https://codereview.chromium.org/4092 - is more
than 9 years old. There are hints that the underlying issue got
fixed in Windows XP SP2 and/or Windows 7. Hence this patch just
removes the check.

Bug: 863855
Change-Id: I26d6e282ec6116ec40fbf86e750367d15dc31604
Reviewed-on: https://chromium-review.googlesource.com/1138241
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: default avatarYuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577097}
      c37f2d0f
    • Javier Fernandez's avatar
      Revert "[css-text] A leading white-space should break before handling overflow" · 04c10b73
      Javier Fernandez authored 
      This reverts commit 6ea2a2e7.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [css-text] A leading white-space should break before handling overflow
> 
> Leading white-spaces are indeed breaking opportunities that should
> prevent, if there are no other css properties forcing it, breaking text
> in the middle of a word when honoring the word-wrap/overflow-wrap CSS
> property.
> 
> We are doing so if the leading white-space sequence is longer than 1
> character, but when we have a single leading white-space, we are missing
> that breaking opportunity and we may lead to cases, like the one
> described in the bug.
> 
> However, this breaking opportunity should be considered together
> with other provided by the word-break CSS property (eg, break-word or
> break-all).
> 
> There is a discussion [1] in the CSS WG github about this issue, which
> provides an interoperability analysis of a few cases where a single
> leading white-space character may produce different results, depending
> on the browser and the combination of line-breaking properties.
> 
> [1] https://github.com/w3c/csswg-drafts/issues/2907
> 
> Bug: 854624
> Change-Id: I49ec8282e899a32990662c104b48cab04057b909
> Reviewed-on: https://chromium-review.googlesource.com/1130515
> Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575596}

TBR=jfernandez@igalia.com,kojii@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 854624
Change-Id: I9ee4cd370dd92b74f9fdc4f42d16638253dd2dee
Reviewed-on: https://chromium-review.googlesource.com/1146360Reviewed-by: default avatarJavier Fernandez <jfernandez@igalia.com>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#577096}
      04c10b73