GitLab

Also removed some unused logs.

Change-Id: Ie23768f8f9fd5ceb6814df9dadd5f896bc809aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793444
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695405}

src/tools/run-swarmed.py uses src/results as the output directory by
default. We should avoid treating them as source files in the repository.

Change-Id: I69ee66aa7c65382d0068bbd949fa761e638a5dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781925
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695404}

If the page was loaded with Most Visited shortcuts, the maximum number
of shortcuts was set to 8. This was not updated if users swapped to
custom links, so an error was thrown.

Do update the maximum number of shortcuts, and remove the error since
we can ignore any shortcuts over the max.

Change-Id: I95e3941ed2c9f2b266075edad7f8a60bddddd93d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793230
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695403}

Bug: 1002737
Change-Id: I74070a0ad0f0633521247e1c74ea0147ccc0505d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797248
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695402}

The code path these test doesn't happen when the feature is on:
* EmbeddedWorkerInstanceTest.DetachDuringProcessAllocation
* EmbeddedWorkerInstanceTest.StopDuringProcessAllocation

Bug: 824858
Change-Id: Iadfc474fc1a0acb56ec9562a17fed28023927931
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795530Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695401}

This CL refactors how we use the feature flags for image decode
acceleration. The goal is that for a given image type (i.e., JPEG or
WebP), we only check the corresponding hardware decode acceleration
feature flag after we know that OOP-R is enabled and the device supports
hardware decoding images of that type. The reason is that we only want
hardware decode acceleration finch experiments to include users from
that population (otherwise, both the control and enabled groups would
always avoid accelerated decodes).

To achieve this, we compute two bool members in the GpuImageDecodeCache
ctor, |allow_accelerated_jpeg_decodes_| and
|allow_accelerated_webp_decodes_|. These are computed by first checking
for OOP-R and hardware decoding support for the corresponding image
type.

We also remove the feature flag checks in
VaapiImageDecodeAcceleratorWorker::Create() (which happens during the
the GPU process startup). This implies that the supported decoder
profiles are always advertised to the renderers. However, the checks in
[1] remain intact and they ensure that the service side only accepts
requests for accelerated decoding if one of the feature flags (JPEG or
WebP) is on. Furthermore, we check the flags again in
VaapiImageDecodeAcceleratorWorker::GetDecoderForImage() to ensure that
if a flag for a specific image type is off, we don't use the decoder for
that type. This is all to prevent compromised renderers from triggering
hardware decodes forbidden by the feature flags.

[1] https://cs.chromium.org/chromium/src/gpu/ipc/service/image_decode_accelerator_stub.cc?l=118-123&rcl=4fbe89686751aa0c90da185c82d796f9f01cf2aa

Bug: 995155
Test: Adds GpuImageDecodeCache test coverage for the new behavior.
Change-Id: I4957f9e2606b012aef337c93b45732eaf010248a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787594
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695400}

Currently for accelerated 3D resources we skip SharedImage provider
and fall through to Texture provider which is not compatible with
Vulkan.

Bug: 985366
Change-Id: Ibc7a6ad38ba62c9e82b86822dcf1dff06a7d2096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796307
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695399}

Using wpt-import in Chromium eaa5aa87.
With Chromium commits locally applied on WPT:
cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
kojii@chromium.org, mstensho@chromium.org:
  external/wpt/css/CSS2

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I08c071c7915b4428a9b35ec803e049a4e76340dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796904Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695398}

Bug: internal b/140761503

Test: audio_video_pipeline_impl_unittest.

Change-Id: I77f8f44dc8fe71e018599e927e48a915c76093d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796643Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695397}

Before, the flags were passed to the test APK.

+ Fix flags to make bundle smoke test run.

Bug: 989654
Change-Id: I175b57af7b0c0ad9badb5d16b341f0eae4b8369a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795311Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695396}

This is the only function in IntentUtils that depends on
chrome/browser. IntentUtils can then be moved to a separate util
build target.

Bug: 995916
Change-Id: I25307932e08b605f292947f7af2d4fe2be98b70f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774301Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695395}

The thread ServiceWorkerContextCore lives on (the "core thread") will
move from the IO thread to the UI thread when the ServiceWorkerOnUI
feature is enabled.

This makes most tests involving extension service workers to pass.

Bug: 824858, 984522
Change-Id: Ide0d60cbe9be15ea6149d29761a50506ac4376fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763560
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695394}

BUG=1002351

Change-Id: Ib351d0251b0914220d55b269079c958ed06ac9d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794522Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695393}

[TaskEnvironment] Get rid of the last explicit usages of MAIN_THREAD_ONLY that snuck in during the transition

TBR=dcheng@chromium.org

Bug: 992483
Change-Id: I1c95dfd52690fdedb0ae35ffa7da9081e2af182f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796753Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695392}

This icon db initialization flow loads the entry keys in
https://chromium-review.googlesource.com/c/chromium/src/+/1788308.

We can log the record count for icon db now.

Bug: 963298
Change-Id: I9bd04a9205484d0b9023ed8bc7816680bf235d07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793824
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695391}

https://webrtc.googlesource.com/src.git/+log/52f7ae7c8988..c5d29588605e

git log 52f7ae7c8988..c5d29588605e --date=short --no-merges --format='%ad %ae %s'
2019-09-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 56140e7d..b5e2f020 (695187:695291)

Created with:
  gclient setdep -r src/third_party/webrtc@c5d29588605e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: Ie4d88c24461de874f0afedb05e017b10d762e115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796124Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695390}

Added a null check in the public API of BottomSheetContent impl in
gesture navigation. This can be invoked before BottomSheetController
is available.

Bug: 1002385
Change-Id: I991c3caed0a118b89178321bd86f5c3e82e406ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795523Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695389}

This adds a //tools/gn/roll_gn.py script that can be run to
roll DEPS to the latest version of GN (or an alternate version of
your choosing).

R=thakis@chromium.org

Change-Id: I88c4357e8566bbed2e3f0339b12733fec96430ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793632
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695388}

It was for testing at impl-side in layer tree mode.

Change-Id: I410643e14ffd85f90be2bfb5ba670a816164da2e
Bug: 994361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795574Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695387}

The AnchorAlignment enum is used in a few places outside of
cr_action_menu.js (tests, settings pages). Move it into a separate file
so that a module exporting it can be easily autogenerated for Polymer 3.


Bug: 965770
Change-Id: I88121da31ce9f016c89fa2a9a83a6fda263094b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795315Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695386}

This reverts commit 1ffb3583.

Reason for revert: This CL breaks Vulkan support for any client running
a Vulkan version earlier than 1.1. The reason for this is that in the
generator, we specify |'min_api_version': 'VK_VERSION_1_1'|, which gets
translated into |if (api_version >= VK_VERSION_1_1)|.

The issue here is that |api_version| is a Vulkan API version which is a
multi-part version number packed into a 32 bit int [1]. VK_VERSION_1_1
on the other hand, is defined as 1 [2], so the version check will
always pass. What we want here is actually VK_API_VERSION_1_1.

I will revert my CL and then upload a CL that fixes my code and all of
the existing code in this generator that uses VK_VERSION_1_1.

[1] https://vulkan.lunarg.com/doc/view/1.0.30.0/linux/vkspec.chunked/ch02s09.html
[2] https://cs.chromium.org/chromium/src/third_party/glfw/src/deps/vulkan/vulkan_core.h?l=3641&rcl=2de2589f910b1a85905f425be4d32f33cec092df

Original change's description:
> gpu: Load vk functions for querying image/buffer properties
> 
> This CL registers a few functions in the Vulkan binding generator script
> to be used for importing dma-bufs as VkImages [1] with the end
> goal of supporting WebGPU on Chrome OS. In particular, we add:
> 
> - vkGetPhysicalDeviceImageFormatProperties2: allows us to query if the
> physical device supports importing dma-bufs into Vulkan via the
> VK_EXTERNAL_MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT flag [2].
> - vkGetMemoryFdPropertiesKHR: allows us to list the types of memory that
> our buffer backed by a dma-buf can be imported as.
> - vkGetImageMemoryRequirements2: allows us to list the types of memory
> supported by a given VkImage which can be compared to the output of
> vkGetMemoryFdPropertiesKHR to determine a suitable memory type for
> import.
> 
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/1796049
> [2] https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/VkExternalMemoryHandleTypeFlagBits.html
> 
> BUG=996470
> TEST=ran the script and used the newly bound functions
> 
> Change-Id: I0f61e531009596d7237153f203084639e649afd7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794142
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: Peng Huang <penghuang@chromium.org>
> Commit-Queue: Brian Ho <hob@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#695296}

TBR=penghuang@chromium.org,dcastagna@chromium.org,hob@chromium.org

Change-Id: Ia1dd50f868aa482bfef6a60e63d0d696c6e309d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 996470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796527Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695385}

https://skia.googlesource.com/skia.git/+log/c0c05047c21b..4fe30e15c06c

git log c0c05047c21b..4fe30e15c06c --date=short --no-merges --format='%ad %ae %s'
2019-09-10 bsalomon@google.com Also skip blurrect_compare on DDL configs
2019-09-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-09-10 bsalomon@google.com Reland "Separate texture creation from uploading in GrGpu subclasses."

Created with:
  gclient setdep -r src/third_party/skia@4fe30e15c06c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=mtklein@google.com

Bug: None
Change-Id: I80be9c6c14912d6b4cc6cd5496d7ca879e480a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796925Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695384}

Currently, while middle-click auto-scroll is in progress on the main
page and if the mouse moves over OOPIF, it sends mouse events to OOPIF
under the mouse instead. As a result, auto-scroll speed is not modified
in proportion to the distance from the middle-click position. As soon
as OOPIF scrolls away and the mouse is over the main page again, it sees
large delta/update in the mouse position. This results in sudden scroll
jump.

This CL fixes the issue by locking the input events to a single
renderer when middle-click auto-scroll is in progress until
interrupted.

Bug: 872832
Change-Id: I2cb29094098d7373b857ec1fc3893cc24c8016af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773540Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#695383}

The caller-side in extensions may want to take different actions
depending on how things failed. Per discussion at:
https://chromium-review.googlesource.com/c/chromium/src/+/1763560

There is no behavioral change yet except that the Stop* function no
longer fails if the worker is STOPPING. There's no reason to fail there,
we can just finish the request as requested.

Bug: 999027, 824858
Change-Id: Ib04cd671e99af6afd082562d13c9677772894c26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792518
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695382}

- Add test for ignore comments for js_modulizer script
- Fix bug in the script, where an ignore starting at the very beginning
of the line did not get removed
- Remove dummy importHtml and instead use the new ignore comments to
remove these calls in tests.

Bug: 965770
Change-Id: I6f63861bef6e93ae918d54273f905c0cc372dbc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793743Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695381}

Instead use OnProfileAdded

Bug: 268984
Change-Id: I733936856f025703272724349de3447aa5313dae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793930Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695380}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/device/bluetooth/bluez.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=mcchou@chromium.org

Bug: 891670
Change-Id: I7aaa1219ecbb2e87d39d7a0920f822a749d4d9b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787102
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695379}

So when fetching authentication challenge fails, update the pending
WebAuthn offer dialog to the error state and show new contents.

Mock: https://docs.google.com/presentation/d/16gfVy4EJ0hPibnOWZ8pqMF09Uy6uCWW2mCd1et9ILDw/edit?ts=5d670e48#slide=id.g33e66b3a17_12_0

Uploaded implementation screenshot in bug comment 11

1) Added function in CCFA to update dialog if error-ed.
2) Added more DialogState enum in model.
3) Changed the way how MVC works. Previously the controller talked to
view directly. Now the controller updates model, and view, as an
observer, observing any state change and updates itself.

Bug: 991037
Change-Id: Ia5159d64f411d51bdcab6d3d1b72638fe014de40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785627Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695378}

This CL makes |MediaToolbarButtonController::Session| a
|WebContentsObserver| so that we get notified when a tab is closed.
This allows us to immediately remove a notification and hide the
toolbar icon when a tab is closed instead of freezing it.

Bug: 994509
Change-Id: I751e3c8a8c0cc696984a9581b7f9dbfe39ed69e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793235Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695377}

Missed this in the last CL; see:
https://chromium-review.googlesource.com/c/chromium/src/+/1793544

Change-Id: I71563a1892af642d13786cf35cb267e107dc1748
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796751
Auto-Submit: Dana Fried <dfried@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695376}

When strong validators are not present, we don't resume download if
CONTENT_LENGTH_MISMATCH error happens.
However, according to UMA, more than 99% of the cases more data will
be received after a CONTENT_LENGTH_MISMATCH error if strong validators
are present. And since we are launching the feature to allow download
resumption without strong validators, many of these interrupted
downloads can now resume.

BUG=1002591

Change-Id: I75facafef994e6c4637e52b340dddc05fca94833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795761Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695375}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53a5a5042e54..dbca865e55f7

git log 53a5a5042e54..dbca865e55f7 --date=short --no-merges --format='%ad %ae %s'
2019-09-10 ehmaldonado@chromium.org depot_tools: Bootstrap Python 3 on Linux/Mac
2019-09-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/depot_tools@dbca865e55f7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:1002153
Change-Id: Ieeacbbcdf91d0f20ccddfe592c41418a94b7f905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795321Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695374}

This reduces complexity of the code in preparation for the multi-window
support.

Bug: 994939
Change-Id: I9fbb0658135b0b26c40644607d09baa1b56309b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796889Reviewed-by: Andrew Luo <aluo@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695373}

The impl tree viewport changes caused by |top_controls_shown_ratio_|
changes are not reflected on the main thread when the top controls are
partially shown. This causes a mismatch each time we push property trees
from main > impl.

This change provides a temporary fix by updating the viewport any time
we push main > impl when in a partially shown state.

Long term we should propagate these changes to the main tree and
avoid this workaround.

Bug: 875943
Change-Id: I47e6a5127e6a2c76b5286e257904d2501e3859a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795572
Commit-Queue: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Auto-Submit: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695372}

These tests were previously migrated from single-threaded MessageLoop to
a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as
part of crbug.com/891670.

//base OWNERS decided in retrospect that it was better to keep a
single-threaded option for TaskEnvironment and introduced
SingleThreadTaskEnvironment. This CL retrofits that decision for
/ios/net/cookies.

This CL is a no-op if it passes CQ.

This CL was uploaded by git cl split.

R=mrefaat@chromium.org

Bug: 891670
Change-Id: I860cd4deb1e73ac378a2fa8fc21ebee528a69a58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787214
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695371}

TabGridSheetToolbarCoordinator, TabGridSheetViewBinder and
TabGridSheetProperties are shared by TabGridDialog and TabGridSheet.
This CL renames shared components as TabGridPanel*.

Bug: 987669
Change-Id: I542963909c55c96f5c2a44fbd88dd0c367aeaae6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790647Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695370}

When SplitSettings is enabled (the default) the browser Appearance
section opens in a tab. In this case, use the "external" link out
icon.

https://screenshot.googleplex.com/47LQzbfZeTx

If SplitSettings is disabled, keep the normal in-page link icon.

Bug: 999354
Change-Id: I7f70ac3a18c4a92b7d24a5b0be926488ec0010b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796784
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695369}

One of my recent CLs added an include of the "settings-shared" CSS
styles to basic_page.html:
https://chromium-review.googlesource.com/c/chromium/src/+/1783060

This added CSS rules for <h2> that matched the "Advanced" toggle button
container and added unwanted padding and text color.

Fix by explicitly setting the padding and color to the correct values.

See bug for screenshots pre-regression, post-regression, and with
this fix.

Bug: 1002422
Change-Id: Ia25ef9b5f4183633f1a1cdd1a15e8a741e7a7513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795498Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695368}

https://pdfium.googlesource.com/pdfium.git/+log/548a26302ef5..881c56bc0687

git log 548a26302ef5..881c56bc0687 --date=short --no-merges --format='%ad %ae %s'
2019-09-10 thestig@chromium.org Roll third_party/icu/ 682a23092..53f6b233a (6 commits)
2019-09-10 thestig@chromium.org Roll third_party/freetype/src/ 543a3b939..3de1b8d0b (5 commits)
2019-09-10 thestig@chromium.org Roll base/trace_event/common/ cfe8887fa..5e4fce17a (3 commits)
2019-09-10 thestig@chromium.org Roll third_party/libjpeg_turbo/ 81aef9014..baa5dc242 (6 commits)
2019-09-10 thestig@chromium.org Roll third_party/zlib/ 2b4888a46..8c79b6c8d (10 commits)
2019-09-10 thestig@chromium.org Roll third_party/android_ndk/ 4e2cea441..099a70aef (1 commit)
2019-09-10 awscreen@chromium.org Remove leading space in .gitattributes

Created with:
  gclient setdep -r src/third_party/pdfium@881c56bc0687

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: None
Change-Id: Iddb32291ac356bcf50e5cf7fe17b81cf755ed397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795996Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695367}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e47094cfbc5..2f637a9deab9


Created with:
  gclient setdep -r src-internal@2f637a9deab9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:1002650
Change-Id: Id393a02403575b0cb0277a1b24b9a0a2a4ec8c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795320Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695366}