Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 23 Jul, 2018 14 commits
    • Rakina Zata Amni's avatar
      Move ReportFindInPage{MatchCount,Selection} to FindInPage · 97d82f88
      Rakina Zata Amni authored 
      This CL moves ReportFindInPageMatchCount and
ReportFindInPageSelection from RenderFrameImpl to FindInPage.
This is done in preparation of mojoifying FindInPage::Find.
ReportFindInPage{MatchCount,Selection} sends FindReply frame
host messages through IPC for calls to the Find method.

After mojoification, these functions will instead call
SetNumberOfMatches/SetActiveMatch on FindInPageClient.
We are moving them now to make the CL for the mojoification
smaller/simpler.

Mojoifying doc: https://goo.gl/JenyGm

Previous CLs:
Introduce FindInPageClient with SetNumberOfMatches and SetActiveMatch
crrev.com/c/1080568

Mojoify FindInPage::StopFinding
crrev.com/c/1058731
(other CLs linked in the CL above)


Bug: 819919
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I2841d2841a44d1473d4118215cd7dd0f238ca001
Reviewed-on: https://chromium-review.googlesource.com/1097237Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577112}
      97d82f88
    • Noel Gordon's avatar
      Add GetFullTestCaseName FilesAppBrowserTestBase helper · fabc87ea
      Noel Gordon authored 
      Add helper to read the "full test case name". Any derived classes that
have testing options (TabletMode, GuestMode, etc) can include those in
the full test case name.

Update FileManagerBrowertestBase to log the "full test case name" when
starting a browser test.

Bug: 836254
Change-Id: I9613a4682a6ae91fb03a842ce20924ceb21c1930
Reviewed-on: https://chromium-review.googlesource.com/1146412
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: default avatarSam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577111}
      fabc87ea
    • Timothy Loh's avatar
      Revert "Match security chip visibility with focus ring" · e7229461
      Timothy Loh authored 
      This reverts commit 26399bca.

Reason for revert: OmniboxViewViewsTest.SelectAllOnTabToFocus is Flaky

Original change's description:
> Match security chip visibility with focus ring
> 
> Instantly hides or shows the IconLabelBubbleView separator when focus
> rings are available to prevent showing the separator when a focus ring
> overlaps it.
> 
> Bug: chromium:865029
> Change-Id: I21a4c296c1da06b81dc91d66101d46e8ad52ad99
> Reviewed-on: https://chromium-review.googlesource.com/1142442
> Commit-Queue: Peter Boström <pbos@chromium.org>
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576358}

TBR=pbos@chromium.org,bsep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 865029, 866230
Change-Id: I30372e90c1613b33690b43dd28fbe151abddddef
Reviewed-on: https://chromium-review.googlesource.com/1146421Reviewed-by: default avatarTimothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577110}
      e7229461
    • Khushal's avatar
      Revert "gpu: Hook up activity flags for glProgramBinary for OOPR." · 3ff6b565
      Khushal authored 
      This reverts commit 13e510ef.

Reason for revert: Causing crashes on the latest canary. I'll debug on Monday.

Original change's description:
> gpu: Hook up activity flags for glProgramBinary for OOPR.
> 
> The activity flags are used to notify the browser if the GPU process
> crashes during shader compilation which could indicate a corrupted disk
> shader cache. Hook this up for the persistent shader caching on the
> GrContext for OOPR.
> 
> R=​ericrk@chromium.org, piman@chromium.org
> 
> Bug: 854416
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I4ed69d41768856b649a500dd5b86777bf0023d26
> Reviewed-on: https://chromium-review.googlesource.com/1142367
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576819}

TBR=khushalsagar@chromium.org,piman@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 854416
Change-Id: I51f5ff5b7427348b06159b7a8a3ec11161d9b6f3
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1146087Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577109}
      3ff6b565
    • Timothy Loh's avatar
      Revert "Add a single buffered mode to CanvasResourceProvider" · aeabd72a
      Timothy Loh authored 
      This reverts commit 5c4bc1ff.

Reason for revert: CanvasRenderingContext2DTest.LowLatencyIsSingleBuffered failing

I suppose this depended on https://chromium-review.googlesource.com/c/1144602/, which was reverted, so the test this CL adds is failing now.

Original change's description:
> Add a single buffered mode to CanvasResourceProvider
>
> This CL completes the initial implementation of Low Latency mode for 2d
> canvases
>
> Bug: 788439
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: I58fcd3fe4ab19fa10f2876f3da4f078fd4fbc2a9
> Reviewed-on: https://chromium-review.googlesource.com/1145235
> Commit-Queue: Justin Novosad <junov@chromium.org>
> Reviewed-by: Fernando Serboncini <fserb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576962}

TBR=junov@chromium.org,fserb@chromium.org

NOTRY=TRUE

Bug: 788439,866211
Change-Id: I8e976b4cb6aca452f6d1891677e35e4411e2a5e4
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1146460
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: default avatarTimothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577108}
      aeabd72a
    • Yutaka Hirano's avatar
      [OOR-CORS] Support header modification on FollowRedirect · 8f6c7797
      Yutaka Hirano authored 
      Bug: 736308
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I86bccc93b2e2050326d59c26a03d05a51ed1ae81
Reviewed-on: https://chromium-review.googlesource.com/1144807
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: default avatarChong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577107}
      8f6c7797
    • Rakina Zata Amni's avatar
      Introduce FindInPageClient, with SetNumberOfMatches and SetActiveMatch · 724f3efe
      Rakina Zata Amni authored 
      FindInPageClient is a per-frame client for FindInPage.
FindRequestManager has a map of frame -> FindInPageClient.
FindInPageClient manages per-frame number of matches, and also
updates the global number of matches and the current active match
rect and ordinal.

In this CL, we are changing ActivateNearestFindResult to call methods
on FindInPageClient instead of calling a callback. SetNumberOfMatches
is called to update the corresponding frame's number of find-in-page
matches and also update the total number of matches in a tab.
SetActiveMatch updates the tab's active match rect and ordinal.

When we mojoify FindInPage::Find, we'll use FindInPageClient to
receive the find replies and remove FindRequestManager::OnFindReply.

Mojoifying doc: https://goo.gl/JenyGm

Previous CLs:
Mojoify FindInPage::StopFinding
crrev.com/c/1058731
(other CLs linked in the CL above)

Bug: 819919
Change-Id: I25a6d81037655801db1b1337f335073f11aa7862
Reviewed-on: https://chromium-review.googlesource.com/1080568
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577106}
      724f3efe
    • Timothy Loh's avatar
      Revert "Update V8 to version 7.0.1." · 48286672
      Timothy Loh authored 
      This reverts commit c2bc780a.

Reason for revert: Lots of breakages on Debug builders

# Fatal error in ../../v8/src/api.cc, line 5960
# Check failed: expected == value ((nil) vs. 0x11b5bca8d0e8).
#
#
#
#FailureMessage Object: 0x7fff42dfe070#0 0x7fd6fdc375fd base::debug::StackTrace::StackTrace()
#1 0x7fd6fd9443cc base::debug::StackTrace::StackTrace()
#2 0x7fd6e76e76f7 gin::(anonymous namespace)::PrintStackTrace()
#3 0x7fd6dad0b918 V8_Fatal()
#4 0x7fd6f9eecfcc v8::String::VerifyExternalStringResourceBase()
#5 0x7fd6e2a5a310 blink::ToBlinkString<>()
#6 0x7fd6e501a9f5 blink::V8StringResource<>::ToString<>()
#7 0x7fd6e501416c blink::V8StringResource<>::operator WTF::AtomicString()
#8 0x7fd6e69322d1 blink::ElementV8Internal::removeAttributeMethod()
#9 0x7fd6e6931faa blink::V8Element::removeAttributeMethodCallback()
#10 0x7fd6f9fa5444 v8::internal::FunctionCallbackArguments::Call()
#11 0x7fd6f9fa3870 v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#12 0x7fd6f9fa1ba8 v8::internal::Builtin_Impl_HandleApiCall()
#13 0x7fd6f9fa15e1 v8::internal::Builtin_HandleApiCall()
#14 0x7fd6fac565f5 <unknown>
Received signal 4 ILL_ILLOPN 7fd6dad10b62
#0 0x7fd6fdc375fd base::debug::StackTrace::StackTrace()
#1 0x7fd6fd9443cc base::debug::StackTrace::StackTrace()
#2 0x7fd6fdc37054 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7fd6df1c60c0 <unknown>
#4 0x7fd6dad10b62 v8::base::OS::Abort()
#5 0x7fd6dad0b925 V8_Fatal()
#6 0x7fd6f9eecfcc v8::String::VerifyExternalStringResourceBase()
#7 0x7fd6e2a5a310 blink::ToBlinkString<>()
#8 0x7fd6e501a9f5 blink::V8StringResource<>::ToString<>()
#9 0x7fd6e501416c blink::V8StringResource<>::operator WTF::AtomicString()
#10 0x7fd6e69322d1 blink::ElementV8Internal::removeAttributeMethod()
#11 0x7fd6e6931faa blink::V8Element::removeAttributeMethodCallback()
#12 0x7fd6f9fa5444 v8::internal::FunctionCallbackArguments::Call()
#13 0x7fd6f9fa3870 v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#14 0x7fd6f9fa1ba8 v8::internal::Builtin_Impl_HandleApiCall()
#15 0x7fd6f9fa15e1 v8::internal::Builtin_HandleApiCall()
#16 0x7fd6fac565f5 <unknown>

Original change's description:
> Update V8 to version 7.0.1.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/d7b61abe..8766d3dd
>
> Please follow these instructions for assigning/CC'ing issues:
> https://github.com/v8/v8/wiki/Triaging%20issues
>
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
>
> TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
>
> Change-Id: Id0a466229f294e8afa3e887d9814926b592815b7
> Reviewed-on: https://chromium-review.googlesource.com/1145698
> Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#576998}

TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com

NOTRY=TRUE

Change-Id: I86ecc3dba8ab82f9e2968b3905033539f9363098
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1146420
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: default avatarTimothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577105}
      48286672
    • chrome-release-bot's avatar
      Updating trunk VERSION from 3500.0 to 3501.0 · 9785f283
      chrome-release-bot authored 
      # This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: I674947b92fc11e1aac2b4855d0a87fe1c8f7c9a2
Reviewed-on: https://chromium-review.googlesource.com/1146212Reviewed-by: default avatarchrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577104}
      9785f283
    • Xiaocheng Hu's avatar
      Stop including editing_behavior.h in editor.h · e3540f40
      Xiaocheng Hu authored 
      This patch removes a header inclusion for better build performance, and
clearer code dependency.

Bug: 866120
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8d3bb813807bbae08350f1b649043752a1198d42
Reviewed-on: https://chromium-review.googlesource.com/1145694
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577103}
      e3540f40
    • Stefan Zager's avatar
      Add class WebScrollbarThemeClient · 3f8543e5
      Stefan Zager authored 
      This is an abstraction to facilitate moving the bulk of platform/scroll
into core. WebScrollbarTheme provides a Mac-only API which is called
into from content, and affects the styling of all scrollbars. After
this patch, all of the other scrollbar and scrollbar theme code can move
out of platform.

BUG=823365
R=skobes@chromium.org,chrishtr@chromium.org
TBR=dgozman@chromium.org

Change-Id: I888e08676b5343156ae391c44b2084e90023de0f
Reviewed-on: https://chromium-review.googlesource.com/1141116
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: default avatarSteve Kobes <skobes@chromium.org>
Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577102}
      3f8543e5
    • Darren Shen's avatar
      [VK] Remove unused friend declaration in KeyboardController. · ffcb250e
      Darren Shen authored 
      In a previous patch, we removed KeyboardLayoutManager's dependency
on KeyboardController's SetContainerType. This means that the friend
declaration in KeyboardController is no longer needed.

TBR=blakeo@chromium.org

Bug: 845780
Change-Id: I56ea22d989dcefc3bc70d4ca054678fd52c5bef7
Reviewed-on: https://chromium-review.googlesource.com/1146139Reviewed-by: default avatarDarren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577101}
      ffcb250e
    • Timothy Loh's avatar
      Use a proper icon for Crostini package install notifications · 3b1c2723
      Timothy Loh authored 
      This CL adds a vector icon for use in notifications for Linux packages.
Using a vector icon allows this to get blue/red colours automatically
to match the notification title color.

Bug: 822464
Change-Id: Ie21f437b8c65aefb8d5be4732e864f826445d361
Reviewed-on: https://chromium-review.googlesource.com/1143046Reviewed-by: default avatarEvan Stade <estade@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577100}
      3b1c2723
    • Darren Shen's avatar
      [VK] Observe changes to keyboard window in KeyboardController. · 3099beca
      Darren Shen authored 
      There are two ways for the keyboard window bounds to change. Either
through KeyboardController or through JavaScript / the IME extension.
Notably, we always receive a JavaScript bound change when initializing
the keyboard UI.

To handle bounds changes from JavaScript, we use a LayoutManager
to intercept those changes and forward them to KeyboardController.
In production, the LayoutManager is installed by ash::Shell.
In unit tests however, we do not always have this setup because the
test may not be able to depend on ash. Unit tests that load the
keyboard will simulate the initial JavaScript bound change, but because
there's no layout manager, KeyboardController does not receive the
update and gets into a bad state.

The current workaround is to manually add a LayoutManager to the
root window in tests that need it. This is not ideal, as the correctness
of KeyboardController is silently dependent on the construction of
a LayoutManager [*].

To fix this, we observe bounds changes to the keyboard window in
KeyboardController. Then, KeyboardController will no longer need the
LayoutManager to notify bounds changes; it can observe them directly.

[*] We didn't have this problem before because we could install the
layout manager on the keyboard container, which was part of the
KeyboardController. Since we got rid of the keyboard container, we can
only install the layout manager on an ash container, which is
external to KeyboardController.

Bug: 845780
Change-Id: I053778f04ab3ccf4d13fcd79d05832f9238b21b5
Reviewed-on: https://chromium-review.googlesource.com/1133607Reviewed-by: default avatarYuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577099}
      3099beca
  3. 22 Jul, 2018 13 commits
  5. 21 Jul, 2018 13 commits