GitLab

Starts shelf layout manager shutdown earlier at the beginning of shell
shutdown sequence (during OnShellDestroying call issued to shell
observers when the shell tear down starts).

The main goal is to prevent shelf state updates that might happen during
shutdown. For example, tablet mode controller destruction, and overview
controller destruction might cause window stacking changes, that in
turn can cause shelf state updates - both of which happen before
Shell::CloseAllRootWindowChildWindows(), which is from where
ShelfLayoutManager::PrepareForShutdown is currently called (with some
indirection).

NOTE: Calls to start shelf shutdown issued from
RootWindowController::CloseChildWindows() are kept around to handle root
window controller shutdowns that happen outside shell shutdown.

BUG=1033343

Change-Id: I86211392b45bdafd5f095bd60c774fe88e8accce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015358Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734253}

- Don't output repaint rects if PaintArtifactCompositor is not tracking
  raster invalidations.
- Rebaseline tests.

Bug: 648274, 757977, 765003, 842356, 931486, 937573, 1029620
Change-Id: Icdf154ca6cb39ead80e1b2aa7eaf71e1c3d941ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014177Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734252}

Implement the animation of the "Start" ("->") button on the Login
Screen for the users that use challenge-response authentication
(a.k.a. smart card login).

The animation is, in accordance with the UI mocks, a continuously
increasing arc around the button.

This change also removes the code that was hiding the "Start"
button - this is replaced by the animation.

Bug: 1016839
Test: log in as a smart card user, log out, click "->" to log in again, verify that the "->" button is animated with a continuously increasing arc
Change-Id: I77e830522c5a0770d583d661122cb3831fbb5390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005988Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734251}

Previous CL https://chromium-review.googlesource.com/c/chromium/src/+/1967804
doesn't fix the issue entirely. Looking deeper in this issue, it's
actually caused by ClientControlledShellSurface::UpdateBackdrop() can be
called on a dragged window (whose backdrop has been disabled (kDisabled)
when drag starts) to re-enable the backdrop.

This CL makes sure an ARC window with disabled backdrop mode won't be
modified.

Bug: 1027269
Change-Id: I4d138ddf17bbcee2ab07e1a5fb9785fc05b3fc0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981133Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734250}

Currently, DisplaySnapshot provides an API that says whether or not
privacy-screen is supported by the display.

This CL modifies this API so that querying the prop will return the
state; whether it exists or not, and enabled/disabled if does.

Bug: b/147451539
Test: display_unittests
Change-Id: Idf4b111f0325550907eebe676f51e705eb8dad2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007871
Commit-Queue: Gil Dekel <gildekel@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#734249}

This CL reduces the sizes of the expected-colors rectangles for the
Pixel_ReflectedDiv test so that it passes on Nexus 5. The result in
that device looks visually fine [1], but pixels along some edges are
slightly different than the expected color:

actual   = rgba(255, 130, 4, 255)
expected = rgba(255, 128, 0, 255)

Therefore, reducing the size of the test rectangles to avoid the edges is
reasonable.

[1] https://chrome-gpu-gold.skia.org/img/images/f357a4dd6c87c632ae787203fcc307fa.png

Bug: 1033279
Test: Same reliability test as in CL:1979059.
Change-Id: I1d7ed61f5d1c7c2cacacb45d2d72b363580cba9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015560Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734248}

Removes references to InkDropMasks not working on Windows, this hasn't
been correct for a long time. Also adds a TODO to replace existing
overrides with HighlightPathGenerator usage.

Bug: None
Change-Id: I3e3724a711b560677b44293f5856c1fce05bb115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015772Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734247}

-Updates intellij to 13.0.
-Adds commons-cli for standalone script.
-Adds Kotlin and jetifier to android_deps.

Bug: 896775
Change-Id: Ibccfda9574261f7f0cc49270bf8ff84a1ff0f5ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992352
Commit-Queue: benjamin joyce <bjoyce@google.com>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734246}

It is desirable (see https://crbug.com/1031119) to focus tab contents
when a navigation is triggered by dropping a link or a file onto the
browser window.

Before this CL, tab contents would be focused any time the OpenURL code
path is used, but not in BeginNavigation code path.  This meant that
dropping a local file (e.g. navigating to a file: URL) would result
in focusing the tab contents (possibly moving the focus away from the
omnibox), but other navigations (e.g. navigating to a https: URL)
would not affect focus.

After this CL any "drop" focuses the WebContents.

Bug: 1042271
Change-Id: Ib1db79faec6e32846747d1cde9a78450dc354b42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003079Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734245}

This is a reland of fe842ad4

Original change's description:
> Update and clarify view ownership for app-list views.
> 
> Bug: 648382
> Change-Id: I0d000accee686dd67b2db1e14cea20ff893835c5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001399
> Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732019}

Bug: 648382
Change-Id: I07aa57e7b497367fd5699bf997dc76c6f36f355c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012835Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734244}

A bunch of countries were being enrolled into the root organisation
during the online demo mode setup flow when they should be enrolled
into their own suborganizations. Fix this for Belgium, Canada,
Ireland, Italy, Luxembourg, Spain, and the United Kingdom. The
corresponding organisational units and admins have been added
already.

Bug: 1039934
Change-Id: I4945eb89db95b95d1c10795390b04a14c74f36af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006900Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734243}

chrome/browser/devtools/protocol/page_handler.cc depends on //components/subresource_filter/browser:browser.

c.f. https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/9894

[51956/72454] CXX obj/chrome/browser/devtools/devtools/page_handler.obj

In file included from ../../chrome/browser/devtools/protocol/page_handler.cc:8:
In file included from ../..\chrome/browser/subresource_filter/chrome_subresource_filter_client.h:13:
../..\components/subresource_filter/content/browser/subresource_filter_client.h(10,10): fatal error: 'components/subresource_filter/core/mojom/subresource_filter.mojom.h' file not found

FAILED: obj/chrome/browser/devtools/devtools/page_handler.obj
C: \b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long)
Change-Id: I49d4fad36a3340fb0df6a758c64f49d9ac1efc54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007807
Auto-Submit: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734242}

DirectlyCompositedImages in blink has a dependency on having compositing
information prior to the painting phase. This can't work the same way in
CompositeAfterPaint. We'll be moving support directly to cc, in which
we'll detect the situations under which we would have directly composited
images (i.e. some specific sets of paint ops within a paint chunk) and
adjust the raster scale appropriately.

Blink's usage always matches layer size and image size, due to the usage
of ReplacedContentTransform and directly setting the content layer
bounds. This means we can reuse the code to detect and compute raster
scale changes, where the current code is handling the case where (i.e.
attempt to use raster scale of 1). A future change will add support for
the paint op detection and set image sizes to non-matching values.

This change generalizes the directly composited image code to use the
image size rather than a boolean. Then use the ratio of layer bounds
to image bounds to determine the raster scale.

Bug: 875110
Change-Id: I4eb60f3f9b603b4e553104440695e13fc2fec43e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009368
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734241}

Fixes downstream desugar error after
https://chromium.googlesource.com/chromium/src/+/556c657dade824fd17dbb30bedbe002bc11ee9f9

Change-Id: I88e0f2661016129deb21dc49c91c91055f5fb94a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015668Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734240}

Bug: 922145
Change-Id: I435dcb8084f92c4c253e9c8356411263076b5b59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003563Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734239}

Bug: 1042757
Change-Id: I5e8bbe40e06176a5fb00d898b749074a1c3d65fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015785
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734238}

We currently have a C++ views object owning an Cocoa object which then owns a
bridge back into some other C++ interfaces. We can simplify this by having the
top-level C++ object handle those interfaces and leave the Cocoa object to
purely manage the SFChooseIdentityPanel.

This doesn't fix the https://crbug.com/987744 but is some cleanup along the
way. Before we add more cases to that logic, reduce the number of places we
spread that logic out.

This does result in some RunUntilIdle() calls in the tests no longer quite
waiting long enough, I suspect because the Cocoa event loop is involved. I've
switched them to specifically wait for the relevant object to be destroyed,
which seems more robust in general. It seems that was also the cause of the
lifetime mismatch in https://crbug.com/1041175 so now we don't need a WeakPtr.

Unfortunately the diff here is kind of hard to read. I had to reorder some of
the classes so they could refer to each other. (Note the old bridge object was
similarly interleaved between the @interface and @implementation.)

Bug: 987744, 1041175
Change-Id: Icccc9e18cdfc64444a6496748dc106be6233896a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978946
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734237}

The previous calculation was using rows / height when it needed to
use SubsampleSize().height. See VideoFrame::visible_data() for the
correct math.

Fixed: 1027442
Change-Id: I152680d6f940cc08b612be7e6ba0c03aae01a895
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013750
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734236}

While the account is removed, AuthenticationService::IsAuthenticated()
returns true while AuthenticationService::GetAuthenticatedIdentity()
returns nil.

This incoherent values make a DCHECK() in the UI failing. Both methods
need to be called in order to make sure the UI knows how to update
the view.

This is a quick fix. The real fix will happen with crbug.com/1044270

Fixed: 1033901
Change-Id: If8eb0a03341fb48eb3c47b5e673ea9d70e899d4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012944
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734235}

Tracking the actual duration of WebAuthn’s
IsUserVerifiablePlatformAuthenticatorAvailable() call. Supposedly extremely
quick, but could be good to confirm as a non-MVP metric.

Bug: 949269
Change-Id: Ia02cb8901830fc22c27378360972d3c91d1983b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993753Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#734234}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/527fd16079a5..c518c7f9fe9a


Created with:
  gclient setdep -r src-internal@c518c7f9fe9a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1039877
Tbr: jbudorick@google.com
Change-Id: I02caa3bbe4f7fd3ec14ba27b16de55836953089f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015022Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734233}

https://swiftshader.googlesource.com/SwiftShader.git/+log/1e8486b1739d..f324fe10ca65

git log 1e8486b1739d..f324fe10ca65 --date=short --first-parent --format='%ad %ae %s'
2020-01-22 sugoi@google.com Improve 565 and 5551 precision

Created with:
  gclient setdep -r src/third_party/swiftshader@f324fe10ca65

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I68fbf3a9390f18c0798e5f5120214e5130c6de00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015544Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734232}

While ACK decimation is not currently enabled by default,
it *is* enabled via experiments ubiquitously. This may cause
a regression in some perf tests, but those tests are not
running with the config used in production (with ACK
decimation enabled).

b/79972781

BUG=842677

Change-Id: Ie2729bd8c47f9d9781e5de6aa39379c740319976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015495
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734231}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/a32acc1be500..9ad78aa7dba2

git log a32acc1be500..9ad78aa7dba2 --date=short --first-parent --format='%ad %ae %s'
2020-01-22 rharrison@google.com Start v2020.0 (#970)
2020-01-22 rharrison@google.com Fix the version string (#971)
2020-01-22 rharrison@google.com Finalize v2019.1 (#969)

Created with:
  gclient setdep -r src/third_party/shaderc/src@9ad78aa7dba2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: Ia361fdd75bca63a2289eb72364aaba5ac8c446af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015447Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734230}

This CL updates generated files, reflecting changes in
https://chromium-review.googlesource.com/c/chromium/src/+/1991066.

Bug: 906850
Change-Id: I4dc79a2afc93e7a22c8c1cf83250d05876cc6103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993003Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734229}

For connections to localhost, ChromeDriver should test both IPv4 and
IPv6 formats to resolve issue where DevTools may not be listening on the
expected protocol.

Bug: chromedriver:3316, b/147285732
Change-Id: Iecbf8f4f1c8df6138fd8ef8d908217e760e13923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013892Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tricia Crichton <triciac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734228}

https://skia.googlesource.com/skia.git/+log/b19c78ebad84..4ca0dacbce51

git log b19c78ebad84..4ca0dacbce51 --date=short --first-parent --format='%ad %ae %s'
2020-01-22 kjlubick@google.com [canvaskit] Roll to 0.12.0
2020-01-22 kjlubick@google.com [canvaskit] Fix color opaqueness
2020-01-22 kjlubick@google.com [canvaskit] Fix colorType bug
2020-01-22 reed@google.com Revert "Revert "use SkM44 internally""
2020-01-22 fmalita@chromium.org [skottie] Cleanup: convert shape layer adapters to new pattern
2020-01-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-01-22 bsalomon@google.com Fix usage enum with GL_NV_pixel_buffer_object.
2020-01-22 bungeman@google.com Glyph 0xFFFF is a valid glyph.
2020-01-22 bsalomon@google.com Disable Programs test on TecnoSparkPro3 Debug test bot
2020-01-22 egdaniel@google.com Reland "Reland "Pass in a SkColorType into SkImage_Gpu ctor.""
2020-01-22 michaelludwig@google.com Add GrQuad::bounds() benchmark
2020-01-22 reed@google.com Revert "use SkM44 internally"
2020-01-22 mtklein@google.com add --dylib to fm
2020-01-22 reed@google.com use SkM44 internally
2020-01-22 csmartdalton@google.com Add a tessellation mode that triangulates the inner polygon separately
2020-01-22 herb@google.com Reduce error control flow in addGlyphToAtlas
2020-01-22 scroggo@google.com Make SkImageInfo::validRowBytes consider alignment
2020-01-22 bsalomon@google.com Rework spefication of src/dst rects/translates throughout SkGpuBlurUtils.
2020-01-22 brianosman@google.com Clamp GrSkSLFP output to valid premul
2020-01-22 bsalomon@google.com Add functions for GL_NV_fence to GrGLInterface.
2020-01-22 robertphillips@google.com Revert "Add compressed backend textures to Metal"
2020-01-22 reed@google.com remove fun operator overloads
2020-01-22 mtklein@google.com split SkBBoxHierarchy into public/base types

Created with:
  gclient setdep -r src/third_party/skia@4ca0dacbce51

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC benjaminwagner@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: benjaminwagner@google.com
Change-Id: I5d3deef4748a5fec14d02d52f0107498a21d87be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015451Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734227}

Update cros_healthd_probe.mojom to keep it in sync with the copy in
Chrome OS.

Bug: 1026848
Test: DeviceStatusCollectorTest.TestCrosHealthdInfo
Change-Id: I7b35f6668f0f2627976c57f7a02cc22efeddbfd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013467Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734226}

This reverts commit 6cf710fa.

Reason for revert: This CL didn't cause the linked bug. That bug was a duplicate of crbug.com/1044520 which is now fixed.

Original change's description:
> Revert "WebApps: Implement unregistering file handlers on Linux."
> 
> This reverts commit 32a1f8bf.
> 
> Reason for revert: LocalNTPJavascriptTest failing on 7 builder(s)
> Fixed: 1044497
> 
> Original change's description:
> > WebApps: Implement unregistering file handlers on Linux.
> > 
> > This will allow us to disable the file handlers for an app on Linux
> > without uninstalling it. This is necessary preparation for the origin
> > trial, as we need to be able to disable/enable the file handlers as
> > the validity of the app's origin trial changes.
> > 
> > Bug: 1028448
> > Change-Id: I63eb6582852ff75d3d88181ede07f0cbd010df2d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010234
> > Commit-Queue: Jay Harris <harrisjay@chromium.org>
> > Reviewed-by: Alexey Baskakov <loyso@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#733859}
> 
> TBR=loyso@chromium.org,harrisjay@chromium.org
> 
> Change-Id: I67239e88d48df1d70ff1a432863b3be26d5d7bd4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1028448
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014352
> Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> Commit-Queue: Yoichi Osato <yoichio@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#733902}

TBR=yoichio@chromium.org,loyso@chromium.org,harrisjay@chromium.org

Change-Id: I5052bf84dc417f11325c51e9a584e13a585c46a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015901Reviewed-by: Jay Harris <harrisjay@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734225}

This follows a similar pattern to how tabs are moved left/right: https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_strip.cc?l=1591&rcl=3e23198594e08a63cc5e091e1eefe79e3dd48454

I deliberately chose not to support MoveGroupFirst() and MoveGroupLast(), since the implementation seemed too finicky and the feature seemed very niche. We can return to it if we decide it's higher priority for accessibility.

Bug: 1039921
Change-Id: Ifcd078d640a84fe96f15c41a38daa82a5090641c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006219
Commit-Queue: Connie Wan <connily@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734224}

Removes the util to test for visual signals feedback panel feature flag
being enabled and removes the ability to show the deprecated panels.

Covered by existing unit tests.

Bug: 1027012
Change-Id: Ia5d2d6536d51d2f31b702308eb5d4f91350b72f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014214Reviewed-by: Austin Tankiang <austinct@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734223}

This one part somehow escaped getting upgraded to the new Mojo names.

Bug: None
Test: Build
Change-Id: Icb4cc5a4c65429a026866e847288a92d0542dc69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015900
Commit-Queue: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Auto-Submit: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734222}

Some users of the script are not Chrome engineers and cannot
build trace_processor_shell

Bug: chromium:1044682
Change-Id: I40e904e3eccd6bc466241e66716683d7d4da6cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015103
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734221}

This change replaces the old time icon with the new material icon

Bug: 1021339
Change-Id: I1ae90a44e01c477097c19f0b94e4e3437a709233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014153Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#734220}

The Drallion (Wilco 1.5) keyboard has a slightly different layout than
Wilco 1.0:

1. The toggle mirror mode button has moved from F12 to its own key
without a corresponding F key.
2. F12 now shares a key with privacy screen toggle on devices with a
privacy screen.

BUG=b:147241224
TEST=build and deploy chrome to a Drallion DUT:
autoninja -C out_drallion/Release chrome chrome_sandbox nacl_helper;
deploy_chrome --build-dir=out_drallion/Release --to={DUT_IP};

Verify that top row keys map to expected key codes:
Privacy Screen -> VKEY_PRIVACY_SCREEN_TOGGLE
Privacy Screen + Fn -> VKEY_F12
Privacy Screen + Search -> VKEY_F12
Privacy Screen + Fn + Search -> VKEY_PRIVACY_SCREEN_TOGGLE

Mirror toggle key always maps to VKEY_MEDIA_LAUNCH_APP2 with Control
held down, regardless of Fn and Search key states.

Change-Id: I8df3d28d7ea9445d736ec831b4423f2c224dd592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008063
Commit-Queue: Mike Wiitala <mwiitala@google.com>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734219}

Secure DNS will be disabled in these windows, allowing users to
complete the captive portal resolution process.

Future cls will add additional conditions that will trigger captive
portal probes in secure mode.

Change-Id: I441d17465a9c9d11567775321ed3ddd8532598ab
Bug: 10161646
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984663Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#734218}

https://chromium.googlesource.com/catapult.git/+log/b9cc8d75a2ad..bc9b29411747

git log b9cc8d75a2ad..bc9b29411747 --date=short --first-parent --format='%ad %ae %s'
2020-01-22 bsheedy@chromium.org Workaround CrOS root partition read-only

Created with:
  gclient setdep -r src/third_party/catapult@bc9b29411747

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC nuskos@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1043953
Tbr: nuskos@google.com
Change-Id: I660987f0c6598ee82936ed502ed292ba108a607f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015542Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#734217}

This is the first file to be moved into the new flags module.

This is CL 3/3 to move ChromeFeatureList to chrome/browser/flags:java

Bug: 1041468
Change-Id: Ie52917a32896d7ee721c4b2278fa7bc6884b417d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007315
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734216}

In ImageResourceContent, |observers_| and |finished_observers_| can both
contain an |observer|. Therefore, in RemoveObserver(), if removing from
|observers_|, it's only fully removed if it does not exist in
|finished_observers_|.

Bug: 1041707
Change-Id: Ia21f21627d62e19788216cfc010715646ee4842d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011137Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734215}

This is limited to bound WebAPKs. This is the first step to make WebAPKs
discoverable via getInstalledRelatedApps.

Bug: 1043970
Change-Id: I1cbb86159d15554c129894b6c405c1efefa42587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012287
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734214}