- 21 Nov, 2017 40 commits
-
-
gogerald authored
Made ServiceWorkerPaymentAppFactory singleton. Bug: 786116 Change-Id: I263edd64e7452a81f07011f1a7bda83e8b57c90e Reviewed-on: https://chromium-review.googlesource.com/774906Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#518442}
-
Henrique Nakashima authored
The values that are now accepted are: - view=Fit - view=FitH - view=FitV Bug: 64309 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1072e3dc895e4c21cd9823adac13a8c3cf5dcd90 Reviewed-on: https://chromium-review.googlesource.com/775153 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#518441}
-
Owen Min authored
Bug: Change-Id: Ib1f3a413560ba926cfb0bf1a4704b84f8ec69847 Reviewed-on: https://chromium-review.googlesource.com/780184 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#518440}
-
Ryan Sleevi authored
SSLSocketDataProvider is used to vend MockSSLClientSockets for unittests. It was originally just used to simulate the behaviour of Connect() with a given cert, but has since grown to include a number of additional fields that are then exposed via the StreamSocket::GetSSLInfo() interface. Rather than maintaining discrete fields on the SSLSocketDataProvider and adding more fields as they grow, just store an SSLInfo in the data provider so that any of the fields can be simulated. BUG=787574 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I03f5dd6241e38221067220e9547b1ea5052a539a Reviewed-on: https://chromium-review.googlesource.com/783256Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518439}
-
Albert J. Wong authored
This is a mechanical refactor moving all free functions that take PartitionRootGeneric as the first parameter into the PartitionRootGeneric struct. See related bug for more details on methodology. Bug: 787153 Change-Id: Ia95fc30ed030397303dc1999f4fdac8a72c01c9b Reviewed-on: https://chromium-review.googlesource.com/780759 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#518438}
-
Xiyuan Xia authored
DCHECK happens for AppWindowCreateFunction did_respond() when an AppWindow is closed before OnReadyToCommitFirstNavigation is invoked. This is because AppWindowCreateFunction respond is deferred until navigation is committed when PlzNavigate is enabled. Bug: 783903 Change-Id: I2d0ef5ee1611c869314a8c9fe07808235f6e318c Reviewed-on: https://chromium-review.googlesource.com/775902Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#518437}
-
Zhongyi Shi authored
with migrate back to default network support. We will not mark session as going away until consistent failure on migrating back to the default network with no platform notifications. This also handles packet write error. Bug: 774622 Change-Id: I9e9fa301d60d7a56c3d1b92af315932451e7db7a Reviewed-on: https://chromium-review.googlesource.com/777612 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Jana Iyengar <jri@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#518436}
-
Carlos Knippschild authored
This reverts commit a2ec7611. Reason for revert: This roll still does not include the fix for the build error on "chromium.win/WinMSVC64 (dbg)". This had to be manually adjusted to the last working commit. Original change's description: > Roll src/third_party/webrtc/ 202be3957..ed1023db0 (19 commits) > > https://webrtc.googlesource.com/src.git/+log/202be3957d95..ed1023db0eb8 > > $ git log 202be3957..ed1023db0 --date=short --no-merges --format='%ad %ae %s' > > Created with: > roll-dep src/third_party/webrtc > BUG=None > > > The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng > TBR=webrtc-chromium-sheriffs-robots@google.com > > Change-Id: I660131e50f90463ee04ddd62292b7858525a8b03 > Reviewed-on: https://chromium-review.googlesource.com/781366 > Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org> > Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518294} TBR=webrtc-autoroll@chromium.org,webrtc-chromium-sheriffs-robots@google.com Change-Id: I79ff7c5d777a62975b20ed5678f982b4e7f7d4ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 787192 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng Reviewed-on: https://chromium-review.googlesource.com/783850 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#518435}
-
Eugene But authored
PurgeCachedWebViewPages() is presumably fail to wait for pageload and -[ChromeEarlGrey waitForPageToFinishLoading] causes assert. Because PurgeCachedWebViewPages() is called multiple times inside a single test it's unclear where the bug actually happens. And the test only fails on bots, so the logs are the only way to debug the failure. This CL makes PurgeCachedWebViewPages() return bool, which pushes assert call up to the test, which should clarify the failure point. PurgeCachedWebViewPages() now uses chrome_test_util::WaitForPageToFinishLoading helper function, because -[ChromeEarlGrey waitForPageToFinishLoading] is not suppose to return bool result. -[ChromeEarlGrey waitForPageToFinishLoading] now uses chrome_test_util::WaitForPageToFinishLoading as well to avoid code duplication. Bug: 785025 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4e45d30394609825fe9974e0d4077918563295cc Reviewed-on: https://chromium-review.googlesource.com/780388Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518434}
-
Gabriel Charette authored
Taking advantage of the new kBoundToThread mode on TestMockTimeTaskRunner. This change also required tweaking the ScopedTaskEnvironment::RunUntilIdle() logic as RunLoop().Run() on TestMockTimeTaskRunner results in advancing time when there's no request to quit-when-idle which is undesired here. New logic gets rid of need for |on_queue_empty_closure_| and I think is simpler overall. As of patch set 20, this new RunUntilIdle() logic also avoids using TaskScheduler::FlushForTesting() as that can result in hangs should a TaskScheduler task synchronously block on the main thread. R=fdoray@chromium.org TBR=gab@chromium.org (IWYU fixes) Bug: 708584 Change-Id: I76ba55ec64d398151420379d3fcdcd5186fbceb8 Reviewed-on: https://chromium-review.googlesource.com/638550 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#518433}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/135c6601bd9d..7c986a085631 $ git log 135c6601b..7c986a085 --date=short --no-merges --format='%ad %ae %s' 2017-11-21 dsinclair Cleanup CXFA_FillData Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I74586a02f10a590e11c3f9af70f6c13021cdfc95 Reviewed-on: https://chromium-review.googlesource.com/783656 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518432}
-
Eugene But authored
This CL completes ios/web Download API implementation. Integration test will be landed in a separate CL. Embedder does not set DownloadController delegate yet, so this CL does not trigger the second download. Design doc: http://go/ios-web-download-api Bug: 780646 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icc9d5c5432a038237f80e7f35ddaa787dbb165fe Reviewed-on: https://chromium-review.googlesource.com/764890 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#518431}
-
Doug Turner authored
This CL creates a URLLoaderFactoryPtr based on the existing URLRequestInterceptor which fails the first N requests then begins allowing the loads. If the network service feature flag is not set, we fall back to just using the old URLRequestInterceptor. Relanding after adding common:interfaces to public_deps. Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If9cda1d728161a7067d8d2f4f8d88b06e55059c9 Reviewed-on: https://chromium-review.googlesource.com/782703Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#518430}
-
Justin Donnelly authored
See the following document for details: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk Bug: Change-Id: I49b7f3a00be777a88e5e6c86a4a582da94b917a9 Reviewed-on: https://chromium-review.googlesource.com/783641Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#518429}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/0a3adc0b0ad8..bff5a98cdfda $ git log 0a3adc0b0..bff5a98cd --date=short --no-merges --format='%ad %ae %s' 2017-11-21 jvanverth Disable tonal color for shadowutils GMs 2017-11-21 benjaminwagner Remove Skolo NVIDIA Linux bots. 2017-11-21 liyuqian Enable DAA for MSVC 2017-11-21 reed detect too many points 2017-11-21 brianosman Remove SampleApp and convert HelloWorld to sk_app 2017-11-21 update-skps Update SKP version Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Icee96a2df8edffec8cef60247ef4fc13c0f56ac7 Reviewed-on: https://chromium-review.googlesource.com/783270Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518428}
-
Evan Stade authored
NotificationPlatformBridge for TRANSIENT notifications until such time that platform bridges can be updated to handle TRANSIENT notifications via their delegates. This should not have any immediate effect as would-be TRANSIENT notifications do not use NotificationDisplayService yet, but it allows them to be updated to use NDS while the platform bridges are still a work in progress. Bug: 783018 Change-Id: I224da7b03172152fbd9a5ee2cd4d5017a4de5f74 Reviewed-on: https://chromium-review.googlesource.com/779067Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#518427}
-
Francois Doray authored
Analysis showed that MRU was as good as engagement score to choose which tabs to discard. The new plan is to build a machine learning model to choose which tabs to discard. Bug: 775644 Change-Id: If85f0911d158201190bcb15f4b865c644c6426b4 Reviewed-on: https://chromium-review.googlesource.com/779081 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#518426}
-
Darren Shen authored
The spec has changed StylePropertyMap's IDL. StylePropertyMap.append and set now take a variadic number of (CSSStyleValue or Strings). This patch changes the IDL and updates the implementation. Bug: 785132 Change-Id: I502abbd369bea20853e68f434f3c96dc6437a892 Reviewed-on: https://chromium-review.googlesource.com/768330 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#518425}
-
Koji Ishii authored
This patch adds the function to find containing LayoutObject for absolute positioned objects in the current inline formatting context. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8f576a49376f9828ca75ee4def4358e7d4a0ee2f Reviewed-on: https://chromium-review.googlesource.com/783290 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#518424}
-
Sidney San Martín authored
Bug: 787571 Change-Id: Id7f2533890ca493b4eb6bee16cd6cdbee475554c Reviewed-on: https://chromium-review.googlesource.com/783750 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#518423}
-
Shubhie Panicker authored
The flag was added in cl/734165, but did not restrict to Android, we want to run the intervention only on Android. Bug: 763573 Change-Id: I180c32992ef4a36cec616e33d59b418305500265 Reviewed-on: https://chromium-review.googlesource.com/780691Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Shubhie Panicker <panicker@chromium.org> Cr-Commit-Position: refs/heads/master@{#518422}
-
Lei Zhang authored
Various RootDirectory test cases exist to make sure browsing file:/// works. However, this action is not allowed on Android, so it is a slight mystery how the tests manage to pass on earlier version of Android. The tests fail under newer version of Android. Given this situation, just disable the tests on Android altogether, as it is pointless to test a disallowed action. Also combine the test cases which are very similar into a single test case with a for-loop. BUG=787149 Change-Id: Icec5ed676b245519ae98e8914b397122d5c7bbd5 Reviewed-on: https://chromium-review.googlesource.com/780921 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#518421}
-
Philip Rogers authored
This patch fixes a bug in where japanese-rl-selection-clear.html was rebaselined incorrectly: https://chromium.googlesource.com/chromium/src/+/cc645ca3adb300e03f222bb239aa9b40b35f0719 Bug: 781419 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: I6c35947c11e912da420f217f6b0c71b568bb324e Reviewed-on: https://chromium-review.googlesource.com/783652Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518420}
-
Miguel Casas authored
This CL moves the Jpeg decode accelerator-related files from their locations in //media/gpu/ipc/{client,service} and //media/gpu/mojo into //media/mojo/{clients,interfaces,services}. This follows up on the TODOs in [1,2]. Most of the updates are fully automatic using tools/git/mass-rename.py. Bug: 699255 [1] https://cs.chromium.org/chromium/src/media/gpu/ipc/client/gpu_jpeg_decode_accelerator_host.h?dr&l=22 [2] https://cs.chromium.org/chromium/src/media/gpu/ipc/service/gpu_jpeg_decode_accelerator.h?dr&l=21 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0ed7f94f1bfc258756293cde6bdd228e6f0197c7 Reviewed-on: https://chromium-review.googlesource.com/778000Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chandan Padhi <c.padhi@samsung.com> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#518419}
-
Jay Civelli authored
On non Windows platforms, the none_and_elevated sandbox type specified in a service manifest would default to utility sandbox. It now defaults to "no sandbox". It used to be only used on Windows specific services so this was not an issue, but an upcoming non-platform specific service will need it. Bug: 787560 Change-Id: Id2370735257a89f7588243be439c97c4769c7429 Reviewed-on: https://chromium-review.googlesource.com/782718Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#518418}
-
Jiaquan He authored
The interface is not used. Bug: 733662 Change-Id: I06667c7d5880bbe7bd1f82c69a8c3184625096fa Reviewed-on: https://chromium-review.googlesource.com/783653Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#518417}
-
liberato@chromium.org authored
This CL causes MCVD to use the Cdm that's provided for secure content. It requests a secure codec when needed, and a secure output surface. Bug: 760821 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I11ac076d729913b0c8b76d9f5133af8ea3f11c09 Reviewed-on: https://chromium-review.googlesource.com/779620 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#518416}
-
Chris Palmer authored
Bug: None Change-Id: I9b44ae7340a4cc7473924d49ad03bbdac0420675 Reviewed-on: https://chromium-review.googlesource.com/780881Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#518415}
-
Kenneth Russell authored
The slaves will be reclaimed in a follow-on CL. BUG=786737 TBR=jmadill@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I006c57e228f02854c848c570cdffc8c09782b0f9 Reviewed-on: https://chromium-review.googlesource.com/781206 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#518414}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/378734c51221..4f407ce208e2 $ git log 378734c51..4f407ce20 --date=short --no-merges --format='%ad %ae %s' 2017-11-21 jmadill Fix Clang dEQP build on Win. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I8b870e82afb00d2b129667bb1f5cb51b592b1173 Reviewed-on: https://chromium-review.googlesource.com/783273Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518413}
-
Jose Dapena Paz authored
For choosing the ATK interfaces to support, AXPlatformNodeAuraLinux was retrieving AtkRole, but it was comparing it with AXRole values, so it was assigning wrong interfaces to roles. Bug: 784583, 787371 Change-Id: Iad114c07e3e6860449b81771cb5d2808903fe603 Reviewed-on: https://chromium-review.googlesource.com/781761Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#518412}
-
Tom Sepez authored
Stop trying to match which syscalls are present based on compiler flags since we already know this via which symbols are defined in the system_headers/*_syscalls.h file. Add a macro for msan poisoning to reduce nesting of ifdefs. Use early returns to avoid "else considered harmful". Change-Id: Ic37cd41037bba11ebd25c8326d8e3db115b58254 Reviewed-on: https://chromium-review.googlesource.com/783332Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#518411}
-
Francois Doray authored
A TabLifecycleUnit represents a tab. The implementation will be in a separate class (TabLifecyleUnitImpl) because we want to expose only part of the it outside of chrome/browser/resource_coordinator/. E.g. the extensions system is allowed call: TabLifecycleUnit::FromWebContents(contents)->Discard(condition); but we don't want it to change the TabStripModel associated with a tab (TabLifecycleUnitImpl::set_tab_strip_model()). Bug: 775644 Change-Id: Idf2ad85bf2969871be1dc09eb1eb3776bc922959 Reviewed-on: https://chromium-review.googlesource.com/774979Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#518410}
-
bsheedy authored
Makes testPoseDataUnfocusedTab resilient to flakes caused by poses not being available on the first requestAnimationFrame. Bug: 787196 Change-Id: I77f29b040ae35890961221735637740334a255e4 Reviewed-on: https://chromium-review.googlesource.com/782145Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#518409}
-
Victor Miura authored
PaintCanvasVideoRenderer::CopyVideoFrameSingleTextureToGLTexture runs TexImage2D without first binding the target texture. This could result in the clobbering of other textures. BUG=787333,710673 Change-Id: Ieff4c3f6068ad3682b3bd356491b6979624dfd66 Reviewed-on: https://chromium-review.googlesource.com/781422Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#518408}
-
Christopher Cameron authored
If HDR is requested, DCHECK that RGBA_16F is supported. R=geofflang TBR=zmo Bug: 784536 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib775c15c8a0a0d4f89c33f408c3dede2907d49ce Reviewed-on: https://chromium-review.googlesource.com/779865Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#518407}
-
Xiyuan Xia authored
- Only MarkSinglePopupAsShown of already shown pup-ups; - Make LoginStateNotificationBlocker to defer showing notifications until the active user PrefService is initialized. This allows Shelf to apply user prefs first so that WebNotificationTray does not HidePopupBubble when user PrefService is initialized sometime later after session state changes to active; Bug: 721717 Change-Id: I86e9978be7b56e92ce847f0086a5fa2e4f6b72db Reviewed-on: https://chromium-review.googlesource.com/782359 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#518406}
-
Francois Doray authored
A LifecycleUnit represents a unit that can switch between the "alive" and "discarded" states. When it is alive, the unit uses system resources and provides functionality to the user. When it is discarded, the unit doesn't use any system resource. Bug: 775644 Change-Id: I32dcf6a2a5a06919154ebcc48a73f88eecca9a8c Reviewed-on: https://chromium-review.googlesource.com/773078Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#518405}
-
Reid Kleckner authored
All bot names with "tester" in them will be removed after this build config change goes live: https://chromium-review.googlesource.com/c/chromium/tools/build/+/782619 R=dpranke@chromium.org, hans@chromium.org NOTRY=true Bug: 587879 Change-Id: I8448b6000b66fa24091040f57371091f1a138af8 Reviewed-on: https://chromium-review.googlesource.com/783518 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#518404}
-
Christopher Grant authored
The /ui/android:ui_java dependency doesn't appear to propagate from the test library to executable targets that need it, so explicitly include ui_java in the Pixel tests as was done for unit tests. BUG= Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I943e24cc0230764c05857501ac3047e7c71b0970 Reviewed-on: https://chromium-review.googlesource.com/783150Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#518403}
-