- 14 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3a3e7d4dd2bc..9f4ab98d1264 git log 3a3e7d4dd2bc..9f4ab98d1264 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 jmadill@chromium.org Return angle::Result from more label functions. Created with: gclient setdep -r src/third_party/angle@9f4ab98d1264 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I9d6e721bd793f0b9157baa8aca3da44e4f7401a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057369Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741518}
-
Aaron Krajeski authored
With deferral enabled we can get a lot of resource thrash when intermediate canvases and contexts are created, updated and drawn to a target canvas multiple times in a tight loop. Add a perf test for this. Bug: 1049491 Change-Id: I360ed39a36027bd6efafddee5582a64b90eb3ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053727Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#741517}
-
Monica Basta authored
Adding a mechanism to compare images by an identifier which is the GAIA picture url with size. This avoids overriding the image and sending uncessary |OnProfileAvatarChanged| while the image is the same. Bug: 1050375 Change-Id: Ie5cdc58d1f18e256c8560cf2b87552d47c3c8bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055083 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#741516}
-
Manu Cornet authored
Bug: 1050788 Change-Id: I462618ca7f4f4486502ecbd3d89be557f6a71c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057088Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#741515}
-
Wez authored
Remove logic from update-sdk.py for cleaning up the Fuchsia SDK from the old download path, since it has been ~years since we migrated. Replace all use of print() with logging.info() and set default logging level to logging.INFO. Bug: 1050703 Change-Id: I816d68988506fd6d5c7b98514048b41c34ab550f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056809Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741514}
-
Matt Jones authored
TBR: dullweber@chromium.org Bug: 1052395 Change-Id: Ieecc844418eb9b3ff976306d6af97768351719e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057152 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#741513}
-
Hongchan Choi authored
This is a preparation work to implement the synchronous stopping in AudioDestination::Stop(). Bug: 1048351 Change-Id: Ib15da752f41e07ccdb810609140371dd9ee7a2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042368 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#741512}
-
Dave Tapuska authored
Add a use counter to track usage of feature. BUG=961448 Change-Id: Ic8166b6b1e23df166024f6db5c51b894fbbd03ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056490Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#741511}
-
Adrienne Walker authored
This can't happen right now, but will be needed when the storage service restarts. Bug: 1015214 Change-Id: I51de219204847310f2b3238c104dea97dc72909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055384Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/86fbe04c6633..c4243361bbb6 git log 86fbe04c6633..c4243361bbb6 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 maruel@google.com [lucicfg] Update in depot_tools to 1.12.2 Created with: gclient setdep -r src/third_party/depot_tools@c4243361bbb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051164 Tbr: agable@chromium.org Change-Id: I849f65990e9018b292be045c8fb3e9253ffc066a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057370Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741509}
-
Becca Hughes authored
Stores artwork URLs associated with the media session and loads them too. BUG=1024379 Change-Id: Ie3f4951da24a57c6e1ba9658ee8e35941e08f845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055686 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741508}
-
shrekshao authored
Bug: 1052344 Change-Id: I411fb5250ade492857a5c57e39324ca98300a75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057110 Commit-Queue: Shrek Shao <shrekshao@google.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#741507}
-
Carlos IL authored
Sets the feature to enabled by default and removes the config from fieldtrial_testing_config.json in preparation for launch. Bug: 1025276 Change-Id: Iffcdd2153491de25b7038a609776255bbdacf2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053024 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#741506}
-
Ben Joyce authored
To update to androidx, we run the "jetify" script on all targets passed to process_java_prebuilt. This converts all references in the jar to androidx without having to modify the source code. This also allows us to not have to check in third_party jars that reference androidx, such as the gms libraries. To compile with the androidx dependencies with the android_support_library references still in the code, we modified the java groups in android_deps/BUILD.gn to have the dependency target depended on androidx, but use the old support library as an input_jar. All the resources (such as layout.xml files) need to be converted to androidx too, which was done in another CL, this CL just activates that feature in compile_resources.py Bug: 896775 Change-Id: Ib53c670b53145999ca57eebd4905e8f22684de67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830506 Commit-Queue: benjamin joyce <bjoyce@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#741505}
-
Stephen Chenney authored
This method is empty for all cases. Bug: 1042141 Change-Id: I449c83c533fa0f1593279a29f71bb019d49d8fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056925 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741504}
-
Tobias Sargeant authored
If chrome is disabled for a secondary user on N-P, then the package from which we loaded webview will still have a BuildInfo that reflects the fact that chrome is the provider, but crashpad isn't able to load the PackageInfo for it, unless it passes MATCH_UNINSTALLED_PACKAGES, since the package appears to be uninstalled for the secondary user. Bug: 1052371 TBR: jperaza@chromium.org Test: manual test following steps in bug Change-Id: I49364bf3f3addb482492a9a2d1c6cdae6b360ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057305 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741503}
-
Fredrik Söderquist authored
Bug: 658305, 968791 Change-Id: I2ffeb070e420d770cf80dbd5dcc9ee97ce9e7bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054187 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#741502}
-
Alexander Timin authored
https://crrev.com/c/2023688 removed automatic enabling of IsProactivelySwapBrowsingInstanceEnabled() when back-forward cache is enabled. However, a bunch of tests check IsProactivelySwapBrowsingInstance and have different expectations based on that. Explicitly enable ProactivelySwapBrowsingInstance (which is a no-op behavioural change when bfcache is enabled) to ensure that the tests have the correct expectations. R=fergal@chromium.org,jbudorick@chromium.org CC=bfcache-bugs@chromium.org BUG=1048097 Change-Id: Ia21d15c1ea79868fcd91a51168bbc16487ca6407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035982Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741501}
-
Peng Huang authored
The issue is because y-axis doesn't match in SkiaOutputDeviceBufferQueue and GLSurface implementations. Fix the problem by unifying them. Bug: 1050992 Change-Id: I0aeac10f0c005547d9a2e43ec87f27e3851cfac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050680Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#741500}
-
Jan Wilken Dörrie authored
This change modifies PasswordAutofillAgent::TryToShowTouchToFill to not trigger Touch To Till in case only fallback data is available. This prevents TTF from triggering on sign-up forms, when the user already has a credential stored. Bug: 1050946 Change-Id: Ie25c6f86335601ba37c705e3c6a9d5c6b0fb418f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057067Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#741499}
-
Roman Aleksandrov authored
Don't call NotifyAccessibilityEvent on the view being destroyed. Bug: 1049414 Change-Id: I06c2a9b24a0f03a948582d9706ae4917e2301a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057068Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#741498}
-
Manu Cornet authored
* No need to call |UpdateLayout| on the delegate in |Initialize| since that will be called as part of |UpdateAfterShelfAlignmentChange|. * Return early when updating the layout and nothing has changed. * Reuse the same animation parameters (duration, tween) from the shelf for the systray animation. * No need to call |StopAnimating| before starting a new animation as that is handled by the preemption strategy. Change-Id: Ia87edfe71597159fbe7d063a600ac84ba35f5e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055358 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#741497}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d249a8cf..c55cadc7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I09cdf9abfddcf75dd4d0fe63e3a1e9a20e0b4b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056645Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741496}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/65862c545fec..c53ba5018faa git log 65862c545fec..c53ba5018faa --date=short --first-parent --format='%ad %ae %s' 2020-02-14 tvanderlippe@chromium.org Only consider module.json files for remove unused globals 2020-02-14 tvanderlippe@chromium.org Remove typedefs from data_grid-legacy.js 2020-02-14 tvanderlippe@chromium.org Remove typedefs from changes-legacy.js 2020-02-14 tvanderlippe@chromium.org Remove typedefs from common-legacy 2020-02-14 tvanderlippe@chromium.org Fix usages for Common.DeferredContent typedef 2020-02-14 tvanderlippe@chromium.org Fix imports for Common.Event typedef 2020-02-14 tvanderlippe@chromium.org Fix internal bindings in ui/ 2020-02-14 tvanderlippe@chromium.org Fix internal bindings in sdk/ 2020-02-14 khamu@microsoft.com High contrast work for treeoutline. 2020-02-14 jacktfranklin@chromium.org Create `StringUtilities` module and migrate `escapeCharacters` Created with: gclient setdep -r src/third_party/devtools-frontend/src@c53ba5018faa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1048378,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2abbcf084fb8f38c9bda91e94a8f91cfb2eb0ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057056Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741495}
-
Avery Musbach authored
Multi-display dragging was not accounted for in https://chromium-review.googlesource.com/c/chromium/src/+/2039140 Test: ash_unittests All/SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.MultiDisplayDragging/0 Bug: 961170 Change-Id: I9db1c280702e0197d24d4e18c8d4c7d441999061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055808Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#741494}
-
Fredrik Söderquist authored
This bug was closed ~3 years ago with the claim that the issue had gone. Expose this statement to the real world. Insert the <img> dynamically since otherwise it might be picked up by the preloader (which may not see the settings changes). Bug: 467635 Change-Id: I12859f45e8aa7d3013cb572c390685c147342852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054561 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#741493}
-
Alex Leung authored
Removes unnecessary dependency on //media when converting between AudioConfig and AudioDecoderConfig for IPC. Merge-With: eureka-internal/363692 Bug: b/149422033 Change-Id: I646e5b6d53a4d7a13329d39f0dffc554219492ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055583Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#741492}
-
Etienne Bergeron authored
The default system font can be changed by the user to has styles. If so, the GetFontFallback should try the unstyled version. The primary font was initially tried and failed to Shape the runs. The unstyled version returned by GetFallbackFont(...) was not tried since the primary font has the same name. GetFallbackFonts(...) was able to find a candidate, but with an higher cost. To fix the issue, we keep track of the raw SkTypeface that are tried. ShapeRunWithFonts is using the typeface to determine the coverage of a run. This issue was found by adding a DCHECK(false) when GetFontFallbacks(...) succeed to find a font. It is also observed in the field in the slow-reports. bug: 995789 R=robliao@chromium.org Change-Id: I5b6b7eada35b11306edf0820e5635d5159efdcaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994443Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741491}
-
Natalie Chouinard authored
This is a reland of 0db01e1d with additional deps added to //chrome/browser/nfc/android:test_support (see Patchset 2). Original change's description: > [Android] Move NfcSystemLevelSetting and modularize NFC code > > NfcSystemLevelSetting is not a shared class used by multiple Settings > screens, so move it out of the org.chromium.chrome.browser.settings > package to org.chromium.chrome.browser.nfc instead. > > Since the classes in org.chromium.chrome.browser.nfc are fairly trivial > to modularize, organize and build to a separate target in > //chrome/browser/nfc as part of go/chrome-hoa efforts. > > Bug: 1052056 > Change-Id: Ia402340b05596ad880f16aef9521003658c1e2a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032785 > Commit-Queue: Natalie Chouinard <chouinard@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741173} TBR=blundell@chromium.org,twellington@chromium.org,yfriedman@chromium.org,pnoland@chromium.org,wnwen@chromium.org Bug: 1052056 Change-Id: Ia03ce9e6c26165615ec9b55646acb6785992c872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055427Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#741490}
-
Monica Basta authored
Add |last_downloaded_image_url_with_size| to |AccountInfo| as well as |kLastDownloadedImageURLWithSize| to |AccountTrackerService|. The goal is to have an identifier to the last downloaded image. |AccountInfo.picture_url| can not be used since it points to the picture related to the account but it does not necessarily map to the current image, that can happen while fetching a new image or failure to fetch. The |AccountInfo.picture_url| is set on |UserInfoFetch| while the |last_downloaded_image_url_with_size| is strictly set when the image is set. This is useful to avoid re-fetching the image every refresh period (currently 24 hours) while the user has not changed their account GAIA image. Change-Id: Ic60c20a9caaf13415c045d11c34ecd9a60fc525d Bug: 1050643, 1050375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834190 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#741489}
-
Etienne Bergeron authored
This CL is adding unittests for some basic scripts on MacOS. Previously, on MacOS, an empty array of test candidates was used. We are adding some of basics languages. Bug: 1022455 Change-Id: I5f1e32feb40cc6c3a6bf22f96821b9e78ceb3906 Fixed: 5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001142 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#741488}
-
Alison Maher authored
This change avoids breaking after leading floats in the case where there is a text indentation. Doing so fixes the following scenario: <div style="width: 100px; text-indent: 40px;"> <div style="float: left; width: 60px; height: 10px;"></div> <div style="display: inline-block; width: 60px; height: 20px;"></div> </div> In the above example, the following steps will happen: 1. The inline div will attempt to fit on the same line as the float. It does not, and a new line opportunity will be created on the next line. 2. The inline div overflows this new line opportunity due to the indent. 3. HandleOverflow() checks if the previous element (ie. the float) can break after. The float can, so it will attempt to rewind. 4. This causes a break in a later DCHECK. Not allowing breaks after leading floats in the case of an indentation fixes the above issue, and appears to match the behavior of other browsers. Bug: 1014247 Change-Id: Icf551f5908a0fcb8e0b80a8b9329c965435dd805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896509Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#741487}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46b98e70c127..0bdce0f5115d git log 46b98e70c127..0bdce0f5115d --date=short --first-parent --format='%ad %ae %s' 2020-02-14 taylori@google.com Merge "perfetto-ui: Fix null track group labels" 2020-02-14 taylori@google.com Merge "perfetto-ui: Fix marked area selection" 2020-02-14 fmayer@google.com Merge "Add test for flamegraph using synthetic example." 2020-02-14 fmayer@google.com Merge "Detect unfinished heap profiles / graphs." 2020-02-14 primiano@google.com Merge "TraceProcessor: add ninja log parsing" 2020-02-14 primiano@google.com Merge "UI: Show confirmation when opening trace from untrusted origins" 2020-02-14 hjd@google.com Merge "Do not compress large packets in ZipPacketWriter" Created with: gclient setdep -r src/third_party/perfetto@0bdce0f5115d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I93d3907a8489f6f88196e9a7703ef17a1fd6b46c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741486}
-
Charlie Hu authored
This CL let document policy use default value when not specified in header. This CL also lets static content such as about:blank/about:srcdoc to always fulfill required document policy so that they are not blocked. Change-Id: I14bf7d114fcd838f92ae91f773bde944f65f2c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039972 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#741485}
-
Xida Chen authored
This CL inverts the meaning of the current throughput metrics. That is, after this CL, 0% means the best throughput and 100% means the worst throughput. Bug: 1048780 Change-Id: I3c2edc21044dd5ad445c33b1adbebd653c3b87ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037836 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#741484}
-
Paul Moy authored
Add a new device command to get a list of available diagnostics routines from the device. --gtest_filter=DeviceCommandGetAvailableRoutinesJobTest.* Bug: chromium:1049762 Test: unit_tests Change-Id: Ia2299e21f84db5f8504538eee549296ae3e1fb79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042141Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Paul Moy <pmoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#741483}
-
Matt Jones authored
TBR: ayui@chromium.org Bug: 1052385 Change-Id: I8440eb11961a304fa43f7084103993afbf65a2e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056491Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#741482}
-
Scott Violet authored
Prior to this the executable name was an empty string. This is problematic as the executable name is written to a file followed by the command line args. If the executable name is empty, it means the first argument is treated as the executable name, which effectively means what should be the first argument is not seen as an argument to weblayer. BUG=1052173 TEST=covered by wpt Change-Id: Icac6504e7174582a1744d23079b193b6da6a40e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057085Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#741481}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f46f19b98c0d..06265e017f9e git log f46f19b98c0d..06265e017f9e --date=short --first-parent --format='%ad %ae %s' 2020-02-14 benjaminwagner@google.com [presubmit] Use bin/gn rather than depot_tools gn 2020-02-14 benjaminwagner@google.com [infra] Move Swiftshader to MEDIUM GCE machines 2020-02-14 robertphillips@google.com Carve some helper functions off of GPUSink (take 2) Created with: gclient setdep -r src/third_party/skia@06265e017f9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: I95544fba46af858c16fbda69b081e310e1ba436a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057060Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741480}
-
Ayu Ishii authored
Bug: 1007698 Change-Id: I29a41f219a9e8780611b76ab7195ae23120d5365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055383Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#741479}
-