- 02 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7f0e83e82ba9..5b5abd79106a 2020-10-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fa57522d..9a738068 (812874:813008) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe958a1712681dc3de14a872052dac5d9def2ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813073}
-
Yuzu Saijo authored
This CL makes a page bfcache-eligible when WakeLock is released. Bug: 1039569 Change-Id: Ie951c5db8eaf0f08c0ff5dd27742c1ac7cf1b8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428504 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#813072}
-
Maggie Chen authored
A new feature switch DirectCompositionUseOverlayDamageList is added to enable the new method that removes the overlay damage from the root damage to get the final optimized damage rect. This CL also adds a new histogram GPU.DirectComposition.DCLayer.OverlayCount which records the total number of overlays we are going to present in the DC overlay processor. Bug:1117235 Change-Id: I1fb97d8b4fd96270ff6447b63ad86785d60c2eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416966 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#813071}
-
Leo Zhang authored
This test failed a few times recently in linux-chromeos-rel, which blocked chromium.chromiumos. Disable it now. TEST=autoninja build content_browsertests successfully Bug: 1134455 Tbr: goto@chromium.org Change-Id: I10b6d7e6648491a9d1b3bc9ebe4724044ee7bb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444610 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#813070}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/444cee2905f5..fbeee8fe0c0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: noel@google.com Change-Id: I2e4731e059f3cfaf123ad2cf43ae56fda367ca72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444733Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813069}
-
Kenichi Ishibashi authored
ServiceWorkerStorage had two PurgeResources() methods but only one is used. Remove unused one. Bug: N/A Change-Id: Ie53a804cde9dac815e93106e7462faa349f337f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444769Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#813068}
-
Patrick Noland authored
This CL encapsulates MenuButton animations behind its coordinator. This is accomplished in two different ways. The url focus animation uses new, property model-targeting Animators instead of operating directly on the view. The TabSwitcher animation is effectively just moved to the coordinator, enabled by moving translateCanvasToView to ViewUtils. Bug: 1086676 Change-Id: I0da3feba45aa009ceff9fad1113d90ef314fcc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414768 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#813067}
-
Matt Falkenhagen authored
The comment referred to deprecated_has_html_body_ which was removed in r567510. Change-Id: I62b8c521b70ed1b9121256338a7db5714d84359c Bug: 794073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444630 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#813066}
-
Vincent Boisselle authored
Bug: 1131172 Change-Id: I2dcca0a7dcecabdd3b8a527e6af4de3f1481dae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443691 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#813065}
-
Kent Tamura authored
- 'Layout' in some items were redundant - Remove unused kLayoutObjectLayoutInline and kLayoutObjectLayoutEmbeddedContent - kLayoutObjectTextArea and kLayoutObjectTextField were not matched to C++ class names. This CL has no behavior changes. Change-Id: Iff8c84234cd264340074d474ba069f605b3e657a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444670 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#813064}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I9b20a18690f4cf3c7b0b58cdf88ba798e4800d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444534Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813063}
-
David Bokan authored
This is a big "many-cases-in-one" test that takes several seconds to run. It appears to occasionally timeout when run as part of web tests. This adds the test to SlowTests. Bug: 1133836 Change-Id: I5a6408ac69228f50e35eb6ec63bd84bc95554dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443542Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813062}
-
Hyunjune authored
When image contained mask is loading, it touches a mask flag called |computed_invalidation_mask_|. Because |MarkForLayoutAndParentResourceInvalidation| is called in |ImageChanged| without layout while loading, so this flag would be changed without clear. And this flag is used in the next layout. Actually this mask can not apply to client element in next time. This patch clears the mask flag in pre-paint time. Bug: 1086070 Change-Id: I55a7a16faafe4eeefac88e8e15e6d3b18b097acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432151Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#813061}
-
Alan Cutter authored
This CL updates our preinstalled web app replacement flow to disable the web app if the Chrome app it's meant to replace has been disabled by admin policy. This is to prevent default apps appearing on enterprise devices during web app migration when they were originally being blocked as Chrome apps. Bug: 1131338 Change-Id: I44a5d0c3c9b547c28a5c3b664e53844335ab3da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425549 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813060}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/3c3e8905ad7e..89ec3381ca3d $ git log 3c3e8905a..89ec3381c --date=short --no-merges --format='%ad %ae %s' 2020-10-01 nharper Remove unmatched clang diagnostic pop #pragma 2020-10-01 renjietang Rename QuicSession::OnStreamDoneWaitingForAcks() to MaybeCloseZombieStream(). 2020-10-01 bnc Pre-allocate storage in http2::HuffmanEncode(). 2020-10-01 wub Set initial self address for all server QUIC connections and client connections that know its own address. 2020-10-01 fayang Internal QUICHE change 2020-09-30 renjietang Remove QuicSession::stream_map_size(). 2020-09-30 fayang Explicitly specify the encryption level of processed packets in QuicConnectionTest. 2020-09-30 renjietang Reject HTTP/2 only frames in HTTP/3. 2020-09-30 bnc Use QuicheTest and quiche_test.h in third_party/http2. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: If12d7a76d4d04b8eff02b9bb8ac73f9238eec5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444369 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#813059}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b09f16ee7aeb..eb1df14b18a0 2020-10-01 jonahr@google.com Suppress MultisampledRenderToTextureBenchmark on Pixel2/GLES 2020-10-01 syoussefi@chromium.org Skip MSRTT tests on Nvidia/Windows7 2020-10-01 b.schade@samsung.com Vulkan: Change sampleCoverage calculation 2020-10-01 lehoangq@gmail.com Metal: Implement transform feedback If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1134286 Tbr: jonahr@google.com Test: Test: dEQP-GLES3.functional.multisample.fbo*sample_coverage* Change-Id: Ic0c7515d2db65c0059c08578fbd0d278069ba5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444160Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813058}
-
Noel Gordon authored
Linux Puppeteer startup in tests.js can sometimes crash. Fix this: add chrome --no-sandbox arg to send to the Puppeteer browser startup. Test: piex/tests.sh does not crash No-try: true Bug: 1132695 Change-Id: I27cccfdb0d49f46dcb07a343dfb474b0d9878331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442910Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813057}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601575120-46ddcdbe4da420985f324196a05692689b215d89.profdata to chrome-linux-master-1601596804-53a4ffa238a2dd27e204a4d6f101c3543de8d4a0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ib033a2bff33e97e7ea90f44a030556a107363881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444709Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813056}
-
Andres Calderon Jaramillo authored
This CL makes the SharedImageBackingFactoryGLTexture notify the GPU watchdog that progress is being made around the code that requests memory allocation or texture upload. This is an attempt to improve the crash rate due to allocation taking a long time (as opposed to it being a GPU hang). Bug: 1082197 Test: added unit test coverage. Change-Id: Ic9530fd53df95d5ce0b675231c0ac52e682c69e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215256 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#813055}
-
Xianzhu Wang authored
Previously rasterize_and_record_micro benchmark measured record time through ContentLayerClient::PaintContentsToDisplayList(), which had mismatched the reality when we switched to synchronized painting which is done as a step of document lifecycle update. It also didn't work in CompositeAfterPaint. Now measure LocalFrameView::RunPaintLifecyclePhase() for record times. It's called from the RasterizeAndRecordBenchmark through LayerTreeHostClient::RunPaintBenchmark(). GraphicsLayer now generates cc::DisplayItemList() during painting, so that it is included in the measured time, also is consistent with what we do in CompositeAfterPaint. Add two new metrics: - raster_invalidation_and_convert_time: it covers raster invalidation and cc::DisplayItemList conversion, which replaces the old record_time. - paint_artifact_compositor_update_time. 'record_time' now means differently than before. Previously it measured cc::DisplayItemList conversion (now measured by 'rasrter_invalidation_and_convert_time'). Now it measures time of forced painting without any invalidation. This is not realistic, but we can see how the caching algorithm work in nearly fully cached situation. Bug: 922642 Change-Id: Ic4e8e50288208f76df4e51ba154bc4a95c60f5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437735 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#813054}
-
Jimmy Gong authored
This is a reland of 3792c739 Reason for reland: This is safe to reland as the original revert was due a merge conflict with crrev/2428735 which has been reverted. This reland will land first. Original change's description: > Add additional states to FindMyDeviceController > > Fully implements the FindMyDeviceControllerImpl class. This change > also features a new state: kRingingNotAvailable. > This state is only set if the DoNotDisturb is enabled. > > Bug: 1106937 > Test: chromeos_components_unittests > Change-Id: Ifeb4dd88ea19ad6949bad2a92d840f392d7ccd47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438773 > Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812962} Bug: 1106937 Change-Id: Id8400f68f1980dc8288d7c1b2545810721844249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444410 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813053}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Ica70ae52f632e5f4236301aa557a5844cec4bb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436412Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813052}
-
Tal Pressman authored
The various AgentSchedulingGroupHost::Create* methods assume that the caller already called InitProcessAndMojos, so there is no need to call SetUpMojoIfNeeded from them. Instead, replace it with DCHECKs to make sure the process is initialized and the mojo remote is bound. Bug: 1111231 Change-Id: I95736b806adaabceae560131dd2a816dfc614f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437993Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#813051}
-
Jesse Schettler authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/d5ad6a50d168..5df72efed1de $ git log d5ad6a50d..5df72efed --date=short --no-merges --format='%ad %ae %s' 2020-09-15 fletcherw system_api: add scan dimensions to lorgnette API Created with: roll-dep src/third_party/cros_system_api Also, update the scanning mojom file and type converters to handle the new enum value in lorgnette_service.proto. Bug: None Change-Id: Ib425f99fdacaa85cd9559b567a2d5b15e61d02e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443271 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#813050}
-
Nate Fischer authored
No change to logic. This autogenerates GpuFeatures.java from the c++ feature definitions using java_cpp_features. This updates ProductionSupportedFlagList to depend on the new constant. This rewrites some feature definitions to conform to java_cpp_features's supported syntaxes. Fixed: 1132502 Test: autoninja -C out/Default system_webview_apk Change-Id: I9a5b562e7b034d5ed8606bff8dd218ca2d5e0790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432195 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813049}
-
Jie Jiang authored
This patch adds and implements the new interfaces/methods for Bluetooth socket. Compared with the old interfaces, the new ones: - add a sock_type field (RFCOMM or L2CAP); - pass Android socket flags directly instead of parsing those into BlueZ flags on Android side, to avoid expose two groups of constants in Android. Also marks the old methods as deprecated, which will be removed when the corresponding patch(es) are landed in both P and R. Android patch see: http://ag/12418518 BUG=b:163099156 TEST=manually tested on octopus with P to make sure the old code path for RFCOMM still works; also see the TEST line in Android patch for R. Change-Id: Ic35732e4e9ee6a45599f9aecd6b2695b60dd124a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366445 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#813048}
-
Jazz Xu authored
This CL changes the media controls' behavior in system menu such that it will be in an empty state instead of hiding after all media have stopped playing. Bug: 1133871 Change-Id: I5e42410abf121c94756e18e9a2cd0eb14375e2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441678Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813047}
-
minch authored
Bug: 1133952 Change-Id: I843e304131eea6f120be6f32f00b427d1f6477df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444453Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#813046}
-
Lei Zhang authored
Adjust callers to call base::Value::ListStorage::reserve(), or use an alternative method to do what they want. Remove a few more deprecated base::Value calls along the way when convenient. Also update comments in base/values.h to remove references to methods that no longer exist. Bug: 646113 Change-Id: Id28a964676e9119687936050a28a19dfa60bc1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437730Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#813045}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/110e287f7da0..444cee2905f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com,karandeepb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1098447,chromium:1124873,chromium:1128750,chromium:1132967,chromium:1134049,chromium:912681 Tbr: noel@google.com,karandeepb@google.com Change-Id: Ief77da176d288ae88174acbfbc1ccb46766961ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444159Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813044}
-
Cathy Li authored
clipping. This fixes clipping for feed header IPH. Bug: b/168859910, 1130592 Change-Id: I19efd691190f05826c7e1ecfd288f8d6bf4df6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442361 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#813043}
-
Ian Barkley-Yeung authored
Untrusted input? Complex C++ parsing code? Put a fuzzer on it! Bug: chromium:1121816 Change-Id: Iddb65e2568d88bbd32157bae49ceacaa1755c04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443396 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#813042}
-
Karandeep Bhatia authored
Change it to accept a dictionary instead of individual arguments for better future compatibility. Also rename it to setExtensionActionOptions for further flexibility. Note that this is a breaking change but we'll reach out to the current users to make sure that they update their extensions. Skipping presubmit since this seems to be hitting crbug.com/956368. BUG=1131746 No-Presubmit: True Change-Id: I6b800985ca2eaff4f52900b984ef5519e3fac266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429260Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#813041}
-
Bailey Berro authored
Enables clients to implement the MemoryUsageObserver interface and register themselves as an observer in order to receive periodic updates about the usage of memory on the device. Example use - crrev.com/c/2424505 Bug: 1128204 Change-Id: I17eaf3b8eb58c287e96d8ff217d3356d3d84c06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439475Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#813040}
-
Tomasz Wiszkowski authored
This change introduces a very simplistic MostVisitedTilesProcessor. The only functionality wired up at this point is updating the Omnibox Editing text with the associated URL and very basic keyboard navigation. Bug: 1106109 Change-Id: Iac224b2c625eb11d9e1a99ff21465c2b3680b3f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437690 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#813039}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b677e985297d..69e30b23c45f 2020-10-01 vadimsh@chromium.org [lucicfg] Update to 1.21.0. 2020-10-01 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1133442 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I924ca88e53208345b4446a4a55b016a13a19e019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813038}
-
Jeremy Roman authored
dtapuska already owns and reviews blink/public/common/. (Sorted because these lists get harder to read the longer they get.) Change-Id: I3fb849854948bcaf01847b93add9f133ad7b5026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442632Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#813037}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ab4a49259c0e..7f0e83e82ba9 2020-10-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3211fba0..fa57522d (812728:812874) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3a95b2f5523f296e04eaf3c9b63b908f8df3c7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444158Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813036}
-
Akihiro Ota authored
This change: 1. Adds the earcons lesson to the interactive tutorial. Functionality for this is included in buildEarconLesson() in i_tutorial.js 2. Adds a test for the lesson. 3. To reduce flakiness, we needed to change how we wait for the tutorial. Now, we wait for all lesson content to finish loading before we perform commands and make assertions. focused. This change also includes an automated test. Test: Manually verify on-device that earcons are played when text is Change-Id: I89d2f3c050a74b8d35df47091d88ba443105dadb Fixed: 1124078 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426968 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813035}
-
Daniel Classon authored
Turns the swap mouse button toggle into a dropdown with Left button and Right button as options, as per the bug. String screenshots: https://storage.cloud.google.com/chromium-translation-screenshots/0de32bdc0a9e5c95680629877c323c11d242cf03 https://storage.cloud.google.com/chromium-translation-screenshots/037c4cf7a5c655f6e15a4ca3c906230359440d50 Fixed: 1132518 Change-Id: I55836c82115a2fc1473d4863b2f96ed9b94f4a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436750 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813034}
-