- 23 Jun, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592913526-8a6b109b6b3679eaf9b2e9a04d6e6b258b48adc2.profdata to chrome-mac-master-1592935173-d1033b26c7b78c08aca84bf70b5b5eb9d34e3499.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I4a585498ff59d807f2ac9e0d4563337c5a46c386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260928Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781485}
-
Chris Sharp authored
TBR=ryansturm@chromium.org Bug: 1087736, 1087876 Change-Id: I42837be8d16e6534b97bb3e8fd6154d39411ab26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260397Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#781484}
-
Sammie Quon authored
Shelf may have delayed bounds setting via animation using BoundsAnimator. An ink drop created during this animation can be shifted. This patch adds an layer transform observer for shelf buttons which uses a new API in ink drop to set the ink drop root layer transform. This sounds like ink drop should handle transforming hosts or maybe views code itself. But this is intended to merge, so this solution is ideal for now. Test: added test, manual Bug: 1097044 Change-Id: I783d86161c8415e5fe419c6e9505bc7b9be77f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258687 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#781483}
-
Jordan Bayles authored
Currently, MediaRemotingIntegrationTest.SeekWhilePlaying is flaky, and has been disabled. After looking at the logs, the primary reason is that media::PipelineIntegrationTestBase::OnEnded is called multiple times, resulting in a DCHECK and test failure. The stack for the second OnEnded call is: media::PipelineImpl::RendererWrapper::CheckPlaybackEnded media::AudioRendererImpl::Render Logs: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890990219267312400/+/steps/media_unittests__with_patch_/0/logs/Flaky_failure:_MediaRemotingIntegrationTest.SeekWhilePlaying__status_CRASH_SUCCESS_/0 Turns out, this is actually a bug in the AudioRendererImpl, where the old method for determining if the content is ended is flaky, resulting in multiple calls to OnEnded. This bug has been resolved by a change made on the AudioRendererImpl, moving to an explicit EndedPlayback signal: https://chromium-review.googlesource.com/c/chromium/src/+/2021292 Bug: 1043812 Change-Id: I8ca939e5166c3fa3c40f33c7a4e34f3a29d0e06b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258342 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781482}
-
Etienne Bergeron authored
Thread priority should not be modified after a test. If that is happening, it needs to be fixed in the code. This CL remove the code that disable the priority checks. NOTE TO SHERIFF: * please paste failure logs when reverting, the goal is to remove flaky tests related to thread priority. * assigned flaky test to etienneb@ Bug: 1097092 Change-Id: I557727e9ab91ff5bdb4e87e54ba8f56b9313a1de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254442Reviewed-by:
Johannes Henkel <johannes@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#781481}
-
Ken Rockot authored
This feature has two problems: - its name is bad and non-inclusive - it's no longer needed with inlined typemap definitions This converts the one remaining dependent typemap to an inlined typemap configuration in GN. Fixed: 1097211 Change-Id: I9515ada1bc833f1306f12b2bcae14a59f1257645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255123 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#781480}
-
Adam Langley authored
Previously we would send the hmac-secret extension to authenticators that didn't advertise support for it. That's fine because it'll be ignored but, in the future when we have more support for hmac-secret, it gets expensive. This change adds the basic infrastructure for that and stops sending the extension unless the authenticator advertises support. Change-Id: I0dc2806c91ab0e032598c1f9ce54899c0b47d269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255210 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#781479}
-
Torne (Richard Coles) authored
Remove myself from OWNERS in //weblayer Change-Id: I978fd3c19a58c29542bc37199dd5ed03b2ed6471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261221 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#781478}
-
Tao Bai authored
- Guard the PersistentHistogram init code in WebView. - The feature is still disabled by default. - Will use the finch to rollout LocalMemory backed PersistentHistogram. - The Renderer process metrics will work, but the unsent metrics will lost on crash or app being killed. Tested manually Bug: 1090682 Change-Id: I3033c853bf2738a2f2dd24efeac6b3913dd79890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259377Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#781477}
-
Michael Hansen authored
Adds support for Fast Initiation advertising to NearbySharingService. When StartAdvertising() is called, the service will acquire a BluetoothAdapter and use it to create a FastInitiationManager, which will handle broadcasting the advertisement. Bug: b:154846208 Change-Id: I5ea0de14901bf14d7f20dd80ef21582c21b10665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211132Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#781476}
-
Jon Mann authored
Bug: 966270 Change-Id: I6c886591d656d1aa681aa5620d682104f4d4b7ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259379Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#781475}
-
Darin Fisher authored
Change-Id: Id5672338460fc8ceb4ad0acb93534f520c4f5c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056759Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781474}
-
danakj authored
For crbug.com/889952 a flush was introduced to get messages sent to the renderer process compositor thread to be handled (and bounced to the main thread) before navigating and starting the test on the renderer main thread. A second flush was also added at that time to the main thread, which would ensure those bounced compositor-thread things would be handled there before proceeding. But since those events don't have side effects that need to be received by the browser before proceeding, this second flush is not needed. The tasks for compositor-thread events bounced to the main thread will be run before the main thread navigates and starts running the test regardless. The fast/selectors/selection-window-inactive.html test was disabled as flaky for bug 889952, but the flushes added to that test did not actually stop it from being flaky. R=avi@chromium.org Bug: 889952, 953991, 1084377 Change-Id: Iea96b364efd36d057f156f940aee19a64aaacf39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261156Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#781473}
-
Albert J. Wong authored
This ensures no accidental copies of the underlying objects. Removing the assignment operator requires use of uniform initialization. This is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/2204539 which in turn is broken out of https://chromium-review.googlesource.com/c/chromium/src/+/1557854 Bug: 1083392 Change-Id: Ia40eafa902e514d2c261489cb0a91a147d389415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258781 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Auto-Submit: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#781472}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b7db183f0206..37b62e51e50c 2020-06-23 brucedawson@chromium.org Get roll-dep to handle \ separators If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I6399572a0b73e711f9dfb1c4835b6751e081b582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260927Reviewed-by:
-
Jeroen Dhollander authored
This file is only compiled when the GN arg |enable_fake_assistant_microphone=true| is used, which is why it was broken without people realizing. Bug: N/A Test: N/A Change-Id: Ibeae35d306506710d2d7a3a9687a2d16db3a7a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260940 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Commit-Queue: Tao Wu <wutao@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#781470}
-
Devlin Cronin authored
Add support in the contextMenus API for the generic "action" key, similar to the support available for "page_action" and "browser_action". Expand testing to cover this case. Bug: 893373 Change-Id: I248c4fd84bf309bc617b95e1e2a13f05b1b51684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159955 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781469}
-
Dana Fried authored
Similar code was already removed from tab_group_underline.cc Change-Id: I5bf15a201b07942123218a56a4c06dbb00aaf881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261157 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#781468}
-
Eugene But authored
Bug: None Change-Id: I88ce75f25fc62b2fefb56f0b9b82a49624141f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255019 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#781467}
-
Harry Cutts authored
This CL adds mappings for the JC-U4013SBK (the wired version) and JC-U4113SBK (wireless) when they're in "D" (DirectInput) mode. (https://crrev.com/c/2252469 adds XInput support for the JC-U4113SBK, and XInput support for the JC-U4013SBK is still to come.) Bug: chromium:1097173, chromium:1096754, b:159466838, b:159368181 Test: Connect gamepads in "D" mode, load gamepadviewer.com, and check that pressing buttons and moving axes is correctly reflected on-screen. Change-Id: I30dae3bd586b5b4ceeccb0a4ae3c02bb8a91447a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259012 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#781466}
-
Ryan Sleevi authored
Enforce publicly trusted TLS server certificates have a lifetime of 398 days or less, if they are issued on or after 2020-09-01. Certificates that violate this will be rejected with ERR_CERT_VALIDITY_TOO_LONG and will be treated as misissued. Bug: 1097982 Change-Id: I0fdccd93cc9fd0ee1011b37be7b584a8ce6653d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258372Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781465}
-
Hesen Zhang authored
If user turns on the instant-fetch flag after the first initial flow, and turn off again after fetch is done, the code path was broken and could never trigger the next normal flow. Fix is mark the first flow completed when ever OnFetchCompeleted called. Have unit test to cover this corner case. Bug: 1087476 Change-Id: Id763b2ad328b9ca0be3ad6849f778aca182c989f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259013 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781464}
-
Adithya Srinivasan authored
No changes in test logic. Bug: 1024850 Change-Id: I9f97de7f1d0a31f7184f0856f025aec219fe79a9 Tbr: dtrainor@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261159Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#781463}
-
Ulan Degenbaev authored
The bug that caused flakiness was fixed. Bug: 1097332 Change-Id: I26b741a59244ad46121ec5738955a6f607dea2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259843Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781462}
-
James Cook authored
set_sources_assignment_filter() causes files to be magically excluded from sources lists based on path substrings. It is considered a mis-feature of gn, see bug. Convert BUILD.gn to use conditionals to include source files only on the platform where they are used. Bug: 1018739 Change-Id: If699383ea8b1d936f5a4d30a1b072291841a4183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255316 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#781461}
-
Chris Hamilton authored
This was recently found by a manual audit after an ASAN fuzzer found a similar issue. BUG=1098226 Change-Id: I4a91ec58ccceadd92719774cf0047cb7a184c5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261392 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781460}
-
Lei Zhang authored
Since circular_deque.h only contains base::circular_deque, it is easy to grep for headers that include circular_deque.h, but not base::circular_deque. Fix IWYU lint errors along the way. Change-Id: I85e8c7cfb255535eecdeaaf91703a21e507c8f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258431Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781459}
-
Sahel Sharify authored
Without this cl changePaymentMethod would fail when the "details" key did not exist in input bundle. With this change the "StringifiedDetails" passed to changePaymentMethodfromInvokedApp()[1] will have the default stringified empty JSON object value. [1]https://cs.chromium.org/chromium/src/components/payments/content/android/java/src/org/chromium/components/payments/PaymentRequestUpdateEventListener.java?l=32 Bug: 1026667 Change-Id: I55ac9d3e5d6dc6923290223317164d1dfdd3faa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255656 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#781458}
-
Milica Selakovic authored
Autofill assistant can perform more than one successful login. Password manager should not show prompts for any of them. Bug: 1063347 Change-Id: Ic2b118192a285723bcf9e1d807cb1e62ba3ab30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252083 Commit-Queue: Milica Selakovic <selakovic@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#781457}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9167e1e22a46..eb0a25a189b7 2020-06-23 amaiorano@google.com Kokoro: add builds with REACTOR_EMIT_DEBUG_INFO and REACTOR_EMIT_PRINT_LOCATION 2020-06-23 amaiorano@google.com Fix build when ENABLE_RR_DEBUG_INFO enabled 2020-06-23 amaiorano@google.com Make Windows Kokoro script less verbose If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie5d4ba044c8fcd661e82aff98d2707861ff6bf36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260521Reviewed-by:
-
Mike Dougherty authored
This fixes compilation (of non EarlGrey targets) when building with Xcode 12b1. Bug: 1096215 Change-Id: I7223b6895d6b4574349f1490f6b0308896f290ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259149 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#781455}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If05d28fb1cee0367e33020de045c8072afed395b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260923Reviewed-by:
-
Etienne Pierre-doray authored
Possible race when Join(): - thread A: Join: worker_released_condition_->Wait() - thread C: WillRunTask: GetMaxConcurrency() returns > 0 - thread B: already running, finishes all the work GetMaxConcurrency() goes 0 - thread B: DidProcessTask: worker_released_condition_->Signal(), - thread A: Join returns (GetMaxConcurrency() is 0) - thread C: TryIncrementWorkerCountFromWorkerRelease worker count goes 1 - thread C: runs worker_task after Join To fix race when Joining, all writes to |state_| are protected by |worker_lock|. Memory ordering is no longer necessary. Alternative: cancel before Join returns with a compare and swap and loop again if new workers. Change-Id: I4e478ffae2bdaec56386739f78de089d0e74e42c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248159 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: -
zhaoyangli authored
Set form factors and iOS versions exactly the same as the union of ios-simulator and ios-simulator-full-configs CQ builders. This is because a unit test in iOS 12 is failing and we need to gather more accurate data before running coverage in CQ. Bug: 1090188 Change-Id: I0875469c874e8745da3f3c1a23d25dbe6297a63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258899Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#781452}
-
Hidehiko Abe authored
This CL sets up an empty LacrosChromeService in lacros-chrome, and connects to it from ash-chrome. BUG=chromium:1094106 TEST=Ran locally. Change-Id: Ie5ae843319d05c249ce33bbe8505fcee43899499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246121 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
-
Daniel Rubery authored
This test became flaky due to an uninitialized variable introduced by https://chromium-review.googlesource.com/c/chromium/src/+/2249162 This was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/2253759 Fixed: 1096975 Change-Id: I659848f1bb82b30f3debd4370a1b6640b72c12a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254349 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#781450}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d15ec1eec289..089f7a6b11cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chanli@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1096382 Tbr: chanli@google.com,csharp@google.com Change-Id: Ib120d756bf02c3d15381d693576a28321b937430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260917Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781449}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ead457578785..8dbca52cb29a 2020-06-23 joselea@microsoft.com Re enable memory test 2020-06-23 joselea@microsoft.com Logic to log event for panel closed. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1074732,chromium:1086641 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8edac18f7a1e7053d1aa01c8cfb96386a1112491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260922Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium fc6f3bb6. With Chromium commits locally applied on WPT: ee0c101e "[COOP] access reporting toward the opener." c98dba7e "[COOP] access reporting. Improves tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I7c90ebcfa58061b3b14385ba7ab8ba199e195583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260396Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781447}
-
Jeremy Leconte authored
Bug: 1093406 Change-Id: If12b3273af093a5ae43bc5d001bfd661de55a12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260657 Commit-Queue: Jeremy Leconte <jleconte@google.com> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#781446}
-
