- 25 Jun, 2019 40 commits
-
-
Dan Harrington authored
- OfflineContentOnDino is launched - AutoFetchOnNetErrorPage will be a new field trial See crbug.com/887670 for launch bug Change-Id: Ibdae9ba0e10bc950781cbe4aac86d6597b990eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667544Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#672254}
-
Reilly Grant authored
This reverts commit 4860e09b. Reason for revert: Cause of compile failure on win32-archive-rel (https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/1912) Original change's description: > DNR: Add filter_list_converter tool. > > Filter List Converter is a tool to convert filter list files in the text format > to a JSON file in a format supported by the Declarative Net Request API. It can > either output the complete extension (with a manifest file and a JSON ruleset) > or just the JSON ruleset. > > This is based on the ruleset converter module in the subresource_filter > component. > > BUG=972290 > > Change-Id: Id67ccaa5cc3cc469da67865c3754b41182d1ab9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1139592 > Auto-Submit: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672233} TBR=lazyboy@chromium.org,dpranke@chromium.org,csharrison@chromium.org,karandeepb@chromium.org Change-Id: I30c97f1d4a37414258ef627b827bf7d099053aaa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 972290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677249Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672253}
-
Reilly Grant authored
This reverts commit fa0a6456. Reason for revert: Reverting again after confirming that this change turned a flaky test into a consistently crashing test. Original change's description: > Add support for FIFE Avatar URL format > > The method GetAvatarImageURLWithOptions() is updated to support > image URLs coming in the FIFE Avatar URL format. > > This should resolve issues related to color-inverted account images > on the Chrome surface. > > Bug: 911332 > Change-Id: I8c0a10be69bc87a40a39cf46e0428b418d97b021 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670888 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672116} TBR=msarda@chromium.org,bsazonov@chromium.org,tangltom@chromium.org Change-Id: Ic6d0b1b4080c2c795a2c60ae7bdec85324ad1751 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 911332,978578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676836Reviewed-by:
-
Clemens Hammacher authored
Added to v8 in https://crrev.com/c/1675963. R=jwd@chromium.org CC=ahaas@chromium.org Bug: chromium:978425 Change-Id: Ie02378eb6075f537dd66ee70ef6438bac779e702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676166Reviewed-by:
-
Matthew Webb authored
The current bio enrollment implementation in the virtual CTAP2 device is stateless and does not have any storage. This CL makes it stateful by tracking enrollments, remaining samples, and current enrollment state. Note that I am also considering switching the list of enrollments from vector<pair<vector<uint8_t>, string>> to map<vector<uint8_t>, string> for readability and simplified code in the virtual device. Feedback on that idea would be much appreciated! Bug: 974046 Change-Id: I8d2b1b5963b37989aea02d32596a34bbbbd6e774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666801 Commit-Queue: Matthew Webb <noviv@google.com> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#672250}
-
Mehran Mahmoudi authored
Bug: 977168 Change-Id: I2571bd8bb63eaa2049d8f80520c6d7f176ad2519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677066Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#672249}
-
Daniel Hosseinian authored
Incorporate a feature flag around PDF document subsetter metadata to switch between enums indicating HarfBuzz or sftnly subsetters. The metadata is later passed down to Skia, which will use the appropriate subsetter. The feature flag, named "HarfBuzz PDF Subsetter," can be toggled on chrome://flags. Change the Skia build config to enable HarfBuzz's subsetter, meaning that both HarfBuzz and sfntly will be available. The addition of HarfBuzz adds a temporary 24kB to Chrome, with the intention of later removing the 50kB that comes with sfntly. Move printing_export.h to a new target to avoid a circular build dependency. This is also a good first step in reorganizing the 'printing/' directory. Original CL by Hal Canary [1] [1] https://chromium-review.googlesource.com/c/chromium/src/+/1531173 HarfBuzz as a PDF font subsetter through a Finch experiment. Bug: 931719, 976905 Binary-Size: Increase is temporary and necessary for validating Change-Id: Ibe67c6c13c5c2379124188a943763076360e9b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659130Reviewed-by:
Ben Wagner <bungeman@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#672248}
-
Tommy Steimel authored
This CL removes the word 'modern' from the rest of the media controls code. Bug: 884215 Change-Id: I502c6717a8ce15d667e3fce0bd1726038aca2f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677104Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#672247}
-
Michael Thiessen authored
Also adds support for showing the context menu on the All Apps button with just the search entry. Bug: 978458 Change-Id: I8c6a1229a84a7b60de2567c298ae1128096e9ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677064Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#672246}
-
cjamcl@google.com authored
Change-Id: I68f882e5e906b66f23808067b1039dc8789accc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651062 Commit-Queue: Connor Clark <cjamcl@google.com> Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#672245}
-
Allen Bauer authored
Bug: 974811 Change-Id: Ie7d2b0cffaa96a908b5c5a905b3e4e928452a436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658651Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#672244}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/69881fb0b5fb..234e27e5e242 git log 69881fb0b5fb..234e27e5e242 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 jcgregorio@google.com Upgrade cipd package for vpython to latest. Created with: gclient setdep -r src/third_party/skia@234e27e5e242 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@google.com Change-Id: I05cc486134ce87aab0fa36c857fd4f7f80cf8c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672243}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52ceb42ee515..a74ad478c04c Created with: gclient setdep -r src-internal@a74ad478c04c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=reillyg@google.com,yhirano@google.com,futhark@google.com Change-Id: Ib9e0a53304a9313ae7b5083d4ef297ad93e0b66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676858Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672242}
-
Vladislav Kaznacheev authored
The test is looking for an app called "Chromium", but on Google-branded builds the app is called "Chrome". Bug: 977737 Test: AppListClientImplBrowserTest.OpenSearchResult Change-Id: I5666ae8f97c8b41e1119ba3f6150020b109c969c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674347Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#672241}
-
Jeroen Dhollander authored
Previously we checked for network connections, which gave a false positive if the connected network had no internet connection. The network connectivity is checked using the (new) CrosNetworkConfig service. TBR=msarda@chromium.org Bug: 960956 Change-Id: Id315812b3db1f5445ffdfb95011638e48abafd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643953 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#672240}
-
Clark DuVall authored
This converts a couple of the easy throttles that just needed to get data from Profile instead of ProfileIOData, as well as converting IsSafeRedirectTarget which now uses ExtensionRegistry instead of extensions::InfoMap from ProfileIOData. TBR=bsazonov@chromium.org Bug: 824844, 976990 Change-Id: Iffb2ba970beeb4aacc0057b2f8ea6c6e0dd4b810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671588 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#672239}
-
John Lee authored
<cr-input> had a mixin of --cr-input-row-container that was incorrectly defaulting the value of the `justify-content` property to normal. When the mixin was removed, <cr-input>s that relied on that value broke. Bug: 978337 Change-Id: I37aaf6e260f901714cd6b4068a2f785bb19d2179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676745Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#672238}
-
Kyle Horimoto authored
When a <network-config> element is used to configure a network without also connecting to it, it was possible for it to get stuck in an unresponsive state. In saveAndConnect_(), we either call networkingPrivate.createNetwork() or networkingPrivate.setProperties(), depending on the network's source. In the createNetwork() callback, we previously did not close the dialog, resulting in a dialog that stays open and does not respond when the "Save" button is pressed. This CL closes the dialog in that case and refactors the element so that the same code path is used for both methods of network configuration. Additionally, this cleans up a check in internet_page.js to use !! to force a boolean value. Bug: 974737 Change-Id: Icca3148d854c645586e5dc0ed0749f6f99a5e362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674412 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Jun Cai authored
Per discussion at: https://chromium-review.googlesource.com/c/chromium/src/+/1665909/4 This CL is a preliminary CL for the above CL. This CL moves ItemAdapter out of the ItemChooserDialog so that it can also be used by BluetoothScanningPermissionDialog in the above CL. Bug: 960960 Change-Id: I9e08b7dc43b7de6b8c7ca55c3ed3cf4d1693ead7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669908 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#672236}
-
Doug Arnett authored
Bug: 895581, 879906 Change-Id: If67cbc221834449b84c2c9491890e06afa10f138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666911Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#672235}
-
Reilly Grant authored
This reverts commit 911ea514. Reason for revert: Earlier revert was a mistake. The failing test is flaky. Original change's description: > Revert "Add support for FIFE Avatar URL format" > > This reverts commit fa0a6456. > > Reason for revert: UserImageManagerTest.SaveUserImageFromProfileImage failing in browser_tests and viz_browser_tests. > > Bug: 978578 > > Original change's description: > > Add support for FIFE Avatar URL format > > > > The method GetAvatarImageURLWithOptions() is updated to support > > image URLs coming in the FIFE Avatar URL format. > > > > This should resolve issues related to color-inverted account images > > on the Chrome surface. > > > > Bug: 911332 > > Change-Id: I8c0a10be69bc87a40a39cf46e0428b418d97b021 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670888 > > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#672116} > > TBR=msarda@chromium.org,bsazonov@chromium.org,tangltom@chromium.org > > Change-Id: I70e2b5b7940158668ce455286cf3d3d8ac679b10 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 911332 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677157 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672221} TBR=reillyg@chromium.org,msarda@chromium.org,bsazonov@chromium.org,tangltom@chromium.org Change-Id: Ic2eb6a7974cb0ac46dfb4524c1b971f897f0a751 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 978578, 911332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677247Reviewed-by:
-
Karan Bhatia authored
Filter List Converter is a tool to convert filter list files in the text format to a JSON file in a format supported by the Declarative Net Request API. It can either output the complete extension (with a manifest file and a JSON ruleset) or just the JSON ruleset. This is based on the ruleset converter module in the subresource_filter component. BUG=972290 Change-Id: Id67ccaa5cc3cc469da67865c3754b41182d1ab9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1139592 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#672233}
-
John Budorick authored
Bug: 790202 Change-Id: I85de5a5e47f198c988148313107f65a546d4283d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677009 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#672232}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/db8b1cb70185..e39534277469 git log db8b1cb70185..e39534277469 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 treehugger-gerrit@google.com Merge "Add support for opening traces from postMessage." 2019-06-25 fmayer@google.com Merge "tools/heap_profile: update trace_to_text prebuilt to handle interned state" 2019-06-25 lalitm@google.com Merge "Ignore exited processes for startup metrics" 2019-06-25 lalitm@google.com Merge "gn: fix incremental build of descriptor when changing transitive deps" 2019-06-25 lalitm@google.com Merge "trace_processor: fix process names for new short lived processes" Created with: gclient setdep -r src/third_party/perfetto@e39534277469 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I45fd032da57dadb8b500d9083822cb08881be39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677029Reviewed-by:
-
Peng Huang authored
Bug: None Change-Id: Ib855d479aa435d401de37496990eecc307a89eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676678Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#672230}
-
Martin Kreichgauer authored
This adds a DeleteCredentials() method to CredentialManagementHandler to support deletion of multiple credentials identified by the CBOR-serialized PublicKeyCredentialDescriptor. It also extends EnumerateCredentialsResponse with the CBOR-serialized PublicKeyCredentialDescriptor such that the UI can use it as an opaque identifier for the credentials without having to do CBOR-serialization. The FidoAuthenticator::DeleteCredential is changed to take PublicKeyCredentialDescriptor rather than a sequence of bytes to identify the to-be-deleted credential. On a CTAP2 level, credentials are identified for deletion not just via their credential ID but via the full PublicKeyCredentialDescriptor. The spec is unclear on whether the non-ID related fields ('transports' in particular) are significant or not. Hence, it's probably wise to just echo the descriptor as it was received during credential enumeration, rather than send an empty descriptor with only the credential ID. Bug: 955859 Change-Id: Id1b7a9094876c701b21000399870bf439de4d8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674411 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#672229}
-
Mohamed Heikal authored
Rename ::android::GetMainProfileKey to ::android::GetLastUsedProfileKey so as to be the same as the comparable function ProfileManager::GetLastUsedProfile. TBR=It is just a rename/refactor. Change-Id: I78f639cd6deb90bd34e672ed782fda7373ae9b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676447Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#672228}
-
Henrique Grandinetti authored
Bug: 921145 Change-Id: Ib40299cdebb289213cedc8e0bf3d9afdd5f28d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673673 Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672227}
-
Matt Reynolds authored
The HidService mojo interface provides access to HID devices without exposing information about devices that the client does not have permission to access. This CL implements the GetDevices, RequestDevice, and Connect methods and adds unit tests. BUG=890096 Change-Id: I4e4edb6d6d2c8d9f58f455824002aecfc70a5c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661183 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Chris Morin authored
Add support for receiving the signal that the ARC++ container has stopped from an Upstart Job script. After the change on the ChromeOS side is made to send the stopped signal from the job script instead of from session_manager, support for receiving the signal from session_manager will be removed. Bug: b:133248517 Change-Id: I932778fde1f14a0581c96f0efb4f28892e991b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673862 Commit-Queue: Chris Morin <cmtm@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#672225}
-
Miguel Casas authored
A few histograms are still interesting so this CL kicks the expires_after can down the road; it also takes the chance to extend the owners with me and the chromeos-gfx@ public list. Bug: 975264, 975422, 975572 Change-Id: I993a5725b74f11c05e505ac9b57067d7c753eabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672625Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/04cffe3289f7..9a5c2e82ebbb git log 04cffe3289f7..9a5c2e82ebbb --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mbonadei@webrtc.org Remove unused command_line_parser dependency. Created with: gclient setdep -r src/third_party/webrtc@9a5c2e82ebbb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6918a241f21562c2ffe9f4d247217a48f88f2a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677026Reviewed-by:
-
Yue Zhang authored
* Shift the grid in dialog up by 8dp. * Put dialog title in the correct position and modify the text appearance. * Replace the original hide dialog button with back arrow. * Round the corners of the dialog by 8dp. Bug: 977273 Change-Id: Id0df26d12264dca313ad4554f8e115366e1d5bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674924 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672222}
-
Reilly Grant authored
This reverts commit fa0a6456. Reason for revert: UserImageManagerTest.SaveUserImageFromProfileImage failing in browser_tests and viz_browser_tests. Bug: 978578 Original change's description: > Add support for FIFE Avatar URL format > > The method GetAvatarImageURLWithOptions() is updated to support > image URLs coming in the FIFE Avatar URL format. > > This should resolve issues related to color-inverted account images > on the Chrome surface. > > Bug: 911332 > Change-Id: I8c0a10be69bc87a40a39cf46e0428b418d97b021 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670888 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672116} TBR=msarda@chromium.org,bsazonov@chromium.org,tangltom@chromium.org Change-Id: I70e2b5b7940158668ce455286cf3d3d8ac679b10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 911332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677157Reviewed-by:
-
Wenjie Shi authored
This document introduces the proposed design changes for modernizing the Chromium sensor backend on Windows allowing it to use the new Windows.Devices.Sensor WinRT APIs instead of the deprecated ISensor Win32 API. This README will not cover the context or justification for the modernization work as it is already captured by this document: https://docs.google.com/document/d/1Vr5xXOu4v-H6ydeCJed1bU_WR9kBYm3ANV-GB-JPZuw/edit?usp=sharing The new README file also reads more like a future looking document (contains "will do this..." and "proposed") since it not implemented yet. Change-Id: Ibcfeb9020bd930d50ab9898ce0ee145c9e645e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664111 Commit-Queue: Wenjie Shi <wensh@microsoft.com> Reviewed-by:
-
Christian Biesinger authored
Now that LayoutNG is on by default, use this bot to run without LayoutNG. R=eae@chromium.org, thakis@chromium.org Bug: 591099 Change-Id: I0d2a9fefed5830e2f83d198e3b196e346484b14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674614 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#672219}
-
Florian Uunk authored
We used this histogram to estimate Butter QPS, but this is no longer needed. BUG=975013 Change-Id: Ib56e84b99c2257f290d165218c4db5008e584010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665937Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#672218}
-
Lucas Furukawa Gadani authored
Bug: 908139 Change-Id: I5ade2d364906e02be87c819d7a97a13f767f1ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676236Reviewed-by:
-
Jared Saul authored
Screenshots are attached in the bug. Will immediately follow up with attempting a browsertest CL, but since Butter-based browsertests were previously flaky, I don't want to include it in this same to-be-merged CL just in case. Bug: 978514 Change-Id: I4cee091e1335d697dbac5e9bbacf44813fa24e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676674 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#672216}
-
Sebastien Marchand authored
The SQL DB owned by the QuotaManager gets destroyed asynchronously, so given the current ordering of the parameters: base::ScopedTempDir temp_dir_; scoped_refptr<QuotaManager> quota_manager_; The release of |quota_manager_| will post a task to close the database stored in temp_dir_ but this is racy with the destruction of |temp_dir_|. Bug: 974310 Change-Id: Ib54ea1fe1652028a1bcf6b7f6107a01d3e99f2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660833 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#672215}
-
