GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108094 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8432006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108093 0039d316-1c4b-4281-b951-d872f2087c98

This change just uses bit testing so Mac GCC does not complain "comparison is always false due to limited range of data type".

BUG=none
TEST=fix build on the "Webkit Mac (valgrind)" bot

Review URL: http://codereview.chromium.org/8427024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108091 0039d316-1c4b-4281-b951-d872f2087c98

Content is centered with 20px margins.

BUG=chromium-os:22002
TEST=Manual

Review URL: http://codereview.chromium.org/8427028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22001
TEST=Manual: title of the OOBE image selection screen should offer to choose, not to change, a picture.

Review URL: http://codereview.chromium.org/8433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108089 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=X509CertificateTest.SerialNumbers no longer failing on http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Redux

Review URL: http://codereview.chromium.org/8432026
Patch from Ryan Sleevi <rsleevi@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108088 0039d316-1c4b-4281-b951-d872f2087c98

This change removes a temporary suppression since we have installed debug symbols of libnss to new memory bots.

BUG=44341
TEST=valgrind bots are green without this suppression.
Review URL: http://codereview.chromium.org/8432029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108084 0039d316-1c4b-4281-b951-d872f2087c98

R=wtc@chromium.org
BUG=101123



Review URL: http://codereview.chromium.org/8382026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108082 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108081 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102045
TEST=None

Review URL: http://codereview.chromium.org/8418016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108079 0039d316-1c4b-4281-b951-d872f2087c98

This change adds another leak suppression for Bug 102327, which happens only on the Mac bots.

TBR=jar
BUG=102327
TEST=make the "Chromium Mac (valgrind)(1)" bot greener.
Review URL: http://codereview.chromium.org/8427027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108078 0039d316-1c4b-4281-b951-d872f2087c98

After refactoring WebUILoginScreen is owned by ExistingUserController.
Also, all users of GetLoginWindow() switched
to use LoginDisplayHost::GetNativeWindow() instead.
Views code from BaseLoginDisplayHost was moved to ViewsLoginDisplayHost.

BUG=chromium-os:21054,chromium-os:20946
TEST=unit_tests,browser_tests


Review URL: http://codereview.chromium.org/8395042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108077 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

TEST=
TBR=caseq@chromium.org

Review URL: http://codereview.chromium.org/8431026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108075 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101123
TEST=net_unittests:X509CertificateWeakDigestTest.*


Review URL: http://codereview.chromium.org/8391036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108074 0039d316-1c4b-4281-b951-d872f2087c98

the preferences with the command-line options via the
CommandLinePrefStore. This allows us to control the preferences
via the PolicyPrefStores or any other pref store in the future.

Patch originally by wtc@chromium.org at http://codereview.chromium.org/7776002

R=wtc@chromium.org
BUG=102019
TEST=none


Review URL: http://codereview.chromium.org/8402019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108073 0039d316-1c4b-4281-b951-d872f2087c98

We had trouble with base_unittests before, so we
ifdef'ed out the larger landing.  This tiny
switch CL will turn it on for the Mac, but can
be quickly reverted if there is a problem.

Scott Hess was able to debug and identify the
cause of the problem (yeah Scott!!!!).  I think
the code we landed corrects for the issue he identified,
and this should prove it (or get reverted trying).

r=rtenneti,shess
bug=101856
Review URL: http://codereview.chromium.org/8387059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108072 0039d316-1c4b-4281-b951-d872f2087c98

better matches expectations.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8432001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108071 0039d316-1c4b-4281-b951-d872f2087c98

Note: This is a kind of temporary fix. The fill fix is tracked
in issue 102412

TEST=unit tests
BUG=none

R=alokp@chromium.org


Review URL: http://codereview.chromium.org/8387045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108070 0039d316-1c4b-4281-b951-d872f2087c98

This change updates a suppression rule to catch up with r108025, which changed MainFunctionParams to content::MainFunctionParams.

TBR=stuartmorgan,jam
BUG=none
TEST=make the "Linux Tests (valgrind)(7)" bot green.
Review URL: http://codereview.chromium.org/8430026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108069 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a rule that suppresses probably-intentional leaks caused by r108026 <http://crrev.com/108026>.

TBR=jar
BUG=102327
TEST=make the "Linux Tests (valgrind)(2)" bot green.
Review URL: http://codereview.chromium.org/8431023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108068 0039d316-1c4b-4281-b951-d872f2087c98

Rather than require an X509Certificate*, which has additional processing
overhead, make X509Certificate::GetDEREncoded a static function which takes an
OSCertHandle. Callers which already have an X509Certificate* can easily use
->os_cert_handle(), while those that have an OSCertHandle, such as by way of
GetIntermediateCertificates(), can use the OSCertHandle directly.

BUG=91464
TEST=none


Review URL: http://codereview.chromium.org/8414047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108067 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108066 0039d316-1c4b-4281-b951-d872f2087c98

Beside other changes the new version of libjingle has 
thread-safe QName class and has all std::string and QName 
statics removed.

BUG=94993,102451
TEST=Compiles


Review URL: http://codereview.chromium.org/8413059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102457
TBR=cmp@chromium.org

Review URL: http://codereview.chromium.org/8431022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108064 0039d316-1c4b-4281-b951-d872f2087c98

sendIq_() requires that WCS is initialized when it is called, otherwise it will switch the session into the "failed" state.  (The state change causes a disconnect() call, which triggers a sendIq_() and the tab locks up.)


Review URL: http://codereview.chromium.org/8427020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102130
TEST=URLRequestTestHTTP.Redirect*Tests

Review URL: http://codereview.chromium.org/8418024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108060 0039d316-1c4b-4281-b951-d872f2087c98

The call to set chrome as default browser due to policy needs to happen on the FILE
thread. This change affects the call to set the default browser due to policy at
startup and during runtime.

BUG=101331
TEST=Manual testing performed


Review URL: http://codereview.chromium.org/8409004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108059 0039d316-1c4b-4281-b951-d872f2087c98

Prevent normal windows from opening when incognito mode is forced.


BUG=97677
TEST=Added a test to chrome/browser/extensions/extension_tabs_test.cc.

Review URL: http://codereview.chromium.org/8373027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108058 0039d316-1c4b-4281-b951-d872f2087c98

Ensure X509Certificate::OSCertHandles are safe to be used on both UI, IO, and Worker threads on Win.

Mirror the behaviour of SChannel by creating a new in-memory HCERTSTORE containing the certificate and its intermediate CA certificates whenever it is necessary to pass in a PCCERT_CONTEXT to a Windows API that may need to access the PCCERT_CONTEXT->hCertStore - such as certificate chain verification or display.

This also paves the way for removing the GlobalCertStore on Windows, which was necessary in order to link certificates with their intermediates for these same APIs.

BUG=47648
TEST=net_unittests:X509CertificateTest.* should cover this. Additionally, on a fresh profile, navigate to different HTTPS sites. From the Page Info Bubble, select Certificate Information, and in the Windows Certificate Viewer, click "Certification Path" and confirm the entire certificate chain is displayed. This is a variation of testing for http://crbug.com/45706, which should not regress.

Review URL: http://codereview.chromium.org/7324039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108056 0039d316-1c4b-4281-b951-d872f2087c98

types.

This adds syncable::APP_SETTINGS on top of the existing
syncable::EXTENSION_SETTINGS, and restructures code accordingly to accommodate.
This is so they can each be synced independently, and eventually tied to their
respective (EXTENSIONS or APPS) sync settings.


BUG=98488
TEST=ExtensionSettings*


Review URL: http://codereview.chromium.org/8375047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108055 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=caseq
Review URL: http://codereview.chromium.org/8387052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100898
R=pkasting@chromium.org

Review URL: http://codereview.chromium.org/8422009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108052 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual testing performed.


Review URL: http://codereview.chromium.org/8335004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108051 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102406
TEST=Copy a long, complex document from docs.google.com and paste into a Gmail compose window.


Review URL: http://codereview.chromium.org/8429022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108050 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we used a different inactive tab image, but that had the problem
that selected background tabs that were showing the throbber would show the
normal tab image within the throbber bounds. This makes us match how views
renders.

BUG=none
TEST=Have a non-active, selected tab show the throbber. The area behind the throbber should match the rest of the tab.


Review URL: http://codereview.chromium.org/8429012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108049 0039d316-1c4b-4281-b951-d872f2087c98

This test was creating an aura::Window but not calling its
Init() method, resulting in a segfault when
RenderWidgetHostViewAura::SetBackground() tried to access
the window's layer.

I have a more ambitious change in progress to add a
RenderWidgetHostView::InitAsChild() method and update a
bunch of callers; this is just a quick workaround so try
bots will stop failing.

BUG=102450
TEST=manual: test no longer segfaults

Review URL: http://codereview.chromium.org/8432020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108048 0039d316-1c4b-4281-b951-d872f2087c98

R=jhawkins@chromium.org
BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8343070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108042 0039d316-1c4b-4281-b951-d872f2087c98

Fixes XCode4.2 compilation error: method attribute can only be specified on method declarations [-Werror,2]
This is a result of XCode4.2 adding "-DIBAction=void)__attribute__((ibaction)" magic.

BUG=102429
TEST=compile under XCode4.2
R=thakis@chromium.org


Review URL: http://codereview.chromium.org/8432015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108041 0039d316-1c4b-4281-b951-d872f2087c98