- 07 Sep, 2016 40 commits
-
-
junov authored
Regression was introduced by this change: https://codereview.chromium.org/2294383002 The change inadvertently modified the steps performed by HTMLCanvasElement::getSourceImageForCanvas by no longer taking advantage of the cached rendering results of the WebGL drawing buffer. A secondary source of regression was that the AccelerationHint was not being propagated correctly. BUG=644401 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel TEST=blink_perf.canvas / draw-static-webgl-to-hw-accelerated-canvas-2d Review-Url: https://codereview.chromium.org/2320663002 Cr-Commit-Position: refs/heads/master@{#417029}
-
dmazzoni authored
This change is mostly refactoring and deleting with just a bit of new code. There were a few places we were still using AXObject::elementRect inside of Blink. Fix those and replace them with the new AXObject::getRelativeBounds or a new function AXObject::getBoundsInFrameCoordinates for cases where we do need absolute frame-relative coordates. There were a few subclasses of AXMockObject that didn't support getRelativeBounds yet but weren't migrated earlier because they had no test coverage for their bounding rects. Fix those and add new tests to cover them. To make it easier to implement those, I moved the implementation of getRelativeBounds from AXLayoutObject to AXObject, and made it dependent on a new protected virtual method layoutObjectForRelativeBounds(). If a subclass of AXObject wants its bounds computed all it needs to do is implement layoutObjectForRelativeBounds() and the rest is done for it. BUG=618120 Review-Url: https://codereview.chromium.org/2287433003 Cr-Commit-Position: refs/heads/master@{#417028}
-
samuong authored
BUG=chromedriver:1495 TBR=stgao@chromium.org Review-Url: https://codereview.chromium.org/2319223002 Cr-Commit-Position: refs/heads/master@{#417027}
-
erikchen authored
BUG=456373 Review-Url: https://codereview.chromium.org/2322603002 Cr-Commit-Position: refs/heads/master@{#417026}
-
timav authored
Video overlay for embedded videos (aka hole punching) was diabled in https://codereview.chromium.org/2026423002/. This CL removes it completely. BUG=616583 Review-Url: https://codereview.chromium.org/2299883007 Cr-Commit-Position: refs/heads/master@{#417025}
-
glevin authored
BUG=639537 TEST=Logged onto a managed account, open SysTray menu, click on "This device is managed by ..." item. This should briefly open https://support.google.com/chromebook/?p=managed which will quickly redirect to something like https://support.google.com/chromebook/answer/2535613?p=managed&rd=1 Review-Url: https://codereview.chromium.org/2308613002 Cr-Commit-Position: refs/heads/master@{#417024}
-
proberge authored
To support a new HashStoreContents which needs to be passed around in a different manner, the PrefHashStoreTransaction now has a raw ptr instead of owning the HashStoreContents. BUG=624858 Review-Url: https://codereview.chromium.org/2297373002 Cr-Commit-Position: refs/heads/master@{#417023}
-
johannkoenig authored
Review-Url: https://codereview.chromium.org/2318053003 Cr-Commit-Position: refs/heads/master@{#417022}
-
rune authored
Custom style rules can be added via the inspector. These were stored in a stylesheet appended to <head>. That meant it was visible to the document via CSSOM. Also, enabling/disabling the inspector would not remember that a stylesheet was added, so the inspector started out with a new blank stylesheet for editing, yet the existing rules still applied. This CL introduces a single inspector stylesheet in the StyleEngine which takes part in the document collection to apply the rules, but it is not appended to the document.styleSheets list. Neither is it accessible through a <style> element in the DOM. The stylesheet ends up after the author stylesheets in the order of appearance. That is similar to how it was, but previously, sheets in <body> would appear after the inspector sheet while sheets in <head> would appear before. The inspector sheet source is stored in a resource container like changes for author stylesheets. This means the inspector sheet source will persist across inspector enable/disable. R=pfeldman@chromium.org,lushnikov@chromium.org BUG=624139 TEST=http/tests/inspector-enabled/reattach-after-editing-styles.html Review-Url: https://codereview.chromium.org/2312953002 Cr-Commit-Position: refs/heads/master@{#417021}
-
danakj authored
Long live GN. R=sunnyps CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2315743005 Cr-Commit-Position: refs/heads/master@{#417020}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c9f2639b..4f2348b4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2321633002 Cr-Commit-Position: refs/heads/master@{#417019}
-
lazyboy authored
Instead, after unpickling the script content, put them in a WebString on its first use (GetJsSources) in a frame. Reuse them for subsequent frames. The cleanup is done when UserScriptSet releases its shared memory connection. A completely naive test shows that on WSJ site, with ABPlus extension installed, this reduced (24025 * 11 + 14785 * 10) = 412125 char copies! BUG=622464 Test=No visible change is expected. Review-Url: https://codereview.chromium.org/2278003002 Cr-Commit-Position: refs/heads/master@{#417018}
-
sugoi authored
Added a new group in third_party/BUILD.gn in order to enable building SwiftShader using 'ninja -C out/Default swiftshader' or similar command. The 'swiftshader' target already existed in third_party/swiftshader/BUILD.gn, but was unaccessible due to not being referenced in any other BUILD.gn files. Note that SwiftShader does not automatically build with Chromium. BUG=630728 Review-Url: https://codereview.chromium.org/2296433003 Cr-Commit-Position: refs/heads/master@{#417017}
-
eroman authored
This was added to the spec in: https://github.com/w3c/webcrypto/commit/90d9f747da7ab2dd0f88638666c2326dcb953536 BUG=630025 Review-Url: https://codereview.chromium.org/2289033002 Cr-Commit-Position: refs/heads/master@{#417016}
-
mcasas authored
This CL reenables a bunch of VideoCaptureDeviceTest test cases for Android and for the "new" APIs For this: - adds a |mTestMode| to VideoCapture.java, interface of all camera java classes. VCCamera2.java tests this flag and adds a capture thread if it's set. - the C++ correspondent classes get a method to configure the java side for testing, and a method to test if the underlying platform is using the new or the old APIs. Also: - Removes DeAllocateCameraWhileRunning because it was equivalent to CaptureWithSize test case. - Cleans up/refactors some parts of the unit tests, adds a few more comments etc BUG=626857 Review-Url: https://codereview.chromium.org/2286303003 Cr-Commit-Position: refs/heads/master@{#417015}
-
msw authored
Move DisplayList class to ui/display, display namespace. Rename existing 'DisplayList' vector alias to 'Displays'. Add ScreenBase class with some basic functionality. Not strictly necessary; but seems beneficial. ( helps codereview.chromium.org/2302673002 ) BUG=NONE TEST=Compiles; automated tests; no behavior changes. R=oshima@chromium.org,sky@chromium.org Review-Url: https://codereview.chromium.org/2314203002 Cr-Commit-Position: refs/heads/master@{#417014}
-
isherman authored
BUG=643878 TEST=none R=acleung@chromium.org Review-Url: https://codereview.chromium.org/2302373003 Cr-Commit-Position: refs/heads/master@{#417013}
-
nasko authored
When renderer is asked to do a session history navigation that is in-page, it should verify whether it has already committed a different document by verifying the document sequence number (DSN) matches between the one it has and the one sent by the browser process. When there is a mismatch, the navigation should not be treated as in-page, since that can lead to mismatch between the origin and URL of a document. This is a slightly modified version of https://codereview.chromium.org/2253233002/, which was reverted and includes a test case to reproduce the race condition causing the mismatch. BUG=628677, 630103 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2316133003 Cr-Commit-Position: refs/heads/master@{#417012}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/ddcf55c02 BUG=632319 TBR=chrishtr@chromium.org Review URL: https://codereview.chromium.org/2319033005 . Cr-Commit-Position: refs/heads/master@{#417011}
-
eroman authored
BEFORE normalizing the algorithm. This matches the change in the spec: https://github.com/w3c/webcrypto/commit/ccd586cc2cf0c7fe8db524622dd35b1fa39fe7c4 The motivation is consistency with other functions. Algorithm normalization might modify the data buffer. BUG=641494 Review-Url: https://codereview.chromium.org/2316633003 Cr-Commit-Position: refs/heads/master@{#417010}
-
lfg authored
constructed. BUG=638400 Review-Url: https://codereview.chromium.org/2322503003 Cr-Commit-Position: refs/heads/master@{#417009}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/408ddbdb8650..0991a2aad45a $ git log 408ddbdb8..0991a2aad --date=short --no-merges --format='%ad %ae %s' 2016-09-07 eakuefner [eslint] Clean up js_checks wording/spacing TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2319713002 Cr-Commit-Position: refs/heads/master@{#417008}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/cb92dc762d5c..1df1efa39218 $ git log cb92dc762..1df1efa39 --date=short --no-merges --format='%ad %ae %s' 2016-09-07 dsinclair Fixup CPDFSDK_PageView and CPDF_Page interactions. 2016-09-07 tsepez Maybe avoid a copy in CPDF_RenderStatus::SelectClipPath BUG=632709 TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2323443002 Cr-Commit-Position: refs/heads/master@{#417007}
-
peconn authored
Add support for a field trial that pushes the first card upwards and disables it's peeking to make the Cards UI more discoverable. BUG=622975 Review-Url: https://codereview.chromium.org/2312253003 Cr-Commit-Position: refs/heads/master@{#417006}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/5d8f69f2d492..5edf2908a305 $ git log 5d8f69f2d..5edf2908a --date=short --no-merges --format='%ad %ae %s' 2016-09-07 halcanary SkPDF: remove unused fallback clipping code 2016-09-07 borenet Run install-sysroot script before 'gn gen' on PDFium bot 2016-09-07 robertphillips Revert of Make AALinearizingConvexPathRenderer able to handle stroke and fill (patchset #7 id:120001 of https://codereview.chromium.org/2301353004/ ) 2016-09-07 caryclark fix pathops fuzzers 2016-09-07 brianosman Add color gamut xform helpers to GrGLSLShaderBuilder 2016-09-07 mtklein GN: fontmgr_custom 2016-09-07 vjiaoblack made point light shadows BUG=644684. 644680,644640 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=caryclark@google.com Review-Url: https://codereview.chromium.org/2319693002 Cr-Commit-Position: refs/heads/master@{#417005}
-
xidachen authored
This line was introduced in: https://codereview.chromium.org/2276033002/, the initialization is implicitly done in the SkPaint constructor. TBR=chcunningham@chromium.org BUG= Review-Url: https://codereview.chromium.org/2317173002 Cr-Commit-Position: refs/heads/master@{#417004}
-
alexander.shalamov authored
Don't disable NFC reader mode when feature is turned off, since the system NFC manager returns null NFCAdapter. BUG=640890,640995 Review-Url: https://codereview.chromium.org/2315203002 Cr-Commit-Position: refs/heads/master@{#417003}
-
schenney authored
The PaintLayer::backgroundIsKnownToBeOpaque method is currently only called by GraphicsLayers on their owning paint layer, or by the recursive child call. The former is by definition always called on a self painting layer, while the latter already has a test to prevent consideration of layers that do not paint into the backing in question. Hence we can remove the check for self painting layer status. These checks cause chicken-and-egg problems when the method is called by the layer itself in order to identify compositing reasons. In such cases we are not concerned with self layer status; we are in fact trying to determine that status. This is a relanding of issue 2297873002 at patchset 140001 (http://crrev.com/2297873002#ps140001) without the DCHECK that was in the that patch. R=chrishtr@chromium.org BUG=381840 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2320713002 Cr-Commit-Position: refs/heads/master@{#417002}
-
svillar authored
Some of the changes added in crrev.com/415676 made layout of grid containers a bit slower. That was because it modified some methods in GridTrackSize.h which is a hot spot. That class is basically a cache of some values and it's critical to keep it really fast. The aforementioned CL was adding an if clause to a getter method, and that was causing the slowdown. BUG=643359 Review-Url: https://codereview.chromium.org/2318993002 Cr-Commit-Position: refs/heads/master@{#417001}
-
msarett authored
This is an incremental step in the clean-up of SkColorSpace enums. Shouldn't change any behavior. BUG= Review-Url: https://codereview.chromium.org/2316123002 Cr-Commit-Position: refs/heads/master@{#417000}
-
qyearsley authored
Specifically, this CL uses: `./format-webkitpy --leave-strings-alone --no-backups --no-autopep8`. Review-Url: https://codereview.chromium.org/2256793002 Cr-Commit-Position: refs/heads/master@{#416999}
-
szager authored
Match what FrameView::synchronizedPaint does, rather than only traversing the mainGraphicsLayer. BUG=490942 R=chrishtr@chromium.org,skyostil@chromium.org Review-Url: https://codereview.chromium.org/2315083002 Cr-Commit-Position: refs/heads/master@{#416998}
-
alokp authored
BUG=616959 Review-Url: https://codereview.chromium.org/2305113002 Cr-Commit-Position: refs/heads/master@{#416997}
-
tdanderson authored
Add support for the vector icon drawing command CUBIC_TO_S, which will correspond to the SVG path command 'S'. This new command computes its implicit first control point by using information about the current point and the second control point on the previous command. BUG=643265 TEST=manual Review-Url: https://codereview.chromium.org/2307533003 Cr-Commit-Position: refs/heads/master@{#416996}
-
derat authored
Prevent browser accelerators from repeating unless they're associated with the following commands: IDC_FIND_NEXT IDC_FIND_PREVIOUS IDC_FOCUS_NEXT_PANE IDC_FOCUS_PREVIOUS_PANE IDC_MOVE_TAB_NEXT IDC_MOVE_TAB_PREVIOUS IDC_SELECT_NEXT_TAB IDC_SELECT_PREVIOUS_TAB BUG=626154 TEST=Ctrl-Tab still repeats but Ctrl-t doesn't Review-Url: https://codereview.chromium.org/2128243003 Cr-Commit-Position: refs/heads/master@{#416995}
-
fdoray authored
SequencedWorkerPool is being migrated to base/task_scheduler and there is no equivalent to IsRunningSequenceOnCurrentThread() in base/task_scheduler. BUG=622400 Review-Url: https://codereview.chromium.org/2320643002 Cr-Commit-Position: refs/heads/master@{#416994}
-
eroman authored
BUG=634443 Review-Url: https://codereview.chromium.org/2289363004 Cr-Commit-Position: refs/heads/master@{#416993}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/f9c6f0966908f1d125ea8f519cf31b8a84aff886 DevTools: Update devtools recipe with tryserver logic (chenwilliam@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=642046 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2319723002 Cr-Commit-Position: refs/heads/master@{#416992}
-
sunyunjia authored
BUG=643167 Review-Url: https://codereview.chromium.org/2302133002 Cr-Commit-Position: refs/heads/master@{#416991}
-
ellyjones authored
BUG=635176 Review-Url: https://codereview.chromium.org/2315243002 Cr-Commit-Position: refs/heads/master@{#416990}
-