GitLab

are allowed to opt-in to having embedded options pages and/or chrome style.

The flag --enable-embedded-extension-options makes the default for embedding
options pages true unless extensions opt-out. This is still useful for
development.

BUG=414920
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/667453003

Cr-Commit-Position: refs/heads/master@{#300190}

Currently the message is reshown if the animation is not finished. However,
since the video is changed and the text message is related to the previous
video, it's the best to just hide it immediately when switching videos.

TEST=Tested manually by playing multiple videos and clicking play with the
     CTRL key pressed.
BUG=422120

Review URL: https://codereview.chromium.org/649073004

Cr-Commit-Position: refs/heads/master@{#300189}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7839915..d12af70

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/666633002

Cr-Commit-Position: refs/heads/master@{#300188}

Adds a QuotaClient for the ServiceWorkerCache system.

* Calls to the QuotaManagerProxy like (NotifyStorageAccessed/StorageModified/OriginInUse/etc..) will be in an upcoming CL.

* The ServiceWorkerCacheQuotaClient is registered by the ServiceWorkerCacheStorageManager.  The QuotaClient holds a WeakPtr to the ServiceWorkerCacheStorageManager since the manager is destroyed before the QuotaClient.

* Added a number of unittests.  They fit better into the StorageManager tests file than in their own file as they rely on a lot of the StorageManager infrastructure.

* In order to support QuotaClient the ServiceWorkerCacheStorageManager needs to be able to list the origins it supports. This data is not currently stored so an "origin" member has been added to the CacheStorage index protobuf.  We won't report the origins of existing caches (if any even exist at this point) until their index is next written.

BUG=420159

Review URL: https://codereview.chromium.org/651983002

Cr-Commit-Position: refs/heads/master@{#300187}

Several of these are cruft (the entries don't exist to suppress), and
the rest are all small (<20MB) so there's no real value in avoiding the
pull.

BUG=None

Review URL: https://codereview.chromium.org/663763003

Cr-Commit-Position: refs/heads/master@{#300186}

wow_helper.exe is needed by the sandbox.

BUG=414808
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/667513002

Cr-Commit-Position: refs/heads/master@{#300185}

(We want to remove it, but there are currently some uses in Blink. We
can stop it from reappearing in Chromium.)

R=thestig@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/647433004

Cr-Commit-Position: refs/heads/master@{#300184}

On Windows the default UDP send buffer size is 8192. OSX default is
9216. On Linux default is 212992. The values are too small on Windows
and OSX. This cannot make good use of the A-MPDU of 802.11n (64KB),
which is the most common network for Cast Streaming.

We have also seen strong evidence that the default buffer size is
limiting, e.g. long packet queuing delay on Windows, p2p socket seeing
a lot of EWOULDBLOCKs.

This code uses pacer maximum burst size (in bytes) as the send buffer
size. Also added an option "send_buffer_min_size" to allow application
to choose an even larger value for send buffer size.

BUG=423545

Review URL: https://codereview.chromium.org/654843007

Cr-Commit-Position: refs/heads/master@{#300183}

R=dtu@chromium.org,tonyg@chromium.org,nednguyen@google.com
BUG=423563

Review URL: https://codereview.chromium.org/659673002

Cr-Commit-Position: refs/heads/master@{#300182}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/664783002

Cr-Commit-Position: refs/heads/master@{#300181}

The main user (and the immediate reason for the change) is to improve handle
ownership in content::ChildProcessLauncher.

This CL is not enforcing clean ownership beyond ChildProcessLauncher; that is
to be covered by subsequent CLs.

BUG=417532
TEST=base_unittests
R=scottmg@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/651253002

Cr-Commit-Position: refs/heads/master@{#300180}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/50e6008..49386a6

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/656533005

Cr-Commit-Position: refs/heads/master@{#300179}

r299567 disabled SSLv3 fallback. This change adds an enterprise policy option
to control this value so that enterprises can reenable the fallback if they
need it.

This option is in contrast to the one added in r299755. That one allows
enterprises to be more aggressive in disabling SSLv3, while this one is
intended for those who need to more slower that Chrome's default.

BUG=418848,419870

Review URL: https://codereview.chromium.org/644913008

Cr-Commit-Position: refs/heads/master@{#300178}

Review URL: https://codereview.chromium.org/664553007

Cr-Commit-Position: refs/heads/master@{#300177}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/dc89ca5..7839915

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/640593005

Cr-Commit-Position: refs/heads/master@{#300176}

Revert of [Mac] Enter should trigger the buttons in the new avatar bubble. (patchset #1 id:1 of https://codereview.chromium.org/644023002/)

Reason for revert:
This doesn't do what it's supposed to do, and after more discussions with groby@, Enter is really only used for default buttons on Mac, not all buttons.

Original issue's description:
> [Mac] Enter should trigger the buttons in the new avatar bubble.
>
> Only space seems to work by default.
>
> BUG=415823
>
> Committed: https://crrev.com/9750bbaa9e0b3d0bbe44431216d570ecc789024f
> Cr-Commit-Position: refs/heads/master@{#299157}

TBR=groby@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415823

Review URL: https://codereview.chromium.org/640593006

Cr-Commit-Position: refs/heads/master@{#300175}

Review URL: https://codereview.chromium.org/638383003

Cr-Commit-Position: refs/heads/master@{#300174}

Again. It got lost somewhere when rebasing or splitting out
https://codereview.chromium.org/625993002. This time add a
regression test.

BUG=416433

Review URL: https://codereview.chromium.org/667483002

Cr-Commit-Position: refs/heads/master@{#300173}

This adds the configuration for the android_apk template to use the crazy
linker for an apk and adds a bunch of crazy linker related targets (including
crazy linker tests).

TBR=ben@
BUG=359249

Review URL: https://codereview.chromium.org/640363002

Cr-Commit-Position: refs/heads/master@{#300172}

Sorry, I won't be doing code reviews. Instead, I have left y'all this
picture of a spider. I trust that this settles the matter.

                                          NMMMMMMMMMMMMM7
                                         MMMMMMMMMMMMMMMM
                                        MMMM
                            7777,       MMM
                        NMMMMMMMMMMMMM$ MMM             ZMMM=
                       MMMMMMMMMMMMMMMMMMMM8        ?MMMMMMMMMMMD,
                      MMMMMMMMMMMMMMMMMMMMMMMMM, ,MMMMMMD?=IMMMMMMMM=
                      MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM7          OMMMMMM+
           7MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM7              :MMMMMD
        ,MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM   OMMMMMMN       MMD
      +MMMMM,        :MMMMMMMMMMMMMMMMMMMMMMOMMMMMMMMMMMMMMMMMMMM,
    =MMMMM            MMMMMMMMMMMMMMMMMI  MI  MMMMMMMMMM     IMMMMM+
    NMMM              ~MMMMMMMMMMMMMMMMMOMMMMMMMMMMMMM         ,MMMMM?
                   =7O8MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM            MMMMM~
            ~DMMMMMMMMMMMMMMMMMMMMMMMMM  DMM  MMMMMMMM              MMMMM
         OMMMMMMMMMO7====MMMMMMMMMMMMMMM     8MMMMMMMM               ,MMMM8
      7MMMMMMZ            MMMMMMMMMMMMMMMMMMMMMMMMMMMZ                 ?MMMM~
    ,MMMMMN,            NMMMMMMMMMMMMMMMMMMMMMMMMMMMM                   +MMMMD
   MMMMM:            ,MMMMMMNMMMMMMMMMMMMMMMMMMMMMMM                      NMMM
 ,MMMM,            ,MMMMM,    $MMMMMMMMMMMMMMMMMMM
  MM?             MMMMO          7MMMMMMMMMMMMM7
                 MMMM             8MMM77?=
                MMMM              MMMO
               ~MMM               MMM
               MMM               ,MMM
              MMMN               7MMM
              MMM                7MMO
             NMM+                7MMM
             MMM                 :MMM
                                  MMM
                                  MMM7
                                  MMMM
                                  ?MMM
                                   OMM

TBR=ajwong,cbentzel,rsleevi,jar
BUG=none

Review URL: https://codereview.chromium.org/537043002

Cr-Commit-Position: refs/heads/master@{#300171}

IsControlCharacter() was checking an unsigned char to
make sure it's >= 0, which is trivially true. This throws
a warning on the default CrOS toolchain, so remove it even though it's harmless

BUG=424334
TEST=net_unittests
R=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/640303008

Cr-Commit-Position: refs/heads/master@{#300170}

We need the ability to observe the Mojo message pump in order to correctly
resolve promises at the end of microtasks triggered by signaling Mojo handles.

Another approach James and I discussed for this CL was to trigger
MessageLoop::TaskObserver, but that requires a PendingTask, which we don't
have. I investigated removing the PendingTask argument from
MessageLoop::TaskObserver, but it's used in a number of tests. Instead, this CL
follows the approach used by MessagePumpLibevent and introduces a specialized
observer interface for the message pump.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/663873002

Cr-Commit-Position: refs/heads/master@{#300169}

Also put some extensions #includes behind ENABLE_EXTENSIONS.

Review URL: https://codereview.chromium.org/657643003

Cr-Commit-Position: refs/heads/master@{#300168}

BUG=418690

Review URL: https://codereview.chromium.org/645263002

Cr-Commit-Position: refs/heads/master@{#300167}

There is a bug in Mavericks for applications linked against OSX 10.8 and
earlier. It requires Screens Have Separate Spaces to be enabled, and for the
window to be on a secondary screen. When AppKit Fullscreen is invoked on the
window, its final frame is 22pt too short.

This CL detects when these specific conditions occur so that the window's size
can be fixed.

Note: This is a bug buried in AppKit. Playing with methods like
-[NSWindowDelegate window:willUseFullScreenContentSize:] will not fix the
problem.

BUG=396980

Review URL: https://codereview.chromium.org/655393002

Cr-Commit-Position: refs/heads/master@{#300166}

That's not a polynomial hash. Match base/strings/string_piece.h's hash.

BUG=none

Review URL: https://codereview.chromium.org/604363003

Cr-Commit-Position: refs/heads/master@{#300165}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bd4495c..50e6008

TBR=dstockwell@chromium.org,aboxhall@chromium.org

Review URL: https://codereview.chromium.org/667493003

Cr-Commit-Position: refs/heads/master@{#300164}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

BUG=424386
TBR=rvargas@chromium.org

Review URL: https://codereview.chromium.org/662123002

Cr-Commit-Position: refs/heads/master@{#300163}

Fix indentation issues to allow enabling Checkstyle indentation rule.

BUG=318404

Review URL: https://codereview.chromium.org/662603004

Cr-Commit-Position: refs/heads/master@{#300162}

BUG=424697
TEST=Test added

Review URL: https://codereview.chromium.org/659393003

Cr-Commit-Position: refs/heads/master@{#300161}

The test must be faulty, as I was able to confirm the browser exhibits
the correct behavior in the same checkout/build on my desktop.

BUG=158913
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/645023004

Cr-Commit-Position: refs/heads/master@{#300160}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none
TBR=cpu

Review URL: https://codereview.chromium.org/661833004

Cr-Commit-Position: refs/heads/master@{#300159}

If it's failing to be sent, this would explain some of the cases of the bug.

BUG=407376
TEST=no change

Review URL: https://codereview.chromium.org/648463004

Cr-Commit-Position: refs/heads/master@{#300158}

Before:
* We'd send the message "containing" the message pipe (handle) first.
* Upon receiving it, the other side would create an endpoint (and
  dispatcher, etc.)
* The other side then sent a message back indicating the new ID (and
  telling the first side to run the message pipe.
* Upon receiving that "run" message, the first side would start sending
  messages for that message pipe.

This makes for rather complicated handshaking, which would only get more
complicated if, e.g., the second side wanted to forward the message pipe
handle that it received to someone else (e.g., over another channel).

Now:
* We "remotely allocate" an ID for the other side and send a message
  telling it to create an endpoint with that ID.
* We forward all the messages queued to that message pipe endpoint
  immediately (since we already know the destination ID).
* We send the message "containing" the message pipe (handle).
* The other side then creates a dispatcher and associates it with the
  (already-existing) endpoint.

Still to do:
* We need to track IDs that we've allocated for the remote side more
  carefully (in case of wrap-around, to avoid collisions).
* Convert everything over to the "attach and run" mode of operation (and
  possibly rename "attach and run" to something shorter), and delete the
  various separate "attach" and "run" methods.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/664763002

Cr-Commit-Position: refs/heads/master@{#300157}

BUG=

Review URL: https://codereview.chromium.org/657433002

Cr-Commit-Position: refs/heads/master@{#300156}

Destroy MojoMain's RunLoop before executing tests.
Reuse the shell handle for multiple test app instances.
Add ApplicationImpl::UnbindShell for message pipe reuse.

Add Apptest, a GTEST base class for application testing.

TODO: Support/Exemplify actual command line arg use.

BUG=392646
TEST=mojo_shell 'mojo:mojo_example_apptests <gtest_args>' still works.
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/654103002

Cr-Commit-Position: refs/heads/master@{#300155}

BUG=423621

Review URL: https://codereview.chromium.org/643093003

Cr-Commit-Position: refs/heads/master@{#300154}

BUG=423049
TEST=Start Chrome with an empty user data dir and --enable-new-avatar-menu.
From the avatar menu, click on "Switch Person", and "Browse as Guest" from
the user manager. Without closing any of the profile windows, choose "Exit"
from the Guest profile's hot dog menu. Restart Chrome. It should start up
and reopen the previous non-guest opened profile.

Review URL: https://codereview.chromium.org/661603007

Cr-Commit-Position: refs/heads/master@{#300153}

R=estade@chromium.org
BUG=275265
TEST=open chrome://settings/importData in 2 windows, uncheck all checkboxes => "Import" disabled both places

Review URL: https://codereview.chromium.org/660623002

Cr-Commit-Position: refs/heads/master@{#300152}

Commit c4a3f88c ("TestWebServer needs to
use a free port") has caused TestWebServer to use a random port number
in each invocation.

This does not play well with tests that assume the server will be
running on a specific port (for example, an HTML asset trying to do XHR
whose contents cannot be changed at runtime).

start() and startSsl() can now be passed an optional port number; if it
is being used, the server will fail to start like it did before the
commit mentioned above.

R=hush@chromium.org, yfriedman@chromium.org

Review URL: https://codereview.chromium.org/666513002

Cr-Commit-Position: refs/heads/master@{#300151}