GitLab

Bug: 1162022
Change-Id: I7d6d3e5691a52505306a600738b813cc27bc73ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601269Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839621}

This will remove the need for the child_infos_ field in LayoutManagerBase.

Somewhat related to the work of integrating fill layout behavior into views::View.

Bug: 1159116
Change-Id: I968aa58fb3b29f78d96cd520e61ccb731c2e9ac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605567
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839620}

https://android.googlesource.com/platform/external/perfetto.git/+log/6005f1179a65..355e9766ff81

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ic2173abfeb3242643e62d657c228a45997159a46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606567Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#839619}

https://chromium.googlesource.com/angle/angle.git/+log/095fd1d3ad25..c2847bbcf303

2020-12-29 thomasanderson@chromium.org [GLX] Don't request exposure events for child windows

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1158170
Tbr: jonahr@google.com
Change-Id: Idedc27d0add4714552349a8eaba629c48e16de27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606320Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#839618}

This is mostly mechanical, though two slightly non-trivial changes
have also been made:

The enrollment dialog view connect_ callback has been unused since:
  https://codereview.chromium.org/10230012
which was over eight years ago, so it has been removed.

FilePathWatcher can be held directly in an std::map, which already
provides std::unique_ptr-like no-moving semantics, allowing fewer
indirections and fewer map lookups. This change is made while here.

Bug: 1007635
Change-Id: I99fde79a09d8968cf37132aac6f85893cd2ee195
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601217
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839617}

Similar to as was done for the holding space tray icon, holding space
item views sections will no longer directly observe the holding space
controller and/or model. Instead, these events will be forwarded from
its parent, a holding space child bubble.

In the next CL to follow, holding space child bubbles may sometimes
withhold events from item views sections, such as when the child bubble
is being animated out.

There should be no user visible change as a result of this CL.

Bug: 1154998
Change-Id: Iccdeaee7dabfd3eeaa5eec0448e300d215377ba8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605419Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#839616}

https://android.googlesource.com/platform/external/perfetto.git/+log/6005f1179a65..355e9766ff81

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ifa14ab39255d05ee797ebac1e08bf14367fae827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603971Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#839615}

https://android.googlesource.com/platform/external/perfetto.git/+log/355e9766ff81..ecce47e1955f

2020-12-29 aeubanks@google.com Merge "Fix std::abs undefined behavior in string_writer.h"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Id3050d6af813d93d9db166c94206540e28fee4f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606545Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#839614}

Updates the expires_after attribute for 115 histograms that show
frequent access in the past 90 days.  These are the 95% most
frequently used histograms over that time that do not already
have a date later than or within 60 days of 2021-03-29.

TBR=chromium-metrics-reviews@google.com

Change-Id: Ib0f18065ee7fef60fb7d1b8f5f78c95c10417107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606425Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#839613}

I haven't been able to get a consistent repro for this hang, so this
is a speculative fix without a unit test. However, I have a strong
reason to believe that this will fix the underlying issue.

With https://chromium-review.googlesource.com/c/chromium/src/+/2521570
...focused nodes are never ignored. This exposed a circular dependency
in this sequence of events:

1) Node A becomes focused
2) A tree update occurs on a node to reparent Node A
3) The new parent is ignored (Node B)
4) Another child of Node B (Node C) has another tree update, which
   recomputes ignored state. This queries if a caret is present.
5) Determining whether a caret is present uses UnignoredSelection,
   which creates AXPositions that in turn ask the anchors if they
   are ignored. But we're already determining ignored state, so there's
   a circular dependency.
6) All of this occurs in the same AXTreeUpdate

This speculative fix simply removes HasCaret's dependency on
UnignoredSelection, so no traversal on ignored nodes will occur. This
seems safe, as the subsequent IsDescendantOf will handle nested focus
without depending on ignored state. For cases where HasCaret has tight
dependencies on UnignoredSelection (like ATK selection offsets), the
UnignoredSelection parameter is explicitly passed in.

Bug: 1156965
Change-Id: I67bac8fc2a1aa5db948aab470de91d39283f3c38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595198
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839612}

Note: in |ToolbarActionsBarBubbleViews::OnWidgetVisibilityChanged|, the
BindRepeating is changed to BindOnce.

Bug: 1152282
Change-Id: I57b6f87f111a160a91e28d32bbd6e194652472a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595931
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839611}

When the "Locate phone" feature is unavailable, we now show a tooltip
explaining to the user why this is the case. Namely, the feature is not
allowed when the phone has "Do Not Disturb" enabled and does not allow
alarms with sounds to disrupt this state.

Bug: 1156382, 1106937
Change-Id: I72f09e2cf8ae3dbd917cf87f49b954f944ef5332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604015
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839610}

https://chromium.googlesource.com/chromium/deps/sqlite.git/+log/0324bd3ef1af..d9581878fcf8

$ git log 0324bd3ef..d9581878f --date=short --no-merges --format='%ad %ae %s'
2020-12-22 huangdarwin Fix SQLITE_OMIT_WINDOWFUNC builds by moving declaration of sqlite3ExpandSubquery out of "ifndef SQLITE_OMIT_WINDOWFUNC" block.
2020-12-22 huangdarwin Amalgamations for release 3.34.0
2020-12-01 drh Version 3.34.0
2020-11-30 Dan Kennedy Update the tea/win/makefile.vc file that ships as part of the autoconf package to use "sqlite3" instead of "tclsqlite3" for the installed dll filename.
2020-11-30 drh Do not reuse the obsolete SQLITE_TESTCTRL_PRNG_RESET value for SQLITE_TESTCTRL_SEEK_COUNT.  Give SEEK_COUNT its own unique value. This avoids incompatibility with legacy test code.
2020-11-27 Dan Kennedy Fix a compiler warning in fts5_aux.c.
2020-11-27 Dan Kennedy Add missing cast to fts5 bm25() code.
2020-11-27 Dan Kennedy Remove a redundant "if( rc==SQLITE_OK )" from the fts5 bm25() code.
2020-11-27 Dan Kennedy Move an "if( rc==SQLITE_OK )" to outside a loop body in the fts5 bm25() code.
2020-11-27 Dan Kennedy Fix a case in the FTS5 integrity check where a corrupt database could cause a buffer overread.
2020-11-26 Dan Kennedy Update mkunicode.tcl to match the change erroneously made to machine generated file fts5_unicode2.c in [b7b7bde9].
2020-11-25 drh Update a requirement mark in the e_expr.test script.
2020-11-25 drh Fix harmless compiler warnings about unused function parameters.
2020-11-25 drh Fix a potential NULL pointer dereference in the geopoly_overlap() routine of the GeoPoly extension.
2020-11-25 drh Fix the shell1.test test script so that it works on windows.
2020-11-25 drh Change the -init option to the command-line shell to honor the -bail option. Also change it to report an error if the filename mentioned cannot be opened.
2020-11-24 drh Fix a typo in the sqlite3_txn_state() documentation.
2020-11-24 drh Add the new sqlite3_txn_state() interface to the set of routines accessible by run-time loadables extensions.
2020-11-24 drh Fix a harmless typo in a comment.
2020-11-24 dan Fix a bug in OOM handling code introduced by [6a28713d].
2020-11-24 dan Ensure that super-journal and other journal filenames passed by SQLite to an sqlite3_vfs.xOpen() implementation may be safely passed to sqlite3_uri_parameter() and similar functions.
2020-11-24 drh Remove the VERSION_NUMBER macro from configure.ac as it has been unused since 2009 check-in [7f4810747b086498].  See also [forum:/forumpost/bb2c634fcd|forum post bb2c634fcd].
2020-11-23 drh Syntactic changes to work around a bug in gcov 9.3.0.  No changes to the generated code for release builds.
2020-11-23 drh In os_unix.c, put ALWAYS() on unreachable branches associated with pathname normalization.
2020-11-23 dan Fix a test script problem causing crash8.test to fail when run with leak-sanitizer.
2020-11-23 drh Allow "substring()" as an alias for "substr()" for compatibility with other SQL engines.
2020-11-20 dan Add file doc/vdbesort-memory.md, containing notes on the way vdbesort.c uses heap memory.
2020-11-19 drh More test case changes so that shared-cache mode tests all work with normalized database names.
2020-11-19 drh Fix the tkt3793 test case so that work even when filenames are normalized.
2020-11-18 drh Improvements to the mechanism that attempts to report SQLITE_CORRUPT if pread() says that the underlying filesystem is corrupt.
2020-11-18 dan Update cksumvfs.c so that if SQLITE_AMALGAMATION is defined, SQLITE_CKSUMVFS_STATIC is implied.
2020-11-18 dan Add test infrastructure for cksumvfs. And update cksumvfs so that it works in concert with version 2 VFSs. No changes to core SQLite.
2020-11-18 dan Fix a problem causing sqlite3_carray_bind() to return an undefined value.
2020-11-18 dan Update test code to fix a problem with SQLITE_OMIT_VIRTUAL_TABLE builds.
2020-11-18 drh On unix, for certain error codes of read()/pread() return SQLITE_IOERR_CORRUPTFS instead of SQLITE_IOERR_READ.  And then convert this error into SQLITE_CORRUPT prior to returning back to the application.
2020-11-17 drh Claw back most of the performance lost in the previous commit.
2020-11-17 dan Fix trivial memory leaks in the shell and sqldiff programs.
2020-11-17 dan Fix test file busy2.test so that it works with the "inmemory_journal" permutation.
2020-11-17 drh Add a single-argument form to the CARRAY table-valued function, with content bound using the sqlite3_carray_bind() interface that is included with the extension.
2020-11-16 drh Enhance the unix VFS so that it removes extra "/", "/./" and "/../" from the database filename.
2020-11-14 drh Modify UPDATE so that two-pass updates on a rowid table use an ephemeral table to store rowids rather than a RowSet.  This uses less memory, though it is slower.
2020-11-12 drh Improved diagnostics output with ".wheretrace 0x800".  No changes to non-debug builds.
2020-11-11 drh Fix a typo in a comment.  No changes to code.
2020-11-08 drh Use NEVER and ALWAYS macros to confirm that the return value from sqlite3ExprSkipCollateAndLikely() is never NULL in some of its use cases.
2020-11-06 drh Add ALWAYS() to conditionals associated with SHM locking that are always true.
2020-11-05 drh Suppress errors associated with TEMP triggers that reference objects in non-TEMP databases.  This is a continuation of the fix for ticket #3810 shown in check-in [ba1afc040171810d] from [/timeline?c=trunk:200908061743|2009-08-06], based on a bug report in [forum:/forumpost/157dc791df|forum post 157dc791df]
2020-11-05 drh Remove unused variable from speedtest1.c
2020-11-02 drh Fix an another OSS-Fuzz discovered assertion fault due to ALTER TABLE and strange triggers.
2020-10-31 drh Add the -tabs command-line option to the CLI.
2020-10-31 dan Update the ALTER TABLE command to correctly handle UPDATE ... FROM statements within trigger programs.
(...)
2020-09-15 drh Do not invoke usleep() for more than 999999 microseconds.
2020-09-11 dan Catch fts5 index corruption caused by issuing 'delete' commands with incorrect data earlier in some cases. Also fix a couple of test script problems.
2020-09-10 drh Try again to fix the typo in the sqlite3_txn_state() documentation.
2020-09-10 drh Fix typo in the documentation for the new sqlite3_txn_state() interface.
2020-09-10 drh If an amalgamation is created using SQLITE_ENABLE_UPDATE_DELETE_LIMIT, ensure that it can still be compiled without that option by setting the SQLITE_UDL_CAPABLE_PARSER flag in the preamble.
2020-09-07 dan Fix another (harmless in practice) tsan error in shared-cache mode.
2020-09-06 drh Remove an artifical limitation on the length of columns in the "box" output mode of the command-line shell.
2020-09-05 drh Fix a bug in Fossil that might cause it to crash if there is a multi-terminal token with a space following the "|" separator. This does not affect SQLite.
2020-09-04 dan Fix a tsan error that could occur when using shared-cache mode.
2020-09-04 dan Ensure that the busy-handler count is reset at the end of each sqlite3_file_control() and sqlite3_prepare() (and _v2() and _v3()).
2020-09-01 mistachkin Fix harmless compiler warning.
2020-09-01 drh In the Lemon output, add a prefix comment that explains that the output file is automatically generated and shows the name of the source file.
2020-09-01 drh Lemon updates:  (1) include the #defines for all tokens in the generated C file, so that the C-file can be stand-alone.  (2) If the grammar begins with a %include {...} directive on line one, make that directive the header for the generated C file.  (3) Enhance the lemon.html documentation.
2020-09-01 drh Improvements to the IN-early-out optimization so that it works more efficiently when there are two or more indexed IN clauses on a single table.
2020-09-01 drh Fix a harmless compiler warning.
2020-08-31 drh New test-control that returns the number of calls to sqlite3BtreeMovetoUnpacked() on the main database and then resets the counter.  This only works for SQLITE_DEBUG builds.
2020-08-31 drh Fix the documentation for the OP_IdxGT family of opcodes to show that the P5 operand is not used.
2020-08-29 dan Fix a sanitizer warning in zipfile.c.
2020-08-28 dan Fix handling of an xShmLock(SHARED, UNLOCK) call when the caller does not hold any lock on the specified slot, but another connection in the same process holds an EXCLUSIVE.
2020-08-28 dan Modify the unixShmLock() function to avoid iterating through the (possibly large) set of connections to the same database file.
2020-08-28 mistachkin Add the miscellaneous 'series' extension to the shell.
2020-08-28 drh Update Lemon documentation.  Patches from sgbeal.
2020-08-28 drh Fix a couple of unreachable branches.
2020-08-28 dan Add fts5 test to confirm that for a table with columns a, b, c and d, "{a b}" and "-{c d}" are handled similarly.
2020-08-27 drh Remove a (harmless) redundant variable from the CLI implementation.
2020-08-27 drh Include the original text of the CHECK constraint in the error message for anonymous CHECK constraints.
2020-08-27 drh Apple the same fix for ticket [9eda2697f5cc1aba] to text-to-integer conversions that was done for floating point conversions by check-in [1c76f1d8ec0937a2].
2020-08-27 dan Do not attempt to run test script analyze3.test as part of the "prepare" permutation.
2020-08-26 drh Enhance the ".databases" command in the CLI so that it shows the result of sqlite3_db_readonly() and sqlite3_txn_state() for each database file.
2020-08-26 drh If the argument to the ".read" command in the CLI begins with "|" then run the remainder of the argument as a command and read input from the output of that command.
2020-08-25 drh Add support for the sqlite3_txn_state() interface.
2020-08-24 drh Reduce the N in the logN term for the sorting cost associated with computing DISTINCT by B-Tree by half, under the assumption that the DISTINCT will eliminate about half the rows of output.  This is really a wild guess.  But we do not have any better way of estimating what the row-count reduction due to DISTINCT will actually be.
2020-08-24 dan Correctly handle expressions like "x IS (not) true/false" within the rhs of IN() expressions. Fix for [f3ff1472].
2020-08-20 dan Fix a crash that could occur in SQLITE_MAX_EXPR_DEPTH=0 builds when processing SQL containing syntax errors.
2020-08-20 dan Avoid a buffer overrun in test code that could occur if certain test functions were passed a hex-string containing an odd number of digits.
2020-08-19 drh Try to make SQLite easier to compiler for Mac Catalyst. See [https://sqlite.org/forum/forumpost/803387a1c5|forum post 803387a1c5].
2020-08-19 drh Do not skip over TK_IF_NULL_ROW operators when bypassing TK_COLLATE operators. Fix to check-in [ac31edd3eeafcef4] which was itself a fix for ticket [45f4bf4eb4ffd788].
2020-08-19 dan Update releasetest_data.tcl so that the "Fast-One" configuration runs bigmmap.test as part of release testing.
2020-08-19 dan Fix a problem in test file bigmmap.test.
2020-08-17 drh Fix the -quote option on the CLI to set the correct column separator.
2020-08-16 drh Optimization to sqlite3BeginWriteOperation().
2020-08-15 drh Optimization of the sqlite3SrcListDelete() routine.
2020-08-15 drh Remove more unnecessary sqlite3GetVdbe() calls, replacing them with assert()s.
2020-08-15 drh Avoid unnecessary calls to the sqlite3GetVdbe() routine.  Add assert() statements to prove each call is unnecessary.
2020-08-15 drh Omit the unnecessary not-NULL check on the upper bound of a forward index range scan.  The subsequent OP_IdxGT will always catch the NULL.  Similarly, omit the not-NULL check on the lower bound of a reverse index range scan, as the SeekLE opcode will disallow the NULL.
2020-08-14 drh Update the version number to 3.34.0 for the next development cycle.
2020-08-14 drh Optimizations to the logic that converts main table accesses into equivalent index accesses.  Code is now slightly smaller and faster than trunk.
2020-08-14 drh For UPDATE and DELETE, use OP_DeferredSeek always.  If the seek must later be resolved, add the OP_FinishSeek opcode after all WHERE clause terms have been processed.  This obviates the need for the WHERE_SEEK_TABLE and WHERE_SEEK_UNIQ_TABLE flags to sqlite3WhereBegin() and the ensuing complication, and it allows the covering index optimization to be used further into WHERE clause processing.
2020-08-14 drh Experimental change to try to get some DELETE operations to access values using the index rather than the main table, so as to avoid unnecessary main table seeks.
2020-08-14 dan Fix an inconsequential memory leak in sqldiff. Update the "Sanitize" case in wapptest.tcl to use -fsanitize=address,undefined, and to run more tests.

Created with:
  roll-dep src/third_party/sqlite/src

Bug: 1161048
Change-Id: Ieb8f0154930d6cc0597b5aee9444678cf021035b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600334Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839609}

https://skia.googlesource.com/skia.git/+log/c85bce8ea6c8..368db7cde02e

2020-12-29 johnstiles@google.com Improve Metal matrix *= support.
2020-12-29 brianosman@google.com Fix bugs/formatting in MSL inverse helpers
2020-12-29 bsalomon@google.com GrSurfaceContext::read/writePixels takes GrPixmap
2020-12-29 johnstiles@google.com Handle values above int32 safely during IR generation.
2020-12-29 reed@google.com add sampling param to drawAtlas
2020-12-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6fa6f0c8 to c7d00ca7 (125 revisions)
2020-12-29 reed@google.com Simplify GrInterpretSamplingOptions
2020-12-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from c8d5277e86ee to 0eb61724c8f1 (1 revision)
2020-12-29 jcgregorio@google.com Add particles and svg support to fiddle.
2020-12-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5e606e5bfce2 to 220642a93da1 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: djsollen@google.com
Change-Id: Idce12b2c9eda0b90af242933f4c10914883cd4cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606544Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#839608}

This CL updates phonehub_api.proto to include fields sent by the phone
on W50+ indicating whether "Find My Device" functionality is available.
Then, it updates FindMyDeviceControllerImpl to use these additional
fields, breaking the dependence on DoNotDisturbController.

Due to this change, we can now use the "locate device" feature while DND
is on, as long as alarms are not also disabled on the phone.

Bug: 1156382, 1106937
Change-Id: I74363b1ca225b6f6f839d5c28034c60d203eaef4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605784Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839607}

Add check to verify that the speech recognition service is still active before sending data down the pipe

This CL contains a speculative fix that addresses a crash when calling AudioReceivedAfterBubbleClosed after the caption bubble is closed. I haven't been able to repro this crash and thus have not been able to verify this fix; however, the recognition client shouldn't send data to the speech recognition recognizer if the speech recognition service is destroyed anyways so this fix is of very low risk.

Bug: 1161756
Change-Id: Ied868dfa17966650f79ceb954a6ac694f59e33d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605295Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#839606}

This CL rolls androidx.legacy:legacy-support-core-utils

BUG=1064277

Change-Id: Iac6cb8a6f83a20c4f37bcc3a00fb2089212ad373
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602392
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839605}

Previously, there were strings without a space before the anchor <a>
tag, because settings CSS would cause subsequent <a>s of <span>s to
have additional margin starts. The lack of a space is confusing, esp
to translators.

This CL adds a space back to those strings, and modifies settings
stylization so that having that space in translation won't cause
additional indentation to the link embedded in the string.

Fixed: 1063036
Change-Id: Id05c847f097d6dcbd2fa9553b6e9540d43dff583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605594
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839604}

Updates the expires_after attribute for 21 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 60 days of 2021-03-29.

TBR=chromium-metrics-reviews@google.com

Change-Id: Id094b38b267ab8a3f05fb636cfc2b8b16d5fb010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605349Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#839603}

Inspect tools provide option to show internal ids of accessible
objects, which is a handy feature for debugging and event recording.
Platform tree formatters rely on internal accessible trees to retrieve
object ids. It should be avoided, because the tree formatters should
operate on external trees to produce same results not depending on how
a tree formatter was initiated (whether by tests or by ax_dump_tree
tool).

WebKit exposes AXIdentifier attribute, which looks like a great match
for this case. However, no comments from Apple so far about what
exactly this attribute is for, so let's move with ChromeIdentifier
attribute for now. Later it can be revisited.

Bug: 1134623
Change-Id: I367158bc8802734d0e9311c9739eb8da13ff0cf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602356
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839602}

The HID spec allows a device to group its functionality into
separate top-level collections within the HID report
descriptor. On Windows, each top-level collection is
represented in the system registry as a separate logical
device node.

This CL identifies when a device exposes multiple top-level
collections and merges them into a single HIDDevice instance.

Bug: 1009715
Change-Id: I0524fee04b5e530dfa5ff724b57d2442187946be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592149
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839601}

Bug: internal b/156555613
Test: cast_base_unittests
Change-Id: I5087a0a2df39559cf510ff5f9712ac9ece6a5b7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605591Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Commit-Queue: Junbo Ke <juke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839600}

Since we haven't enabled the new CDM with HW HEVC support yet overall,
we need to condition adding the HEVC codecs in EME on the same flag as
the CDM being enabled.

BUG=b:176202075
TEST=GPM playback works with default Alcatraz CDM

Change-Id: I626cb1e33973b812dce59edc514c086a578b45bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605292
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#839599}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8db531ffa636..9c73806bc052

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: 
Change-Id: Ia3aec89d2ef653871b95315f69436e1f2db34eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605597Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#839598}

This CL enables editing the local profile name from the picker's main
view. A hover state is added to guide the user of the possibility of the
inling editing. On click, the local profile name is editable.

Bug: 1159740
Change-Id: I2fba0602944b9e7334ee32663c081b5c308428b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599869Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839597}

This is semantically more correct, and avoids a bug in ::String with
non-ASCII bytes that led to loss of this setting on restore and quickly
growing memory use.

(I'll fix that separately).

Bug: 1161142
Change-Id: If998dab411d41e18f844d79f0dea12ea1fbcade7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602380Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839596}

Bug: 1162205
Change-Id: Iff1144b300c8b414cc2534fbf6aacdf94a318a01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606366
Commit-Queue: Lily Chen <chlily@chromium.org>
Auto-Submit: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839595}

This improves the behavior a bit by:
- Running the compile as a deferred startup task instead of right after
startup completes, which makes sure it doesn't interfere with the first
page load, and makes sure the base dex is not invalidated before
starting child processes.
- Removing the "-f" option for force compiling the dex. This prevents
recompiling the base dex if it is already correctly compiled.
- Using "-r shared" instead of explicitly passing the compile mode, so
the system can figure out what mode to compile shared APKs in.

Bug: 1159608
Change-Id: Ib15c626bc3c85f882046b806cde5e7b872d25e12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602837Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839594}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/2813dd74be34..f3b4fc743758

2020-12-29 saklein@chromium.org service/dependency: collapse cache parsing functions
2020-12-29 chrome-bot@chromium.org Update config settings by config-updater.
2020-12-29 vapier@chromium.org toolchain_util: stop hardcoding master branch

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: Ie5cbb652c50bc90bef8f2be08e94fda1116b4fef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606365Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#839593}

https://skia.googlesource.com/skia.git/+log/d1b593f446d3..c85bce8ea6c8

2020-12-29 bsalomon@google.com Revert "Make textures used with alpha-only color-types produce 0s for RGB"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: djsollen@google.com
Change-Id: I126b3126e0a7bb56687069bed1ac27efa6111380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606310Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#839592}

This change fixes the CaptivePortal routine problems and a misspelling.

Bug: none
Change-Id: I4e5226bb27ee179830b3544edd45eb87bb3a8dfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602114Reviewed-by: Kartik Hegde <khegde@chromium.org>
Commit-Queue: Trent Begin <tbegin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839591}

https://android.googlesource.com/platform/external/perfetto.git/+log/6005f1179a65..355e9766ff81

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I45874a937cee3afaf7a2556b38deff6876e9fcad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606108Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#839590}

It is not guaranteed that upon a badge tap that the associated
Infobar still exists. The Messages implementation has a similar
issue, but Objc nil object selector executions are no-ops. Thus,
an explicit nil check is necessary before attempting to present
an Infobar modal overlay.

Fixed: 1041375
Change-Id: I072879ef4ab2a163223cc896ea3a59288c09998e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605400
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839589}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012290600_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/gYicacAmlNBTfmj5bqOqzRfHBhSEG6KBAY2UtDyAakQC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: media-app@grotations.appspotmail.com
Change-Id: I42705f082d530b2fc23f44546a6fb5b3b55c89a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605593Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#839588}

Bug: 1162262
Change-Id: I44c5a9041eb384a654dffd962cb7aa4487f49dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603755Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Danila Kuzmin <dkuzmin@google.com>
Cr-Commit-Position: refs/heads/master@{#839587}

Bug: 1159430
Change-Id: I9923cc0a1590a26a2fa9988a6bbd5220d40fa9e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2604911
Commit-Queue: Danila Kuzmin <dkuzmin@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839586}

We are renaming "online" to "no throttling" for the network throttling
setting. We need to rebaseline the test expectation when the rename
rolls from devtools-frontend into chromium.

Bug: 1028078
Change-Id: Icb1db48350401d697a62b57e9dd6f825377c9c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606344
Commit-Queue: Yang Guo <yangguo@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Yang Guo <yangguo@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839585}

...at least once there's an arm cipd binary.

gclient's DEPS variables have a host_cpu variable (backed by
detect_host_arch.py in depot_tools, which even correctly returns "arm64" on
M1s), but it can't be queried via Var() in DEPS (and even if that was possible,
the x64 value is "x64" and not "amd64" like we'd need for the cipd package
name) and we can't use it in a gclient `condition` here either since we'd have
to do something like

  'src/buildtools/mac': {
    ...'gn/gn/mac-amd64'
    condition: 'host_os == "mac" and host_cpu == "x64"'
  }
  'src/buildtools/mac': {
    ...'gn/gn/mac-arm64'
    condition: 'host_os == "mac" and host_cpu == "arm64"'
  }

and then gclient would complain that we have two entries for the key
'src/buildtools/mac'. So gclient variables and cipd deps don't synergize very
well here.

However, cipd has a bunch of built-in variables too, and ${arch} is populated
based on runtime.GOARCH and that is "amd64" in x64 and "arm64" on arm64, so we
can use that:

  https://chromium.googlesource.com/infra/luci/luci-go/+/master/cipd/client/cipd/ensure/doc.go

(In fact, we could use `gn/gn/${{platform}}` and remove the conditional on
host_os. That might confuse linux/arm and windows/arm machines since we might
not have gn prebuilts for those, but trying to build on those platforms
probably doesn't work great for other reasons already?)

Bug: 1103319
Change-Id: I2d445a02e5e05f9553929404a3d569f7fe7a2213
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602663
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#839584}

Bug: 1161528
Change-Id: I80dd4f0e2950f0cbaba864fd7529dab10e15cbce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602430
Commit-Queue: Monica Basta <msalama@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#839583}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I622f5e4593f3365a4e0d93076f39aaaafb5775bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606208Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#839582}