- 17 Sep, 2020 40 commits
-
-
Sylvain Defresne authored
To allow incremental removal of set_sources_assignment_filter feature, move the global list to a separate .gni file that will need to be used by all BUILD.gn that depend on a global filter list (until they are converted). To reduce the size of the CL, the file is imported from BUILDCONFIG.gn to call set_sources_assignment_filter (and save the variable with the old name). Bug: 1018739 Change-Id: Id6f89127327e13731d7fddb839af72dd242ecce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416496 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#808026}
-
Nico Weber authored
Chrome/mac/arm builds with nacl disabled. Bug: 1117244 Change-Id: I1f44b9452b2d6692684c918ca200b3530a3a8bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416742 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#808025}
-
Olivier Yiptong authored
This change implements Mac font enumeration browser-side. The current implementation is located in blink, cached in FontCache. This browser-side implementation makes the Mac platform in-line with all the other platform implementations. A subsequent changelist removes the blink implementation altogether. Bug: 1043306 Change-Id: Ic6dff854a74d27ad6d3df9d2ef3eb5217e3e55ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410594 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#808024}
-
Stephen Chenney authored
There seem to be multiple failure modes here. Give them one bug and sort it all out as the issues get fixed. TBR: ikilpatrick@chromium.org Bug: 1129522 Change-Id: Ida9b4f6858f305e7d2f3d0f5f1b89c5949e4abd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416934Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#808023}
-
Philip Rogers authored
When a frame has a forced intersection observation, throttling should be ignored and lifecycle updates should still occur. This did not happen for forced updates that were under a throttled frame. This occurs on [1] but was not discovered due to a bug in our DCHECKS [2]. [1] external/wpt/html/browsers/browsing-the-web/navigating-across-documents/abort-document-load.html [2] https://chromium-review.googlesource.com/c/chromium/src/+/2410526 Change-Id: I25a9127faafc87ab15ac2a8fbb465c43165a2e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412252 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#808022}
-
Nico Weber authored
Due to innovation in ld64's warning output, some non-interesting warnings make it past our filters: warning: /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: archive library: clang_x64_v8_arm64/obj/third_party/perfetto/protos/perfetto/common/libzero.a the table of contents is empty (no object file members in the library define global symbols) Innovate right back. Also make it clear which of these patterns span several lines. Bug: none Change-Id: I8542ab4d82005eaa67fae4a7af398ba1ebf8220f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416830 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#808021}
-
Yann Dago authored
Bug: 243833 Change-Id: Ibe12c7396feca063344525f73e1286255fa37f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410530Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#808020}
-
Reilly Grant authored
This change implements a static requestPermission() method on the IdleDetector interface and switches the API from requiring the "notifications" permission to the new "idle-detector" permission. Bug: 878979 Change-Id: If2162f6a1f770544aeb82f98fcc65a76059b7d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359539 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#808019}
-
kylechar authored
Make sure that member variables are either default initialized or const so they must be initialized in the constructor. Bug: none Change-Id: I69d8aa51b035f37e26412604797430dda63c5717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410524Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#808018}
-
Pavol Marko authored
Split KeyPermissionsManager, KeyPermissionsManager::PermissionsForExtension and KeyPermissionsManagerUserService into a public virtual API and implementation in *Impl classes. This will be used in a follow-up CL to test interactions with KeyPermissionsManager in unit tests. Note: This CL does not change any behavior. Bug: 1127506 Change-Id: Iacbbd6e533db0b476b2fb5d6e04e241966c7bafa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413248Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Edman Anjos <edman@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Edman Anjos <edman@chromium.org> Cr-Commit-Position: refs/heads/master@{#808017}
-
Nicolas Ouellet-Payeur authored
BrowserSwitcher.Decision and BrowserSwitcher.DecisionTime are expiring soon. Set the expiry of every histogram in BrowserSwitcher.* to the same date, so we can update them all at the same time next time. Bug: 1127946 Change-Id: I0b20c342e1d7413611f826b6619e7ce47a8512d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414674 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#808016}
-
Renjie Tang authored
This code is no longer needed and breaks ARM mac. MacOS added support for the Linux-style socket option sometime between 2008 and 2010 (see links below) and Chrome currently only supports macOS versions as far back as Yosemite which was released in 2014, and iOS 10 which was released in 2016. So we are safe to remove this workaround which was added in 2013. https://opensource.apple.com/source/xnu/xnu-1504.9.37/bsd/netinet/in.h https://opensource.apple.com/source/xnu/xnu-1699.22.73/bsd/netinet/in.h https://codereview.chromium.org/99923004/diff/200001/net/udp/udp_socket_libevent.cc Change-Id: Ib67ec88aa618b977fe1f64a4862edda8c8ffefe1 Bug: 1128459 Change-Id: Ib67ec88aa618b977fe1f64a4862edda8c8ffefe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415193 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#808015}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I6d4c52d17c6b144cb916c1e90564b6a0ef170f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416396Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808014}
-
Carlos Knippschild authored
Bug: 1129504 Change-Id: Icb74a2b914c65ba2cfda14409f0d7a7642d132f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417049 Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#808013}
-
Rakib M. Hasan authored
Bug: 1050760 Change-Id: I61a688ce504575f78f43b9071370489714ea3999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414844Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#808012}
-
ckitagawa authored
This CL removes the paint preview when the tab is hidden for any reason other than the activity being hidden. This should hopefully avoid possible memory leaks by keeping the preview active for hidden tabs that didn't finish loading. Change-Id: Ibbc66d7e9303592be4e933a37490a6ead0bcb6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416770 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#808011}
-
Mike Dougherty authored
LocationBarSteadyStateTestCase/testFocusingOmniboxDismissesEditMenu Bug: 1129095 Change-Id: I7d9f7676530c3f657cc31e1be7e9b3937718297c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414566 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#808010}
-
Joshua Pawlicki authored
This reverts commit fa06bf45. Reason for revert: Believe this introduces flakiness and failures on lacros. See https://bugs.chromium.org/p/chromium/issues/detail?id=1129425 Original change's description: > ozone/wayland: gracefully shutdown the browser on protocol error. > > Wayland may disconnect the client if it hits an unrecoverable > error. That is, it prints an error message and client cannot > do anything about that after that except shutting itself down. > > Thus, while watching the display fd, always check for errors. If > a protocol error is set, trigger |shutdown_cb| and also stop > watching the fd. > > Bug: 1127278 > Change-Id: Ie324af93d455c0c83f8e75cdecfafe2254da1972 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404931 > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807775} TBR=rjkroege@chromium.org,msisov@igalia.com Change-Id: Ie1cfa657b34930ebc6e568c1d422dbfae910197a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416884Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#808009}
-
Behdad Bakhshinategh authored
This reverts commit ee15e47d. Reason for revert: Step "vulkan_content_browsertests on Android device Pixel 2" failing (crbug.com/1129552) Original change's description: > Add Google Sans to FontUniqueNameLookup browser test > > This will help ensure we have local access to the Google Sans although > the bots only verify this on Pixel devices, not on OEM devices which > retrieve Google Sans from GMScore. Currently there is only manual > verification for the latter. > > Bug: 1115064 > Change-Id: Ie3a2233e1dc972a10aaa4229a6d06ac2220607ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404852 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807921} TBR=avi@chromium.org,drott@chromium.org Change-Id: I1f626d35309e86829577f9e300ca0e4cd1fb3d0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1115064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417094Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#808008}
-
Javier Fernández García-Boente authored
When exploring breaking opportunities we were early return, and shaping to the end, when we detected that current candidate overflow and next breaking opportunity surpass the item's range end. However, since we landed in r807457 the new TextBreakIterator's behavior of breaking always after the space run, we can get some opportunities that surpass the item's range_end even if the candidate doesn't overflow. An example of this could be when trailing spaces are located in different items. This patch ensures that even when the candidate doesn't overflow, we never consider breaking opportunity offsets that surpass the item's range end; since we are not overflowing, we'll proceed with the shaping logic considering range_end as maximum of the breaking opportunity offset. Bug: 1128571 Change-Id: I704eb8091cdca00713fed15e22749bb633bacc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414196 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#808007}
-
Caroline Rising authored
Read Later is hidden behind the feature flag kReadLater. This change sets up the webui for the read later menu with basic functionality displaying unread/read items which open on click. This menu will appear in a bubble anchored to a new button in the bookmarks bar. Items can be added to this menu through selecting 'Add to Read later' from the omnibox star button. screenshot: https://screenshot.googleplex.com/394BCbWa9836Y2Y Bug: 1109316 Change-Id: I9b8ac6ea7c7bac879b8e01e074c68fe33039a915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386218 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#808006}
-
Jun Mukai authored
This reverts commit 885496b1. Reason for revert: build failures on chromeos-chrome uprev Original change's description: > Roll src/third_party/icu/ 79326efe2..d7eebbfb2 (4 commits) > > https://chromium.googlesource.com/chromium/deps/icu.git/+log/79326efe26e5..d7eebbfb276a > > $ git log 79326efe2..d7eebbfb2 --date=short --no-merges --format='%ad %ae %s' > 2020-09-16 hidehiko icu: Expand is_linux to is_linux || is_chromeos. > 2020-09-11 fdegans [fuchsia] Bring more changes from the Fuchsia copy > 2020-09-01 fdegans Upstream Fuchsia changes in build file > 2020-06-29 adetaylor Add CPEPrefix. > > Created with: > roll-dep src/third_party/icu > > Bug: 1110266 > Change-Id: I41906106d93794e7d11d65571512e9bea85352e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413511 > Reviewed-by: Eliot Courtney <edcourtney@chromium.org> > Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807389} TBR=hidehiko@chromium.org,edcourtney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1110266 Change-Id: Icae9eb5bd44fe2553cfcf3ee80c06b51bd7df62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416735Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#808005}
-
Stephen Chenney authored
The flag is expiring and there's no need to keep it. The feature is disabled only via finch for 1% and that study ends shortly, so there's no reason for users to need to flip it. The Blink feature still needs to exist until the one test that disables it is fixed. Bug: 805798 Change-Id: I342bda406c7ce4b5dc05881e0762aba835b4a159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414572 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#808004}
-
rbpotter authored
Since shared resources are now preprocessed before being passed to rollup, there should not be any <if expr> in files used as inputs to rollup. For UI specific files (not shared), preprocessing should be done before passing files to rollup by either (1) passing rollup the output of a preprocess_grit target or (2) correctly specifying preprocessing for grd entries corresponding to files using <if expr> Since there are no <if expr> in any inputs, there should also be no such expressions in the bundled output. This CL: (1) Adds a check and assert that no <if expr> are found in the bundled output files generated by rollup. (2) Removes preprocess="true" for files generated by rollup, as it should now be unnecessary. (3) Fixes a few existing cases in settings/OS settings, where preprocessing was not specified in the grd for files that use <if expr>. Bug: 1071641 Change-Id: I0f2b48af1d4b200a2f721217e8f294f296c9a5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415044Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#808003}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Change code in //remoting to check the platform before adding plaform-specific source files to "sources" variable and clear the filter to prevent regressions. Bug: 1018739 Change-Id: I55117af22cc41733056bd570907d9540168e5ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416690 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#808002}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1d8e2d5acaf5..249019878c55 2020-09-17 ianstruiksma@google.com Update WPR instructions to match new mod changes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1032253 Tbr: oysteine@google.com Change-Id: I30501c76839672eadf4d41233fa551a09c7c61df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416956Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#808001}
-
Alex Ilin authored
Otherwise, the element has 0px by 0px size which makes it difficult to style. Bug: 1129186 Change-Id: I92c32daabccfc56bc0eaf95103215093cf1a2cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414278 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#808000}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009170800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/eZF7wGbjnvEFjjXfgf2r7RFlP-O6S4MHLat3S-d47SsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Iaa7f1d387a9c0a049e5d2689fbe9b118669d8cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416798Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807999}
-
Ben Kelly authored
This CL refactors the FetchDataLoader to use a mojo::DataPipe to stream data directly to the BlobRegistry when loading to a blob. Previously it would accumulate the entire data set in memory before creating the blob which would then send it down to the registry. Streaming the data is more memory efficient for very large blobs. For example, with this CL we will be able to stream data directly from a network response to a file managed by the BlobRegistry. Bug: 1127008 Change-Id: I9748690028ac67948b49a98f2e721c4ac4c88c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404562 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#807998}
-
Sunny Sachanandani authored
This reverts commit ab1868c4. Reason for revert: Breaks sw compositing trace tests on ChromeOS GPU FYI: crbug.com/1129421 Original change's description: > gpu: Run trace tests with pixel test browser args > > Trace tests don't take extra browser args specified by the corresponding > pixel test into account. Most tests don't have any extra browser args, > but a few disable gpu compositing and don't depend on the browser args > for correctness. However, an upcoming pixel test will need its browser > args for correctness: > > https://chromium-review.googlesource.com/c/chromium/src/+/2402192 > > Bug: 1077211 > Change-Id: Ieaaa5fd0c466c8f3b52291ae903d8ab5ec7d43d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415088 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807663} TBR=zmo@chromium.org,sunnyps@chromium.org Change-Id: Ie16dc30ff94d845dd23a1e91f0488fc321e1aaa4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1077211, 1129421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416752Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#807997}
-
John Abd-El-Malek authored
This matches Chrome in that the url bar is shown at the start of every navigation if it was hidden. It will stay visible for non committed navigations (again matching Chrome), but allows the user to scroll up to hide it. Also fix this for the failed-load case. Bug: 1127937 Change-Id: I6b91a1ae17a02f5340c5160f048b77d190e4b28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415673Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#807996}
-
Clark DuVall authored
This is a reland of 7cfe51d0 The build error should be fixed by https://crrev.com/c/2416892 Original change's description: > [WebLayer] Enable WebLayer in split on canary > > This enables WebLayer in a split in WebView bundles in canary. I tested > on L-Q and ran all instrumentation tests on P with this setup. > > Bug: 1105096 > Change-Id: I517bce4109531108a4fb3af64a87aa1f5d2a91bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412705 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807252} Bug: 1105096 Change-Id: I0d179670f0979809866ae278d7a4e6fd7a58dfbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416878Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#807995}
-
Fredrik Söderqvist authored
Remove the "foreignObject zoom hack" and apply the reverse zoom factor before processing foreignObject children instead. This means that descendants of the <foreignObject> will get zoom applied "as normal" and thus they will convert back to unzoomed space properly. For resources the <foreignObject> element now needs to use a zoomed reference box because the userspace of the element is after the zoom factor has been reversed. Since font-size for <foreignObject> descendants are now subjected to proper zoom there is some changes to how text of those descendants are rendered (arguably more accurate). The ref. for svg/custom/foreignObject-font-size-on-zoom.html is adjusted to account for this. Bug: 976224 Change-Id: Id98539322d28c0cb66b57b6380d6095ab63d6d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179515 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#807994}
-
Keren Zhu authored
Requested by UX, this CL includes * Change "Dismiss" to "Got it" * Change buttons order depending on OS. * Change button padding Bug: 1121399 Change-Id: I2a019f15e5bdd6c188583922511595aa4aca6c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414836 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#807993}
-
Lei Zhang authored
Both enable-chrome-duet and enable-chrome-duet-labels have been expired for a while, and have no references anywhere else. Change-Id: Ic73397dcb831d5472172a31af7384738abdc81bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415236Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#807992}
-
Keren Zhu authored
This CL adds snooze to Tab Group IPH. It will not be in effect until Finch is set up on the server side. Future CLs: * Add UMA. * Add multi-arm Finch experiments to test on/off snooze and snooze duration. Bug: 1121399 Change-Id: I5d7396ad783c6da14fd33ed8d9d78e4b79179c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398940 Auto-Submit: Keren Zhu <kerenzhu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807991}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88907d712312..d5044ddf05e6 2020-09-17 alexrudenko@chromium.org Revert "Remove support for remote modules" 2020-09-17 tvanderlippe@chromium.org Remove support for remote modules 2020-09-17 changhaohan@chromium.org update grid adorner e2e test to include inline-grid 2020-09-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1047356,chromium:1066772 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib04062095ff5c8230a6eb6330d3739fd370ba4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416949Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807990}
-
David Bienvenu authored
Also fixes a few cpp lint warnings. No functional changes. Bug: 1010217 Change-Id: If2e666a7b57f92a0f8dce2c1b81957d89adc9122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416848Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807989}
-
Peng Huang authored
Bug: 1100728 Change-Id: Idfdd5c7f2e94c0c37665184e21c98ad01c344002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410843 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#807988}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Change code in //third_party/libxml to check the platform before adding plaform-specific source files to "sources" variable and clear the filter to prevent regressions. Bug: 1018739 Change-Id: Iba4ae10ec163ce8b7ba3774cd47ebba7ad92f29a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416350 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#807987}
-