- 09 Oct, 2019 40 commits
-
-
Oleg Davydov authored
Class ContentHashWaiter is declared in content_hash_fetcher_unittest.cc but can also used in other tests, so it makes sense to move it to test_utils.h under content_verifier directory. Bug: 796395 Change-Id: I238a77018efa730153ede75a659b846d2a181103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847296 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704113}
-
Eric Seckler authored
This reverts commits bea22be5 and d51c2555 Reason for revert: crbug.com/914092 should now be fixed Original change's description: > Disable tracing benchmark amazon and bing on Windows. > > tracing.tracing_with_background_memory_infra/http://www.amazon.com > is flaky on windows. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=tracing.tracing_with_background_memory_infra%2Fhttp%3A%2F%2Fwww.amazon.com&testType=performance_test_suite > > Bing is also flaky on windows: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=tracing.tracing_with_background_memory_infra%2Fhttp%3A%2F%2Fwww.bing.com%2F&testType=performance_test_suite > > THe error is > > (ERROR) 2018-12-20 01:29:53,039 page_test_results.Fail:587 Failure recorded: TraceImportError: Unable to select a master clock domain because no path can be found from "TELEMETRY" to "WIN_QPC". > at ClockSyncManager.ensureAllDomainsAreConnected_ (/tracing/model/clock_sync_manager.html:283:17) > at ClockSyncManager.selectModelDomainId_ (/tracing/model/clock_sync_manager.html:254:12) > at ClockSyncManager.getModelTimeTransformer (/tracing/model/clock_sync_manager.html:156:14) > at TraceEventImporter.toModelTimeFromUs_ (/tracing/extras/importer/trace_event_importer.html:3368:42) > at TraceEventImporter.processCompleteEvent (/tracing/extras/importer/trace_event_importer.html:586:16) > at TraceEventImporter.processEvent_ (/tracing/extras/importer/trace_event_importer.html:1245:30) > at TraceEventImporter.importEvents (/tracing/extras/importer/trace_event_importer.html:1148:16) > at importer (/tracing/importer/import.html:198:65) > at task.subTask (/tracing/importer/import.html:145:32) > at Task.run (/tracing/base/task.html:80:50) > > See https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=a09f20a96be90a851afcae573b59b2e9c47b55f7&as=tracing.tracing_with_background_memory_infra%5Cbenchmark_log.txt > TBR=charliea@chromium.org > NOTRY=true > > > Bug: 914092 > Change-Id: I1125eaccf4b68863d75b48998f5731330074c169 > Reviewed-on: https://chromium-review.googlesource.com/c/1387551 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618289} TBR=crouleau@chromium.org TBR=charliea@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 914092 Change-Id: Id1956e8e7a8d29539ff92fcd038b8f5ce53bf6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849372 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#704112}
-
Kinuko Yasuda authored
TBR=wangxianzhu@chromium.org Bug: 1012638 Change-Id: Ic7af4fd1616459f5858d829c77c502748be5b0f6 No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849490 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#704111}
-
Rune Lillesveen authored
For native rendering of form controls on Mac, use a dark theme when the used value of color-scheme is dark, and a dark theme is available in the MacOS version. Bug: 929098 Change-Id: If5af6192a6b1d722b6c16926e3b14c05a75bca0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848691Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#704110}
-
Ionel Popescu authored
This CL updates the datalist UI for date related types. Pixel tests are added to validate the new UI. Bug: 1011681 Change-Id: I4a6fd18f563fa1d8cf9247bb4c024c1cebe45440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844071 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#704109}
-
Adam Rice authored
Check that the "connection" and "closed" promises are resolved or rejected correctly in the WebSocketStream unit tests. BUG=983030 Change-Id: I1c6b8aa72438f75a7b078fa49c58b844fe6bde0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847231Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#704108}
-
Himanshu Jaju authored
This change would be followed up by transport mode name changes. Bug: 1009454 Change-Id: I53041f711e157df69ef03218539032229cb9fc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845391Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#704107}
-
Alexander Timin authored
Do not put offline pages in back-forward cache as if we have network, we should reload the full page and if there is no network, offline page will be reloaded. R=jianli@chromium.org CC=bfcache-bugs@chromium.org BUG=1001087 Change-Id: I2dd9fea312a4ced6355ad3aaa052aeb44ca99779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837625Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704106}
-
Dominik Röttsches authored
Mark virtual/threaded/external/wpt/css/css-animations/animation-opacity-pause-and-set-time.html as flaky under threaded compositing. Bug: 1012600 TBR: drott Change-Id: I5519ff7dc239ffafcc0526f354ba663e9f0c4a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849012 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#704105}
-
Adam Rice authored
Previously, initialisation of ReadableStreamNative, WritableStreamNative and TransformStreamNative objects was done in the constructor. However, this resulted in calling into JavaScript inside the constructor, which could cause problems with garbage collection. Move the code from inside the constructor to a separate InitInternal() method which is called from Create(). The content of the new methods is copied verbatim from the constructors so there should be no functional differences. Manually tested. There are no automated tests as I don't know how to make them not be flaky. BUG=1008470 Change-Id: I394cc60b0bac397dccbef18ca166a66528c22bd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837326Reviewed-by:
-
Huanzhong Huang authored
At this point cookie controls setting is exposed only in incognito mode. This cl makes changes to the setting being persisted across incognito sessions. Bug: 967668 Change-Id: Icc42a7365186af5ccc74777236574ee9813ae3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844819 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#704103}
-
Yoshifumi Inoue authored
This patch changes |LayoutInlineCollector| to use |IsDescendantOf()| instead of using |HashSet<T>| to make |SelftFragmentsOf()|, which is used by hit testing and others, faster. I found the slowness of |LayoutInlineCollector| by CPU profiling[1] where |HashSet<T>::insert()| consumes most of time. So, it seems traversing fragment tree + LayoutObject::IsDescendnatOf()| is faster than two times of traversing fragment tree + |HashSet<T>::insert()|. [1] https://bit.ly/2pXQbcE Bug: 1008523 Change-Id: I825197f2b85fd2ef573e8ff159ddf966489361be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847602 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#704102}
-
Roman Sorokin authored
Bug: 1001458 Change-Id: Id88dd59b8a97df515c3bbaa3f4e5cea3c356eda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844982 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#704101}
-
Lukasz Anforowicz authored
This CL partially reverts r666946 [1] - after r694827 [2] same-origin requests can be detected directly, by looking at the request_initiator field of network::ResourceRequest. [1] https://crrev.com/c/1642752: [CORS] Partially rely on factory bound initiator origin. [2] https://crrev.com/c/1633232: Set |request_initiator| to the website, not to the content script's origin. Bug: 940068 Change-Id: Ib82b83a8b25338c40a5d0a3a550d98e8e09db67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834952Reviewed-by:
Mike West <mkwst@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#704100}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I543d9b9e31bae35abb6ea749514d4724f6cdc24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848855Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704099}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e986cb92544a..c932f3309322 git log e986cb92544a..c932f3309322 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 beaufort.francois@gmail.com Attribute offset needs to be multiple of 4 bytes Created with: gclient setdep -r src/third_party/dawn@c932f3309322 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I6c3a9356bffabccdaa02b5f77edb3a5024990c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848878Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c6dbc23aeca4..713e9ad3279d git log c6dbc23aeca4..713e9ad3279d --date=short --no-merges --format='%ad %ae %s' 2019-10-09 simonhatch@chromium.org Pinpoint - Cache resolves to HEAD Created with: gclient setdep -r src/third_party/catapult@713e9ad3279d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1012200 Change-Id: Ie90850f5047a5d0964367d5767eeb010920aae29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848853Reviewed-by:
-
Julian Watson authored
Change-Id: Ib5ed389fe154f5c32d1db4f8ea5c8be281ac9d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846619 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#704096}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77dde599c98a..54548626a977 git log 77dde599c98a..54548626a977 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a333b87cfcbe..8e7d9d6c2326 (9 commits) Created with: gclient setdep -r src/third_party/skia@54548626a977 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None Change-Id: If94791f9695bd7df6bb8aaa997b0754706bad4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848882Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/44e07101f19f..f86cc6ba6a29 git log 44e07101f19f..f86cc6ba6a29 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 zhuohao@chromium.org kukui: add firmware builder Created with: gclient setdep -r src/third_party/chromite@f86cc6ba6a29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2073a146bb449505238353d2c8019949ca11ac0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848894Reviewed-by:
-
nancy authored
After install the ARC app, update the equivalent Chrome app to add the badge on the icon. When the ARC app is removed, update the equivalent Chrome app to remove the badge on the icon. This is the follow up for crrev.com/c/1833006 to implement the the change in extension_apps. This CL breaks unit tests when testing multiple profiles: NoteTakingHelperTest.AddProfileWithPlayStoreEnabled WebAppInstallTaskTest.InstallWebAppWithParams_GuestProfile The reason is IsArcAllowedForProfile returns true for any profile under tests. crbug.com/1010137 is used to fix that. Since that is out of the scope of this CL, for this CL, a work around is implementted to look up |user_to_profile_for_testing_| map before going to the default primary user. Bug: b/141388525 Change-Id: Ic11965d72ec6ad1636cd0765f57cadc377bd5479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824307 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704093}
-
Yusuke Sato authored
This allows chrome/ and components/ unit tests to cover the cases where D-Bus signals (e.g. VmStoppedSignal) are sent from Concierge. BUG=b:142144019 TEST=try Change-Id: I40b715344450e9a9dd44211a47b9c49212d5d42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846025Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#704092}
-
Yusuke Sato authored
This allows arc::ArcSessionManager to restart the VM when needed. BUG=b:135556154, b:141966414 TEST=kill off ARCVM's crosvm, verify the observer detects the event. Change-Id: Iba71de782db078b1b89d196ef06c749ebd17f260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841250Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#704091}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 309b078c. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9b5ff08abc7085d73a5bc213c2a529acb177f5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849231Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704090}
-
Hsin-Yu Chao authored
Some CrOS platform will support BT wideband speech, and CRAS will change to report type BLUETOOTH_NB_MIC for the legacy narrow band input, while output and wideband speech input stay in type BLUETOOTH. In commit 087ec22e we lowered the priority of BT input because using HFP means BT output falls to lower quality. Users don't like it and don't understand the technical detail behind that. With the support of wideband speech, we think the audio quality is acceptable and deserves equal node priority as BT output. Bug: 1000576 Change-Id: I3c027afe349c6b9c3d55cf0e3a0472e28863cedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828765 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Auto-Submit: Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#704089}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4d6ee0d7320..cb5338375637 Created with: gclient setdep -r src-internal@cb5338375637 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I86c552fd7543c453a89034a498f286bdc16fca90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848877Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704088}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7de9f95df905..8e7d9d6c2326 git log 7de9f95df905..8e7d9d6c2326 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 kbr@chromium.org Add EGL_ANGLE_device_cgl extension. Created with: gclient setdep -r src/third_party/angle@8e7d9d6c2326 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ieb96b7b38b1e9d172f713dcab0b3a830d12022f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849191Reviewed-by:
-
Manu Cornet authored
As far as I understand, it was introduced in the past because the app list UI used to be outside of ash. As things are currently, this artificial divide creates significant unnecessary complexity within ash/app_list, with functionality spread over several classes with semi-ridiculous names (e.g. app list presenter delegate impl) and a class hierarchy designed to overcome the divide, and a lot of duplication and passing information (between the app list controller, the app list presenter, the app list presenter delegate, each one with its "impl" class) that slows down development and makes understanding the class structure difficult. The historical reasons for this separate namespace are no longer relevant. With everything in the "ash" namespace, the next step will be to start consolidating and reduce over-engineering. There were a few naming conflicts: with SearchResultType, that was resolved by renaming one of them to AppListSearchResultType, one with DialogPlate (one was postfixed with "Deprecated") and another with AssistantMainView (same resolution). This contains no semantic change and doesn't have any expected user-visible implications. Change-Id: I0755476a1fb7a6f0898258dee6e8981b7358c904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838269 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Ethan Jimenez authored
1. Exposing `AXRange` code for comparing endpoints; this is done since such logic is currently specific to `AXRange::AsForwardRange`, but it could be used elsewhere to ensure text ranges are well-formed. 2. Fixing a bug in `ITextRangeProvider::GetAttributeValue` that caused it to include values from an unexpected anchor if either one of the range's endpoints was located at the start or the end of such anchor without spanning a single character of its text representation. In order to fix this, at the beginning of `GetAttributeValue` we normalize the text range by moving the start and end endpoints to positions located right before and after a character respectively. Note that such normalization may change the position of the endpoints in the `AXTree`, but they should still be equal as text positions. 3. Fixing a bug in `ITextRangeProvider::ExpandToEnclosingUnit` that, after enclosing the last word on a line before a `<li>` element, caused `GetBoundingRectangles` to include the bounding rectangle belonging to the list item marker of the following `<li>`. Similar to #2, the fix for this issue involves normalizing the range's endpoints before returning in `ExpandToEnclosingUnit`. 4. Adding test coverage for the scenarios described in #2 and #3. 5. Fixing some minor issues of validating `ITextRangeProvider` calls. Bug: 928948 Change-Id: I2f40545eca20c53db8d4cbabb36f17a27799e987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838707 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#704085}
-
Hajime Hoshi authored
This adds new metrics for eviction by back-forward navigation: BackForwardCache.EvictedAfterDocumentRestoredReason BackForwardCache.EvictedAfterDocumentRestoredReason records the reason why the page is evicted from back-forward cache e.g., by the race condition with JavaScript. This is separate from a regular eviction metrics because restoring the document happens once. Bug: 1004676 Change-Id: I0d0475022e6f8a7edbcfbb0cd43e634f63292efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828766 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0f9dd4eb407b..44e07101f19f git log 0f9dd4eb407b..44e07101f19f --date=short --no-merges --format='%ad %ae %s' 2019-10-09 vapier@chromium.org pylintrc: add isort module settings 2019-10-09 vapier@chromium.org cros lint: fix running under Python 3 2019-10-09 dburger@chromium.org Stop AFDO uprevs by the chrome PFQ. Created with: gclient setdep -r src/third_party/chromite@44e07101f19f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibf1a041506b8272db86d605b913711de452d66b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849331Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b1a25a4d324..77dde599c98a git log 2b1a25a4d324..77dde599c98a --date=short --no-merges --format='%ad %ae %s' 2019-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5c41949c..309b078c (481 commits) Created with: gclient setdep -r src/third_party/skia@77dde599c98a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None Change-Id: I15e1258b6601768e4c5dc96c2ba500471313a268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849251Reviewed-by:
-
Eric Willigers authored
The proto used by WebAppSyncBridge and WebAppDatabase now contains DisplayMode. TBR=dominickn@chromium.org Bug: 1009909 Change-Id: Ic720d4837f5b6fb15e4f025370bc8d3191a8d2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846634Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#704081}
-
Junyi Xiao authored
Issue: the "more tabs" dropdown button doesn't have enough contrast when hover/keyboard focused in dark theme This change changes the hover/focused color to match the rest tool bar button Screenshots: https://imgur.com/a/TBoOlzR Bug: 963183 Change-Id: I9ff66c3be732cf598d18d71af643d01a7de5ce54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841580Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704080}
-
Anushruth authored
Temporary fix for chrome_all_tast_tests_informational as it takes more than 60 minutes to complete a run. Tast tests cannot be sharded yet (See crbug.com/968262). Also includes a bugfix which replaces use of 'str' to 'encode' as some informational tests use '
🔥 ' '❄ ' characters. Timeout example: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel-hw-tests/15876 Bug: 988581 Change-Id: Idd85797811d722289176565e452d163d6e8bb3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839018 Commit-Queue: Anushruth <anushruth@chromium.org> Reviewed-by:Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#704079}
-
Ramin Halavati authored
Three incognito icon resources are updated to match the new material design. Bug: 997054 Change-Id: I4fd65a6e91992eea88a72f19dc4deeabf41b2b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794862Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#704078}
-
Abhijeet Kandalkar authored
This CL converts usage of |ProducerClientRequest| to |mojo::PendingReceiver<mojom::ProducerClient>| Bug: 955171, 978694 Change-Id: I54d5a576b097e98c9d80bdf966d2f92262d24d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842174Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#704077}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b45c693f..6092f6bc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifdeb051941a7f2cb8c8228ee3b78d56aeab07058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848622Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704076}
-
Shuo-Peng Liao authored
In media/gpu/v4l2/v4l2_device we have V4L2PixFmtToVideoPixelFormat() and VideoPixelFormatToV4L2PixFmt() to convert V4L2PixFmt (fourcc code) to VideoPixelFormat, and vice versa. Also, in media/gpu/vaapi/vaapi_utils, we have VideoPixelFormatToVAFourCC() to convert VideoPixelFormat to VAFourCC (fourcc code). As we plan to use fourcc to replace VideoPixelFormat to represent video format in platform-agnostic class (refer to crbug.com/1005636). However, since the use case right now is restricted to ChromeOS V4L2/VAAPI, we move the converters to media/gpu/chromeos. Also, to break the dependency on platform-specific headers like <linux/videodev2.h> and <va/va.h>, for V4L2 and VAAPI, respectively, we defines a set of commonly used Fourcc enum with value based on V4L2 definition. Then we define a Fourcc class to store fourcc enums and to provide converters Fourcc <-> {VideoPixelFormat, V4L2PixFmt, VAFourcc}. Finally, though many V4L2 and VAAPI fourcc map to the same VideoPixelFormat have the same value, there exists some exception. For example: I420 in V4L2: V4L2_PIX_FMT_YUV420 (Fourcc "YU12") I420 in VAAPI: VA_FOURCC_I420 (Fourcc "I420") BUG=1005636 TEST=Pass CQ Change-Id: Id1099120a86c1964fee9ce7058a3cf2ede6e5ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828763 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704075}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/955a6a3e261a..e4d6ee0d7320 Created with: gclient setdep -r src-internal@e4d6ee0d7320 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0312ed0123f82b1cd4163e39fde559e41aadb75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849091Reviewed-by:
-
