- 23 Jun, 2018 5 commits
-
-
Becca Hughes authored
Adds some WPT tests to test env() with @supports as well as fallback values. BUG=825890 Change-Id: I071f5c2582f8056fe39b4a50ab62140d579c577d Reviewed-on: https://chromium-review.googlesource.com/1111023Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569852}
-
Sammie Quon authored
This does not fix for non-unified system tray. Test: manual Bug: 855216, 812536 Change-Id: I1705d248e784ad8f021b4d13d76956187f1d94a1 Reviewed-on: https://chromium-review.googlesource.com/1110946Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#569851}
-
Kevin Marshall authored
This is a prerequisite step toward supporting multi-package deployments. * Replaces all calls to fuchsia_executable_runner() with package and script generation targets. The revised rules are simple enough that fuchsia_executable_runner() is no longer a major convenience. * Delete test_runner_script() for the same reasons. * Use sensible defaults for things like sandbox_policy to clean up the parameters for most instances of the rules. Bug: 855242 Change-Id: I2f04e1baa9afaf24cfd5d979d33e9912a0475e55 Reviewed-on: https://chromium-review.googlesource.com/1110749Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#569850}
-
Min Qin authored
Currently DownloadManagerImpl intializes InProgressDownloadManager. However, when only ServiceManager is running, DownloadManagerImpl will not be created. As a result, some other class will initialize InProgressDownloadManager. And when chrome fully starts, DownloadManagerImpl needs to know whether InProgressManager has been initialized. This CL allows InProgressDownloadManager to take more callbacks to notify when initialized. So multiple classes can observe the initialization event. BUG=842245 Change-Id: I5881b10db0f93f98262ab1baebc67621c2743fbe Reviewed-on: https://chromium-review.googlesource.com/1111027 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#569849}
-
Nate Fischer authored
We recently introduced a series of ApiHelperFor* classes to help us ensure the WebView APK's classes pass compile-time verification in order to avoid runtime verification (which causes logspam and startup penalties). However, proguard was inlining these classes in our release builds, which re-introduced the class verification issues. This adds an annotation to prevent inlining. The @DoNotInline annotation is used to configure Proguard. R=torne@chromium.org (tested on L,M,NMR1 with standalone webview and monochrome) android-webview-google -v --pageset-repeat=1 (no startup penalty on L device) "StatusRetryVerificationAtRuntime" (ensure the fixed classes no longer show up) Bug: 791099 Bug: 838702 Test: adb logcat | grep 'Failed resolution of' Test: tools/perf/run_benchmark system_health.webview_startup --browser \ Test: use oatdump after installing APK. Then, grep for Change-Id: I7e85718916313f03287e5f2d5fe8f51a02661f11 Reviewed-on: https://chromium-review.googlesource.com/1109464Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569848}
-
- 22 Jun, 2018 35 commits
-
-
Matt Falkenhagen authored
context_ is a weak ptr and if shutdown is happening resource_context() is null. Bug: 851829 Change-Id: Ie1353b4fd583f88cc791227e2afd9ba27c3d39eb Reviewed-on: https://chromium-review.googlesource.com/1111766Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#569847}
-
Esmael El-Moslimany authored
Bug: 845576 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I57ccafda9dc31d616f4e94c1d9077cdbc951ae28 Reviewed-on: https://chromium-review.googlesource.com/1112631Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#569846}
-
Zhongyi Shi authored
There was a typo in the test which caused the test to V1 behavior previously. Bug: 843299 Change-Id: I255226a5f2febea541017fee1a27eb53141b12fa Reviewed-on: https://chromium-review.googlesource.com/1112652 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569845}
-
Ted Choc authored
BUG=852297 Change-Id: Ia18c775059b61c90e2c10050699ebb256233c7b1 Reviewed-on: https://chromium-review.googlesource.com/1106423 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#569844}
-
Ryan Landay authored
This is an easy change to make the tabs taller in the Android horizontal tab switcher (by reducing how much they're cropped at the bottom). Even after this change, there's still some cropping at the bottom as a result of some interesting math in TabLayer::SetProperties(), so if we can fix that, the tabs will be even taller. Bug: 849401 Change-Id: Ic5ff94c5cc012806ed05c48dfe94b668532d054d Reviewed-on: https://chromium-review.googlesource.com/1112662Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#569843}
-
Ken Rockot authored
Was botched a bit by r569686. This CL fixes the two problems: - FDs will once again be properly retained by a sender until the receiver acknowledges their transmission - If a message fails to send and is queued for retransmision, it will actually retain its FDs instead of replacing them with invalid ones. TBR=jcivelli@chromium.org Bug: 753541 Change-Id: I0c045f25eb1c9f1a89925f6cdc29ffcffea3d7b3 Reviewed-on: https://chromium-review.googlesource.com/1112651Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569842}
-
Ryan Hansberry authored
Inject a SecureChannelClient and RemoteDeviceRef (representing the local device) into ProximityAuthSystem, which are required by RemoteDeviceLifeCycle in order to establish a secure connection to a remote device. R=jhawkins@chromium.org, khorimoto@chromium.org Bug: 824568, 752273 Change-Id: Iab717e9b9a9d1e992da661406d4d8ddd233c2d6d Reviewed-on: https://chromium-review.googlesource.com/1109505 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#569841}
-
Wenzhao Zang authored
1) Add tabIndex to all the buttons on the new wallpaper picker and add event listener for the Enter key. 2) Save the images info to sync and local storage, so that when the picker is open without network, there are still some offline wallpapers available for users to choose from. Bug: 835195 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie4639ab7e21d14a137c4ac9db45967d43e2c3c09 Reviewed-on: https://chromium-review.googlesource.com/1098471 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#569840}
-
Wenzhao Zang authored
The resume token is generated by the Backdrop wallpaper server by encoding the list of all wallpaper IDs that a particular device has used. Overtime, this value can become a unique identifier to each individual device. To mitigate the privacy impact, the client should discard the resume token returned by the server. The disadvantage is that, there's no way to avoid duplicate images (1/N probability of returning the same daily refresh wallpaper). We'll need to implement the mechanism to avoid duplication on the client-side later (likely in wallpaper_manager.js). Bug: 843537 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia03170f5d8c320f977407e67c8d916c3a2264c9d Reviewed-on: https://chromium-review.googlesource.com/1110745Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#569839}
-
Ryan Hansberry authored
R=khorimoto@chromium.org Bug: 824568, 752273 Change-Id: I4ee3b3e108a7bc82570e97dbfe460adb0fbe6ec8 Reviewed-on: https://chromium-review.googlesource.com/1108383 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569838}
-
Frank Liberato authored
Bug: 844494 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia5cac58367ca7e532c92f16a4418397c38230216 Reviewed-on: https://chromium-review.googlesource.com/1110437 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#569837}
-
Wei Li authored
The original CL https://crrev.com/c/1102026 got reverted due to failed test BrowserViewTest.BrowserFullscreenShowTopView on "Mac ASan 64 Tests (1)" bot. The failure is most likely due to that the system preference for "always show toolbar in full screen" may be different on different bots. This CL explicitly set up the preference at the beginning of the test. Original change's description: > [MacViews] Show/hide top UI in fullscreen mode correctly > > Unlike Windows and Linux, Mac allows top UI to show or hide in browser > fullscreen mode. Also this option can be toggled at runtime to make the > change. But in tab fullscreen mode, top UI should always hide. These > require propagating fullscreen and user preference changes, recording > the toolbar styles and applying the layout accordingly. > > This CL makes sure the top chrome UI status is correct across different > fullscreen modes, and responds to user changes as well. Some tests are > also added. > > BUG=851261,831219,852779 > TEST=Pls check the toolbar/tabstrip show or hide correctly when > entering and exiting various fullscreen modes. Bookmark bar, slide-down > menu and traffic lights will be fixed later. > > Change-Id: I78a2b68821d5e633ac5c2823f65390809a57dad5 > Reviewed-on: https://chromium-review.googlesource.com/1102026 > Commit-Queue: Wei Li <weili@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Sarah Chan <spqchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569301} Change-Id: I37a2641b5a578dabcf922792158c0f13b2e197e8 Reviewed-on: https://chromium-review.googlesource.com/1111015 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569836}
-
Alex Newcomer authored
Add a right alignment option for touchable menus. Bug: 846940 Change-Id: I5a41d915fa76eff9d99ebb5d2b57a68c79d53082 Reviewed-on: https://chromium-review.googlesource.com/1103381Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#569835}
-
Marijn Kruisselbrink authored
With network service there should always be a BlobURLToken/blob URLLoaderFactory, so this fallback code should never be reached. Tbr: jam@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 800901 Change-Id: I6e1446f9ed5b5f43c4e5f3be27b098d8401b6a51 Reviewed-on: https://chromium-review.googlesource.com/1112663 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569834}
-
Lei Zhang authored
Change-Id: Idc244d82ccadc7b38376eba585e2aca7977d1038 Reviewed-on: https://chromium-review.googlesource.com/1112638Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#569833}
-
Zhongyi Shi authored
These tests verify that connection migration on write error can eventually succeed and rewrite the packet on the new network after multiple consecutive write errors. Bug: 818259, 843299 Change-Id: If9e3672dd8fb07b65aa5fa9a892ec2a7dec7babc Reviewed-on: https://chromium-review.googlesource.com/1112630Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569832}
-
Scott Violet authored
BUG=none TEST=none TBR=msw@chromium.org Change-Id: I7b5ef0675bdc920380fccd3c78d1860f01c7f34c Reviewed-on: https://chromium-review.googlesource.com/1112626Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#569831}
-
sczs authored
- Changes the current SigninPromoView implementation to use a UIStackView. Screenshots Old: https://drive.google.com/open?id=1k4_CJMGyM0shDfjmw3W4cfq1_6mTVLTD https://drive.google.com/open?id=1AT7VnSVVPBcHJ-0FuTrpnbDQ2Xye5ByF New: https://drive.google.com/open?id=1fUECZTt5dXPjqNJtgxnfsLE0xWTvE5Fo https://drive.google.com/open?id=1H1aWOm__89dG6YsjnHfSX1X29FAFp-li Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I275bd9c8af32507a1f484b34b44f58b72003c2c4 Reviewed-on: https://chromium-review.googlesource.com/1109579Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#569830}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9fff1c76c108..b59b36610e39 git log 9fff1c76c108..b59b36610e39 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 thestig@chromium.org Fix some nits in gold.py. 2018-06-22 rharrison@chromium.org Follow up to removing JS alert/beep magic numbers Created with: gclient setdep -r src/third_party/pdfium@b59b36610e39 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I60cb9defce3029a3bcff490599e96462f206ea8b Reviewed-on: https://chromium-review.googlesource.com/1112228Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569829}
-
Devlin Cronin authored
Don't allow extensions to debug file:-scheme URLs if the extension does not have explicit file access (as set in chrome://extensions). Achieve this by introducing a new virtual method on DevToolsAgentHostClient to allow the implementor to check if a given host is allowed to be inspected. Add regression tests for the same. Bug: 666299 Change-Id: Icb5ee89bf788643eee166eef83802d10ab825a6c Reviewed-on: https://chromium-review.googlesource.com/1104954 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569828}
-
Xi Cheng authored
This CL introduces new structs InternalFrame and InternalModule for sampling data transfer from NativeStackSampler to ProfileBuilder. After the transfer, ProfileBuilder converts InternalFrame/InternalModule to Frame/Module, and deduplicates modules. Bug: 851163 Change-Id: I550a80d2528688ebef95066d9781104976063950 Reviewed-on: https://chromium-review.googlesource.com/1108957 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569827}
-
Bret Sepulveda authored
The home button's width was being set to 0 when it was off, which caused its ink drop to be also set to size 0, but the ink drop isn't updated when the bounds change later. This patch fixes this by having the home button's width never be set to 0. A test was hitting a DCHECK because of this, so that test is re-enabled. Bug: 853990 Change-Id: I5313aead457c4c51db6c8201ad9bc8e652935e52 Reviewed-on: https://chromium-review.googlesource.com/1109270Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#569826}
-
Ryan Hansberry authored
This injects SecureChannelClient and local device into RemoteDeviceLifeCycle, both of which are used to make a call to SecureChannel service. If the chromeos::features::kMultiDeviceApi flag is enabled, they are used to create an authenticated BLE connection to the remote device, instead of using BluetoothLowEnergyConnectionFinder. This change also injects a real ClientChannel into ProximityAuthMonitor. R=jhawkins@chromium.org, khorimoto@chromium.org Bug: 824568, 752273 Change-Id: Iefb03d1356ea7e8f5aac0136c8d7a4280302da16 Reviewed-on: https://chromium-review.googlesource.com/1107490 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569825}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96b1ecc25d00..c5c3df66430a git log 96b1ecc25d00..c5c3df66430a --date=short --no-merges --format='%ad %ae %s' 2018-06-22 ruiqimao@google.com renamed samplecode/Nima to samplecode/SampleNimaActor 2018-06-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-22 borenet@google.com Presubmit: blacklist .recipe_deps 2018-06-22 bungeman@google.com Make fontmgr_bounds change with veryVerbose 2018-06-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-22 csmartdalton@google.com ccpr: Recycle the stashed atlas's texture explicitly 2018-06-22 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader a9969b2ab8c3..932640b2d9cd (1 commits) Created with: gclient setdep -r src/third_party/skia@c5c3df66430a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: Ia5f798a4063e47af1cd453473ba05c4d905f2f76 Reviewed-on: https://chromium-review.googlesource.com/1112226Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569824}
-
Eric Karl authored
Make ExternalBeginFrameControllerImpl implement ExternalBeginFrameSource directly, and rename to ExternalBeginFrameSourceMojo. This allows GpuDisplayProvider and RootCompositorFrameSink to deal with an ExternalBeginFrameSource directly, allowing for alternative implementations to be dropped in in the future. To allow this, Display assignment is moved from RootCompositorFrameSink and a new DisplayObserver callback is added to handle cleanup/lifetime. Bug: 811967 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I3e1475ebe6338eef4bbee5d98a06a4215c254485 Reviewed-on: https://chromium-review.googlesource.com/1109027 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#569823}
-
rbpotter authored
Fix failing extensions browser tests for Polymer2. Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I00cb68204fa3206f29e50d7044e50f1e6b8cc753 Reviewed-on: https://chromium-review.googlesource.com/1109450 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#569822}
-
Peter Kasting authored
This standardizes callers on using GetLayoutConstant(TAB_HEIGHT) for the tab height, instead of using a variety of methods. It simplifies a few places slightly and reduces the dependencies on tab.h slightly. To avoid excess verbosity in tab_unittest.cc, this also gives Tab a preferred size, solely so tests can call SizeToPreferredSize(). BUG=none TEST=none Change-Id: I15f22caee10f4acf5d3992d88133f5edf2d6e33a Reviewed-on: https://chromium-review.googlesource.com/1107299 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#569821}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c48318a35b17..08d753e88484 git log c48318a35b17..08d753e88484 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-22 tandrii@chromium.org Revert "bot_update: Don't force solutions to be unmanaged." 2018-06-22 tandrii@chromium.org Revert "Wipe out shallow checkout support from bot_update." 2018-06-22 tandrii@chromium.org Wipe out shallow checkout support from bot_update. Created with: gclient setdep -r src/third_party/depot_tools@08d753e88484 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812,chromium:853032,chromium:855700,chromium:855137,chromium:855700,chromium:855137 TBR=agable@chromium.org Change-Id: I9f3c95031934c4be4cbdb53960a09bd707f61bc6 Reviewed-on: https://chromium-review.googlesource.com/1112227Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569820}
-
Marijn Kruisselbrink authored
This class was the initial attempt at adding blob URL support to the network service, but later a different approach was taken for blob URLs where a explicit URLLoaderFactory needs to be passed in for every blob URL fetch. Getting rid of the old code revealed some places where the new code doesn't pass in a blob URL Loader Factory, so fallback code is added to those places (in NavigationControllerImpl for browser initiated navigations and in RenderFrameHostImpl for renderer initiated navigations) to make sure things keep working in all cases. Bug: 800901 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Icebab3007bef73910b20f6994c963c36f090605e Reviewed-on: https://chromium-review.googlesource.com/1100100 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#569819}
-
Ramya Nagarajan authored
Change-Id: I14c3080d8b042d64339594ce5e4cbb5fcdc77034 Reviewed-on: https://chromium-review.googlesource.com/1112645Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569818}
-
edchin authored
Using the tab strip to close a tab crashes on iPad when using multitasking. The difference when running multitasking is that |-viewDidDisappear:| is not called on the tab grid. This may be a race condition. The view controller lifecycle documentation shows that the "Did" methods are not guaranteed to be called. Quick successive presentation/dismissal calls can cycle just between the "Will" methods. This CL changes the bookkeeping in grid view controller to use the "Will" methods. Bug: 849608 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idf3a95ad8d07d7f0dc1f64a6009f92eff07d5bc3 Reviewed-on: https://chromium-review.googlesource.com/1112378Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569817}
-
Alex Newcomer authored
Fixes menu positioning miscalculations in ShelfView, also refactors GetMenuAnchorRect so its more readable. Bug: 852153 Change-Id: Ie8c377de9b2191c3ae739f5adec7f16fc8003bd7 Reviewed-on: https://chromium-review.googlesource.com/1102028 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569816}
-
Dale Curtis authored
This implements the codec string processing as described here: https://aomediacodec.github.io/av1-isobmff/#codecsparam Valid mime types look something like the following: "av01.0.04M.10.0.112.09.16.09.0" "av01.0.01M.08" Bug: 784607 Test: New unit tests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I320dbdc4571b49a6ccea0a464c10f8ba4e656037 Reviewed-on: https://chromium-review.googlesource.com/1109412 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#569815}
-
Parastoo Geranmayeh authored
Sometimes, server misidentifies countries and states, and we can handle it with rationalization. This usually happens when the form/field signature of the two are identical. See go/rationalize-repeated-fields. Tests + Refactoring. Fixes: www.coolstuffinc.com Bug: 850220 Change-Id: I85f601cd37f6c24b51423c8d3ccee0fc117f4f12 Reviewed-on: https://chromium-review.googlesource.com/1099559 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569814}
-
Marijn Kruisselbrink authored
This will make it possible to check if the feature is enabled from outside blink, and will also make it easier to turn the feature back off if necesary after trying to launch it. Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 800901 Change-Id: I4cba8299c9f43727b5d52cb5c329d0da296e2b59 Reviewed-on: https://chromium-review.googlesource.com/1110846 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569813}
-