GitLab

TBR=benwells@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11434117

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171066 0039d316-1c4b-4281-b951-d872f2087c98

It's only accessible at chrome://settings/managedUser and requires the --enable-managed-users switch.

Also, not all of the settings are hooked up yet.

TBR=ben@chromium.org,cpu@chromium.org
BUG=163884


Review URL: https://chromiumcodereview.appspot.com/11414294

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171065 0039d316-1c4b-4281-b951-d872f2087c98

1. src/chrome/browser/nacl_host
2. src/chrome/browser/automation
3. src/chrome/browser/autofill
4. src/chrome/browser/autocomplete
5. src/chrome/browser/captive_portal
6. src/chrome/browser/geolocation

Review URL: https://chromiumcodereview.appspot.com/11415289

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171064 0039d316-1c4b-4281-b951-d872f2087c98

to catch memory problems early, easily, and cleanly.

This is disabled by default.

Because of gyp limitations, the flag is to force-disable the feature, but there is no flag to force-enable it.

BUG=30715
TEST=none

Review URL: https://codereview.chromium.org/11266019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171063 0039d316-1c4b-4281-b951-d872f2087c98

also, differentiate cancel from success in AutofillDialogController.

BUG=157270

Review URL: https://codereview.chromium.org/11299323

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171062 0039d316-1c4b-4281-b951-d872f2087c98

The scoped_ptr<LifeCycleObject> was unncessary and confusing. The LifeCycleWatcher safely owns its LifeCycleObject and deletes it. The scoped_ptr made things a bit confusing even, since the only reason we weren't getting a double delete was because the scoped_ptr had an (ever so) slightly narrower scope than watcher.

Making the LifeCycleObject mostly private should encourage future callers not to add scary aliases. 

R=willchan@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/11416166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171058 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129187
TEST=NONE


Review URL: https://chromiumcodereview.appspot.com/11348344

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171057 0039d316-1c4b-4281-b951-d872f2087c98

This bug was caused by returning a string as an index from list_selection_model.js in an Event argument of a change event. In the list.js, such index stored as string was incremented, which caused concatenation instead of incrementation. This patch converts these values to number to avoid such problems.

TEST=Enable ChromeVox, enter Files.app (CTRL-M), navigate among files. Correct item number should be spoken, eg. 2/x, 3/x.
BUG=164061


Review URL: https://chromiumcodereview.appspot.com/11421214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171056 0039d316-1c4b-4281-b951-d872f2087c98

> 
> * Adds support for Apache libraries to be able to use multipart in Java
> HTTP clients.
> * Orders all Android-specific DEPS
> * Adds missing third_party/findbugs to .gitignore
> 
> BUG=159203
> 
> Review URL: https://codereview.chromium.org/11421224

TBR=nyquist@chromium.org
Review URL: https://codereview.chromium.org/11415295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171055 0039d316-1c4b-4281-b951-d872f2087c98

json minify was landed in r124878. Chromium stopped using it in r132692,
but not all files were removed. Removing it completely.

Review URL: https://codereview.chromium.org/11416227

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171053 0039d316-1c4b-4281-b951-d872f2087c98

We need to launch DevTools before WebUI for login screen is up and running so we can attach remotely do run automation tasks there. 

BUG=162730
TEST=make sure you can connect to devtools when ChromeOS is camping on the login/OOBE screen


Review URL: https://chromiumcodereview.appspot.com/11412281

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171052 0039d316-1c4b-4281-b951-d872f2087c98

As calculateDrawTransforms has evolved, the math has become substantially more
overhead. This patch refactors the matrix math to reduce the number of matrix
copies and matrix multiplications. Changes that would drastically affect
readability or robustness are avoided.

With this patch, cc_perftests improves by approximately 6-8%.
SevenTabSwitcher: 2030 runs/s --> 2220 runs/s  (9.3%)
tenTabSwitcher: 757 runs/s --> 807 runs/s  (6.6%)

BUG=163769

Review URL: https://codereview.chromium.org/11280271

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171051 0039d316-1c4b-4281-b951-d872f2087c98

Use "Remove all" for the recently closed tabs list, and "Remove" for
all other lists.

BUG=163944

Review URL: https://chromiumcodereview.appspot.com/11416322

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171050 0039d316-1c4b-4281-b951-d872f2087c98

BUG=145734


Review URL: https://chromiumcodereview.appspot.com/11299307

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171049 0039d316-1c4b-4281-b951-d872f2087c98

PhantomWindowController shows two styles of window, STYLE_SHADOW and STYLE_DRAGGING.
Although STYLE_SHADOW is specific to workspace, STYLE_DRAGGING is not specific to
workspace. This CL separates this feature into two classes so that the
STYLE_DRAGGING part can be used from non-workspace specific code

- Extract the STYLE_DRAGGING part from PhantomWindowController into DragWindowController.
- Move the ownership of the copied window layer from WorkspaceWindowResizer to
  DragWindowController.

BUG=156519


Review URL: https://chromiumcodereview.appspot.com/11280283

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171048 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/11316335

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171047 0039d316-1c4b-4281-b951-d872f2087c98

Add enough recycling logic to ResourcePool to eliminate unnecessary
command buffer flushes.

BUG=163430
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/11418299

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171046 0039d316-1c4b-4281-b951-d872f2087c98

* Adds support for Apache libraries to be able to use multipart in Java
HTTP clients.
* Orders all Android-specific DEPS
* Adds missing third_party/findbugs to .gitignore

BUG=159203

Review URL: https://codereview.chromium.org/11421224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171045 0039d316-1c4b-4281-b951-d872f2087c98

Make wallpaper picker manifest and thumbnails available when offline.

This CL did the following:

1. Save/update manifest in chrome.storage.local when user successfully
requested latest manifest from server. If user failed to get manifest
from server(offline or server error), fallback to the manifest saved
in chrome.storage.local last time.

2. Lazily saves all requested thumbnails to thumbnails directory. And
load from that directory when user open wallpaper picker next time. Note
that thumbnails are shared across user session. So after one user saved
thumbnails, all other users will directly use the thumbnails that saved
in thumbnail directory.


BUG=158668


Review URL: https://chromiumcodereview.appspot.com/11348215

TBR=bshe@chromium.org
Review URL: https://codereview.chromium.org/11280300

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171043 0039d316-1c4b-4281-b951-d872f2087c98

cros: Fix a comparison of a bool with -1

BUG=none
TBR=bshe

Review URL: https://codereview.chromium.org/11419315

TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11434113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171042 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164184

Review URL: https://codereview.chromium.org/11280296

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171041 0039d316-1c4b-4281-b951-d872f2087c98

BUG=159714

Review URL: https://codereview.chromium.org/11316305

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171040 0039d316-1c4b-4281-b951-d872f2087c98

Check WebKit::WebRuntimeFeatures::isEncryptedMediaEnabled() instead of chromium switch because in LayoutTest chromium switch is not used.

BUG=163785
TEST=LayoutTest


Review URL: https://chromiumcodereview.appspot.com/11434076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171039 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164064
TBR=tapted, benwells

Review URL: https://codereview.chromium.org/11428167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171038 0039d316-1c4b-4281-b951-d872f2087c98

The code that relied on there being a valid TabContents has changed, so we can
now create an ExtensionWebUI for all extension URLs.

BUG=106255


Review URL: https://chromiumcodereview.appspot.com/11348358

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/11415205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171035 0039d316-1c4b-4281-b951-d872f2087c98

We want to use cygprofile for the same purpose as the chromeos: To generate order_text_session files based on earliest run of each function call.

BUG=150893


Review URL: https://chromiumcodereview.appspot.com/11348354

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171034 0039d316-1c4b-4281-b951-d872f2087c98

shipping name has to come from the credit card name when "use billing for shipping" is checked.

BUG=157270

Review URL: https://codereview.chromium.org/11414243

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171033 0039d316-1c4b-4281-b951-d872f2087c98

BUG=154637


Review URL: https://chromiumcodereview.appspot.com/11316333

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171032 0039d316-1c4b-4281-b951-d872f2087c98

These libraries are already in Chrome's third party, so we just add
a library.dsc to build them.  They will eventually need to be converted
to GYP file along with the rest of the NaCl SDK gyp work.

R=binji@chromium.org
BUG=162141


Review URL: https://chromiumcodereview.appspot.com/11417098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171031 0039d316-1c4b-4281-b951-d872f2087c98

Extend the suppression for leak in webkit_glue::CppBoundClass::BindToJavascript (issue 150648)

BUG=164198,150648
TBR=eugenis
Review URL: https://codereview.chromium.org/11412331

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171030 0039d316-1c4b-4281-b951-d872f2087c98

Underlying bug is already fixed.

BUG=160861
Android java test change. Ran through android trybot
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11299337

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/11348337

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171027 0039d316-1c4b-4281-b951-d872f2087c98

Add a new suppression for dbus leaks (issue 163111)
Suppress uninit values in WebCore::RenderBox::paintFillLayers (issue 164198)

BUG=164185,163111,164198
TBR=eugenis
Review URL: https://codereview.chromium.org/11412329

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171026 0039d316-1c4b-4281-b951-d872f2087c98

This does not fix handle passing, but messages that don't carry handles will probably work.

BUG=163021,163861


Review URL: https://chromiumcodereview.appspot.com/11434042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171025 0039d316-1c4b-4281-b951-d872f2087c98

- move enums from ShelfLayoutManager to shelf_types.h
- remove redundant VisibilityState
- added SHELF_ prefix to these state.

BUG=151417
TEST=none

Review URL: https://chromiumcodereview.appspot.com/11316323

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=bshe

Review URL: https://codereview.chromium.org/11419315

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171023 0039d316-1c4b-4281-b951-d872f2087c98

On platforms that don't support installing plug-ins, show a "plug-in
unsupported" message instead of a "missing plug-in" message.

BUG=158871

Review URL: https://codereview.chromium.org/11414010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171021 0039d316-1c4b-4281-b951-d872f2087c98

Finding the routing id requires LaunchSelLdr to run from the
main thread.  However, some sel_ldr instances host nexes that do
not actually need to use Pepper APIs (e.g., the PNaCl translator),
and should be run on a background thread.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=3176


Review URL: https://chromiumcodereview.appspot.com/11428063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171020 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/11299338

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171019 0039d316-1c4b-4281-b951-d872f2087c98