GitLab

Make already-implemented functions up to date. Unimplemented features such
as piping and strategy are still unimplemented.

BUG=393911

Review URL: https://codereview.chromium.org/712043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185181 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Implementing Element.closest() API according to specs https://dom.spec.whatwg.org/#dom-element-closest

This API will parse selectors and if fails then throw SyntaxError
else return closest ancestor that matches selectors if there is
no ancestor that matches selectors, it will return nullptr.

Blink-Dev Intent to Implement and ship Link :
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/yk_Fo6hyvb8

This patch is a merge from webkit http://trac.webkit.org/changeset/174324
by Dhi Aurrahman <diorahman@rockybars.com>".

BUG=422731, 417603
R=habib.virji@samsung.com

Review URL: https://codereview.chromium.org/701723007

git-svn-id: svn://svn.chromium.org/blink/trunk@185180 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes animation-test-helpers.js not care about which
properties are being tested by always working with strings from computed
style directly. The previous behaviour relies heavily on the no longer
web-exposed getPropertyCSSValue which we want to delete.

Instead of having separate expectation types for different properties,
we simply match numeric substrings of the computed style value. The top
of the file has a comment explaining in more detail.

BUG=428595

Review URL: https://codereview.chromium.org/716963002

git-svn-id: svn://svn.chromium.org/blink/trunk@185179 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Following Christian's suggestion on https://codereview.chromium.org/715083002

Review URL: https://codereview.chromium.org/718943003

git-svn-id: svn://svn.chromium.org/blink/trunk@185178 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It is not allowed to destruct HRTFDatabaseLoader::m_thread during a sweeping phase
because WebThreadSupportingGC's destructor enters a safe point scope.
This CL avoids the situation by explicitly joining with the loader thread in AudioContext::uninitialize().

In order to make sure that the loader thread finishes touching m_thread,
this CL posts a clean-up task and wait for its completion before calling
m_thread.clear().

BUG=432041

Review URL: https://codereview.chromium.org/711323002

git-svn-id: svn://svn.chromium.org/blink/trunk@185177 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit d43def09a965260b603064b5e6916c534b74b17c, aka r185145.

Speculative revert to fix content_browsertest failures on chromeos_rel
bot.

TBR=bokan
BUG=

Review URL: https://codereview.chromium.org/717053002

git-svn-id: svn://svn.chromium.org/blink/trunk@185176 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I've benchmarked and found that DOMDataStore::setReturnValueFast
is quite effective for document.implementation and
getElementsByTagName.  We should keep this method.

BUG=235436

Review URL: https://codereview.chromium.org/702523003

git-svn-id: svn://svn.chromium.org/blink/trunk@185175 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some layout tests time out since the switch to apache server, with
AcceptEx failures logged on error log. This may fix the issue.

BUG=30536, 431172

Review URL: https://codereview.chromium.org/695193006

git-svn-id: svn://svn.chromium.org/blink/trunk@185174 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Cache and reset the intrinsic content logical height of children when stretching them
in FlexBox. This is to avoid them reseting it to the stretched height, which leads
us to improperly avoiding layout later when stretching is no longer necessary.

This solution is too fragile, but I couldn't come up with one that was more robust
but doesn't break the optimization.

BUG=409779

Review URL: https://codereview.chromium.org/715083002

git-svn-id: svn://svn.chromium.org/blink/trunk@185173 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185157

BUG=420901
TBR=bungeman@chromium.org

Review URL: https://codereview.chromium.org/717043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185172 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185161

BUG=423834
TBR=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/716973003

git-svn-id: svn://svn.chromium.org/blink/trunk@185171 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Having fragmentation data be lazy on RootInlineBox only saves us a single
int (due to the pointer and the fact that we have room to pack its bool
into InlineFlowBox's bitfields), and the allocation overhead was large enough
it appeared on performance tests (see bug).

BUG=313700

Review URL: https://codereview.chromium.org/715973004

git-svn-id: svn://svn.chromium.org/blink/trunk@185170 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL ensures ResourceFetcher::requestPreload to request with
an appropriate context, RequestContextPrefetch.
This CL fixes the issue that ASSERT in
MixedContentChecker::contextTypeFromContext is hit when preloader
is invoked.

This is to prepare for CL http://crrev.com/673603002 , which makes
preloader to be invoked more often.

TESTS=http/tests/security/mixedContent
BUG=421300

Review URL: https://codereview.chromium.org/711213002

git-svn-id: svn://svn.chromium.org/blink/trunk@185169 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since ContentDecryptionModuleResult objects are often used to return
promises, add ContentDecryptionModuleResultPromise as a base class
that includes the promise and allow existing classes to only override
the complete() method that they expect to get called.

BUG=358271
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/687533004

git-svn-id: svn://svn.chromium.org/blink/trunk@185168 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423071

Review URL: https://codereview.chromium.org/716023002

git-svn-id: svn://svn.chromium.org/blink/trunk@185167 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Makes CSSRule and its subclasses inherit from ScriptWrappable.

Amongst top 10 mobile web sites, only one web site instantiates
only one instance of CSSRule unless Developer Tools is opened.
Most of web pages don't instantiate CSSRules and its subclasses
(unless Developer Tools is opened), so it should be okay to make
CSSRule inherit from ScriptWrappable, although it increases the
size of CSSRule by 4 or 8 bytes (= the size of v8::Persistent).

BUG=390065

Review URL: https://codereview.chromium.org/699043003

git-svn-id: svn://svn.chromium.org/blink/trunk@185166 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As getPropertyCSSValue, CSSPrimitiveValue, etc. are no longer
web-exposed, we should stop testing them so we can delete the interface.

BUG=428595

Review URL: https://codereview.chromium.org/715913003

git-svn-id: svn://svn.chromium.org/blink/trunk@185165 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Apache gets stuck when the pipe connected to stderr gets filled up and
not read. This patch makes stderr of apache directly goes to build log.

BUG=30536, 431172

Review URL: https://codereview.chromium.org/712253002

git-svn-id: svn://svn.chromium.org/blink/trunk@185164 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412088

Review URL: https://codereview.chromium.org/713823005

git-svn-id: svn://svn.chromium.org/blink/trunk@185163 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need a way to show hidden transition elements when coming back from native app (when back button is pressed).

This is the Blink side of the CL. The Chrome side is here: https://codereview.chromium.org/712183002/

BUG=370696

Review URL: https://codereview.chromium.org/715653004

git-svn-id: svn://svn.chromium.org/blink/trunk@185162 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a pixel bleed issue on very high-DPI screens.

BUG=423834

Review URL: https://codereview.chromium.org/711163002

git-svn-id: svn://svn.chromium.org/blink/trunk@185161 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This avoids doing a null check in this method, adjust
all call sites.

Review URL: https://codereview.chromium.org/715023002

git-svn-id: svn://svn.chromium.org/blink/trunk@185160 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Nobody uses this anymore.

R=haraken@chromium.org, tkent@chromium.org
BUG=263316

Review URL: https://codereview.chromium.org/705363003

git-svn-id: svn://svn.chromium.org/blink/trunk@185159 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185149

TBR=vollick@chromium.org

Review URL: https://codereview.chromium.org/721543002

git-svn-id: svn://svn.chromium.org/blink/trunk@185158 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Related skia change:
https://codereview.chromium.org/692083002/

BUG=420901

Review URL: https://codereview.chromium.org/718673004

git-svn-id: svn://svn.chromium.org/blink/trunk@185157 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/704303004

git-svn-id: svn://svn.chromium.org/blink/trunk@185155 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use existing AtomicStrings instead of a string literals
that need to be converted to them.

Review URL: https://codereview.chromium.org/716873002

git-svn-id: svn://svn.chromium.org/blink/trunk@185154 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=374270

Review URL: https://codereview.chromium.org/710213002

git-svn-id: svn://svn.chromium.org/blink/trunk@185153 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that the Blink IDL supports the Promise<T> syntax, update
the EME idl files with the promise type.

BUG=358271
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/694773004

git-svn-id: svn://svn.chromium.org/blink/trunk@185152 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Things that make you go 'WAT.' This comment was added in the patch
that split RenderBoxModelObject out of RenderBox --
eb6efbfaa79de8624ce72ad4e26ef0d3f808650e -- without any additional
explanation. I don't think it's helping anyone.

H/T to Ojan for finding today's WAT.

Review URL: https://codereview.chromium.org/718843002

git-svn-id: svn://svn.chromium.org/blink/trunk@185151 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The iframe load was racing with the main frame setting the onmessage
event handler. To fix this, defer the iframe loads until the main frame
onmessage event handler has already been set.

BUG=none

Review URL: https://codereview.chromium.org/704413010

git-svn-id: svn://svn.chromium.org/blink/trunk@185150 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The math to position the host layer does not account for scrolling, and
this causes incorrect behavior with nested scrollers.

BUG=None

Review URL: https://codereview.chromium.org/667913003

git-svn-id: svn://svn.chromium.org/blink/trunk@185149 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Take the text path (simple vs complex) into account when computing the
width of a space character used to strip leading and trailing spaces.

R=leviw@chromium.org
BUG=427415
TEST=fast/text/international/complex-text-leading-space-wrapping.html

Review URL: https://codereview.chromium.org/721433002

git-svn-id: svn://svn.chromium.org/blink/trunk@185148 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently animation-test-helpers.js supports prefixing element ids with
"static:". This patch removes this prefix as we just just remove them
and do nothing differently.

Review URL: https://codereview.chromium.org/693613006

git-svn-id: svn://svn.chromium.org/blink/trunk@185147 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Restarting content_shell periodically helps keep memory usage down. This should
improve cycle times on bots by preventing the machines from going into swap.

BUG=427569
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/709603005

git-svn-id: svn://svn.chromium.org/blink/trunk@185146 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The main frame's size is no longer simply the viewport size. Instead,
WebViewImpl sizes it after layout to be the either the content width with
a height matching the viewport aspect ratio, or the viewport at minimum page
scale. This fixes a bug where the innerWidth/innerHeight values would be
wrong during an onload event if the onload would happen before the content was
properly sized.

BUG=431097,428722

Review URL: https://codereview.chromium.org/705423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185145 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch passes 'true' value for layoutPositionedObjects() in case of size change.
It helps to avoid unneccessary setChildNeedsLayout() and setPreferredLogicalWidthsDirty() calls.

Review URL: https://codereview.chromium.org/714933002

git-svn-id: svn://svn.chromium.org/blink/trunk@185144 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make clear that imageLoader is potentially constructing the
ImageLoader by renaming to ensureImageLoader. Also rename
hasImageLoader to imageLoader and make it return a pointer,
so it can be used both to check if the ImageLoader is created
as well as use it if not null.

http://trac.webkit.org/changeset/175764

Review URL: https://codereview.chromium.org/715633005

git-svn-id: svn://svn.chromium.org/blink/trunk@185143 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use onmessage instead of the iframe onload event, since the test itself
triggers navigation. Depending on the timing, the iframe onload handler
may run more than once.

BUG=381464

Review URL: https://codereview.chromium.org/713453003

git-svn-id: svn://svn.chromium.org/blink/trunk@185142 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=yurys, haraken, keishi, oilpan-reviews

Review URL: https://codereview.chromium.org/707273003

git-svn-id: svn://svn.chromium.org/blink/trunk@185141 bbb929c8-8fbe-4397-9dbb-9b2b20218538