GitLab

Set Extension Infobars to have a fixed height determined by the developer (clamped to sane min and max values).

BUG=92656
TEST=This needs to be tested with an Extension, which I can provide.
Review URL: http://codereview.chromium.org/7635019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97132 0039d316-1c4b-4281-b951-d872f2087c98

Exclude a UI test failing on an arena assertion on Mac OS, exclude DnsTransactionTest.FirstTimeoutTest from all TSan runs (was: win-only)

crbug is down now, so writing failure output here instead of adding crbug comments:
http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20UI%20%28valgrind%29%281%29/builds/4693/steps/memory%20test%3A%20ui/logs/stdio
[ RUN      ] UILayoutTest.MediaUILayoutTest
findSb: can't find pointer 0x1F7FE190 in arena 'client'

valgrind: the 'impossible' happened:
   findSb: VG_(arena_free)() in wrong arena?
==44438==    at 0x38034E05: ???

sched status:
  running_tid=1

Thread 1: status = VgTs_Runnable
==44438==    at 0x163FD: free (vg_replace_malloc.c:366)
==44438==    by 0x7E4A1F: inflateEnd (in /usr/lib/libz.1.2.3.dylib)
==44438==    by 0x182B8F35: png_read_destroy (in /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib)
==44438==    by 0x182B8C2A: _cg_png_destroy_read_struct (in /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib)
==44438==    by 0x397E9B5: _CGImagePluginInitPNG (in /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/ImageIO)
==44438==    by 0x397D37D: makeImagePlus (in /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/ImageIO)
...
==44438==    by 0xE049E9: -[NSWindow makeKeyAndOrderFront:] (in /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit)
==44438==    by 0xBAD2F84: _ZN18BrowserWindowCocoa4ShowEv (in /b/build/slave/chromium-rel-mac-valgrind-ui-1/build/src/xcodebuild/Release/Chromium.app/Contents/Versions/15.0.856.0/Chromium Framework.framewo


http://build.chromium.org/p/chromium.memory/builders/Chromium%20Mac%20%28tsan%29/builds/8091/steps/memory%20test%3A%20net/logs/stdio
[ RUN      ] DnsTransactionTest.FirstTimeoutTest
[72206:2823:0817/063330:4543072922370295:FATAL:dns_test_util.cc(18)] Check failed: !numbers_.empty().
Backtrace:
  0   net_unittests                       0x00061f03 operator new(unsigned long, void*) + 392087
  1   net_unittests                       0x00061f37 operator new(unsigned long, void*) + 392139
  2   net_unittests                       0x0006231e operator new(unsigned long, void*) + 393138
  3   net_unittests                       0x000625d9 operator new(unsigned long, void*) + 393837
  4   net_unittests                       0x00747ba9 start + 7062665

TBR=glider
BUG=58146,88225
Review URL: http://codereview.chromium.org/7671018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97131 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97130 0039d316-1c4b-4281-b951-d872f2087c98

Includes fixes for LayoutTests directory rename from chromium-mac to chromium-cg-mac.

TBR=tony

BUG=
TEST=

Review URL: http://codereview.chromium.org/7621039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97129 0039d316-1c4b-4281-b951-d872f2087c98

This is needed after r97067.

BUG=none
TEST=building with GYP_DEFINES="profiling=1" works
TBR=tfarina

Review URL: http://codereview.chromium.org/7624014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97128 0039d316-1c4b-4281-b951-d872f2087c98

TODO: crbug is down today (wow!) so couldn't file one of the bugs extracted from
http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20UI%20%28valgrind%29%286%29/builds/394/steps/memory%20test%3A%20ui_1/logs/stdio

TBR=glider
BUG=75051,76386,80022,89304,92741
Review URL: http://codereview.chromium.org/7621041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97127 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:17610, chromium-os:18965
TEST=None


Review URL: http://codereview.chromium.org/7529048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97126 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97125 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tony

BUG=
TEST=

Review URL: http://codereview.chromium.org/7621038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97124 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yusukes@chromium.org
BUG=none
TEST=Build succeeds

Review URL: http://codereview.chromium.org/7621037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97123 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=manual

Review URL: http://codereview.chromium.org/7670022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97120 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=Existing tests pass: FileSystemDirURLRequestJobTest.*, FileSystemURLRequestJobTest.*, FileSystemContextTest.*, DatabaseTrackerTest.*, QuotaFileUtilTest.*, FileSystemPathManagerTest.*, SandboxMountPointProviderMigrationTest.*


Review URL: http://codereview.chromium.org/7633016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97119 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97118 0039d316-1c4b-4281-b951-d872f2087c98

Whitespace change: http://codereview.chromium.org/7621036

BUG=none
TEST=none
TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/7669005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97117 0039d316-1c4b-4281-b951-d872f2087c98

1) Skip the report&suppression frames starting from
    testing::internal::BlahExceptions and RunnableMethod
   as they usually have nothing to do with the error but significantly increase
   the size of the suppressions
2) Drop anonymous namespace prefixes
3) Unify boring callers between error reporting code and suppression generation

TEST=ran locally on base_unittests Sanity tests with sanity suppressions removed
Review URL: http://codereview.chromium.org/7665001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97116 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Pepper Flash on Youtube. Go fullscreen and back. Obeserve with xrestop that X resources aren't leaked


Review URL: http://codereview.chromium.org/7670018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97115 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93006
TBR=jam
TEST=Valgrind unit_tests go green
Review URL: http://codereview.chromium.org/7672013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97112 0039d316-1c4b-4281-b951-d872f2087c98

JSON doesn't support NaN or positive/negative infinity.  I'm
hoping that this DCHECK will slightly increase the odds that
bugs are caught before they start corrupting pref files.

BUG=73856
TEST=none


Review URL: http://codereview.chromium.org/7646032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97111 0039d316-1c4b-4281-b951-d872f2087c98

It's an interface and shouldn't have any member variables.  Also, it's
not used anymore.

TEST=PluginDataRemoverTest browser tests


Review URL: http://codereview.chromium.org/7664018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97110 0039d316-1c4b-4281-b951-d872f2087c98

The notable change is that now characters are input in the timing of touchend
instead of touchstart.
This is necessary for showing popup keyboard by long-press without inputting
the chracacter of the pressed key.
This CL also changes the key to send a pair of keydown and keyup on touchend,
which is consistent with Android keyboard behavior.


BUG=none
TEST=Manually on the device


Review URL: http://codereview.chromium.org/7606030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97109 0039d316-1c4b-4281-b951-d872f2087c98

Also uses StringToLowerASCII for consistency with AF code. Fixes a crash under Win Dbg.

BUG=92937
TEST=WebDatabaseMigrationTest.MigrateVersion32ToCurrent

R=dhollowa@chromium.org


Review URL: http://codereview.chromium.org/7645038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97108 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7650027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97105 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97104 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92270
TEST=none


Review URL: http://codereview.chromium.org/7670020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97102 0039d316-1c4b-4281-b951-d872f2087c98

Spun off from http://codereview.chromium.org/7599018/ to facilitate try server usage.

BUG=
TEST=


Review URL: http://codereview.chromium.org/7670010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97100 0039d316-1c4b-4281-b951-d872f2087c98

Gaia should only show up after 3 bad auth attempts.

BUG=chromium-os:19248
TEST=Verify fix for chromium-os:19248.


Review URL: http://codereview.chromium.org/7670014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97099 0039d316-1c4b-4281-b951-d872f2087c98

the expected number of bytes.

We cannot assume a single SSL read is enough to read all the bytes.
This depends on how the SSL sender fragments the data into SSL records,
and whether the SSL receiver returns all available records at once or
one record at a time.

R=hclam@chromium.org,rvargas@chromium.org
BUG=none
TEST=net_unittests --gtest_filter=SSLServerSocketTest.DataTransfer

Review URL: http://codereview.chromium.org/7648010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97098 0039d316-1c4b-4281-b951-d872f2087c98

Use a logic similar to zel's original code that calls VerifyOAuth1AccessToken when we have oauth token in user's profile or we don't have cookies.

BUG=chromium-os:19241
TEST=Verify fix for chromium-os:19241


Review URL: http://codereview.chromium.org/7671007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97095 0039d316-1c4b-4281-b951-d872f2087c98

GURL doesn't escape when cannonicalizing, and are illegal
in the query portion of the URL according to spec.  Fix that
behavior, so if gurl is a valid url, so is GURL(FormatURL(gurl)).

BUG=90387
TEST=NetUtilTest.FormatUrlRoundTripPathASCII, NetUtilTest.FormatUrlRoundTripPathEscape, NetUtilTest.FormatUrlRoundTripQueryASCII, NetUtilTest.FormatUrlRoundTripQueryEscaped

Review URL: http://codereview.chromium.org/7649024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97093 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw
BUG=none
Review URL: http://codereview.chromium.org/7671013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97092 0039d316-1c4b-4281-b951-d872f2087c98

Since the new pepper plugin can arrive later we needed a way to
integrate better with the webkit::PluginList, unfortunately there
is still value on the PepperPluginRegistry for development use
cases.

So this change adds new plugins to both the pepper plugin lists in
the browser (in PluginService) and the renderer (in PepperPluginRegistry)
on demand.



TEST=see bug
BUG=89248
Review URL: http://codereview.chromium.org/7670003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97091 0039d316-1c4b-4281-b951-d872f2087c98

In particular, adds functions DeleteOriginBoundCert, DeleteAll, and
GetAllOriginBoundCerts. These functions will be used by the cert management UI.
Also changes SetOriginBoundCert's return value to void.

BUG=88782
TEST=net_unittests (in particular DefaultOriginBoundCertStoreTest.*)

Review URL: http://codereview.chromium.org/7585037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:14322
TEST=Pepper Flash on Youtube, go full screen


Review URL: http://codereview.chromium.org/7670008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=59767

Review URL: http://codereview.chromium.org/7671009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97087 0039d316-1c4b-4281-b951-d872f2087c98

I'll use the new function to implement a UI for virtual keyboard management.

BUG=None
TEST=ran unit_tests

Review URL: http://codereview.chromium.org/7663008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97084 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87457
TEST=none


Review URL: http://codereview.chromium.org/7645032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97083 0039d316-1c4b-4281-b951-d872f2087c98

BUG=no
TEST=no


Review URL: http://codereview.chromium.org/7663019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97081 0039d316-1c4b-4281-b951-d872f2087c98

Revert 97076 - Add DCHECK to BrowserAccessibilityManager::Remove to detect undefined behavoir that may lead to a crash.
- Remove logic BrowserAccessibilityManagerTest.TestCreateEmptyDocument that attempts to change an accessibility object's role.

BUG=92716
Test=none
Review URL: http://codereview.chromium.org/7648055

TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/7669012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97080 0039d316-1c4b-4281-b951-d872f2087c98