GitLab

This reverts commit 9256783c.

Reason for revert: This CL may be responsible for multiple All/Overview* flaky use-of-uninitialized-value.

First failed build:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/16416?blamelist=1#blamelist-tab

Because the original CL has been landed for few days, the change in
tools/metrics/histograms/histograms.xml are not reverted due to merge warning.

Original change's description:
> Cros: Add metrics for transitions in the hotseat
>
> Report animation smoothness for the transition into the hotseat in the
> HomeLauncher.
>
> Bug: 1022178, 1022177
> Change-Id: I5dc5e76688aa5a88bcabb5d688b419d819932867
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917941
> Commit-Queue: Ana Salazar <anasalazar@chromium.org>
> Reviewed-by: Alex Newcomer <newcomer@chromium.org>
> Reviewed-by: Manu Cornet <manucornet@chromium.org>
> Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718266}

TBR=nikunjb@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1022178, 1022177, 1028255
Change-Id: If460f00f10fb8f8df2a9f7d3d41abfdd91f0ad0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933739
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718782}

https://skia.googlesource.com/skia.git/+log/61169e9c4794..4a327bcb1019

git log 61169e9c4794..4a327bcb1019 --date=short --first-parent --format='%ad %ae %s'
2019-11-25 herb@google.com Fix chrome build bots
2019-11-25 herb@google.com Structured binding for SkZip and SkEnumerate
2019-11-25 herb@google.com Simplify SubRun structure in GrTextBlob

Created with:
  gclient setdep -r src/third_party/skia@4a327bcb1019

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bungeman@google.com
Change-Id: I121c7bf090c7586fac33f8e24e476b9db7332164
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933380Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718781}

This will make it easier to detect unibuild-related VM configuration
errors.

BUG=b:123309049
TEST=try, git cl lint

Change-Id: Ie0dae50fe7df6a517ec3f41872e7e00a1e4aa8ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931747
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718780}

GetKeyboardLayoutEngine() has the side effect of creating a stub keyboard
layout engine if there's no previous layout engine. Avoid this as it
shouldn't be necessary and it creates ordering dependencies between
tests. In particular, running EventConverterEvdevImplTest after
XkbLayoutEngineVkTest causes a crash when we enable use_xkbcommon in GN.
This shows up as a flaky failure on infra:

  flaky failures [ignored]:
  EventConverterEvdevImplTest.KeyPress

Removing the implicit initialization required fixes to a few components:

- KeyEvent tests must create a layout engine if they call GetDomKey or GetCharacter
- ozone/x11 needs to provide a layout engine to chromium. There was no
  layout engine support in that component at all. This needs followup
  work as Linux builds that need proper keyboard layout support need to
  use XkbKeyboardLayoutEngine rather than StubKeyboardLayoutEngine.
- Chromedriver needs to create a layout engine if run headlessly in X11
  (USE_X11) builds without an X display. This is a particularly unusual
  case as we've building ozone code in a non-ozone build.

This patch makes those components create a StubKeyboardLayoutEngine
explicitly, which is equivalent to the previous implicit behavior.

KeyEvent tests that rely on the global layout (because they call
GetDomKey or GetCharacter) now use ScopedKeyboardLayout, which has been
updated to create a StubKeyboardLayoutEngine under the hood. If more
control is required, a custom layout engine can be provided via
ScopedKeyboardLayoutEngine (ozone specific).

Bug: 1026406

Change-Id: I925ed2d0de880e19eaee41a2b36595fea467b6bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928250Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718779}

This reverts commit d96236b5.

Reason for revert: This may cause "WebKit Linux Leak" failure
First failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/7276

Original change's description:
> Sanitize style elements in clipboard markup
> 
> This patch sanitizes clipboard markup before pasting it into document
> by removing all pasted style elements and serializing them onto
> elements as inline style. In this way, we stop stylesheets in clipboard
> markup from being applied to the original elements in the document.
> 
> This patch follows the same approach as in WebKit [1]:
> - First create a dummy document to insert the markup
> - Then computes style and layout in the dummy document
> - Re-serialize the dummy document as the markup to be inserted. This
>   reuses the code path that we serialize a selection range into
>   clipboard, where we need to serialize element computed style into
>   inline styles so that the element styles are preserved.
> - Make sure all style elements are removed before inserting markup
>   into document
> 
> This patch also adds a complete test to ensure that content pasted from
> Excel is still properly styled, which is the main reason we used to
> preserve style elements in clipboard markup [2].
> 
> [1] https://trac.webkit.org/changeset/223440
> [2] http://crbug.com/121163
> 
> Bug: 1017871
> Change-Id: I3bb5a4ae7530a3fdef5ba251975e004857c06f1e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922919
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#718281}

TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1017871, 1027386
Change-Id: I1d500647d6227c9be3ae14d9604ba702e9c29834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933452Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718778}

BUG=1027262

Change-Id: Id6745691e05f337a41de1aff2c5cbda558f85c14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929617Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718777}

This patch puts an early out for cases where the layout (for position)
or paint (for pagination) is blocked by the display lock.

This takes the growing update time on the referenced bug (example
in comment 17) from ~8ms per frame to ~1ms per frame on my linux desktop.

R=chrishtr@chromium.org

Bug: 999486
Change-Id: I1c7a2a1948371c61565c079d30341c0ee4c7e8b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934509Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718776}

Converting script values to Indexed DB keys is a recursive algorithm
in the spec. The implementation is naively recursive as well, but this
can hit stack limits on some configurations (compiler, OS, build type,
etc).

Convert the implementation to do recursion on the heap instead of the
stack. No functional changes.

Bug: 1022460
Change-Id: I7292d38113d540c5bdf725c8354e19e1e13b0f25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921636
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Olivier Yiptong <oyiptong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718775}

Bug: 807144
Change-Id: Ia7d6f83381509113b6601839b5c1d8eacdbc4860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929985Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718774}

* Add setters for testing to arc::FileSystemStatus
* Add CreateArcVmClientAdapterForTesting() that allows the unit tests
  to rewrite the FileSystemStatus object

BUG=b:123309049
TEST=try, git cl lint

Change-Id: Id1054af7343c02d0f345b24ebd9546faeb98d774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931541
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718773}

Follow-up CL will change the JNI API to restrict reading and writing
to these keys only.

Bug: 1022108
Change-Id: Ibf61af08dbffbe44f92977cc3127c0e568661af2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930692Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718772}

https://dawn.googlesource.com/dawn.git/+log/8e9c3f663ccd..e9356045a4e0

git log 8e9c3f663ccd..e9356045a4e0 --date=short --first-parent --format='%ad %ae %s'
2019-11-25 rharrison@chromium.org Rolling 3 dependencies

Created with:
  gclient setdep -r src/third_party/dawn@e9356045a4e0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I8c5397947208aa856122b44bb4b7588c6c999d1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933759Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718771}

The test was mistakely disabled on all platforms but Mac. However, it
should be disabled in the exactly opposite way.

Tbr: dpapad@chromium.org
Bug: 1028129
Change-Id: Ie54a98fe84db3be5a8989bd9cf1553591c69f067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933597Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718770}

This CL moves away from listening on the generic window onfocus event
and moves towards sending a custom WebUI event when the AccessiblePane
receives focus. This resolves 2 main issues:
(1) Visual focus indicators being visible on focus caused by touch.
(2) The tab strip scrolls to the very first tab on tap because the
first tab immediately becomes focused on window focus.

Bug: 1017472
Change-Id: I8565b2e244a205791ba81eca23ba5a475c2f441c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929447
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718769}

This CL includes a fix for a heap use after free error that existed
in the previous submission.

Bug: 1025050
Change-Id: I4928100f7a2599beb17741ec5f0ab22774385c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931411
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718768}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c4a36ad5..96a59c93

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia9bf276084e93ccdd226a594af2d3d441e6d4450
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934487Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718767}

The default focus ring is an undesired blue box that appears around
the view when focused. Since we use custom highlighting for suggestion
chips, similar to Assistant buttons, this should be removed.

Bug: b:144404660
Change-Id: I4599c4d925bdbffcd59a901bf2979c850465315f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934513Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#718766}

https://pdfium.googlesource.com/pdfium.git/+log/e87972e30da4..f20323a4a264

git log e87972e30da4..f20323a4a264 --date=short --first-parent --format='%ad %ae %s'
2019-11-25 tsepez@chromium.org Use PartitonAlloc to buffer some vectors in gif.

Created with:
  gclient setdep -r src/third_party/pdfium@f20323a4a264

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: If94bcfb9063917c6538bd15cb8f15e3ce9aa2d8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933757Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718765}

https://webrtc.googlesource.com/src.git/+log/712a26f3842b..f534a6404772

git log 712a26f3842b..f534a6404772 --date=short --first-parent --format='%ad %ae %s'
2019-11-25 gustaf@webrtc.org AEC3: Sub-band nearend detector
2019-11-25 ssilkin@webrtc.org Allow min start bitrate to be lower than min bitrate.
2019-11-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0ec8ef3c..e0dd604c (718517:718623)
2019-11-25 philipel@webrtc.org Fix VideoStreamEncoder to not reference encoded data from the RunPostEncode task.

Created with:
  gclient setdep -r src/third_party/webrtc@f534a6404772

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:b/130016532,chromium:none,chromium:None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ie49d39846129313cef04a70187b5e06fcba80c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933755Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718764}

This CL has goal to use IsA<HTMLAreaElement>(element) in place of
IsHTMLAreaElement(element)

Bug: 891908
Change-Id: Ie3f3eeae304c0ae607531816c2d9782c0fdf365b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930537Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#718763}

https://chromium.googlesource.com/external/github.com/google/flatbuffers.git/+log/9bf9b18f0a70..136d75fa6580

$ git log 9bf9b18f0..136d75fa6 --date=short --no-merges --format='%ad %ae %s'
2019-11-21 dbaileychess Changed null checks in test. Removed verifier pointer usage (#5634)
2019-11-19 31897320+vglavnyy Add testing of C++ with sanitizers (CI-Docker) (#5631)
2019-11-19 i add namespace prefix in FLATBUFFERS_MAX_BUFFER_SIZE (#5629)
2019-11-15 malarkannan.invention Support for python grpc - continuing the work from the pull request #4270 #4705 (#5613)
2019-11-14 dbaileychess Removed idl_gen_general.cpp and move contents to code_generators.cpp (#5625)
2019-11-14 dbaileychess Lua cleanup (#5624)
2019-11-14 dbaileychess [C++] Adds basic schema evolution tests (#5611)
2019-11-11 dbaileychess [C++, C#, Java] Separated C# and Java generators into their own classes (#5618)
2019-11-11 Captfrozenberg add check for root_type specified for json schema generation (#5622)
2019-11-12 messense [Rust] Bump smallvec version to 1.0 (#5621)
2019-11-11 dbaileychess Ran src/clang-format-all.sh (#5617)
2019-11-07 aardappel Improved pull request & clang-format instructions.
2019-11-07 derekbailey Change monster_extra generation to use flatbuffers::unique_ptr (#5612)
2019-11-07 derekbailey [C++] Refactor to conform to Google C++ style guide (#5608)
2019-11-04 aardappel Fixed deprecated method in GRPC Java test.
2019-11-04 aardappel Fixed Apache license not using canonical version.
2019-11-04 even.rouault include/flatbuffers/base.h: fix no_sanitize issue with old clang (#5610)
2019-11-04 dbaileychess [C++, Java, C#, TypeScript, JavaScript] Skip generation of mutable union types (#5599)
2019-11-04 even.rouault flatbuffers.h: fix documentation warning (#5607)
2019-11-04 dbaileychess Add Lua FlatbufferBuilder Clean() method to enable reuseable builders (#5606)
2019-11-04 paulovictor.pinheiro [Kotlin] Fix union vector accessor after change in Java API (#5605)
2019-11-04 paulovictor.pinheiro [flatc] Remove an always true condition for flexbuffers (#5604)
2019-11-04 llchan [Go] Add UnPackTo functions (#5598)
2019-10-31 me [Go] Object API support (#5339)
2019-10-28 freaken Rust: Add idiomatic iterator for Vector type (#5579)
2019-10-28 even.rouault Fix typos in comments (#5590)
2019-10-28 dbaileychess C++ verifier for evolved union fields should return true (#5586)
2019-10-28 dbaileychess Add ByteBuffer copy for vector of bytes in Java (#5587)
2019-10-28 freaken Rust: Fix Copy and Clone impls for a few generic types (#5577)
2019-10-22 31897320+vglavnyy Add `--clean-first` to the cmake-build command (travis) (#5574)
2019-10-19 ojaslandge Fix Follow implementation for bool (#5554)
2019-10-19 31897320+vglavnyy Fix issue #5557 (#5573)
2019-10-18 bjornharrtell Avoid intentional unsigned integer overflow getting caught by sanitizers (#5572)
2019-10-18 bharat.tak Python: Add forceDefaults opt to python Builder (#5564)
2019-10-17 jaceks Java: Don't annotate vector-of-tables item getters with @nullable. (#5562)
2019-10-17 aardappel Fixed warnings generated by recent JSON sorting feature.
2019-10-18 ishinberg0 [Java] byte buffer factory returned buffer capcity is used instead of the requested size (#5558)
2019-10-17 gunter.burchardt #5544 Fix of Array of table is not sorted if Create<type>Direct() is used (#5546)
2019-10-15 BrianHarris Fix build with gcc version 7.4.0 (#5570)
2019-10-10 aardappel Fixed JSON parser not sorting vectors of tables/structs with key.
2019-10-04 paulovictor.pinheiro [FlexBuffers][Java] Cache size of Sized objects in FlexBuffers (#5551)
2019-09-30 paulovictor.pinheiro Fix issue #5542 (#5543)
2019-09-30 aardappel Fixed Android STLPort related error.
2019-09-30 hkmix Fix namespaced struct/field name collision detection (#5540) (#5545)
2019-09-27 paulovictor.pinheiro [flac] Add FlexBuffers option for generating data (#5519)
2019-09-26 rw Update Rust versions under test from 1.30.1 to 1.37.0 (#5538)
2019-09-26 29380294+mjvk Adds XOPEN_SOURCE for PATH_MAX and POSIX 1993 for stat (#5529)
2019-09-25 paulovictor.pinheiro [FlexBuffers][Java] Add override Key::toString (#5533)
2019-09-25 paulovictor.pinheiro [FlexBuffers][Java] Fix wrong access to a string using Reference::asString(). (#5532)
2019-09-23 31897320+vglavnyy Fix Mutate() methods of Array<scalar/struct> (override 5508) (#5526)
(...)
2019-04-16 31897320+vglavnyy Add logging of warnings from the flatc compiler (#5289)
2019-04-11 aardappel Fixed VS2010 build.
2019-04-11 aardappel Allow Set() methods to handle reference types
2019-04-12 31897320+vglavnyy Fix the proto-enum leaking issue (#5286)
2019-04-12 31897320+vglavnyy Detect leak with sanitizer (#5283)
2019-04-09 31897320+vglavnyy Add basic test for enum defaults (#5280)
2019-04-09 31897320+vglavnyy Part of #5265, neutral changes (#5281)
2019-04-09 31897320+vglavnyy Enable MSVC assert report box [Abort|Retry|Ignore] if a debugger is present (#5279)
2019-04-06 lee0906 Add files generated by CMake to git ignore (#5278)
2019-04-06 lee0906 [C++]Sync the sample monster.fbs file with the tutorial (#5277)
2019-04-05 matthew Ensure we don't subtract with underflow getting enum names (#5246)
2019-04-05 wolfviking0 Add method GenerateTextFromTable issue #5249 (#5266)
2019-04-05 krojew Fix for build break in c# vector of unions (#5271)
2019-04-04 unexge Fix typo in Go tutorial (#5274)
2019-04-02 31897320+vglavnyy Add compile-time checking of numerical limits in C++ code. (#5270)
2019-03-28 16469394+tymcauley Update grammar to reflect required type signature for enum declarations. (#5269)
2019-03-25 AustinSchuh Add missing test data file to BUILD file (#5264)
2019-03-25 laszlocsomor Bazel CI: fix bad value in yml (#5262)
2019-03-25 nickkuznetsov Fix a warning on compiling with clang (#5258)
2019-03-25 lp.cordier Add inequality operator (inspired from #263) (#5257)
2019-03-22 lee0906 [C++] Changes in the flathash program (#5255)
2019-03-22 ashayshirwadkar12 Fixed tutorial markdown file (#5248)
2019-03-21 aardappel Further fixes to make minireflect compatible with old behavior.
2019-03-19 31897320+vglavnyy Unify line ending rules in '.editorconfig' and '.gitattributes' (#5231)
2019-03-18 aardappel Fixed vector_delimited excluding delimiter
2019-03-18 aardappel Fixed shadowing warning in older gcc for vector_delimited
2019-03-14 aardappel Made ToStringVisitor backwards compatible with older behavior.
2019-03-11 aardappel Made JS enum declarations compatible with google closure
2019-03-11 aardappel Disabled constexpr for hashing functions.
2019-03-12 31897320+vglavnyy Narrows template ascii routines to prevent a possible signed overflow in generic code. (#5232)
2019-03-11 25543498+RandyStevens Fix typo in dart documentation (#5230)
2019-03-11 aardappel [C++] Object API: document custom string type requirements,
2019-03-09 bspeice [Rust] Don't use inner attributes for `allow` (#5212)
2019-03-08 freaken Small usability tweaks to the rust codegen. (#5213)
2019-03-08 16469394+tymcauley Fix rust crate for big-endian targets (#5229)
2019-03-07 aardappel Removed -Wc++98-compat-extra-semi for compatibility with older clang.
2019-03-07 AustinSchuh Bazel ci (#5228)
2019-03-04 aardappel Fixed vector of union JSON parsing.
2019-03-06 25088801+jean-airoldie [Rust] Fixed codegen documentation for Tables (#5227)
2019-03-05 davidn [Go] Add mutation functions for vector elements (#5221)
2019-03-04 42381407+ll-antn Clean-up nested_parser on all paths (#5179) (#5184)
2019-03-04 laurent.stacul [Fix #5112] flatc generates constructors with memset for non-trivial types (#5222)
2019-03-01 5284924+csukuangfj [doc] fix typos in doc. (#5217)
2019-02-27 naure Rust: Fix lifetime in union _as_ accessors (#5140)
2019-02-26 kulikov.alexey90 Java: Calculation of vtable and vtable size moved to the __init method. (#5210)
2019-02-26 kulikov.alexey90 Java: Removed unused duplicate of bytebuffer from "Table#__string" method. (#5211)
2019-02-26 iskandarov_egor Lua library: fix vtable reuse. (#5214)
2019-02-25 aardappel Attempting to make travis not kill the Android build.
2019-02-25 marcus IterateValue: Use ReadScalar instead of unportable reinterpret_casts (#5209)
2019-02-25 bwelling Fix incorrect code generation on Solaris Sparc. (#5208)

Created with:
  roll-dep src/third_party/flatbuffers/src

Change-Id: I46bd259878ab27cade6323fb31a56b86edd56cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928296Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718762}

https://android.googlesource.com/platform/external/perfetto.git/+log/9a1a942e18ee..a8c56ef52145

git log 9a1a942e18ee..a8c56ef52145 --date=short --first-parent --format='%ad %ae %s'
2019-11-25 lalitm@google.com Merge "trace_processor: take into account asc/desc for eliminating constraints"
2019-11-25 lalitm@google.com trace_processor: update metrics to stop using ref/ref_type

Created with:
  gclient setdep -r src/third_party/perfetto@a8c56ef52145

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:135177627
Tbr: perfetto-bugs@google.com
Change-Id: Icc3625f6ebc30854da6ab5664e09ad7d3cebd4dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933756Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718761}

TBR=eugenebut@chromium.org

Bug: none
Change-Id: Iac187c621250cbcacf46ea7f90e8b8bfe30b5621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924964Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718760}

In dark mode, the IPH background and the text color in tab switcher are
same, so the button is not visible.

Bug: 1028032
Change-Id: Iaff4b4a1b3d1f693be29fec3aa2ce3b87b1fd175
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934512
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718759}

This crash is caused by the following code in GenerateMessages():

  std::vector<base::string16> message;
  std::transform(external.begin(), external.end(), message.begin(),
                 [](const auto& extension) { ... });
  std::transform(forbidden.begin(), forbidden.end(), message.begin(),
                 [](const auto& extension) { ... });

Here, 'message' is empty so message.begin() doesn't point to a valid
location, which causes a crash when std::transform() tries to assign to
it. There is another bug too - the second std::transform() invocation
reuses message.begin(), so it will overwrite messages produced by the
first invocation.

This change:
1) Fixes both bugs mentioned above
2) Adds unit test coverage of this logic

Bug: 1028003
Change-Id: I2cbd660a5d5beb56a910a8c1a8ba239818c235f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933952
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718758}

Leftover from the earlier version of CL:1925769, when the string
contained the number of shown results.

BUG=1028036

Change-Id: Ie036e2cb13a992bf93667139d6dd4f73175f2078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934508
Auto-Submit: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718757}

Change-Id: I5bc9d4c7de8d6078e50919fac14660832a19f2f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903723Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718756}

Bug: fuchsia:41855
Change-Id: I3d8798424fe92ef298d7a2e4a7c17ddb10398aab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927043
Commit-Queue: Felipe Archondo <felipearchondo@google.com>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718755}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0f4dbab33c4..f70aafdb1ad2


Created with:
  gclient setdep -r src-internal@f70aafdb1ad2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:None,chromium:None
Tbr: jbudorick@google.com
Change-Id: I7bcf12c7c3f10468fc60b587eed1872c66abfddd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933378Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718754}

"Ready for playback" signal was not sent in all the needed cases.

Bug: internal b/145057846
Change-Id: Id063e85922e60a5abcc4f85fc4b51ac3f79459db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933453
Auto-Submit: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718753}

Change-Id: Idac3787790fd8aa4959f1509bcc9836fa69e5c56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934514
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718752}

The idea here is to remove the hardcoded dependencies specific to
the recovery component, and allow future extension of the action runners
so that handling actions defined by embedders such as //chrome/updater
becomes possible.

The improved recovery component is fully functional for Windows only.
The macOS implementation is missing an action handler, and it is not
registered anymore on macOS. macOS is still using the original
recovery component.

Future dependent CLs will land before this issue can be resolved:
* The kitchen sink update_client::Configurator contains functions related
to injecting recovery component specific objects such as unpacking key
hashes and elevators. These function can be removed.
* Tests for the recovery component ActionHandler class can be written
as part of the unit_tests.

Bug: 1027610
Change-Id: I4d62515b810a2f3b0e85566a2c3596f986cb3041
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929863
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718751}

This CL fixes content tests so that they work if append frame origin to
network isolation key is enabled by default. BeginNavigation now expects the
correct frame origin in the NIK and WebContentsSplitCacheBrowserTestEnabled
disables AppendFrameOriginToNetworkIsolationKey since
WebContentsSplitCacheWithFrameOriginBrowserTest already tests with the feature
enabled.

Bug: 1026388
Change-Id: If855a1e2d6dd4137e9ae0d6273f057c8760f6c56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928644Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718750}

https://chromium.googlesource.com/angle/angle.git/+log/04e074d1aae0..34e5a96edc3e

git log 04e074d1aae0..34e5a96edc3e --date=short --no-merges --format='%ad %ae %s'
2019-11-25 jmadill@chromium.org Fix header typo in rapidjson.

Created with:
  gclient setdep -r src/third_party/angle@34e5a96edc3e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ic8e421b636ececc4617309ef267034609cbdcf82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932473Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#718749}

crrev.com/c/1919544 is the potential fix for the test.
I have to enable the test to see if it really can fix
the test and then enable more disabled tests.

Bug: 956016
Change-Id: I9448cb928edf50e131e8c1c5886e7d26437b0aaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928129Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718748}

Bug: 993033
Change-Id: I391a119d1bd8c9bb6c3c398129920f5e0949ce13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928619Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718747}

Change-Id: I89348845e26f7f898466b0ec748050469ea4256e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931583
Auto-Submit: Carlos IL <carlosil@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718746}

This CL updates feature status and WebPreferences to enabled
OffscreenCanvas and SurfaceLayer video for webview if VizForWebview
enabled.

Bug: 805739
Change-Id: I4043c5edd7cd59d72b1a48207eb8eae4cbeb7bfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925217
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718745}

Bug: 985510
Change-Id: I215fd8efbae4286568bda3fa62f9db6a0bbe4cf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929642Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718744}

Moves non-DFM specific code from //chrome/android/modules/image_editor
to //chrome/browser/image_editor. Only DFM module code should be in
//chrome/android/modules.

Bug: 1024586
Change-Id: Ic0b54482032ef8bc4392e3f18e22fa1660f250ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928299
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718743}