GitLab

Also cleaned up:
- duplicate 'printing' section in WebLocalFrame
- superfluous IsLoading() override in WebLocalFrame

Bug: 416660
Change-Id: I2a9d1ed89d1f8d4d7c3d297fe9066a42fa77f2f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864617Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706667}

- Fetch ThreadState from page header instead of TLS.
- Avoid virtual call when checking for large object pages.
- Directly go through object_start_bitmap() instead of using
  FromInnerAddress, as we know that the address is neither null, nor in
  the linear allocation area or pointing to free space.
- Fold TryMark and Mark at the expense of an Unmark() for the rare
  case where an object is in construction.

Output on Z840 (down from ~21.8x):
[ RUN      ] WriteBarrierPerfTest.MemberWritePerformance
*RESULT WriteBarrierPerfTest writes during GC: = 28129.39521800281 writes/ms
*RESULT WriteBarrierPerfTest writes outside GC: = 480769.2307692308 writes/ms
*RESULT WriteBarrierPerfTest relative speed difference: = 17.091346153846157 times
[       OK ] WriteBarrierPerfTest.MemberWritePerformance (32 ms)

Bug: 1014414
Change-Id: I9319a312a94a4fbafd4d87145414e7b2f4acd583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865163
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706666}

l10n_util::GetApplicationLocale() returns empty string on Android since
we don't pack any .pak file into our apk, which makes the notification
client always fallback to en-US. This CL fixes this by calling
base::android::GetDefaultLocaleString() on Android to get back the
default locale.

Bug: 1001291
Change-Id: I0d8499d00dcd8a1343109377b3bee6f708c43e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864362
Auto-Submit: Yuwei Huang <yuweih@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706665}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/341f30345fd1..4283206673b9

git log 341f30345fd1..4283206673b9 --date=short --no-merges --format='%ad %ae %s'
2019-10-16 khegde@chromium.org diagnostics: Add healthd_ec to cros_ec-access

Created with:
  gclient setdep -r src/third_party/chromite@4283206673b9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I2caa5eda4bfd750f0673b0c2fb0b3a1d19d3e833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865584Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706664}

This operation doesn't make sense on remote frames.

Bug: 416660
Change-Id: I24ab6dfbfa1e582a920f7502076e88e24eccaa47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865610Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706663}

(1) Feature kEnableCrOSActionRecorder is added with param
    "CrOSActionRecorderType" to initialize CrOSActionRecorder.

(2) Used that flag in unit tests.

(3) Associate a Chrome flag enable-cros-action-recorder to the Feature
    so that the Feature can be enabled from chrome flags.

Bug: 1012936
Change-Id: I21cb53b3a2201a7fa959c936ccee32b397708f4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859806Reviewed-by: Tony Yeoman <tby@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Auto-Submit: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706662}

This reverts commit 305eca2a.

Fixed: Only disable ARB_texture_rectangle for WebGL contexts.

Original change's description:
> Revert "WebGL: Don't expose ARB_texture_rectangle on Mac passthrough"
>
> This reverts commit f061988f.
>
> Reason for revert: Failures on webgl(2)_conformance_gl_passthrough_tests on Mac FYI bots
>
> Original change's description:
> > WebGL: Don't expose ARB_texture_rectangle on Mac passthrough
> >
> > Uses the new DisableExtension functionality from
> > https://chromium-review.googlesource.com/c/angle/angle/+/1838418
> > to prevent ARB_texture_rectangle from being exposed to WebGL shaders.
> >
> > Bug: angleproject:3770
> > Change-Id: I106785757235f3f1748d74ddf25dac9384caa281
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842223
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Commit-Queue: James Darpinian <jdarpinian@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#705802}
>
> TBR=kbr@chromium.org,jdarpinian@chromium.org
>
> Change-Id: I924e7a306fbb91feb914973b9a3a24b857d738e4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: angleproject:3770
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863155
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705994}

Bug: angleproject:3770
Change-Id: I32a776e0f7473574b2d985b9a07aebae799d47e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864092
Auto-Submit: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706661}

This change adds the ability to navigate to the allocation stacks in
the memory tool from a keyboard. It uses arrow keys to navigate the stack,
and the links can be accessed from pressing enter when the item has focus,
or from a context menu for consistency with other callstacks with links.

Before: https://imgur.com/gz1mCyY

**Note context menu text has been updated since recording After gif. It now
reads 'Reveal in Sources panel'
After: https://imgur.com/aJJgco0

Bug: 963183
Change-Id: I0babaab431c60913f94eca7f0fee9bb0e8c25532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696400
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Reviewed-by: Jeff Fisher <jeffish@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706660}

Bug: 965770
Test: No more HTML Import warnings in DevTools
Change-Id: I0abdba8172166dee7bd8f45121440d1bc01b7a0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863951Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706659}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ee8e9c15222c..9e4f6d03f2f7

git log ee8e9c15222c..9e4f6d03f2f7 --date=short --no-merges --format='%ad %ae %s'
2019-10-16 johnkslang@users.noreply.github.com Merge pull request #1932 from zoddicus/anotherSemiColonFix
2019-10-16 johnkslang@users.noreply.github.com Merge pull request #1934 from durswd/master
2019-10-15 johnkslang@users.noreply.github.com Merge pull request #1866 from rumblehhh/master
2019-10-15 johnkslang@users.noreply.github.com Merge pull request #1930 from ux3d/fix/CMakeOptionalExternalBuild
2019-10-15 cepheus@frii.com GLSL/SPV: Pre SPIR-V 1.5, subgroupQuadBroadcast index must be constant
2019-10-12 johnkslang@users.noreply.github.com Merge pull request #1880 from georgeouzou/master
2019-10-12 johnkslang@users.noreply.github.com Merge pull request #1928 from Xottab-DUTY/patch-1
2019-10-12 johnkslang@users.noreply.github.com Merge pull request #1926 from zoddicus/fixChromiumRoll
2019-10-11 johnkslang@users.noreply.github.com Merge pull request #1888 from Roy-AMD/Adjusting-code-interface
2019-10-11 johnkslang@users.noreply.github.com Merge pull request #1925 from greg-lunarg/kg107

Created with:
  gclient setdep -r src/third_party/glslang/src@9e4f6d03f2f7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com,jmadill@google.com

Bug: None
Change-Id: I3d0e77f6c08b064a99949946d1919ffde8065191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865581Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706658}

This patch updates the activation reasons to classify tab focus and
selection as being viewport activations.

This implements the resolution from:
https://github.com/WICG/display-locking/issues/87

R=chrishtr@chromium.org, rakina@chromium.org

Change-Id: I9202713a5b375775a7ac5fd3348d949d8f4a3cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864821
Commit-Queue: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Auto-Submit: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706657}

This CL adds a banner to the Safety Tip bubble on desktop platforms. It
introduces two UIs: one for URL lookalikes, and one for suspicious
sites.

It now looks like this:
https://drive.google.com/file/d/1RppvDBXThzzbu5CknJ_-nYP6iKkXH8l6/view

Bug: 1013401
Change-Id: Id2eef386ddeedc89535f8e8097a8348bf2572558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865539Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706656}

Prior to https://chromium-review.googlesource.com/c/chromium/src/+/1842298
errors that occurred on a destroyed context were hidden. The change
turned the errors into a null pointer failure. Appropriately reject
promises for handles that are associated with a destroyed context.

BUG=1015086

Change-Id: I75d7b334ec2c2c219e703c5afa31036895e0c7a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865649
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706655}

Bug: 724598
Change-Id: Icd4f59dcd9a917bfd9ab910c51dc27396b581d79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863353
Commit-Queue: Evan Liu <evliu@google.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706654}

https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/c1a585fab0c1..e637a4b3de2f

$ git log c1a585fab..e637a4b3d --date=short --no-merges --format='%ad %ae %s'
2019-10-10 ebrahim Minor, add a zero length tolerant memset, hb_memset
2019-10-09 corbett.dav Reorder U+1C29 LEPCHA VOWEL SIGN OO
2019-10-09 grieger Convert existing uses of serialize_append in gsub subsetting to use subset_offset_array.
2019-10-07 grieger Add subset_offset_array helper function which simplifies subsetting offset arrays during stream operations.
2019-10-08 ebrahim [ot-metrics] Don't use mixed scaled and not scaled for generating extents
2019-10-08 ebrahim [glyf] Address Behdad's reviews
2019-10-08 ebrahim [glyf] fix scaling direction
2019-10-08 ebrahim minor
2019-10-08 ebrahim [glyf] Move glyph bytes drop hints logic to GlyphHeader
2019-10-08 ebrahim [glyf] Implement depth limit for add_gid_and_children
2019-10-08 ebrahim [glyf] Move add_gid_and_children to glyf table
2019-10-08 ebrahim Minor, replace hb_set_add with private API
2019-10-08 ebrahim [glyf] Move subset related methods inside GlyphHeader
2019-10-07 ebrahim [glyf] minor
2019-10-07 ebrahim [glyf] Move padding removal logic to GlyphHeader
2019-10-07 ebrahim [glyf] minor
2019-10-06 ebrahim [glyf] Aggregate get_offsets uses
2019-10-08 ebrahim [cff] minor on number_t
2019-10-06 ebrahim [ot-font] Apply font scaling before turning to int
2019-10-06 ebrahim [glyf] minor, remove GlyphHeader::simple_* helpers
2019-10-06 ebrahim [glyf] Move get_instruction_length inside GlyphHeader struct
2019-10-06 ebrahim [glyf] cleanup
2019-10-06 ebrahim [glyf] Remove get_composite_iter and refactor bytes_for_glyph for shape uses
2019-10-06 ebrahim [glyf] Rewrite composite iterator to new iterators convention
2019-10-05 ebrahim [gvar] minor
2019-10-05 ebrahim [glyf][gvar] Make HB_NO_VAR buildable
2019-10-04 ebrahim [gvar] minor
2019-10-04 ebrahim [glyf] Use common convention of other tables access, format
2019-10-03 ebrahim [glyf] minor
2019-10-03 ebrahim [hmtx] Use more conventional internal API style
2019-10-03 ebrahim [hmtx] Use more optimal way to access glyf table
2019-10-01 ariza Implement gvar table and variable glyf
2019-10-03 ebrahim [ot-font] Use var vmtx side bearing in calculating v-origin
2019-10-03 ebrahim [hmtx] Prepare to fix and minor fixes
2019-10-03 ariza Implement hmtx/vmtx metrics read from hvar/vvar
2019-10-02 ebrahim Add Repology badges by @luzpaz
2019-10-01 ebrahim [cff] minor
2019-10-01 ebrahim Minor, tweak spaces
2019-10-01 ebrahim Fix -Wsizeof-array-div clang warning
2019-09-30 behdad 2.6.2
2019-09-10 behdad [docs] Misc fixes
2019-09-26 ebrahim [icu] Remove HB_ICU_STMT (#1993)
2019-09-26 iceflower Define HB_UNUSED for clang
2019-09-26 iceflower [dwrite] Fix extra semicolon issue
2019-09-18 qxliu [subset] GPOS Lookup Type 3: CursivePos
2019-09-24 ebrahim Revert previous change and fix -Wrange-loop-analysis complains
2019-09-24 ebrahim Minor, normalize for each calls
2019-09-24 ebrahim [serialize] use for each as #resolve_links, format
2019-09-23 48925186+qxliu76 memory leak fix in serializer (#1988)
2019-09-23 ebrahim [gpos] minor
2019-09-23 ebrahim [cmap] remove has_format14, minor format
2019-07-12 ariza added skip(), get_next_value() to inc_bimap to subset VarStore with retain-gids
2019-07-01 ariza added VariationStore serializer to be used by HVAR/VVAR subsetters

Created with:
  roll-dep src/third_party/harfbuzz-ng/src
R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org

Change-Id: Iad918444b9c9c8274e8e73c137cba56b6074f822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865711Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706653}

We have disabled mock theme for web tests except for
fast/scrolling/scrollbars/ in
https://chromium-review.googlesource.com/c/chromium/src/+/1856359.

This CL makes the remaining tests work (or with filed bugs) with
native themes, and removes the all mock theme code.

Change-Id: Ifcf74c643d0e972093fe5307f6767e6f7d108d2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835272
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Rahul Arakeri <arakeri@microsoft.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706652}

An overload of SpdyTestUtil::ConstructSpdyReplyError() takes a |stream_id|
parameter, but ignores it and always uses 1 for the stream ID.

All callers pass 1 anyways, so this should be a safe change.

Change-Id: Ib57281ad88711bb90c5cde86e3dcec3809fa3c38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865749Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706651}

https://swiftshader.googlesource.com/SwiftShader.git/+log/01cc61ab9c9c..6652f0b64287

git log 01cc61ab9c9c..6652f0b64287 --date=short --no-merges --format='%ad %ae %s'
2019-10-16 amaiorano@google.com Subzero: fix calling C functions on Windows x86
2019-10-16 amaiorano@google.com Subzero: fix invalid arg access on Windows x86
2019-10-16 amaiorano@google.com Subzero: fix warnings for VS 2019 x86 build
2019-10-16 amaiorano@google.com Subzero: fix calling C functions on Windows x64
2019-10-16 amaiorano@google.com Add .clang-format file to third_party/subzero
2019-10-16 amaiorano@google.com Reactor: add test for external call to routine
2019-10-16 amaiorano@google.com Reactor: add unit tests for testing arg passing
2019-10-16 amaiorano@google.com Reactor: add overload of rr::Call for void(...)

Created with:
  gclient setdep -r src/third_party/swiftshader@6652f0b64287

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/142132927,chromium:b/142132927,chromium:b/142132927,chromium:b/142132927,chromium:b/142132927,chromium:b/142132927,chromium:b/142132927,chromium:b/142132927
Change-Id: Id0e48836f45275261ed2bde45771a69d9a20d5c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865583Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706650}

This removes "future: True" from the Legacy cookie access enterprise
policies to activate them, as the implementation is now complete.

Bug: 978172
Change-Id: I6f5073483b680532572113a58a44081ef211ef33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865593Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706649}

Bug: 1009413
Change-Id: I96251acc1010789d41e43b3dd1bac5b16b8698cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863856Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706648}

Removes the mojom enum equivalent of leveldb::Status. Status is used
everywhere DatabaseError was used before.

Bug: 1000959
Change-Id: Ib1e957f7d7b6c6e66162ea768d591f7394d558dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863775
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706647}

The GCM handler doesn't need to create the GCM token. Splitting this interface
simplifies the code. Additionally, we can now always create the gcm handler,
even in reduced mode.

GetGCMToken() is now a global function, and still called only after browser start.

This is safer, because the handler is accessed by
another keyed service. Before this CL, there was no guarantee that the gcm handler
would be created before it's accessed by gcm_profile_service_factory.cc

Change-Id: I27ab837f4294f450ee11dfaa9a833ba90cf3c83a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690712
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706646}

RoundedCornerImageView ran into a few problems exposed by omnibox usage:
- ImageView#setImageResource() doesn't end up calling setImageDrawable()
on some Android versions.
- BitmapDrawable can apply a scale so getIntrinsicWidth/Height won't be
the same as get Bitmap#getWidth/Height.  This wasn't handled in this
code.
- Also some general code clean-up to make it easier to parse and update
in the future.

Bug: 1001209
Change-Id: Ib861686ce51eb019cc068e24e042aca1ae42cd23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788299
Commit-Queue: Ender <ender@google.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Auto-Submit: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706645}

Roll broadwell AFDO profile from 79-3903.0-1569840015-benchmark-79.0.3923.0-r1 to 79-3904.41-1571046112-benchmark-79.0.3940.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_EXTRA_TRYBOTS=
TBR=c-compiler-chrome@google.com

Change-Id: I302bfe26522e9cbe85acd3e2077d73998b4eb05c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865700Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706644}

For debugging, it will be useful to track the model weights over time
to rule out any bad behaviour in the model itself. This CL VLOGs the
weights each time they are changed.

Note the code for this looks a little misplaced at the bottom of
SearchResultRanker::Train, but that's where other metric-related code
lives in a parallel CL.

Bug: 1011221
Change-Id: I8a737b0f8221f7016d08c6f2f3f4e96d253ffd47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864492Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706643}

Bug: 923594
Change-Id: Id7fee971d9d52eac80a79523c9a354fd53809c64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862732
Commit-Queue: Max Li <themaxli@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706642}

Roll airmont AFDO profile from 79-3904.19-1569838411-benchmark-79.0.3923.0-r1 to 79-3931.2-1571054549-benchmark-79.0.3940.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_EXTRA_TRYBOTS=
TBR=c-compiler-chrome@google.com

Change-Id: I73bcebfebd035be911e59d8888636c81580e7e11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865699Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706641}

Roll silvermont AFDO profile from 79-3904.19-1569836348-benchmark-79.0.3923.0-r1 to 79-3928.0-1571049528-benchmark-79.0.3940.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_EXTRA_TRYBOTS=
TBR=c-compiler-chrome@google.com

Change-Id: Iac049fe0b473b4b6bab48aafc56dec10191f187d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865698Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706640}

This test is flaky on the bots when run as part of the suite. Although
unable to reproduce locally, the calls to ExecuteJavaScript were failing
which points to a general test problem.

Without being attached to a windowed view, WKWebView can internally
suspend processes. Add the |web_view| to a windowed container to try to
prevent flake.

Additionally, extend the timeout for JavaScript execution because the
old timeout was too short for JavaScript execution to always complete.

Bug: 1013206
Change-Id: I1bd685563bc0e522647ab0402e64428fa746e430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856659Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706639}

This reverts commit 6cd69069.

Reason for revert: broke weblayer instrumentation tests, see https://ci.chromium.org/p/chromium/builders/ci/Mojo%20Android/20184?blamelist=1#blamelist-tab

Original change's description:
> Persist cookies for profiles with non-null path
>
> Currently the cookies are not persisted because the default
> implementation of ContentBrowserClient::CreateNetworkContext doesn't
> specify cookie_path parameter. In this CL CreateNetworkContext is
> overridden in WebLayer implementation.
>
> Bug: 1014048
> Change-Id: I1b7a307a64cd836eb5c4a45817412b997b89f1f5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862677
> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706390}

TBR=jam@chromium.org,boliu@chromium.org,pshmakov@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1014048
Change-Id: I7b302c7ea8618acd1c578b14ac9c8ed894744cca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865130Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706638}

This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

https://github.com/WICG/import-maps/pull/176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842928
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706637}

Bug: 1002714
Change-Id: Iad2c658e651d5301353ca0db289570d1ea94530a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865650Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706636}

BUG=none
TEST=none

Change-Id: Id93a18c55d148eb9cf4f7fea9a53f2c4add63d6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861514
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706635}

Keyboard accessiblity: In this change user can navigate through swatches using LEFT AND RIGHT arrow keys.
Pressing ENTER or SPACEBAR selects focused color.

This change was reviewed earlier here https://chromium-review.googlesource.com/c/chromium/src/+/1687564 has been broken down
1. Make swatches in color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1817344
2. Make swatches screen reader accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816875
3. Make shades of a color palette keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816873
4. Make close button keyboard accessible https://chromium-review.googlesource.com/c/chromium/src/+/1816874

Bug: 963183
Change-Id: I4877d89c49c1c1072deb2da7f6a811af7cd5c21d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817344Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Reviewed-by: John Emau <John.Emau@microsoft.com>
Commit-Queue: Chandani Shrestha <chshrest@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#706634}

Eliminates use of the BatchedOperation mojom struct from
LocalStorageContextMojo.

Bug: 1000959
Change-Id: I09b849a3a53379735535dc7d00db19d2c745bfe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863253
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#706633}

Bug: 1011908
Change-Id: I01c20af558317070d99313252823aef38f85338c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864460
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706632}

https://android.googlesource.com/platform/external/perfetto.git/+log/f73d91573493..71a18f6f4b01

git log f73d91573493..71a18f6f4b01 --date=short --no-merges --format='%ad %ae %s'
2019-10-16 bhamrick@google.com Merge "trace_processor: Bounds checks for reading Fuchsia record data"
2019-10-16 treehugger-gerrit@google.com Merge "Reland "processor: Move TimestampedTracePiece into its own header""

Created with:
  gclient setdep -r src/third_party/perfetto@71a18f6f4b01

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I4a561bf2f3b74d9a451b178acc112876bf0b7337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864817Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706631}

This is a test for regression introduced by
https://chromium-review.googlesource.com/c/chromium/src/+/1856929

Change-Id: I833a24ceb7b316f432033f3bf721084a708dfd64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863850
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706630}

https://webrtc.googlesource.com/src.git/+log/64444bc865d2..562a37f926dd

git log 64444bc865d2..562a37f926dd --date=short --no-merges --format='%ad %ae %s'
2019-10-16 danilchap@webrtc.org Increase timeout in test-only helper SendTask back to infinity
2019-10-16 phoglund@webrtc.org Remove the fileutils hack for good.

Created with:
  gclient setdep -r src/third_party/webrtc@562a37f926dd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: Ia0ee3c28f4bcfca84c687501e96c93eb0f7ac2e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864818Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#706629}

Previously, the paused_ flag was used to signal that the animation was
in a paused state.  This flag is not part of the spec and is being
phased out.  Instead, we look for pending pause or play tasks and
whether there is a start time to determine if the animation is paused in
alignment with the spec.

Note that fixing play state calculation entailed fixing the handling of
setting a zero playback rate.  Previously, setting the playback rate to
zero would clear the start time; however, this has the unwanted side
effect of forced the animation into the paused state, which is not to
spec.  A running or finished animation should have a start time (if not
a pending change) even if the playback rate is zero.

https://drafts.csswg.org/web-animations/#play-states

Bug: 960944

Change-Id: I1fd43315d3b1c42b22302bf730c450a03836861a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862258
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706628}