- 30 Nov, 2018 40 commits
-
-
Leszek Swirski authored
Bug: 866868 Change-Id: I2c86c688d6d3df2a4506876724ba7c5fbc4290ad Reviewed-on: https://chromium-review.googlesource.com/c/1347360Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#612613}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Ia3cab69f49adc2efd6cdec851186254aeb6e6e54 Reviewed-on: https://chromium-review.googlesource.com/c/1352756 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#612612}
-
Colin Blundell authored
dice_browsertest.cc checks the |is_valid| param in its implementation of IdentityManager::Observer::OnRefreshTokenUpdatedForAccount(). This param is slated for removal (see bug), so we need to change this. Happily, (or unhappily), the tests do not depend on this check; it can just be removed. Bug: 908412 Change-Id: Id59c9370bf8258d077de689ee5ba55fd67d89f2e Reviewed-on: https://chromium-review.googlesource.com/c/1353893Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#612611}
-
David Roger authored
To simplify authentication error handling, this CL updates the SigninErrorController to get its error state from the token service by observing it. This removes some coupling between the classes, and removes the AuthStatusProvider mechanism, leading to an overall simplification of the code. TBR=eugenebut Bug: 836212 Change-Id: Ie9b849fcd804d4fe6b4787b277b27fb848cdf2dc Reviewed-on: https://chromium-review.googlesource.com/c/1070154 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#612610}
-
Javier Ernesto Flores Robles authored
Clears the vertical constraints for reuse. Removes extra vertical constraints from separator. Bug: 878388, 845472 Change-Id: I5ba9efdacd2ac642361069b241a9e53956edc215 Reviewed-on: https://chromium-review.googlesource.com/c/1355137Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#612609}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Change-Id: I3afc1e03c280c88cce039ac8d4a6b288edd7be78 Reviewed-on: https://chromium-review.googlesource.com/c/1355173Reviewed-by:
-
Patrik Höglund authored
Long-running bots have been removed and the buildbot master is gone. Tbr: jbudorick@chromium.org Bug: chromium:877018 Change-Id: If9e6ccbcf4ccb2e31ae1a76bb44ebdd22401a2fb Reviewed-on: https://chromium-review.googlesource.com/c/1356580Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#612607}
-
Keishi Hattori authored
Convert (anonymous namespace), [A-C]* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: Ia7b39ef2c27c5b4e4f98086212de128a2fe1b3b4 Reviewed-on: https://chromium-review.googlesource.com/c/1348871Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612606}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I81882f7148677e303550d5dc13bfffb74715ac57 Reviewed-on: https://chromium-review.googlesource.com/c/1352779Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#612605}
-
Kent Tamura authored
HTMLElement::IsLabelable meant "this is a LabelableElement", and now supersedes LabelableElement::SupportLabels. This CL is a preparation to add support of <label> and 'labels' IDL attribute to form-associated custom elements. This CL has no behavior changes. Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: I93868364d754df1b43b8269e539c29e29ab8e563 Reviewed-on: https://chromium-review.googlesource.com/c/1356177Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#612604}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b75782c63717..46cbcf081bc5 Created with: gclient setdep -r src-internal@46cbcf081bc5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mmoss@chromium.org Change-Id: I719d1705e776ae8f766f9bf56cf8a4940a3986f7 Reviewed-on: https://chromium-review.googlesource.com/c/1356381Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612603}
-
Carlos Caballero authored
TSAN will otherwise complain as this variable is accessed from multiple threads. This was found while running TSAN tests in https://crrev.com/c/1350917 Change-Id: I29761910a56ae8e29a205288ad1ddff57969d6ea TBR=fdoray@chromium.org Change-Id: I29761910a56ae8e29a205288ad1ddff57969d6ea Reviewed-on: https://chromium-review.googlesource.com/c/1355183 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612602}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ie373bcee369c0f5736a2a055b8ff6b43eaecda3b Reviewed-on: https://chromium-review.googlesource.com/c/1356559Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612601}
-
Greg Thompson authored
BUG=910493 TBR=wzang@chromium.org Change-Id: Iba2c449b0db5842bd4d77c020bedc38b94f83415 Reviewed-on: https://chromium-review.googlesource.com/c/1356579 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#612600}
-
Matt Falkenhagen authored
As explained in the bug by pwnall: ServiceWorkerDatabase::GetRegistrationsForOrigin() obtains a LevelDB iterator and calls ServiceWorkerDatabase::ReadResourceRecords() in a loop. ReadResourceRecords() in turn calls ServiceWorkerDatabase::HandleReadResult(), which may call ServiceWorkerDatabase::Disable() if the status is a failure. Disable() contains a "db_.reset()" which deletes the leveldb::DB instance. So, ReadResourceRecords() may end up deleting the database before the iterator used by GetRegistrationsForOrigin() is deleted. The contract for leveldb::DB::NewIterator() [1] states that the iterator must be deleted before the DB instance is deleted. [1] https://cs.chromium.org/chromium/src/third_party/leveldatabase/src/include/leveldb/db.h?l=92&rcl=73d5834eceee8efa9a8ccfec77dc096a9e8ba18a Bug: 909024 Change-Id: Ifee9aa0f7e1db9168d61b6407a11e249b2001986 Reviewed-on: https://chromium-review.googlesource.com/c/1354730 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#612599}
-
Greg Thompson authored
BUG=626703 TBR=grt@chromium.org NOTRY=true Change-Id: Ia98f89acc155d170063dc851c18fba426ebbc280 Reviewed-on: https://chromium-review.googlesource.com/c/1356540Reviewed-by:
-
Eric Seckler authored
Adds a new DataSource for the Cast system tracing agent and enables the corresponding TracingController test on Cast for perfetto. Bug: 900603 Change-Id: I249066a57003996bb0c40dcc88bcbe5b23414b8d Reviewed-on: https://chromium-review.googlesource.com/c/1353892Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
-
Richard Li authored
In this CL, fetch_api_request.mojom is moved from blink/public/platform/modules/fetch/ to blink/public/mojom/fetch/ Change-Id: I2679cd178e79561213d67a15413a60b66ae1d8f9 Reviewed-on: https://chromium-review.googlesource.com/c/1351885 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#612596}
-
Yutaka Hirano authored
Currently HashMap<K, V>::IsValidKey takes PeekInType. This is causing a problem when K is a scoped_refptr<T>, because PeekInType for scoped_refptr<T> is essentially a raw pointer while KeyTraits::IsDeleted which is called in IsValidKey takes scoped_refptr<T>, not T*. Bug: 910033 Change-Id: I60bceb11a3e4f219c40030e0b606d709d4f13cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1351979 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#612595}
-
Vaclav Brozek authored
vabr@ going hobby-only and being no longer OWNER after https://crrev.com/c/1354009 will no longer need the CL updates. Bug: 908813 Change-Id: I5348adbee43a4137719e9c38fe255ec2654ce053 Reviewed-on: https://chromium-review.googlesource.com/c/1356039 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#612594}
-
Hayato Ito authored
To isolate unrelated style change from another CL. It looks document.{cc,h} is not well formatted. Change-Id: I914e9f1cad29774538d4fa78f9d0d37e3ef25deb Reviewed-on: https://chromium-review.googlesource.com/c/1356440Reviewed-by:Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#612593}
-
Xiaocheng Hu authored
This patch fixes a null-deref bug caught in DCHECK-enabled Canary. The issue is minor and doesn't worth too much investigations, while we don't have a repro case, so this patch simply patches it without regression test case. Bug: 905594 Change-Id: Icbfa1d7937872c63033d9c7459e6280894e83910 Reviewed-on: https://chromium-review.googlesource.com/c/1355904Reviewed-by:
-
Yuta Kitamura authored
It's unused as of now. Bug: 826203 Change-Id: I8e54a8234cb83c1ac871768a62fb2224be9ba0d0 Reviewed-on: https://chromium-review.googlesource.com/c/1356461Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f0a854a2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Ia5f36ab856b57acb27217cbf32513d0af4832d67 Reviewed-on: https://chromium-review.googlesource.com/c/1356335 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612590}
-
Ken Rockot authored
Migrates a bunch of stuff related to either ash, mash, or viz, over to ServiceBinding instead of the deprecated ServiceContext/EmbeddedServiceInfo etc APIs. Bug: 891780 Change-Id: Ia5313525013cd75c845b04f7ff6550a2880553f6 Reviewed-on: https://chromium-review.googlesource.com/c/1355981 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#612589}
-
Patrik Höglund authored
The bot fails with stale video, let's see what it looks like. Bug: 877018 Change-Id: I9432dcfa9d420ea44bef14f81e502b11eb840f84 Reviewed-on: https://chromium-review.googlesource.com/c/1355159 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#612588}
-
Evan Stade authored
BrowserWithTestWindowTest now creates a MusClient, which is important for its native widget factory. AshTestViewsDelegate doesn't set the context on context/parentless widgets for Mash, since DesktopNativeWidgetAura doesn't require that and it interferes with getting the correct aura::Env. Using Shell's Env is problematic because the aura::Window for a WebContents wants to use aura::Env::GetInstance, which differs from the shell's Env. WebContentsViewAura uses the Env of its context for the aura::Window it creates, if there is a context. Also, spot fixes for: 1. LockScreenAppStateTest 2. ChromeLauncherControllerTest 3. ImmersiveModeControllerAshTest (some of these pass, a couple still fail, but none should crash) 4. TabStripTest 5. BookmarkBarViewTest Bug: 906906,905430 Change-Id: I19ce303a0cad91262c1a393379ecd5c9d2bf75fb Reviewed-on: https://chromium-review.googlesource.com/c/1351884Reviewed-by:
-
Luciano Pacheco authored
Change test |dirRenameWithoutChangingCurrent| to use helper function |expandTreeItemInDirectoryTree| which waits for the expansion action to finish, the helper used previously didn't expect the expansion to finish which was causing flakiness. Bug: 910468 Change-Id: I96c901af27799898470cb928e760a511a6f53d4c Reviewed-on: https://chromium-review.googlesource.com/c/1356441 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612586}
-
Peter Kotwicz authored
This CL changes the behaviour of H2OMainActivity when it enables SplashActivity. This CL changes H2OMainActivity to launch SplashActivity after enabling it. H2OMainActivity needs to launch SplashActivity so that when a user 1) Launches the WebAPK for the first time (and the user has a SplashActivity compatible browser installed) 2) The user returns to the home screen without swiping away the WebAPK 3) The users taps the WebAPK's app icon The already launched WebAPK is brought to the foreground instead of being relaunched. The WebAPK is killed as a result of the PackageManager call to enable SplashActivity. This CL relaunches SplashActivity by sending an intent to the host browser with a boolean extra - org.chromium.webapk.relaunch - indicating that it wants to be relaunched. Doc summarizing all of the "New Splash WebAPK" launch flows: https://goo.gl/J2yB87 BUG=901954 TEST=LaunchTest.*, MainActivityTest.* Change-Id: I6f34cb71a1e1bfe63cad664f24dd48b9b5791c7d Reviewed-on: https://chromium-review.googlesource.com/c/1318377 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612585}
-
Sam McNally authored
Bug: 909056 Change-Id: I57857d8dc027a173e669d8d77bc06c00f42977e4 Reviewed-on: https://chromium-review.googlesource.com/c/1355316Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612584}
-
Sam McNally authored
Bug: 909056 Change-Id: Ia7eb34e4c6c157f8083d0624d1e5d5066c69135e Reviewed-on: https://chromium-review.googlesource.com/c/1355312Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612583}
-
Sam McNally authored
Bug: 909056 Change-Id: If12158a436f4c384c663f7ffcceb081018d6be8d Reviewed-on: https://chromium-review.googlesource.com/c/1355307Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/75a486e0a03a..dae4dfd2c5df git log 75a486e0a03a..dae4dfd2c5df --date=short --no-merges --format='%ad %ae %s' 2018-11-30 thestig@chromium.org Use size_t in more places in fxbarcode. Created with: gclient setdep -r src/third_party/pdfium@dae4dfd2c5df The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I576c903c837e86a1d64bf98c665a775017228f73 Reviewed-on: https://chromium-review.googlesource.com/c/1356400Reviewed-by:
-
Matt Giuca authored
This reverts commit 2b45d94c. Reason for revert: WPT patch can't be responsible for regressing this test. Since this is >1M old, we have no data to investigate (may be bot flake), so re-enabling the test and if it's still a problem, we'll have more data. Original change's description: > Disable HostedAppTest.DesktopPWAsFlagDisabledCreatedForInstalledPwa on Mac > > Test failures were introduced by a WPT patch > https://chromium-review.googlesource.com/c/chromium/src/+/1293038 > > TBR=robertma@chromium.org > NOTRY=true > > Bug: 897719 > Change-Id: I10f67a682e8747e745bf12c180356f5ec1674b01 > Reviewed-on: https://chromium-review.googlesource.com/c/1292803 > Reviewed-by: Yi Gu <yigu@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601560} Bug: 897719 Change-Id: Ieb3f4a3959faeb46e9c6378d5721e18dba5b2ef9 Reviewed-on: https://chromium-review.googlesource.com/c/1356173Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#612580}
-
rajendrant authored
Some tracking pixel images could be mentioned using CSS style. Deferring such images could lead to be double fetched if it gets near the viewport. Bug: 875086 Change-Id: I3ad2da26c552b21de374539b7ad49e35c95afc11 Reviewed-on: https://chromium-review.googlesource.com/c/1352978 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#612579}
-
Toni Barzic authored
Also, ClearSigninProfile now closes any browser window opened in the profile. Ideally, no browsers would be open in the sign-in profile, but we've had cases where that had happened. This is attempt 2 at CL:1347105 - moved the call to clear the sign in profile to a later stage, when the login host (which might be using sign-in profile) is shutdown. Also, clearing the profile does not delay of user session finalization. BUG=906837,901768 Change-Id: I374c2342bfe153d9e3420135275f1a543d40b60c Reviewed-on: https://chromium-review.googlesource.com/c/1351764Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612578}
-
Kent Tamura authored
Updating 'form' attribute didn't update the element's owner <form>. HTMLElement should call ListedElement::FormAttributeChanged() when 'form' content attribute is changed. Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: Iec16f0c40290fda963c2a8c863ea8925f3a154b3 Reviewed-on: https://chromium-review.googlesource.com/c/1356174Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#612577}
-
Jun Mukai authored
Things are really complicated when a tab is about to be dragged with touch events during immersive fullscreen mode in Mash. The details are depicted as https://docs.google.com/document/d/1fS6YlkYUCqPCHJpVvKEVbgVilkmnPGl5x2a2kZvW7z0/edit?usp=sharing. This CL allows Ash to pick up the right target window by setting the insets when the reveal status is changed. The test also needs to be fixed because: - without reveal lock, it can't say the tabstrip is really there (and the insets are properly set) - QuitWhenNotDragging needs to be executed for touch events too, otherwise it doesn't wait for asynchronous touch events. Bug: 901544 Test: see the filter. also manually checked the behavior Change-Id: I9215fd0198f48a0ac641cd850ff290513e185775 Reviewed-on: https://chromium-review.googlesource.com/c/1336370 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
Using GetUserAgent in a sandboxed process results in a wrong value, so get the string in the browser process and pass it to other processes. Bug: 818450 Change-Id: Ic8a0ca4c602617f9444bcb23327eda46b560c1b5 Reviewed-on: https://chromium-review.googlesource.com/c/1353052Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
This reverts commit 173a384b. Reason for revert: Breaks WebKit Unit Tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Audio%20Linux/26824 [ RUN ] LazyLoadFramesTest.LazyLoadWhenNotRestricted Received signal 11 SEGV_MAPERR 000000000000 #0 0x5583c9247e5f base::debug::StackTrace::StackTrace() #1 0x5583c92479e1 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7fe0e028f330 <unknown> #3 0x5583cb205d8b content::WebURLLoaderImpl::Context::Start() #4 0x5583cb209f04 content::WebURLLoaderImpl::LoadAsynchronously() #5 0x5583cb226023 blink::WebURLLoaderMock::LoadAsynchronously() #6 0x5583c75e2862 blink::ResourceLoader::StartWith() #7 0x5583c75df8ba blink::ResourceLoadScheduler::Request() #8 0x5583c75e2458 blink::ResourceLoader::Start() #9 0x5583c75d3d19 blink::ResourceFetcher::StartLoad() #10 0x5583c75d2dd0 blink::ResourceFetcher::RequestResource() #11 0x5583c75c0f96 blink::RawResource::FetchMainResource() #12 0x5583ca624b45 blink::DocumentLoader::StartLoading() #13 0x5583ca63158c blink::FrameLoader::CommitNavigation() #14 0x5583ca22aed2 blink::WebLocalFrameImpl::CommitNavigation() Original change's description: > LazyLoad: Add support for restricting LazyLoad to Data Saver users. > > This CL adds support for restricting the lazy loading of frames and > images separately by field trial parameters. For lazy image loading, to > avoid the performance hit from repeatedly locking the mutex in > NetworkStateNotifier, the value of > NetworkStateNotifier::SaveDataEnabled() is queried once for each frame > and used for all images in that frame. > > Bug: 901571 > Change-Id: Ic08416ebe40b6377d5c383616b4f0ceff920637a > Reviewed-on: https://chromium-review.googlesource.com/c/1354694 > Commit-Queue: Scott Little <sclittle@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612554} TBR=dcheng@chromium.org,pfeldman@chromium.org,sclittle@chromium.org Change-Id: I95266601549407d894a91ea3b7724b0b8bceed2c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901571 Reviewed-on: https://chromium-review.googlesource.com/c/1355318Reviewed-by:
-
