- 10 Mar, 2017 40 commits
-
-
mdjones authored
Dynamic inflation of the progress bar caused it's color to be incorrect on incognito tabs. This change modifies the ToolbarTablet to set the appropriate color whenever the tab's model changes. BUG=698715 Review-Url: https://codereview.chromium.org/2742573006 Cr-Commit-Position: refs/heads/master@{#456201}
-
alokp authored
BUG= Review-Url: https://codereview.chromium.org/2743773003 Cr-Commit-Position: refs/heads/master@{#456200}
-
wylieb authored
When we run integration tests, we need accounts with a clean slate. This CL clears out the data on sync servers for the given test account, and restarts sync. This operation doesn't require read/writing any data to the account, and thus passphrase decryption is by-passed (Some tests have the side-effect of setting a decryption passphrase that requires clear server data to be run without decryption). R=pavely@chromium.org,skym@chromium.org TEST=run this command ninja -C out/Debug sync_integration_tests -j 200 && \ xvfb-run --server-args="-screen 0 1920x1080x24" \ out/Debug/sync_integration_tests \ --gtest_also_run_disabled_tests \ --gtest_filter=*E2ETest* \ --sync-url=https://clients4.google.com/chrome-sync/dev \ --sync-user-for-test=testuser@gmail.com\ --sync-password-for-test=testpassword --vmodule=*sync*=1 BUG= Review-Url: https://codereview.chromium.org/2716413003 Cr-Commit-Position: refs/heads/master@{#456199}
-
mcasas authored
No new code, just shuffling things around so WebKit/Source/modules and content/browser have a more related structure, also in terms of bug components and OWNERS. BUG=none (no new code) Review-Url: https://codereview.chromium.org/2745583005 Cr-Commit-Position: refs/heads/master@{#456198}
-
ynovikov authored
BUG=700060 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2741853005 Cr-Commit-Position: refs/heads/master@{#456197}
-
emircan authored
chfremer@ has been very active on this area. Adding more active chrome devs would be beneficial while tommi@ stays as webrtc owner. https://paste.googleplex.com/4940035765829632 Review-Url: https://codereview.chromium.org/2739303004 Cr-Commit-Position: refs/heads/master@{#456196}
-
thakis authored
The ASan runtime recently changed to print slice information in stacks (https://reviews.llvm.org/D27390). The last clang roll included that change. The upstream asan_symbolize script was changed to be able to understand slice information in https://reviews.llvm.org/rL291280. We need to merge in that change to make symbolizing asan stacks work again on Mac. This roll brings in the following changes: https://reviews.llvm.org/rL294450 https://reviews.llvm.org/rL294303 https://reviews.llvm.org/rL291280 https://reviews.llvm.org/rL256578 https://reviews.llvm.org/rL251356 https://reviews.llvm.org/rL248962 https://reviews.llvm.org/rL247642 https://reviews.llvm.org/rL231492 BUG=686113,699062 Review-Url: https://codereview.chromium.org/2739213005 Cr-Commit-Position: refs/heads/master@{#456195}
-
thomasanderson authored
BUG=700117 TBR=boliu@chromium.org Review-Url: https://codereview.chromium.org/2748443003 Cr-Commit-Position: refs/heads/master@{#456194}
-
erg authored
- Drag now works again. - Ensure the nested run loop gets torn down on errors. - Adds logs of dvlogs for debugging when needed. - Moves registration of aura components to //ui/aura/. BUG=699235,665077 Review-Url: https://codereview.chromium.org/2739213003 Cr-Commit-Position: refs/heads/master@{#456193}
-
jonross authored
MojoTestConnection is responsible for creating the inter-process mojo pipes. These must be set on the command line for the child processes running individual test cases. It is also responsible for bringing up services. This however was being done at test enqueuing time. When the remote service was brought down at the end of the first test case, all registered services were having their pipes close. Thus preventing subsequent tests from connecting. This change moves the service registration until the child process is being connected. This actually occurs after the previous test has completed. mash.browser_tests.filter has also been updated to include more tests which are passing locally. This way we get expanded coverage on the bots. TEST=BrowserTests BUG=678687 Review-Url: https://codereview.chromium.org/2737353003 Cr-Commit-Position: refs/heads/master@{#456192}
-
ymzhang authored
We are adding COMPONENT/TEAM information into OWNERS file( signin, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=rogerta@chromium.org Review-Url: https://codereview.chromium.org/2740953005 Cr-Commit-Position: refs/heads/master@{#456191}
-
kkhorimoto authored
If a history navigation item occurs and the current NavigationItem is transient item, it will get discarded in CRWSessionController's |-discardTransientItem|. This CL updates history navigation logic to store copies of the current NavigationItem's information before calling any CRWSessionController code that might deallocate it. BUG=700319 Review-Url: https://codereview.chromium.org/2745653007 Cr-Commit-Position: refs/heads/master@{#456190}
-
qyearsley authored
BUG=697971 Review-Url: https://codereview.chromium.org/2745793005 Cr-Commit-Position: refs/heads/master@{#456189}
-
teravest authored
It looks like these get manually rolled. TESTED=none R=derat@chromium.org BUG= Review-Url: https://codereview.chromium.org/2743713004 Cr-Commit-Position: refs/heads/master@{#456188}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/5c1961dfa0b1..6791295a4e8c $ git log 5c1961dfa..6791295a4 --date=short --no-merges --format='%ad %ae %s' 2017-03-10 npm Normalize channels when transforming CMYK to RGB Created with: roll-dep src/third_party/pdfium BUG=699459 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2746613002 Cr-Commit-Position: refs/heads/master@{#456187}
-
hansberry authored
BUG=672263 Review-Url: https://codereview.chromium.org/2744803003 Cr-Commit-Position: refs/heads/master@{#456186}
-
estevenson authored
The docs still need to be updated with more detailed instructions and tips, but currently the docs don't even mention debugging in Android Studio. BUG=620034 Review-Url: https://codereview.chromium.org/2740353003 Cr-Commit-Position: refs/heads/master@{#456185}
-
tanvir.rizvi authored
EphemeralRange unit tests updated with better HTML and shadow-DOM attached explicitly. Previously few of the test cases introduced extra dependency on the UA shadow DOM under <input>, which was irrelevant to EphemeralRange. BUG=697989 Review-Url: https://codereview.chromium.org/2738203002 Cr-Commit-Position: refs/heads/master@{#456184}
-
bruthig authored
Darkening the shelf by 90% for the --ash-shelf-color experiment was too close to black. Changing to 70% will make the color more visible. TBR=sky@chromium.org BUG=595010 Review-Url: https://codereview.chromium.org/2742833006 Cr-Commit-Position: refs/heads/master@{#456183}
-
jokulik authored
move StopReading() from QuicSpdyStream to QuicSpdyServerStreamBase because this is server side feature. No behavior change. Merge internal change: 149180639 https://codereview.chromium.org/2746443003/ Remove PathCloseFrame, QuicPathId, DefaultPathId and InvalidPathId. Merge internal change: 149147915 https://codereview.chromium.org/2743883002/ Drop Packets with the multipath bit set before decryption. Protected by FLAGS_quic_reloadable_flag_quic_remove_multipath_bit. Merge internal change: 149034371 https://codereview.chromium.org/2739323002/ Introduce a new error code QUIC_HEADERS_STREAM_DATA_DECOMPRESS_FAILURE for invalid headers stream data due to decompression error. Not protected. Merge internal change: 148932025 https://codereview.chromium.org/2737273004/ No longer send or process the socket recieve buffer value in QUIC. Protected by FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer. Merge internal change: 148785639 https://codereview.chromium.org/2744663004/ Remove multipath_enabled from quic_config and quic_connection. No functional change expected. Also including clean up has_multipath_flag from test methods. Merge internal change: 148763093 https://codereview.chromium.org/2739313002/ Delete unused code from quic_framer_test.cc Merge internal change: 148657314 https://codereview.chromium.org/2737353005/ Remove static_assert for QuicTransmissionInfo size (portability fix for iOS 64-bit build) Merge internal change: 148495524 https://codereview.chromium.org/2739053004/ R=rch@chromium.org BUG= Review-Url: https://codereview.chromium.org/2747443002 Cr-Commit-Position: refs/heads/master@{#456182}
-
mathp authored
BUG=None TBR=sebsg@chromium.org Review-Url: https://codereview.chromium.org/2746543003 Cr-Commit-Position: refs/heads/master@{#456181}
-
samans authored
DelegatedFrameHost can no longer create a new local surface id on frame eviction. This would normally break a few things but after https://codereview.chromium.org/2736053004/ we should be good. I tried testing this CL by setting the maximum number of saved frames to 1 so that each new tab causes the eviction of the previous tab and compared the current behaviour vs behaviour after this CL and did not notice any difference. Without https://codereview.chromium.org/2736053004/ if you switch tabs fast enough DCHECKs will fail in SurfaceManager for allocating a surface using a surface id that is already in use, but that CL fixes this issue. TBR=jam@chromium.org BUG=697864 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2731793002 Cr-Commit-Position: refs/heads/master@{#456180}
-
msw authored
Merge ItemSelected and GetAppMenuItems mojo interface functions. (return app menu items with the action taken from selection handling) Remove the non-mojo ash::ShelfItemDelegate base class. Remove some unused mash pinning and reordering functionality. (it'll be fixed later, when mash and cash can use the same pattern) Replace ShelfApplicationMenuItem with the MenuItem mojo struct. Add ShelfAction and ShelfLaunchSource mojo enums and traits. BUG=557406 TEST=No Chrome OS shelf item (or app menu) behavior changes; automated. R=jamescook@chromium.org,tsepez@chromium.org Review-Url: https://codereview.chromium.org/2718563008 Cr-Commit-Position: refs/heads/master@{#456179}
-
dbeam authored
R=scottchen@chromium.org BUG=none (that I know of) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2743863002 Cr-Commit-Position: refs/heads/master@{#456178}
-
shend authored
ComputedStyle::operator== excludes some data members in the comparison, and it's not clear what members are compared and what are not. Ideally, the equality operator would be replaced with a named method that better describes which data members are compared. BUG=628043 Review-Url: https://codereview.chromium.org/2740953003 Cr-Commit-Position: refs/heads/master@{#456177}
-
wangxianzhu authored
Use LayoutObject::visualRect() instead. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2745793004 Cr-Commit-Position: refs/heads/master@{#456176}
-
huangs authored
This CL updates role and aria-* attributes to get screen readers to work. BUG=697142 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2742833002 Cr-Commit-Position: refs/heads/master@{#456175}
-
kozyatinskiy authored
With the experiment, we see the markers for a brief second before they are immediately removed without any user intervention. This CL fixes the race. BUG=chromium:695236 R=luoe@chromium.org,lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2742653003 Cr-Commit-Position: refs/heads/master@{#456174}
-
sebsg authored
BUG=699256 Review-Url: https://codereview.chromium.org/2740633002 Cr-Commit-Position: refs/heads/master@{#456173}
-
paulirish authored
BUG=608869 Review-Url: https://codereview.chromium.org/2717543002 Cr-Commit-Position: refs/heads/master@{#456172}
-
lgrey authored
BUG=700327 Review-Url: https://codereview.chromium.org/2743803003 Cr-Commit-Position: refs/heads/master@{#456171}
-
caseq authored
BUG= Review-Url: https://codereview.chromium.org/2740223002 Cr-Commit-Position: refs/heads/master@{#456170}
-
hiroshige authored
This CL removes FetchRequest::mutableResourceRequest() calls that are used to modify ResourceRequest created just before, i.e. replaces: FetchRequest request(ResourceRequest(foo), bar); request.mutableResourceRequest().baz(); with: ResourceRequest resourceRequest(foo); resourceRequest.baz(); FetchRequest request(resourceRequest, bar); To clarify what kind of modifications to ResourceRequest via mutableResourceRequest() is needed (https://crbug.com/632580#c8). BUG=632580 Review-Url: https://codereview.chromium.org/2740253002 Cr-Commit-Position: refs/heads/master@{#456169}
-
ymzhang authored
We are adding COMPONENT/TEAM information into OWNERS file (UI>ProximityAuth related, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=tengs@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2743073002 Cr-Commit-Position: refs/heads/master@{#456168}
-
jrummell authored
The code in ParsedContentType is based on RFC2045, which does not mention what should happen if the same parameter name is mentioned multiple times. However, RFC6838 (Media Type Specifications and Registration Procedures), which defines the MIME types for media and is based on RFC2045/2046, has the following statement: It is an error for a specific parameter to be specified more than once. Add an option to have ParsedContentType fail if the same parameter is specified multiple times. navigator.requestMediaKeySystemAccess() is updated to reject MIME types that mention the same parameter name more than once. BUG=698436 TEST=new tests pass Review-Url: https://codereview.chromium.org/2736283002 Cr-Commit-Position: refs/heads/master@{#456167}
-
bmcquade authored
This is required for the existing subresource filtering and css scanning page load metrics, as well as for the upcoming metrics for pages where media is played. In the render process: * move policy decision about whether to process timing or metadata updates from blink to chrome/renderer/page_load_metrics code * instantiate MetricsRenderFrameObservers for child frames * track metadata updates for child frames * send at most one update per second per frame over IPC to the browser process (this is the existing page load metrics IPC policy) In the browser process: * track child frame loading behavior flags * notify observers whenever the loading behavior flags for a child frame are updated In the SubresourceFilterMetricsObserver: * consider the page to have filtered subresources if subresource filter loading behavior is observed in either the main frame or child frames Note that we still do not track timing updates for child frames. This change gets us closer to being able to do so, but given that there is no current need, we don't do this for the time being. BUG=699849 Review-Url: https://codereview.chromium.org/2737563007 Cr-Commit-Position: refs/heads/master@{#456166}
-
bnc authored
Fix SpdySessionPool::FindAvailableSession() to log the correct NetLog event type and the correct Net.SpdySessionGet histogram value when pooling to an existing HTTP/2 connection by IP address every time, not only the first time. BUG=700451 Review-Url: https://codereview.chromium.org/2739183005 Cr-Commit-Position: refs/heads/master@{#456165}
-
klausw authored
Revert of Re-land WebVR compositor bypass via BrowserMain context + mailbox (patchset #37 id:710001 of https://codereview.chromium.org/2729523002/ ) Reason for revert: Layout tests still failing for mac and windows despite passing on the trybots. Example: https://build.chromium.org/p/chromium.webkit/buildstatus?builder=WebKit%20Mac10.9&number=43627 Original issue's description: > Re-land WebVR compositor bypass via BrowserMain context + mailbox > > Implement compositor bypass for WebVR via mailbox copy: > > - Create a GPU command buffer GL context in the VrShellGl thread that's > backed by a native Surface. This is encapsulated inside the new > MailboxToSurfaceBridge class. > > - WebKit's VRDisplay sends a MailboxHolder for each frame (as drawn > via WebGL on the GPU process) as argument to the SubmitFrame mojo > call. > > - MailboxToSurfaceLayerBridge uses its GPU command buffer GL context > to draw the mailbox content to a Surface. > > - VrShellGl picks up the frame from the corresponding SurfaceTexture > and proceeds with rendering as usual with its native GL context > as needed for the low-level GVR API. > > Also implements on-the-fly canvas resizing, the transfer surface and > GVR renderbuffer are resized as needed to match the source canvas. > > Added frame number as an argument to various TRACE_EVENTs for timing > analysis. > > It includes two separate modes for frame scheduling, the more > aggressive one is conditional on > chrome:://flags#enable-webvr-experimental-rendering since the > framerate seems a bit less stable. > > BUG=698643 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2729523002 > Cr-Original-Commit-Position: refs/heads/master@{#455592} > Committed: https://chromium.googlesource.com/chromium/src/+/6280ec5b6e3b4c307926eb1bf0167acc2a0d4a74 > Review-Url: https://codereview.chromium.org/2729523002 > Cr-Commit-Position: refs/heads/master@{#456130} > Committed: https://chromium.googlesource.com/chromium/src/+/9f86464794416e81abfe5921e9fac892716c610b TBR=mthiesse@chromium.org,bajones@chromium.org,khushalsagar@chromium.org,dcheng@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=698643 Review-Url: https://codereview.chromium.org/2742083002 Cr-Commit-Position: refs/heads/master@{#456164}
-
ssid authored
The CL implements peak detection in memory dump scheduler. More discussion at https://goo.gl/0kOU4A. BUG=607533 Review-Url: https://codereview.chromium.org/2737153002 Cr-Commit-Position: refs/heads/master@{#456163}
-
lushnikov authored
This patch fixes a bug in the TabbedEditorContainer's handler for persistence binding. As the binding comes in, we should retain selected tab no matter what. R=dgozman Review-Url: https://codereview.chromium.org/2740053002 Cr-Commit-Position: refs/heads/master@{#456162}
-