- 09 Mar, 2015 40 commits
-
-
dnicoara authored
Make all the LOGs that follow DRM calls PLOGs since we're interested in the error message. Also add a few more LOGs during device probing just in case we end up in odd states where the DRM device is controlled by another process and we're trying to take ownership. BUG=none Review URL: https://codereview.chromium.org/991963002 Cr-Commit-Position: refs/heads/master@{#319716}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/86e31a1..d2737ad CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=mtklein@google.com Review URL: https://codereview.chromium.org/995473002 Cr-Commit-Position: refs/heads/master@{#319715}
-
fsamuel authored
BUG=442033 TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/990253003 Cr-Commit-Position: refs/heads/master@{#319714}
-
jdduke authored
Revert of [Android] Fix a flicker in stopping Chrome (patchset #11 id:200001 of https://codereview.chromium.org/843883002/) Reason for revert: Caused regression with lockscreen battery consumption. Original issue's description: > [Android] Fix a flicker in stopping Chrome > > Currently, we draw a blank frame as we release resources in onStop(). > This can be prevented if we hide the tab when the window gets hidden instead of > on activity stop. > > BUG=434401 > > Committed: https://crrev.com/e4b1990c9d49fd9734940fa863513ad43b82c6e7 > Cr-Commit-Position: refs/heads/master@{#311809} TBR=tedchoc@chromium.org,dtrainor@chromium.org,yusufo@chromium.org,aelias@chromium.org,sievers@chromium.org,changwan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=434401 Review URL: https://codereview.chromium.org/990183004 Cr-Commit-Position: refs/heads/master@{#319713}
-
sergeyu authored
Now XMPP is implemented directly in remoting/signaling instead of relying on WebRTC. The new code is mostly just a translation of the XMPP implementation we use in the webapp from JavaScript to C++ and uses the same layout and class names, except that the main class is called XmppSignalStrategy instead of XmppConnection. BUG=459756, 443806, 417336 Review URL: https://codereview.chromium.org/958703003 Cr-Commit-Position: refs/heads/master@{#319712}
-
agoode authored
Review URL: https://codereview.chromium.org/989913002 Cr-Commit-Position: refs/heads/master@{#319711}
-
jlklein authored
BUG= Review URL: https://codereview.chromium.org/989673002 Cr-Commit-Position: refs/heads/master@{#319710}
-
rvargas authored
The request and response headers can change between the original request and the requets that receives 304. Make sure the state of the cached entry reflects the latest headers. BUG=453306 TEST=net_unittests Review URL: https://codereview.chromium.org/976373005 Cr-Commit-Position: refs/heads/master@{#319709}
-
rtenneti authored
R=rch@chromium.org Review URL: https://codereview.chromium.org/985383003 Cr-Commit-Position: refs/heads/master@{#319708}
-
k.czech authored
Blink's CL exposes aria row and column headers. BUG=451047 Review URL: https://codereview.chromium.org/955373002 Cr-Commit-Position: refs/heads/master@{#319707}
-
stuartmorgan authored
Upstreams miscellaneous helper classes and utility files that don't have other dependencies, and can thus be built and tested as-is. BUG=464810 Review URL: https://codereview.chromium.org/988383002 Cr-Commit-Position: refs/heads/master@{#319706}
-
jamiewalch authored
This provides a central location for application-specific cleanup code and also allows the "no error message on cancel" logic to be made application-agnostic. Review URL: https://codereview.chromium.org/988963003 Cr-Commit-Position: refs/heads/master@{#319705}
-
xhwang authored
The observer is running on another pipe which could cause race conditions and make the implementation unnecessarily complex. This CL drops the observer and merges the config update into the main mojo::DemuxerStream interface. BUG=460154 TEST=No DCHECK fires and playback works. mojo:media_test passes. Review URL: https://codereview.chromium.org/981423002 Cr-Commit-Position: refs/heads/master@{#319704}
-
newt authored
Android lint complains when we use APIs added to Android after ICS because these will causes crashes if used on ICS devices. In cases where we only call the API on later versions of Android, we need to annotate the method or class with @TargetApi to tell Android lint that each particular use of the new API is safe. This adds a bunch of such @TargetApi annotations. BUG=266140 Review URL: https://codereview.chromium.org/969883002 Cr-Commit-Position: refs/heads/master@{#319703}
-
spang authored
Review URL: https://codereview.chromium.org/991783005 Cr-Commit-Position: refs/heads/master@{#319702}
-
paulmeyer authored
The chrome-specific web_view event code was not fully updated during the guest_view_events refactor, resulting in the one chrome-specific event, 'contextmenu', not working properly. This patch updates that code. BUG=465194 Review URL: https://codereview.chromium.org/989173005 Cr-Commit-Position: refs/heads/master@{#319701}
-
michaelbai authored
Make it to use base::android::OnJNIOnLoad interface. BUG=447393 Review URL: https://codereview.chromium.org/984163002 Cr-Commit-Position: refs/heads/master@{#319700}
-
spang authored
Same as previous fix, but for mouse buttons. The SYN_DROPPED part is N/A because that is handled by libevdev. BUG=463002 TEST=Tested unplug by unplugging mouse with left button held. Left mouse button gets properly released rather than being stuck. (NB: Could not reproduce without adding a delay to expose the race). Review URL: https://codereview.chromium.org/983213003 Cr-Commit-Position: refs/heads/master@{#319699}
-
mariakhomenko authored
Adds the ability to extract which applications can handle a particular intent. BUG=464934 Review URL: https://codereview.chromium.org/988963004 Cr-Commit-Position: refs/heads/master@{#319698}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/13e51f9..86e31a1 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=mtklein@google.com Review URL: https://codereview.chromium.org/994643002 Cr-Commit-Position: refs/heads/master@{#319697}
-
erikchen authored
Revert of Re-enable the new SQLitePersistentCookieStore load strategy. (patchset #1 id:1 of https://codereview.chromium.org/953993002/) Reason for revert: This CL causes hangs during shutdown. https://code.google.com/p/chromium/issues/detail?id=465271 Original issue's description: > Re-enable the new SQLitePersistentCookieStore load strategy. > > When I first turned on the new load strategy, it caused deadlocks during > shutdown. I found and fixed the bug in SequencedWorkerPool. > > BUG=448910 > > Committed: https://crrev.com/043d6b497dda7a39138eca1fb9df89ee340e543b > Cr-Commit-Position: refs/heads/master@{#318305} TBR=erikwright@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=448910 Review URL: https://codereview.chromium.org/992723002 Cr-Commit-Position: refs/heads/master@{#319696}
-
Sadrul Habib Chowdhury authored
Chrome Apps (e.g. hangouts etc.) can set a custom shape for the windows. Make sure the shape is translated correctly in hidpi environment. BUG=461120 R=pkotwicz@chromium.org Review URL: https://codereview.chromium.org/985993002 Cr-Commit-Position: refs/heads/master@{#319695}
-
pfeldman authored
BUG=463892 Review URL: https://codereview.chromium.org/988003002 Cr-Commit-Position: refs/heads/master@{#319694}
-
danakj authored
R=Nico BUG=464816 Review URL: https://codereview.chromium.org/983223004 Cr-Commit-Position: refs/heads/master@{#319693}
-
fsamuel authored
autosize is no longer used in <extensionoptions> and it adds a lot of complexity. I eventually want <extensionview> and <extensionoptions> to merge to reduce maintenance overhead, especially on the <webview>/GuestView team. This dead code makes it harder to reach that objective. BUG=442033 Review URL: https://codereview.chromium.org/990223002 Cr-Commit-Position: refs/heads/master@{#319692}
-
noms authored
BUG=462246 TEST=Start Chrome with --enable-new-avatar-menu and a single, local profile. Sign in. The avatar button should correctly update and display the synced name. Review URL: https://codereview.chromium.org/974373002 Cr-Commit-Position: refs/heads/master@{#319691}
-
creis authored
We were putting the wrong FrameTreeNode ID on the OpenURLParams when a navigation was destined for a different WebContents. BUG=464944 TEST=Shift click a link to https://chrome.google.com/webstore in --site-per-process mode. Review URL: https://codereview.chromium.org/988953003 Cr-Commit-Position: refs/heads/master@{#319690}
-
tommycli authored
The objective of the patch is that the poster attribute for plugins can support high-dpi images via the img srcset syntax, i.e. <param name="poster" value="poster1x.png 1x, poster2x.png 2x" /> BUG=457333 Review URL: https://codereview.chromium.org/981623003 Cr-Commit-Position: refs/heads/master@{#319689}
-
kalman authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/983793003 Cr-Commit-Position: refs/heads/master@{#319688}
-
estade authored
Also fix position of bubble for requestAutocomplete dialog. BUG=464640 Review URL: https://codereview.chromium.org/981293003 Cr-Commit-Position: refs/heads/master@{#319687}
-
meacer authored
The last committed URL check isn't sufficient in certain scenarios. This CL ensures that login interstitials always replace any existing interstitial. BUG=458972 Review URL: https://codereview.chromium.org/938713003 Cr-Commit-Position: refs/heads/master@{#319686}
-
twellington authored
Revert "Revert of Output closure-compiled JavaScript files (patchset #10 id:180001 of https://codereview.chromium.org/958383003/)" This reverts commit 30fc31d1. Missed a renaming a reference to run_js_check Original issue's description: > Output closure-compiled JavaScript files > > If generate_output is set, chcker.py adds compiler flags to actually > output the compiled JS. It will also output a source map if the build > is Debug. > BUG=393874 Review URL: https://codereview.chromium.org/990983002 Cr-Commit-Position: refs/heads/master@{#319685}
-
bnc authored
Fix off-by-one in SpdyFramer::GetNumberRequiredContinuationFrames(). BUG=464748 Review URL: https://codereview.chromium.org/989283002 Cr-Commit-Position: refs/heads/master@{#319684}
-
mdempsky authored
This makes it easier to run verification within bpf_dsl_unittests too, though it also exposes that FakeTrapRegistry was being sloppy by not reusing trap IDs when a trap handler is assigned a second time. BUG=449357 Review URL: https://codereview.chromium.org/935743003 Cr-Commit-Position: refs/heads/master@{#319683}
-
dtapuska authored
Add a dbus implementation for the wifi ap manager. ap_manager is a ChromeOS service that manages the hostapd instance; this is a dbus binding that the ChromeOS service. BUG=463194 Review URL: https://codereview.chromium.org/980973003 Cr-Commit-Position: refs/heads/master@{#319682}
-
kundaji authored
When user saves an image, add headers requesting a pass through from the data reduction proxy. Without this, images will be saved in webp format which is not supported by most image viewers. BUG=464436 Review URL: https://codereview.chromium.org/988453002 Cr-Commit-Position: refs/heads/master@{#319681}
-
bnc authored
Introduce struct AlternativeService and use it in BrokenAlternateProtol{List,Map} instead of BrokenAlternateProtocolEntry. This is the first step towards making an alternative service broken not with respect to an origin, but by itself. BUG=392576 Review URL: https://codereview.chromium.org/987813002 Cr-Commit-Position: refs/heads/master@{#319680} -
andresantoso authored
The typedefs in native_web_contents_modal_dialog.h are no longer needed after http://crrev.com/866263008. This change removes them, as discussed in that CL. Review URL: https://codereview.chromium.org/985133002 Cr-Commit-Position: refs/heads/master@{#319679}
-
rdevlin.cronin authored
Right now, there's a chance that the NSMenu can outlive the underlying menu model (which is owned by the view controller). Make sure we reset the context menu before destruction and before creating a new menu to correct this. BUG=462175 Review URL: https://codereview.chromium.org/967883006 Cr-Commit-Position: refs/heads/master@{#319678}
-
bnc authored
Revert of [Fallback icons] Change "explicit flow" interface so color hex strings don't use "#". (patchset #4 id:60001 of https://codereview.chromium.org/988863002/) Reason for revert: This seems to be causing FallbackIconUrlParserTest unit_tests to fail, see, for example, https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/7625 https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/7297 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/39924 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/10797 Original issue's description: > [Fallback icons] Change "explicit flow" interface so color hex strings don't use "#". > > Design: go/chrome-fallback-icons > > Fallback icon "explicit flow" URL used to have '#' in hex colors, e.g.: > > chrome://fallback-icon/,#01f,#123456,,/http://www.google.com > > Problem: "#" denotes fragment in URLs, so we get rid of it. This causes no ambiguity > with named color (e.g., "red") because no named color consists of letters a-f only. > Also adding "ARGB" hex color since this is supported in Skia color parsing. > > BUG=455063 > > Committed: https://crrev.com/8fa91aabefbe9784eca0c169bc2ad2dd92f5d887 > Cr-Commit-Position: refs/heads/master@{#319630} TBR=jhawkins@chromium.org,huangs@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455063 Review URL: https://codereview.chromium.org/989133003 Cr-Commit-Position: refs/heads/master@{#319677}
-