GitLab

NOTRY=true
BUG=357566

Review URL: https://codereview.chromium.org/216773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=348616

Review URL: https://codereview.chromium.org/214983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260211 0039d316-1c4b-4281-b951-d872f2087c98

A follow up to https://codereview.chromium.org/214543009 where boliu@ noticed
that we are using getInstrumentation().getTargetContext() in AwSettingsTest
instead of simply getting the context of the container view.

This change required some overhaul of testing classes as they didn't have access
to the container view.

Review URL: https://codereview.chromium.org/216823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260210 0039d316-1c4b-4281-b951-d872f2087c98

The browser test is showing Mac ASAN failures.

> Handling LevelDB errors encountered after open.
>
> The previous IndexedDB implementation only checked for (and reported)
> corrupted LevelDB's during open. If they are determined to be corrupted
> during use then the database was simply closed. The page would be unaware of
> this, and would likely reopen the database at a later time (which would work)
> only to fail again during a read/write operation. There was no way for the
> page to get out of that corrupted state - the user would have to delete all
> origin data.
>
> This change will record the fact that the backing store was corrupted, and
> during open this would be read and, if present, result in the same dataLoss
> state being reported to the page in the upgradeneeded event.
>
> Also split IndexedDBBackingStore's REPORT_ERROR macro in two:
> REPORT_ERROR_UNTESTED (which calls NOTREACHED) and REPORT_ERROR. REPORT_ERROR
> is used for errors which are encountered during tests. This was done so that
> runtime errors could still be caught during a debug build run.
>
> BUG=322707
> R=isherman@chromium.org, jochen@chromium.org, jsbell@chromium.org
>
> Review URL: https://codereview.chromium.org/197333009
>
> Patch from Christopher Mumford <cmumford@chromium.org>.

TBR=jsbell@chromium.org

Review URL: https://codereview.chromium.org/216433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260209 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357559
TEST=manual
R=dzhioev@chromium.org

Review URL: https://codereview.chromium.org/216473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260208 0039d316-1c4b-4281-b951-d872f2087c98

Make a new class, ExtensionGarbageCollector, which performs:
- ExtensionService::GarbageCollectExtensions(),
- extension_file_util::GarbageCollectExtensions() (the file-thread impl of
  ExtensionService::GarbageCollectExtensions()),
- ExtensionService::GarbageCollectIsolatedStorage()

BUG=351891
TBR=rkc@chromium.org (for c/b/chromeos/kiosk_mode - no functional changes, but the TODO has moved from ExtensionService to ExtensionGarbageCollector).

Review URL: https://codereview.chromium.org/204983020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260207 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260205 0039d316-1c4b-4281-b951-d872f2087c98

This is just intended to reduce some code duplication and allow increased velocity on altering the SkCanvas API

Review URL: https://codereview.chromium.org/199043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260204 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=170229:170313&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/216433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353127
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/214413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260202 0039d316-1c4b-4281-b951-d872f2087c98

On machines with slow I/O, the localserver might not shut down immediately,
wait for it if necessary.

BUG=

Review URL: https://codereview.chromium.org/145873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260201 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260200 0039d316-1c4b-4281-b951-d872f2087c98

R=mallinath@chromium.org

Review URL: https://codereview.chromium.org/215133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357621
TEST=manually tested

R=hirono@chromium.org
TBR=arv@chromium.org
# TBRing for adding a resource.

Review URL: https://codereview.chromium.org/209853011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260198 0039d316-1c4b-4281-b951-d872f2087c98

This is a pre-requirement to remove webkitCreateShadowRoot in blink.
The patch on the blink side is here: https://codereview.chromium.org/208503004/.

BUG=336121

Review URL: https://codereview.chromium.org/214093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260197 0039d316-1c4b-4281-b951-d872f2087c98

[Hotword] Make ConfirmDialog subclass from SettingsDialog so that any preferences set in the ConfirmDialog will update.

BUG=345811

Review URL: https://codereview.chromium.org/215423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260196 0039d316-1c4b-4281-b951-d872f2087c98

Helper extension then notifies chrome and tells the extension to turn on/off.

BUG=345811

Review URL: https://codereview.chromium.org/212253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260195 0039d316-1c4b-4281-b951-d872f2087c98

No changes in behavior except a DCHECK will fail in BindTexImage
instead of returning false when egl_image_ is EGL_NO_IMAGE_KHR.
This is more appropritate as only a bug in the implementation of
GLImageEGL can cause this to happen.

BUG=356871
TBR=sky

Review URL: https://codereview.chromium.org/212933009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260194 0039d316-1c4b-4281-b951-d872f2087c98

Caused a heap-use-after-free in GLES2DecoderManualInitTest.AsyncPixelTransfers
on Linux ASan+LSan Tests (1):
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%281%29/builds/863


> By keeping track of transfer buffer usage (both sync and async), it is
> possible to reuse an existing transfer buffer earlier than it is today.
> 
> For synchronous uploads, this is done by inserting tokens marking a
> buffer's last usage. If such a token has passed, the buffer can be
> reused.
> 
> For asynchronous uploads, this is done by adding an internal async
> upload token to the GLES2Implementation and GLES2CmdDecoderImpl that
> enumerates all asynchronous uploads. When an upload is completed, the
> token is synchronized with the client which then can free the memory
> associated with the async token.
> 
> The fenced allocator and mapped memory manager gets a callback that is
> used to allow fenced allocator to make the user, in this case
> GLES2Implementation, poll the current async upload token and free any
> associated memory.
> 
> BUG=328808
> 
> Review URL: https://codereview.chromium.org/116863003

TBR=jadahl@opera.com

Review URL: https://codereview.chromium.org/216673006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260193 0039d316-1c4b-4281-b951-d872f2087c98

KioskTest.LaunchAppWithNetworkConfigAccelerator

TBR=zelidrag@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=350056

Review URL: https://codereview.chromium.org/217053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260192 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260191 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following changes:

r111 Implementation of the woff2 format changes proposed by the W3C working group.
r112 Remove unused kShortFlagsContinue.

TBR=yusukes@chromium.org
BUG=

Review URL: https://codereview.chromium.org/216203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260190 0039d316-1c4b-4281-b951-d872f2087c98

The cursor is invisible unless set explicitly, so set a bitmap from
CursorFactoryEvdevDri upon construction.

Configuration of the cursor plane must be delayed until we've configured
the hardware, so store the bitmap on DriSurfaceFactory and set it in
RealizeAcceleratedWidget.

TEST=content_shell --ozone-platform=dri
BUG=252315

Review URL: https://codereview.chromium.org/208553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260189 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357024

Review URL: https://codereview.chromium.org/217023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260188 0039d316-1c4b-4281-b951-d872f2087c98

The ordering has recently changed and some alternate shelf layout got not corrected.

BUG=346678
TEST=visual testing
R=flackr@chromium.org

Review URL: https://codereview.chromium.org/215693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260187 0039d316-1c4b-4281-b951-d872f2087c98

This code bit was missed when re-factoring in: https://codereview.chromium.org/196403008/

TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/216553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260186 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/212623012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260185 0039d316-1c4b-4281-b951-d872f2087c98

This change does not fix the bug, just a preparation for the actual fix.
No behavior change is intended.

Return cancel closure from DownloadOperation and FileSystem.
Change user code (SyncClient and DriveFileStreamReader) to use the returned closure.

BUG=344789
TEST=unit_tests

Review URL: https://codereview.chromium.org/214363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260184 0039d316-1c4b-4281-b951-d872f2087c98

should_content_update may be false for new files if it's opend.

BUG=353680
TEST=unit_tests

Review URL: https://codereview.chromium.org/216333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260183 0039d316-1c4b-4281-b951-d872f2087c98

To implement FakeDriveService without GData WAPI classes.

BUG=334544
TEST=unit_tests

Review URL: https://codereview.chromium.org/216433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260182 0039d316-1c4b-4281-b951-d872f2087c98

sky is about to check something in that will interact poorly with this
and it'll be easier to apply the necessary changes after that.

> Fixup mojo dylibs to support mojo in content
> 
> Second try after revert of
> https://codereview.chromium.org/211503005/
> 
> The isolates failed because libmojo_system.dylib wasn't getting copied.
> 
> BUG=
> TBR=mark@chromium.org
> 
> Review URL: https://codereview.chromium.org/217003003

TBR=davemoore@chromium.org

Review URL: https://codereview.chromium.org/216793008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260181 0039d316-1c4b-4281-b951-d872f2087c98

Adds expectations for video resolution output on all tests that use peerconnection-call.html call.

BUG= 350538

Review URL: https://codereview.chromium.org/214663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357190

Review URL: https://codereview.chromium.org/212173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260178 0039d316-1c4b-4281-b951-d872f2087c98

possible to reuse an existing transfer buffer earlier than it is today.

For synchronous uploads, this is done by inserting tokens marking a
buffer's last usage. If such a token has passed, the buffer can be
reused.

For asynchronous uploads, this is done by adding an internal async
upload token to the GLES2Implementation and GLES2CmdDecoderImpl that
enumerates all asynchronous uploads. When an upload is completed, the
token is synchronized with the client which then can free the memory
associated with the async token.

The fenced allocator and mapped memory manager gets a callback that is
used to allow fenced allocator to make the user, in this case
GLES2Implementation, poll the current async upload token and free any
associated memory.

BUG=328808

Review URL: https://codereview.chromium.org/116863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260177 0039d316-1c4b-4281-b951-d872f2087c98

This is bringing Aura in line with the existing GTK behaviour. Windows
with a coloured frame still have the Windows 8 look.

App windows on Linux now always use AppWindowFrameView instead of the
blue CustomFrameView.

BUG=322256

Review URL: https://codereview.chromium.org/210363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260176 0039d316-1c4b-4281-b951-d872f2087c98

Second try after revert of
https://codereview.chromium.org/211503005/

The isolates failed because libmojo_system.dylib wasn't getting copied.

BUG=
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/217003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260175 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353067
TBR=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/217213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260174 0039d316-1c4b-4281-b951-d872f2087c98

This change makes it so hitting the Esc while the omnibox has focus shows the URL unless search term replacement is being performed, in which case we revert to the original search terms.

This holds for both the hide-on-mouse-release and hide-on-input options.  For the latter, this means that a click in the omnibox will also hide the origin chip.  This supports the case where the user is trying to get at the URL and forgets to click on the origin chip or misses it due to existing muscle memory.  In this case, an Esc will show the URL as users are accustomed to.

In no case will hitting Esc cause the origin chip to reappear.

BUG=349497

Review URL: https://codereview.chromium.org/214613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260173 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/213243002/ had an error where we log the
new metrics to the wrong bucket. This should fix that.

BUG=352266, 357162
TBR=tommi@chromium.org
NOTRY=True (ios_debug broken and tripping up CQ)

Review URL: https://codereview.chromium.org/216683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260172 0039d316-1c4b-4281-b951-d872f2087c98

Separate pre-classification checks for client-side malware and phishing detection and enable the client-side malware
feature in all channels (not just dev and canary).

BUG=352782

Review URL: https://codereview.chromium.org/173133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260171 0039d316-1c4b-4281-b951-d872f2087c98