GitLab

Bug 19757 discusses how we block the UI thread on the core thread when shutting
down sync. Until that is fixed, we have to fess up to the Thread police.

BUG=69570,19757
TEST=Start syncing in debug build.  Stop sync.  Don't crash.

Review URL: http://codereview.chromium.org/6328001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71361 0039d316-1c4b-4281-b951-d872f2087c98

This adds a "killed tab" page to be displayed in the case where a tab is killed instead of crashing.

It also adds "about:kill" to simulate kills.

On ChromeOS killed tabs will be reloaded as soon as the user clicks on them unless they are the only tab, or the currently focused tab is killed.

BUG=http://crosbug.com/10043, http://crosbug.com/10711
TEST=Built linux and ChromeOS Chrome and killed a tab, and then did about:crash and made sure that the "Aw, Snap!" page was displayed. Did about:kill and made sure kill page was displayed.

Review URL: http://codereview.chromium.org/6053012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71360 0039d316-1c4b-4281-b951-d872f2087c98

TEST=try
BUG=none

Review URL: http://codereview.chromium.org/6189008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71359 0039d316-1c4b-4281-b951-d872f2087c98

BUG=touchbot fails
(http://build.chromium.org/p/chromium.fyi/waterfall?branch=&builder=Chromium+Linux+Touch&builder=Chromium+Linux+Touch+%28dbg%29)
TEST=touchbot works

Review URL: http://codereview.chromium.org/6317002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71358 0039d316-1c4b-4281-b951-d872f2087c98

The sync server supports a new "progress token" scheme that allows data types to be requested with a different timestamp per datatype.  The benefits of this approach are:
 - timestamps become opaque to the client, which makes
 - the client no longer has to rely on timestamps converging for all datatypes.
 - the server will send fewer redundant updates after enabling a new datatype.
 - the flexibility of the opaque field allows the server to implement other optimizations which will increase scalability & performance

BUG=58217
TEST=manual test of sync (old profile+new profile), unit tests, integ tests

Review URL: http://codereview.chromium.org/6104003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71357 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69440
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71354 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jschuh
Review URL: http://codereview.chromium.org/6325001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71353 0039d316-1c4b-4281-b951-d872f2087c98

I'm going to be updating the underlying class (in WebKit) and don't want these
functions to be siliently disconnected in the event that the WebKit merge
doesn't work exactly as planned.

BUG=none
TEST=compile

http://codereview.chromium.org/6320001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71352 0039d316-1c4b-4281-b951-d872f2087c98

We can't alter the envionment once we have gone multithreaded because
glibc's getenv doesn't take the environment lock. Thus we add an
EarlyNSSInit() function which can do so, early in startup.

BUG=66835
TEST=ThreadSanitizer

http://codereview.chromium.org/6185005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71351 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71350 0039d316-1c4b-4281-b951-d872f2087c98

(Note that this code was developed by try-server so if something appears
to be terribly wrong, it probably is.)

BUG=none
TEST=net_unittests

http://codereview.chromium.org/6180001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71349 0039d316-1c4b-4281-b951-d872f2087c98

BUG=touchy clicks don't work
TEST=touchy clicks work

Review URL: http://codereview.chromium.org/6175006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71348 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61012
TEST=Covered by existing media tests.

Review URL: http://codereview.chromium.org/6179006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71347 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=open cert manager, try to import non-existent file / etc

Review URL: http://codereview.chromium.org/6277001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71346 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/5967003/
and is no longer flaky as of Friday, Jan 7.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=NamedInterfaceTest&testType=ui_tests

BUG=66414
TEST=none

Review URL: http://codereview.chromium.org/6224004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71345 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots

Review URL: http://codereview.chromium.org/6254001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71341 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=run chrome, install app with background page, see new art on wrench menu

Review URL: http://codereview.chromium.org/6252002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71339 0039d316-1c4b-4281-b951-d872f2087c98

Now that the sync integration tests are designed to be self-contained
and not rely on external network resources like GAIA, we need to ensure
that background network access for things like auto update is disabled.

This patch adds the --disable-background-networking command line switch
to the sync integration test framework.

BUG=69469, 53931
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/6282001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71338 0039d316-1c4b-4281-b951-d872f2087c98

We typically add all known workers when Initializing the SyncBackendHost,
but this one is causing crashes and isn't used by default.

BUG=53916,69561
TEST=none

Review URL: http://codereview.chromium.org/6111012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71337 0039d316-1c4b-4281-b951-d872f2087c98

during closing a window with unload handlers if a tab is disconnected then
we delay cleanup by way of PostTask with the tab being
disconnected. During the time between when the disconnect happens and
the task is run the unloader handler sets still maintain a reference
to the tab. If ProcessPendingTabs is invoked during this window and
the tab is deleted, then we can crash.

I'm fixing it by making disconnect remove from the sets immediately,
but delay the call to ProcessPendingTabs. I'm also doing a similar
thing in TabDetachedAt.

BUG=15620
TEST=none

Review URL: http://codereview.chromium.org/6203006

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/6318001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71336 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6262003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71335 0039d316-1c4b-4281-b951-d872f2087c98

Add some tests (for aborting calls).

BUG=none
TEST=ppapi_tests

Review URL: http://codereview.chromium.org/6220006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71334 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Remove SetAppearsAsDefault() since it is no longer called externally.  Inline its functionality into the lone internal caller.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6133011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71333 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68797
TEST=previous buildbots test old path, new buildbots will test the GPU path

Support for webkit side changes:
https://bugs.webkit.org/show_bug.cgi?id=52333

Review URL: http://codereview.chromium.org/6258001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71332 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71331 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/6246001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71330 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/6255001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71328 0039d316-1c4b-4281-b951-d872f2087c98

during closing a window with unload handlers if a tab is disconnected then
we delay cleanup by way of PostTask with the tab being
disconnected. During the time between when the disconnect happens and
the task is run the unloader handler sets still maintain a reference
to the tab. If ProcessPendingTabs is invoked during this window and
the tab is deleted, then we can crash.

I'm fixing it by making disconnect remove from the sets immediately,
but delay the call to ProcessPendingTabs. I'm also doing a similar
thing in TabDetachedAt.

BUG=15620
TEST=none

Review URL: http://codereview.chromium.org/6203006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71327 0039d316-1c4b-4281-b951-d872f2087c98

There are more gcc 4.5 issues to be solved so GYP_DEFINES=='werror='
is still required to build with 4.5 even with these changes.

BUG=66652
TEST=compiles with gcc 4.5 and trybots

Review URL: http://codereview.chromium.org/6186008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=56340
TEST=Click on a browser action to open it. Click on the button again to close it. Click on it a third time to open, and it should open as expected.

Review URL: http://codereview.chromium.org/6195004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71324 0039d316-1c4b-4281-b951-d872f2087c98

This patch is a cleanup of existing Tab code, as per the review comments of 5572007 Patch Set 2.  Some of the comments from that review apply to pre-existing code, and so I separated out those changes into their own CL (this one).

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6080002
Patch from Chad Faragher <wyck@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=all targets build, tests pass.

Review URL: http://codereview.chromium.org/6042009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71322 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6303001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71321 0039d316-1c4b-4281-b951-d872f2087c98

if locale was changed (as a result of sync or because user preference differs from login locale): show notification.

BUG=chromium-os:9164
TEST=Manual

Review URL: http://codereview.chromium.org/5976005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71320 0039d316-1c4b-4281-b951-d872f2087c98

The PrerenderResourceHandler is being used instead.

BUG=61745
TEST=trybots

Review URL: http://codereview.chromium.org/6111010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6191001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71318 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69258
TEST=None

Review URL: http://codereview.chromium.org/6196004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71317 0039d316-1c4b-4281-b951-d872f2087c98

Also fix bug 69054 (reg_writer erroneously outputs integers as decimal values).

BUG=68843, 69054
TEST=tools/grit/grit/format/policy_templates/*_unittest.py

Review URL: http://codereview.chromium.org/6176005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71316 0039d316-1c4b-4281-b951-d872f2087c98

- Add support for 'deprecated' attribute in template generator
- Add support for both int- and string- based enums in the template generator
- Add logic to handle ProxyMode and fall back to ProxyServerMode

BUG=68134
TEST=ConfigurationPolicyPrefStore*, new policy template generator tests

Review URL: http://codereview.chromium.org/5958014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24672
TEST=trybots

Review URL: http://codereview.chromium.org/6193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71314 0039d316-1c4b-4281-b951-d872f2087c98