- 10 May, 2019 40 commits
-
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I26cde7a7d5b606d7e038ae609c460e6434155c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599064 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#658402}
-
Charlene Yan authored
The wrench menu (3 dot menu) was broken on touch when changing AppMenuButton to inherit from ToolbarButton rather than MenuButton. The fix involves moving the handling of OnGestureEvent to ButtonController from Button so that it gets invoked properly. Bug: 956860 Change-Id: Iefe14b0c988faed12e5a7dc2dec91bc145d791e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600079Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658401}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I9cd5e6caed5a36add1cc4db9fec18a96246794a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604103 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#658400}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cd078c339256..776694cdad40 git log cd078c339256..776694cdad40 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 jonahr@google.com Change all ANGLE workarounds to use struct definition with info. Created with: gclient setdep -r src/third_party/angle@776694cdad40 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: I45e13cb4a593b23df3cc13884395ab1c1bd586e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604183Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658399}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4585cc846e0f..8c59e4b6dba6 git log 4585cc846e0f..8c59e4b6dba6 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 primiano@google.com Merge "perfetto: fix compile on gcc" Created with: gclient setdep -r src/third_party/perfetto@8c59e4b6dba6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I221e9db3a3380eab99212b24acc92babb43538f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605300Reviewed-by:
-
Lei Zhang authored
Print Preview currently talk to printers through a thread pool in LocalPrinterHandlerDefault. This includes the possibly of talking to multiple printers simultaneously. This is fine with CUPS, but not safe on Windows. Change LocalPrinterHandlerDefault to have a TaskRunner. For Windows, make the TaskRunner a SingleThreadTaskRunner. BUG=957242 Change-Id: Iad5bd30799504f2104c808057139bf06223d4128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604206Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#658397}
-
Michael Martis authored
Since we are still using the same set of metrics to measure the stable launch of this feature in M75, we push their expiry date to the estimated release of M76. Bug: None Change-Id: I436ee88d4c2a48c59146f930acfaa3fb60890719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591492Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#658396}
-
Tao Bai authored
Bug: 945027 Change-Id: I6e5674c968569cb82ae7c2199a5e2b67d145f940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576098 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658395}
-
Alex Danilo authored
CL:1593885 changed scrolling on focus behavior for the directory tree. A bug triggered by this change scrolls the entire client area of the FilesApp under some focus changes. This CL disables the scroll on focus completely. Bug: 955566 Change-Id: I3b5d8b67501308ab5b5f3a69d3d373ec1127719b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605382Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#658394}
-
Bruce Dawson authored
ProcessMetrics silently ignores failures in GetProcessTimes because of concerns about race conditions, but since ProcessMetrics *owns* a duplicated process handle such concerns are not valid. If they were then we could get occasional handle errors when debugging or using Application Verifier which is unacceptable any. So, adding a DCHECK. Change-Id: I97475f4223ab71be87ae9025d3f8a00fe2363ff0 Bug: 890051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601540Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#658393}
-
Daniel Cheng authored
Change-Id: Ic77300a39d6f7cd6e58ada65393a7b2cd131cd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603347 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#658392}
-
Jun Mukai authored
Bug: 961467 Test: manually seeing chrome://tracing Change-Id: I0303adeea2ba52f656811ab891ed6f0a7bcfbe65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604050Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#658391}
-
Christopher Lam authored
Bug: 836128 Change-Id: I10a8ac0af55dbd313419a4effaa9305ef8a890c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517213 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#658390}
-
Michael Thiessen authored
This will allow NoTouchActivity to support things like oauth flows and not clear history stack when something opens in a new window. Bug: 959338 Change-Id: I287f8642cc94d4bc8a7578e296cac1f48be8d194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600961Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#658389}
-
Chris Lu authored
Bug: 954624 Change-Id: I24cff48293ad2943f42fa5e305274c2c7389c8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597112 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658388}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f86c9af41fc7..2bca3f229ed9 Created with: gclient setdep -r src-internal@2bca3f229ed9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=dvadym@google.com,noel@google.com,jbroman@google.com,xialinyan@google.com Change-Id: I6ee061bcde863c6e9c6846ee31aee9fa6de3ec17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604056Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658387}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I9c57610d7343732658c543af328ec9ed7cd76843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604470Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#658386}
-
Noel Gordon authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961547 Change-Id: Ia5adbbb01b3ad4dad4b98e5a72bb76bf6fa94173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605283Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#658385}
-
Chase Phillips authored
This reverts commit 379c0975. Reason for revert: crbug.com/961487, FindIt detected this CL as causing flake in large-requests-abort.html: 17:54:55.845 50941 [18/20] external/wpt/IndexedDB/large-requests-abort.html failed unexpectedly (test timed out) Original change's description: > IndexedDB: Convert IDBDatabase.GetAll to native Mojo callback > > Bug: 717812 > Change-Id: Ide1572f90b9b576af0f0bc53a6c735b3394d9c75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534709 > Commit-Queue: Chase Phillips <cmp@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658224} TBR=cmp@chromium.org,dmurph@chromium.org,tsepez@chromium.org Change-Id: I625f219b1642a18daa0006b55653a43114539b4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605151Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#658384}
-
Findit authored
This reverts commit 2f2d5d96. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 658376 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJmMmQ1ZDk2MGE1OWE0YTUxMGM0YjBhZGZlYTNkMzQwNDk3ZGZmMWQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Fuchsia%20ARM64/69714 Sample Failed Step: compile Original change's description: > Onion soup canvas_capture_handler.cc/h > > This is a first step to OnionSoup content/renderer/media_capture_from_element/. > > It summary, this CL > > - Moves content/renderer/media_capture_from_element/canvas_capture_handler* to > third_party/blink/renderer/modules/mediacapturefromelement/. > - Adapts the existing code for Blink restrictions, eg use WTF::Bind > instead of base::Bind. > - Removes the code that used to plumb the creation of > content::CanvasCaptureHandler instances through blink::Platform, and make > blink::HTMLCanvasElementCapture to create it (see the second TODO > below). > > To be done (follow up CLs): > > - migrate some remaining base::Bind{Once,Repeating} uses to the > respective Blink/WTF alternatives. This is now blocked on having > a CrossThreadBindOnce implementation available (see > crrev.com/c/1597228). > - eliminate blink::WebCanvasCaptureHandler > third_party/blink/public/platform/web_canvas_capture_handler.h. > Note that this is not done now because there is code in > third_party/blink/renderer/core/html/canvas/canvas_draw_listener.cc|h > that use blink::WebCanvasCaptureHandler, and can not use > blink::CanvasCaptureHandler directly, because core/ can not depend on > modules/. > > R=kentaro@chromium.org, guidou@chromium.org > > BUG=787261 > > Change-Id: Id2dc1f6441e2568c8420f0849a2cb5f87f9a6d75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600898 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#658376} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=787261 Change-Id: Ic421bd5c65d48ec6b9c1036833fc6e6fcb203be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605343 Cr-Commit-Position: refs/heads/master@{#658383}
-
Alex Cooper authored
Bug: 961327 Change-Id: I43487bf1f5ada33917e32805e6dd793c838e386d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602450 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#658382}
-
Ryan Sturm authored
This metric is intended to be used to compare experiments effect on user battery. It is not useful outside of experimental comparison, as other apps can easily affect this. Bug: 958176 Change-Id: I1604af419c3912521ad89ba0c185305ffc393cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592340 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#658381}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e4605daf9407..3e511440e774 git log e4605daf9407..3e511440e774 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 chrisforbes@google.com Remove UNIMPLEMENTED on unsupported features 2019-05-09 chrisforbes@google.com Accept OpExtension SPV_KHR_variable_pointers 2019-05-09 chrisforbes@google.com BufferView has id in shared space with ImageViews 2019-05-09 sugoi@google.com Allow 3d <-> 2d image copies Created with: gclient setdep -r src/third_party/swiftshader@3e511440e774 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/130937460 TBR=swiftshader-team+autoroll@google.com Change-Id: Id9ab4286f36076197a59c98bc39112f6c3777221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603782Reviewed-by:
-
Yuke Liao authored
This CL works around the issue that layout test results merger script tries to use the profdata directory (CWD) as output directry and wipes out the content of that directory. Bug: 960994 Change-Id: I1ca5383d9eb19aba6799cf19d0d5d95c2af82c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602332Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#658379}
-
Joe DeBlasio authored
This CL modifies the DownloadTargetDeterminer state machine to add a call out to its delegate to check whether the download should be blocked. This happens immediately after initial download path is determined, but before the user might be prompted. This will eventually be used to block downloads as active mixed content. Bug: 960819 Change-Id: I9a90dd811c97808d229a98e4a4fcf74feb4d0396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590412Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#658378}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2cf3aa8e54db..09537e93fddd git log 2cf3aa8e54db..09537e93fddd --date=short --no-merges --format='%ad %ae %s' 2019-05-09 perezju@chromium.org [Telemetry] Remove old browser_info methods Created with: gclient setdep -r src/third_party/catapult@09537e93fddd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:921000 TBR=charliea@google.com Change-Id: I4d54774de69f05f2951bf449bc1540627dda80c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603144Reviewed-by:
-
Antonio Gomes authored
This is a first step to OnionSoup content/renderer/media_capture_from_element/. It summary, this CL - Moves content/renderer/media_capture_from_element/canvas_capture_handler* to third_party/blink/renderer/modules/mediacapturefromelement/. - Adapts the existing code for Blink restrictions, eg use WTF::Bind instead of base::Bind. - Removes the code that used to plumb the creation of content::CanvasCaptureHandler instances through blink::Platform, and make blink::HTMLCanvasElementCapture to create it (see the second TODO below). To be done (follow up CLs): - migrate some remaining base::Bind{Once,Repeating} uses to the respective Blink/WTF alternatives. This is now blocked on having a CrossThreadBindOnce implementation available (see crrev.com/c/1597228). - eliminate blink::WebCanvasCaptureHandler third_party/blink/public/platform/web_canvas_capture_handler.h. Note that this is not done now because there is code in third_party/blink/renderer/core/html/canvas/canvas_draw_listener.cc|h that use blink::WebCanvasCaptureHandler, and can not use blink::CanvasCaptureHandler directly, because core/ can not depend on modules/. R=kentaro@chromium.org, guidou@chromium.org BUG=787261 Change-Id: Id2dc1f6441e2568c8420f0849a2cb5f87f9a6d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600898Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#658376}
-
James Cook authored
The conversion from ARC to native assistant left some dead code in settings. Bug: 960937 Test: turned assistant feature flag on and off in about:flags Change-Id: Icb4b03aee055cfffbd9118c56661c6431debac65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602658Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#658375}
-
Kenichi Ishibashi authored
This experiment uses a variation parameter to control how V8 code cache is generated for service worker scripts. We need to put the value of the parameter explicitly. Bug: 915081 Change-Id: Ie9cb565e3ad09396de5d125a46b9b5db755bbb14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597494 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#658374}
-
Mei Liang authored
This CL adds a closing tab behavior when TabGroupAndroid is enabled. Close the app when closing the last normal tab in Chrome using TabGroupUi. Bug: 960196 Change-Id: Iad35c0dc885f7cc2bb30848ce7199912ceadaedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598231Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#658373}
-
sczs authored
- Creates Mobile.Messages.Modal.Event for all generic Infobar Modal events. These will be used by the generic InfobarMetricsRecorder - Creates Mobile.Messages.Passwords.Modal.Event for all password specific Infobar Modal events, along with a Mobile.Messages.Password.Type suffix. - The previous Histogram will be used by a new class PasswordInfobarMetricsRecorder. - Logs InfobarModal metrics mostly from InfobarPasswordTableVC and some from its Coordinator since they need presenting context. Bug: 945478, 911864 Change-Id: Id53c47c884c9c2e0e52e10fae27dbe0f864d9eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598331 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Bailey Berro authored
- Adds AutomaticUsbPrinterConfigurer to CupsPrintersManager - AUPC installs automatic usb printers as they are added Bug: 951135 Change-Id: Ib06441e8574b4fd64deef250a6c3bc152cee11af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594690 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#658371}
-
Antonio Gomes authored
This CL factor IOTaskRunnerTestingPlatformSupport out of modules/mediastream/media_stream_video_capturer_source_test.cc into a helper class/file platform/testing/io_task_runner_testing_platform_support.cc|h. This allows it to be reusable. This is a preparation CL for crrev.com/c/1600898. R=haraken@chromium.org,guidou@chromium.org BUG=787261 Change-Id: I2d5a11d4a93c19b27dc4290d025be10a9502c890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602593Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#658370}
-
rbpotter authored
Change downloads to use the same approach as settings, extensions, and print preview: (1) Use an individual grd file instead of browser_resources.grd (2) Create unpak folder Bug: 715296 Change-Id: Ifd0ce1c46e11ad80ee17fa8c5e55aab33543bfa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598320Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#658369}
-
Alex Moshchuk authored
Previously, with strict origin isolation, we computed the site URL as the URL's full origin whenever the URL's origin had a host (and was not a file URL). This also incorrectly triggered for effective URLs, such as chrome-extension://hosted_app_id/, where returning the origin right away skipped some essential logic below that appended the non-translated site URL to the site URL's hash. That led to not being able to swap processes on cross-site transitions within hosted apps. Fix this by restricting strict origin isolation to only affect HTTP/HTTPS URLs. Bug: 961386 Change-Id: I224cfe4df23ec55a0429c626fd6f439da1ef3041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603745Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#658368}
-
Kristi Park authored
getTilesPerRow_() only checked the grid's maximum number of tiles per row when detecting if the tiles needed to be rebalanced. Therefore, if the window's maximum tiles per row was less, the tiles were not rebalanced. Use the lesser of the two maximums when detecting if the tiles need to be rebalanced. Screencast: https://drive.google.com/open?id=19amLd8JRyzLSzBeA4Ypt7PIZYlaqhaIz Bug: 961203 Change-Id: I3200a043b40b3282a61a7512e00e6b6ae4ebbd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603209 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#658367}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2e48312247a8..1b52d87ab536 git log 2e48312247a8..1b52d87ab536 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 ehmaldonado@chromium.org Reland "git-cl: Keep git push traces" Created with: gclient setdep -r src/third_party/depot_tools@1b52d87ab536 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:955206 TBR=agable@chromium.org Change-Id: I7ccb7132cb4df67eedaa488c98159e38241d54e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603922Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2a84e59b407e4700d9d76fd71493e6d49f5da995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604246Reviewed-by:
-
Brandon Wylie authored
Large rebase mistakes left some cruft in the code, cleaning that up. TBR=yfriedman@chromium.org Bug: 938050 Change-Id: I264807dcc12aa69397ef5ddf56db5236ade0bf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603524 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#658364}
-
Sinan Sahin authored
Bug: 958491 Change-Id: I03277ad2839d3707decb63804a876efea2c95a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604044Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#658363}
-
