- 25 May, 2018 40 commits
-
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/da060ba107fb..710fa99b0bd2 $ git log da060ba10..710fa99b0 --date=short --no-merges --format='%ad %ae %s' 2018-05-25 thestig Mark CPDF_Object pointers in pattern code as const. 2018-05-25 dsinclair [xfa] Generate CXFA_EventParam.newText dynamically 2018-05-25 dsinclair [xfa] Add missing xfa.event.cancelAction property 2018-05-25 dsinclair [xfa] Clamp selStart, selEnd values in CJX_EventPseudoModel Created with: roll-dep src/third_party/pdfium BUG=chromium:1066,chromium:1066,chromium:1066 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I81ca482708c0a39b45eadf412a89ce864199a1ad Reviewed-on: https://chromium-review.googlesource.com/1073635Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561981}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fcd16760. With Chromium commits locally applied on WPT: 7a0d5e18 "[Mojo Blob URLs] Handle more navigation cases." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/18567 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=kereliuk No-Export: true Change-Id: Iad92620ea5cf712901994ef0deccb57b01f9c62c Reviewed-on: https://chromium-review.googlesource.com/1073627 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#561980}
-
kylechar authored
The test failures from using GLES2DecoderPassthroughImpl have been fixed. Re-enable viz_screenshot_sync_tests on Win7 GPU FYI bots now that it passes. Bug: 825906 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0da7271ecdfa65de3c767dffbda96fa6b80979c4 Reviewed-on: https://chromium-review.googlesource.com/1070329Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#561979}
-
Calder Kitagawa authored
This is part of a series of Fuzzers to be added to Zucchini for security review. This tests the full patch generation logic exercising the patch writer and gen process. It covers ~44% of code in 100000 runs. The remaining code is split between ZTF Apply Fuzzer (~30%) and the aggregate of DEX Disassembly (not in launch scope), patch serialization (trusted input), and other testing/debugging/error handling code which isn't triggered. With the supplied seed corpus the fuzzer reaches approximately 4000 execs/s. The file format for the seed is a FilePair proto of a ZTF base file and a ZTF updated file as used in Raw Gen. Also fix bug where wrong fuzzer was running for apply. Bug: 835341 Change-Id: Ib99dd70ba01820b874d72fecb2b543ea7082f649 Reviewed-on: https://chromium-review.googlesource.com/1072229 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#561978}
-
Maksim Sisov authored
This CL is a part of Wayland gpu/ui split effort, which fixes the Ozone/Wayland and makes it functional when the gpu service is running off the browser process. The patch does not bring any functionality changes, but rather prepares Ozone/Wayland dmabuf based approach, which uses ozone/drm code, to be landed in the upstream. In particular, drm_util is partly moved to ui/ozone/common/linux and implements drm format conversion methods, which are used by Ozone/drm and are going to be used by Wayland with dmabuf approach. Bug: 820047 Change-Id: I024fd1f6a57b9e9693864e62d5cb8a443afd9e2a Reviewed-on: https://chromium-review.googlesource.com/1071792Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#561977}
-
Eric Orth authored
Split everything in the net/dns directory off into its own BUILD.gn file in that directory with separate source_sets depended on by the main //net target. Control access external to the network stack using public/private headers with whitelisted access via friend lists. The main HostResolver API is public, and everything else is whitelisted to just network (and network service) code and current external usage. This will block most external code from adding new includes of anything except HostResolver. Note: There are some parts of chromium where the restrictions are not enforced (eg //third_party/* and some large parts of //chrome/*), but I checked that there are no current violations (by enabling enforcement in src/.gn for everything and searching the results for "net/dns"). Circular dependencies between //net and //net/dns were too ingrained to be resolved. Configured to allow such dependencies and locked the dns build rules (via visibility) to only allow direct dependency through the //net target. Very reasonable since dns code should still live in the net.dll component. Bug: 846454 TBR: allenvic@chromium.org,thestig@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0b6eb60741a7910013b0f7897127c5153cff3f15 Reviewed-on: https://chromium-review.googlesource.com/1060304 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#561976}
-
Devlin Cronin authored
Take steps to make it harder to mess up extension_function_histogram_value (which can happen if the enum is ever reordered). Do this in two ways: * Add explicit values to the enum values. This makes it much more difficult to accidentally insert an enum in the middle, because it is clear that they are all increasing. What's more, adding one with a duplicate value will cause ExtensionFunctionRegistrationTest.CheckForDuplicateEntries to fail. * Add a unittest that compares the values in the C++ enum to the values specified in the enums.xml file. To do this, hijack the code to read and parse the enums.xml file from about_flags_unittest.cc and put it in a common place in base/test/enum_test_util. Between the two of these, it should hopefully be very difficult to accidentally reorder the histogram. Bug: None Change-Id: I8932c7da32af8121ec94ef89bf591365e93ce575 Reviewed-on: https://chromium-review.googlesource.com/1062201Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561975}
-
Joel Einbinder authored
There was a missing comma that broke the hosted mode server Change-Id: I240ba5dad5ce9508e163717935a525174a339e3c Reviewed-on: https://chromium-review.googlesource.com/1073632Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#561974}
-
Marc Treib authored
This new model type was introduced in https://crrev.com/c/1068528, which failed to add the new whitelist entry. Similar to https://crbug.com/818570. Bug: 846252 Change-Id: Ie11443d48f62cc034bf177ff0e7d35d06aa6c2c8 Reviewed-on: https://chromium-review.googlesource.com/1070139Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#561973}
-
Saman Sami authored
ClientFrameSinkVideoCapturer survives gpu crashes. Bug: 806377 Change-Id: Ibef855c77440ef8098ebd7d1aaed4c5d39d32e29 Reviewed-on: https://chromium-review.googlesource.com/1072414 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#561972}
-
Eric Stevenson authored
This reverts commit dc6ff4ef. Reason for revert: Binary size regression of almost 880 KB. Original change's description: > Android: Enable in-tree libc++ builds > > BUG=767901 > R=thakis > CC=pcc > > Change-Id: Ib394126f8e729192ee41520eefd85e22531bfd65 > Reviewed-on: https://chromium-review.googlesource.com/1066596 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561361} TBR=thakis@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 767901, 846745 Change-Id: Ie330b21911f3d4a75c114d488efa3a705ad8616a Reviewed-on: https://chromium-review.googlesource.com/1073489Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#561971}
-
Andrew Luo authored
Bug: 816709 Change-Id: I3104dc5b0856d413ecd54fc93cc7fe77b6eef7c5 Reviewed-on: https://chromium-review.googlesource.com/1060591 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#561970}
-
Kyle Horimoto authored
The tests were broken on debug builds because they assumed that the address of a ClientConnectionParameters object would remain unchanged throughout the life of the test, but this was not true since the object was std::move()'ed. In release builds, this did not trigger a failure. Bug: 824568, 752273 Change-Id: Ic03cbde9d5c74030bdccfc87adf1041a038fed0c Reviewed-on: https://chromium-review.googlesource.com/1073653Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#561969}
-
Emily Stark authored
It's not clear why whitelisted --unsafely-treat-insecure-origin-as-secure origins should bypass CORS, and there doesn't seem to be any equivalent behavior in the Blink CORS stack, nor is there a test for this code. See https://chromium-review.googlesource.com/c/chromium/src/+/735242/16/content/renderer/loader/cors_url_loader.cc#26. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia19c1961fd8c4a2122f7216b971cd12fc300364f Reviewed-on: https://chromium-review.googlesource.com/1070466 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#561968}
-
chromite-chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/04b73c195727..13f43437558c $ git log 04b73c195..13f434375 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 xiaoyinh Revert "Add ARC++ Mojo support libs to chrome deployment" Created with: roll-dep src/third_party/chromite BUG=chromium:822034 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Id8c9baa63b8186441590a368e7e73dd845296c83 Reviewed-on: https://chromium-review.googlesource.com/1073105 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561967}
-
Luna Lu authored
This reverts commit a1559706. Reason for revert: Suspect causing theses tests to fail: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10013 RankerModelLoaderImplTest.BadLocalAndRemoteModel RankerModelLoaderImplTest.IncompatibleCachedFileTriggersDownload RankerModelLoaderImplTest.LoadFromExpiredFileTriggersDownload RankerModelLoaderImplTest.LoadFromBadFileTriggersDownload RankerModelLoaderImplTest.LoadFromURLOnly RankerModelLoaderImplTest.LoadFromFileAndBadUrl RankerModelLoaderImplTest.IncompatibleDownloadedFileKeepsExpired Original change's description: > Migrate AssistRanker to SimpleURLLoader > > As part of the effort to bring the new Network Service online, we are > deprecating URLFetcher in favor of SimpleURLLoader. > > Background: https://docs.google.com/document/d/1YZDPeg3bf46QPU_vUotFwOEPHquww36b-UdRlO3ZpMU/edit > > Bug: 844937 > Change-Id: I4a00c42b481f10c03657aa52b9a3d197febdc6ed > Reviewed-on: https://chromium-review.googlesource.com/1070110 > Reviewed-by: Andrew Moylan <amoylan@chromium.org> > Reviewed-by: Rachel Blum <groby@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561845} TBR=groby@chromium.org,mmenke@chromium.org,pilgrim@chromium.org,amoylan@chromium.org,charleszhao@chromium.org Change-Id: I486df02edd2d762c0a0f93449d47aafdf5337f27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844937 Reviewed-on: https://chromium-review.googlesource.com/1073656Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#561966}
-
danakj authored
After this viz/client/ does not use cc/ (only cc/base/), and does not include any mojo-bindings-specific code. We add a negative DEPS rule for them with a comment, as well as mentioning it in the viz/README.md for the client/ directory. The ClientLayerTreeFrameSink from viz/client/ moves to cc/mojo_embedder/ which is a separate component from cc that is able to depend on mojo bindings. This keeps viz/client/ and cc/ agnostic to the means for communicating with viz, as webview uses classic IPC to get to the viz process, and deprecated browser compositor uses in-process communication with viz. The public viz mojoms had dependencies on cc/ in their typemaps but they were incorrect as the types have all moved to the viz component, so these DEPS are updated to reflect that. After this, allowed dependencies look like: aura,content -> cc/mojo_embedder -> cc,mojo-bindings cc -> viz/client,viz/common R=kylechar@chromium.org TBR=dcheng Bug: 722935 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iec542fcc20f7b2bd2a42737c51dc30e0a4180de6 Reviewed-on: https://chromium-review.googlesource.com/1072314 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
R=dmazzoni@chromium.org Change-Id: I8abe52772cf2b45bda48f3e8ddb3fb747150c50f Reviewed-on: https://chromium-review.googlesource.com/1072559Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#561964}
-
Ben Pastene authored
This'll give me more time to debug hung VM tasks. As it is, 20min isn't really enough time for my ssh'ing to yield much results. TBR=dpranke@chromium.org Bug: 832374 Change-Id: I58f9b065190c1029c495756d914304abcca7b5a0 Reviewed-on: https://chromium-review.googlesource.com/1070450Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Fernando Serboncini authored
Change-Id: Ie88b31b0490874975fc425fdbcde2373d03ee2c3 Reviewed-on: https://chromium-review.googlesource.com/1073501Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#561962}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0e97383613e5..0ceb1eccef76 $ git log 0e9738361..0ceb1ecce --date=short --no-merges --format='%ad %ae %s' 2018-05-23 wangxianzhu [Tracing UI] Fix drag_handle when there are size constraints Created with: roll-dep src/third_party/catapult BUG=chromium:842238 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic57d0a62391b55de1ac459e9bbc2ce6da95ca4f5 Reviewed-on: https://chromium-review.googlesource.com/1072459 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561961}
-
Xiaoqian Dai authored
It's a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1065499. The newly added tests in the original CL broke the asan build. It's an initial implementation of the feature. See the UI mock: https://docs.google.com/presentation/d/1zCV2v5rXFUndWC5ECMKj06i5WNbRJ-uZWyZTFxU8dEE/edit#slide=id.g21b4c071a9_0_116 See Doc for expected behaviors: https://docs.google.com/document/d/1rm8_JyTY883IiNNis6LGtI1jsx_WHCWm5KY7hwAGOe8/edit#heading=h.i5t24a7vxw8j See recorded video: https://drive.google.com/open?id=1KcqAyHrxj6zheSEkgGz-ozlg7mILrmxT 1) Add a new feature flag --enable-features=DragTabInTabletMode And also expose it to chrome flag --enable-drag-tabs-in-tablet-mode 2) Only tab(s) area can be dragged. 3) For a maximized window, its tab(s) can be dragged out to create a new window to either be maximized or snapped to one side of the screen, or can also be merged back to the original window 4) For a snapped window, its tab(s) can be dragged out to create a new window to snap to either side of the split, or can also be merged to an existing window to either side of the split TBR=sky@chromium.org, oshima@chromium.org Bug: 823769 Change-Id: I6d6a3e196afa4752523d2d18ca4fc8d78186b660 Reviewed-on: https://chromium-review.googlesource.com/1072464Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#561960}
-
Robbie McElrath authored
This is needed to migrate sensor layout tests to using mock mojom services instead of testRunner.setMockDevice[Motion|Orientation]. Currently the event pump classes don't bind to a mojom service if they're running as part of a layout test, but they'll need to in order to use a mock mojom service to provide the testing data. This will make existing layout tests try to connect to the generic sensor provider mojom service, which could break the existing tests if the null-event is fired when the service isn't found. This isn't actually an issue with the existing layout tests because of the way the sensor event pump classes handle missing mojom services. DeviceSensorEventPump::HandleSensorProviderError is called when the SensorProvider service can't be found, which resets the mojom pipe without calling OnSensorCreated, which would lead to the null-event being fired. Eventually we should fix the sensor event pump classes to send the null-event when the sensor provider mojom service isn't found, but for now the fact that we don't allows us to migrate the sensor layout tests piecemeal, which is good. There are two tests that this affects. One of them is a wpt test that we currently timeout on, but now fails. I'll fix that in a followup CL. The other test this breaks is testing behavior that goes against the spec, so I updated that test to actually test what it says it's testing, and to match the spec. Bug: 774183, 802815 Change-Id: I376d94a7e7f35aefdb4b586050a03e198988e8be Reviewed-on: https://chromium-review.googlesource.com/1060380Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#561959}
-
Kyle Horimoto authored
This class handles connection failures specific to BLE initiator connections. Specifically, this request type allows retries for some failures, including timeouts and GATT errors. Bug: 824568, 752273 Change-Id: If8748896a2b6540fac9203c59dd1fd180c6782a8 Reviewed-on: https://chromium-review.googlesource.com/1041209 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#561958}
-
Marco Paniconi authored
https://chromium.googlesource.com/webm/libvpx.git/+log/e27a331778c4..36825590ba67 $ git log e27a33177..36825590b --date=short --no-merges --format='%ad %ae %s' 2018-05-24 jianj VP9: Fix issues with high bitdepth in real-time. 2018-05-24 marpan vp9-svc: Add max_consec_drop to SVC frame drop. 2018-05-23 marpan vp9: Rate control adjustments for screen content. 2018-05-22 marpan vp9-svc: Add full superframe drop mode. 2018-05-21 marpan vp9-svc: Small code cleanup in nonrd-pickmode. 2018-05-21 jzern remove unused vpx_ports/config.h 2018-04-24 niveditha.rau Add Solaris to supported platforms 2018-05-19 jzern configure,ios: add missing c++11 checks 2018-05-18 paulwilkins Experiment regarding playback problems on Bravia TVs. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I153aec8d8d6f22ccdad3692dc3abb80a14627aa1 Reviewed-on: https://chromium-review.googlesource.com/1072720Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#561957}
-
Alexei Filippov authored
NOTRY=true BUG=846665 Change-Id: I0c6dcde484386fd7fa5ee2705c0df67f17b157c2 Reviewed-on: https://chromium-review.googlesource.com/1073633Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#561956}
-
Dirk Pranke authored
They're currently marked as experimental on the release builder, so they should probably be that way on the experimental builder as well. NOTRY=true Change-Id: Ic8771d4b014b24bd153033f22e9c51235b9de730 Reviewed-on: https://chromium-review.googlesource.com/1070504 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#561955}
-
Jun Choi authored
Replace current use of relying party ID and client data hash constants in unit tests to constants in fido_test_data.h that is consistent with example 5, 6 of the CTAP spec.[1] [1]: https://fidoalliance.org/specs/fido-v2.0-rd-20170927/fido-client-to-authenticator-protocol-v2.0-rd-20170927.html Bug: 798573 Change-Id: I55d0ab5a54a1dd9d1718afeea0ddd503140876c6 Reviewed-on: https://chromium-review.googlesource.com/1034291 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#561954}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/be0f656a8e61..da060ba107fb $ git log be0f656a8..da060ba10 --date=short --no-merges --format='%ad %ae %s' 2018-05-25 dsinclair [xfa] Restrict the editable xfa.change properties 2018-05-25 dsinclair [xfa] Rename pValue to pReturn for clarity 2018-05-25 dsinclair [xfa] Allow accessing the event changed parameter from JS. Created with: roll-dep src/third_party/pdfium BUG=chromium:1066,chromium:1066,chromium:1066 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I27df8788ab601c6946f39b14dd09a03dfad4cddc Reviewed-on: https://chromium-review.googlesource.com/1073571Reviewed-by:
-
Qiang Xu authored
Bug: b/79387303 Test: covered by tests Change-Id: Ifd4e04ce456c9d9995b85f0bd1a86f97608a9444 Reviewed-on: https://chromium-review.googlesource.com/1072641 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561952}
-
Xiaocheng Hu authored
As cold mode idle time spellchecker is shipped into M68 and no regression is obversed, this patch removes the flag from M69 as cleanup. Bug: 716642 Change-Id: I8f850c52469590ee9d5e542c14f4dae842a6163a Reviewed-on: https://chromium-review.googlesource.com/1072953Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#561951}
-
James Cook authored
WindowSizerAsh needs synchronous access to the target display for each new browser window. * Create ash::ShellState and move root_window_for_new_windows_ there * Introduce mojom::ShellState interface in ash * Create a ShellStateClient in chrome to cache the target display id for new windows The interface is not implemented by ash::Shell because ash::Shell is already massive (1500 lines). Also, shell.h is included in 900 places in the code base and I don't want to add mojo generated headers to shell.h. Windows still don't appear on the secondary display with --enable-features=Mash, but chrome is getting the correct display id and setting the window bounds properly. I think ash needs to be fixed to support top-level bounds on the secondary display, but that will need to be a follow-up CL. Bug: 764009, 768908 Test: ash_unittests, unit_tests for WindowSizer Change-Id: Ib77834f8ed5dc4e65f02ff83ab81acbf3331db61 Reviewed-on: https://chromium-review.googlesource.com/1067591Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#561950}
-
Daniel Nicoara authored
This is a reland of ce767464 Original change's description: > [Ozone-DRM] Refactor plane management and add tests > > * We use plane properties on legacy DRM to get some details (plane > type, in_formats). Read the properties in HardwareDisplayPlane and > check that the required properties are available in DRM atomic. > * Split dummy plane into its own class to clean up code. > * Remove test plane since we can now create the real objects via > injected state in DrmDevice. > * Cleanup plane initialization. > * Remove MockHardwareDisplayPlaneManager and rely on MockDrmDevice to > inject the necessary state. > > BUG=839487 > TEST=Ran unittests > > Change-Id: I03c91620557dcf7426629cf97bb989d8d7e83c68 > Reviewed-on: https://chromium-review.googlesource.com/1048585 > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561616} Bug: 839487 Change-Id: Ifb74647dfe1f05ef3339261dd1f7c51c0c371622 Reviewed-on: https://chromium-review.googlesource.com/1073487Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#561949}
-
Shenghua Zhang authored
TBR=jbudorick@chromium.org Bug: 731559 Change-Id: I6ed4bfa7b6c22f41a9fd65732cabc22064eb8162 Reviewed-on: https://chromium-review.googlesource.com/1073620Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Commit-Queue: Shenghua Zhang <shenghuazhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#561948}
-
Dominic Mazzoni authored
Use a switch so that if a new enum value is added, a compile error will force us to update this code. Bug: 817124 Change-Id: I4183b735c913532c47df97c0518853b7d26aa91d Reviewed-on: https://chromium-review.googlesource.com/994414 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#561947}
-
Emily Hanley authored
from each shard. Updating bot map format to include an optional begin and end value to indicate a subset of stories to run. Bug: 713357 Change-Id: Id3188cc350e9df2c82177057e032301ddc8b851d Reviewed-on: https://chromium-review.googlesource.com/1070310Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#561946}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5f9482f4c52b..d0a7d10f397d $ git log 5f9482f4c..d0a7d10f3 --date=short --no-merges --format='%ad %ae %s' 2018-05-07 jiawei.shao ES3.1: Set unordered access view related resource limits on D3D11 Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I2d5dcd77f664b58d6e7fdadd5cdad8606656ea63 Reviewed-on: https://chromium-review.googlesource.com/1073102 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561945}
-
Sebastien Marchand authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1072787 with fixes. ps1 is the original CL, the fix is in ps2 the problem is that I'm casting a LocalSiteCharacteristicsNonRecordingDataStore* to a LocalSiteCharacteristicsDataStore* instead of a SiteCharacteristicsDataStore* (the common interface between the 2 classes) Bug: 773382, 846492 Change-Id: I6cad02e8ca771debc3b4b2028616dec8fbcaf521 Reviewed-on: https://chromium-review.googlesource.com/1073050Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#561944}
-
Mike Dougherty authored
Bug: 228355 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9177b7841982999299f31084ce3b042aefd59fdc Reviewed-on: https://chromium-review.googlesource.com/942027Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#561943}
-
Amy Qiu authored
The top_25_pages page set is not used in any benchmarks or inherited by any other classes, therefore remove it. Bug: 760553 Change-Id: I37849b76f92aab88e124ac2086b596782a3b0546 Reviewed-on: https://chromium-review.googlesource.com/1072447Reviewed-by:
-
