- 07 Jul, 2020 40 commits
-
-
Sreeja Kamishetty authored
-org.chromium.chrome.features.start_surface.StartSurfaceTest.* -org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest.* -org.chromium.chrome.browser.tasks.ReturnToChromeTest.* -org.chromium.chrome.features.start_surface.InstantStartTest.* -org.chromium.chrome.browser.datareduction.DataReductionSavingsMilestonePromoTest.* -org.chromium.chrome.browser.tasks.tab_management.TabSuggestionMessageCardTest.* -org.chromium.chrome.browser.feed.FeedContentStorageConformanceTest.* -org.chromium.chrome.browser.status_indicator.StatusIndicatorTest.* BUG=1102633 Change-Id: If64f3fc873214c498939d48ed847e558390c4acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284630Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#785729}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fd8f0e2fac09..f6f11215cd93 2020-07-07 capn@google.com Implement shaderStorageImageExtendedFormats support 2020-07-07 capn@google.com Implement scatter/gather for 1- and 2-byte texels If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4609eefb2cd213da920d0c43b70337f608b4ffd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284698Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785728}
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: I90f88cf35e85a8a0ab1811e5533347d329365b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283508Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#785727}
-
Tsuyoshi Horo authored
Bug: 1007689 Change-Id: I98819b9e1d33b28ddb81f92951961094801f6613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269394Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#785726}
-
Antonio Gomes authored
... instead of WebMediaStreamSource. BUG=704136 R=guidou@chromium.org Change-Id: I335a78a565b03c6db198cf921e02ef26a3ae0392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283763Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#785725}
-
Yuki Shiino authored
HTMLInputElement.labels is declared as readonly attribute NodeList labels; so, blink::HTMLInputElement::labels is expected to return blink::NodeList*, however, blink::HTMLElement::labels returns blink::LabelsNodeList (a subclass of blink::NodeList) without defining LabelsNodeList. From a PoV of bindings, there is no way to find the LabelsNodeList's definition. This patch fixes the problem. Bug: 839389 Change-Id: Iebc530cad7088cbe5231c31cb47df3637c265df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283038Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#785724}
-
Titouan Rigoudy authored
Originally based on a partial revert of crrev.com/c/2116892. This CL lays some groundwork for CORS-RFC1918 code changes. Bug: 986744 Change-Id: I26a10d07099fab39a77fdc6e12c1d4b2de324076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257752 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#785723}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594101275-38e9917f0b53891d9ca12d959315a5fd47c1594e.profdata to chrome-mac-master-1594123101-dfa27c4a1c98aa42fbcdd14d71d9320361fd45b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I5bf631c58312a2591f69a6c20a44c5dfad6bd7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284799Reviewed-by:
-
Omer Katz authored
This worklist is now drained by concurrent markers but the the task-local segments that are used for draining were not flushed back in case the marking deadline expired before the worklist was emptied. Bug: 1102394 Change-Id: Iab6a9bd8148472ed521e0f32643fd114b534b335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282934 Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#785721}
-
Stephen Nusko authored
Some tests post tasks to the threadpool, and currently the base layer_tree tests attempts to use base::RunLoop().Run() [0] to catch any running tasks. However that doesn't catch tasks running in the new TaskEnvinonment which you need to use CCTestSuite::RunUntilIdle. One possible fix would have been to change [0] to RunUntilIdle, but this seems less invasive. [0] https://cs.chromium.org/chromium/src/cc/test/layer_tree_test.cc?l=1085&rcl=a29f36b9f2ba61507abc10be33bb151c52a37694 Bug: 1096962 Change-Id: I016331a24cf206b7e2f66c9a8cef6636e436b840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282562 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#785720}
-
Asanka Herath authored
InspectableIdentifiabilityStudy{Settings => State} Bug: 1100424 Bug: 973801 Change-Id: I37c8840146ec7f3868d0f2c4115f74e18565947c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279924 Auto-Submit: Asanka Herath <asanka@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#785719}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a166a353fbc3..3444a49d77b0 2020-07-07 eshr@google.com [Adaptation] Remove deg.prefs from ResourceAdaptationProcessor 2020-07-07 deadbeef@webrtc.org Relanding: Fix data channel message integrity violation 2020-07-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 31d34f54..5f083e73 (785408:785559) 2020-07-06 titovartem@webrtc.org Add simulated time support for PC level test. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I16e9eb5b96b51ab15bbfce204e08372abb6b1baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284782Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3039024ba5b4..b4e2a786fc30 2020-07-07 fmayer@google.com Merge changes Ib781e8e8,Ia3009134 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6c6e24496c7ec079152950eee4e8985792729793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284783Reviewed-by:
-
Hajime Hoshi authored
This is a preparation to test CLS. Bug: 1014174 Change-Id: I07927ed55dfd2b6e3390207fca98c39d454d90a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279309Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/36a97db1bb2b..dcd57068bed4 2020-07-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 8188e3fbbc10 to db06fce926b0 (1 revision) 2020-07-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 5c38b18ab460 to e8b96e86fe2e (2 revisions) 2020-07-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from a173c025f8fe to 4c6019a855e9 (4 revisions) 2020-07-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 2c1ff230c26d to 6a4da9da4215 (2 revisions) 2020-07-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3121585acce2 to f6f11215cd93 (7 revisions) 2020-07-07 timvp@google.com Remove debug info from SPIR-V 2020-07-07 syoussefi@chromium.org Build specialized version of glslang If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Test: Test: CQ Change-Id: I8b8e009256fdb6c3b2934f95f9759a94b4f201bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284699Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8221db0d..fb40750b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I51669fe0e78155bead5813026baa8893e8bdf6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282954Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785714}
-
Victor Costan authored
This may improve the code used for certain containers, such as std::vector<url::Origin>. Change-Id: I0968aebece0ab773c5631a198894280d582c8c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281555Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d589211091cf..86436e7f59cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hendrich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1101659,chromium:1102729 Tbr: hendrich@google.com Change-Id: I5ecb7337a2165b12ea6810de9606cafcb08aaae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284701Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785712}
-
Vasiliy Telezhnikov authored
Enable feature on ToT by default before ramping up to 100% on stable channel. Bug: 900973 Change-Id: Ic13a46ab80a3715b9e5cfee2e276b9271a18b3d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283569Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#785711}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6130d5079d55..05da783f87fb 2020-07-07 csmartdalton@google.com Revert "Make SkGpuDevice hold a GrRecordingContext" 2020-07-07 csmartdalton@google.com Revert "Return the actual block capacity from GrBufferAllocPool::makeSpaceAtLeast" 2020-07-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2d0c7f09 to e6974b0e (315 revisions) 2020-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3121585acce2 to f6f11215cd93 (7 revisions) 2020-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 59ccb1f6de17 to 92554d75f354 (5 revisions) 2020-07-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 465a912582bb to 8b80e852bd6c (11 revisions) 2020-07-07 csmartdalton@google.com Return the actual block capacity from GrBufferAllocPool::makeSpaceAtLeast 2020-07-07 robertphillips@google.com Make SkGpuDevice hold a GrRecordingContext If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:816629 Tbr: mtklein@google.com Test: Test: Test: CQ Change-Id: Ia2e7b6d870aa78aeae06026789f568da5e974aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284700Reviewed-by:
-
Adam Rice authored
Add WebSocketReassembleShortMessages to fieldtrial_testing_config.json to make Finch happy about the upcoming beta trial. BUG=1086273 Change-Id: I04292429d1c676efb0ff99eb9d16f940e135e62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277695Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#785709}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: I416970f3ccd80e32c62fc7c5f7f246337d4b7fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280142Reviewed-by:
-
Harald Alvestrand authored
Bug: chromium:1091163 Change-Id: I07466bad328ebd98f1e4c62c54c8ef7fd149d2fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283605 Auto-Submit: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#785707}
-
Philipp Hancke authored
BUG=None Change-Id: I55bb3f38df5e359cb78b3905f1bb4599ff1cafff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283585 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#785706}
-
sandromaggi authored
This finally moves the action chain used for |ClickOrTap| (and as a result also |SendKeyboardInput|) to the util. The chain for |SetFieldValue| still remains, as extracting that one requires a bit more work to be done. Bug: b/158153191 Change-Id: I255ed476f1e55f4ac8dd5aececf49a9cf8143b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276266 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#785705}
-
Friedrich Horschig authored
This CL adds the (still unused) model and controller for the password check feature. As sample entry, it uses a method to update credentials and transforms it into elements that can be bound to items in a list view. Neither data nor names are final but the basic data structure (i.e. a ListModel) is strictly required to bind views and test them. Binding the (already existing) view with a view binder and a MCP happens in a follow-up. READMEs are stealing heavily from touch_to_fill since their general structure aligns fairly well. Bug: 1101256,1092444 Change-Id: Ic85a8c36b01ee89e617706372e512cb7f5148119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275959 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#785704}
-
arthursonzogni authored
All of this is put behind a flag disabled by default. This is mostly based on the initial prototype: https://chromium-review.googlesource.com/c/chromium/src/+/2223934/24 This modify the generated V8Window bindings. For every "CrossOrigin" methods and attributes accesses, this calls CheckCoopAccess(). When an accessing context tries to access another one from a different virtual browser context group, a COOP access report is potentially sent. COOP access reporting: [1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [3/N] this patch. Bug: chromium:1090273 Change-Id: I63d96cc9e28b20aae310c98a8df97d29a445f5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270472Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Shubham Aggarwal authored
CorruptSizeInHeader is a test helper function that allows to simulate a corrupt database by altering the header of the DB file. In WAL mode, transactions don't always touch the DB file, which means the database can behave normally even when corrupted in this way. In this change, the CorruptSizeInHeader method checkpoints and truncates the WAL file. This ensures that any subsequent transaction is guaranteed to hit the DB file and hence be affect by the header corruption. This change also adds a test that verifies that the function works correctly. Change-Id: Ic584e29f89b09a886d96e4424a17de8d37683314 Bug: 78507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278413 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#785702}
-
Sreeja Kamishetty authored
- WebUsbServiceImplTest.OpenAndNavigateCrossOrigin BUG=1102632 Change-Id: I911438a223ee0455ca7f7226afe713064a37a25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283947Reviewed-by:
-
Roman Sorokin authored
The class is only used for "user adding" flow. This CL inlines UserSelectionScreen from SigninScreenController. Also drops observing for OnUserImageChanged - not needed for "user adding". Bug: 1067260 Change-Id: Iec5a398f5d75a88156f173b6275ba7113b15218c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279807Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785700}
-
Karandeep Bhatia authored
DOMWrapperWorld pointer. Change ExecutionContext::GetContentSecurityPolicyForWorld and other associated APIs to accept a DOMWrapperWorld pointer instead of a reference. This is more compatible with APIs like ExecutionContext::GetCurrentWorld which returns a scoped_refptr and also ensures that call sites don't have to assume the main world when the current v8 context is empty. This should have no behavior change. BUG=1099975 Change-Id: I142e46409764fcf3680811e4ef9e2f665dd89b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284342 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#785699}
-
Denis Kuznetsov authored
Bug: NONE Change-Id: Ib4bc88135502ecec51bf804e85e60e0f0bc2396b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283349 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785698}
-
Philip Rogers authored
Bug: 1079418 Change-Id: Ib48fbedd92a01f161b954c614f081f91a5ad89f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283246 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#785697}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 85-4176.0-1593423523-benchmark-85.0.4183.11-r1 to 86-4176.0-1593425184-benchmark-86.0.4190.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I12881344637cbe535bfb3a55999786932e843fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284788Reviewed-by:
-
Cammie Smith Barnes authored
https://chromium-review.googlesource.com/c/chromium/src/+/2264857 caused a performance regression when adding a metric to measure when frames are first eligible to be painted. This CL is to fix that regression by adjusting the new metric's implementation. TBR=johnidel@chromium.org Bug: 1100404 Change-Id: Ia730bc69a7ac5669c1c7b8c291baa6abb96c5929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276674 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#785695}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 85-4147.51-1593425684-benchmark-85.0.4183.11-r1 to 86-4147.51-1593427277-benchmark-86.0.4190.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia4c25e02991c850fdf9213df628c89940f25a026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284787Reviewed-by:
-
arthursonzogni authored
There are 4 headers: - Cross-Origin-Opener-Policy: 3 values. - Cross-Origin-Opener-Policy-Report-Only: 3 values. - Cross-Origin-Embedder-Policy: 2 values. - Cross-Origin-Embedder-Policy-Report-Only: 2 values. I was asked to produces tests about the different configurations. There are up to 24 possibilities. Currently, we are producing a new test file for every combinaison, like: page_with_coop_and_coep.html{,mock-http-headers} If we want to test further, the number of files is going to grow quickly. Moreover we would have to produce very complex name: page_with_coop_ro_same_origin_allow_opener_coop_same_origin_coep.html It would be better if we could specify the headers to use in tests. This is possible thanks to the "/set-headers?" handler. The file above can be replaced by the path: "/set-headers?" "Cross-Origin-Opener-Policy: same-origin-allow-popups&" "Cross-Origin-Opener-Policy-Report-Only: same-origin&" "Cross-Origin-EmbedderPolicy: require-corp" This is much more readable and flexible. This patch deletes all the current files we have and use "/set-header?" instead. Bug: chromium:1090273 Change-Id: I67195f0940c4bb1a873014fe69c49321dcf76774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279803Reviewed-by:Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785693}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9585c468a280..92554d75f354 2020-07-06 rharrison@chromium.org Update path of third_party/spirv-tools to SPIRV-Tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0e04f22134b2d6437934142a45672509bb6bf0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284080Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I284183d571b9119a5a8268cf26dbaaea1a94d383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284695Reviewed-by:
-
Denis Kuznetsov authored
This CL introdces WizardContext object that would be used to pass data between screens in a unified way. Due to implementation complexities, ErrorScreen might get null context now, it will be resolved later. Also this CL updates mocking syntax to a new approach that does not require to specify number of arguments. Bug: 1102342 Change-Id: I38ed842c9450cc87d2c0d0ac0dc925525280dac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282928 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
