GitLab

MessageListView crashes when a notification is updated during the
UnifiedSystemTray is closing. Like other views::Widget methods,
SynthesizeMouseMoveEvent() should not be called during the widget is
closing.

See the bug for the asan trace.

TEST=manual
BUG=894070

Change-Id: I9ffba0f73260542ebf21b2aef572af1f68e5c40b
Reviewed-on: https://chromium-review.googlesource.com/c/1276225
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598768}

The new minimal behavior of the keyboard accessory requires it to show
only on password fields. Before this CL, we still had tests expecting
the accessory to show up on username fields.

This CL replaces clicks into the username field with password field
clicks.
For the one case (autofill dialog dismissal), we add a more explicit
call to force that behavior.
Additionally, a new test checks that the accessory is dismissed when
changing from a password to a username field.

Additionally, it uses real password sheets instead of sheetless tabs
which is much closer to the actual use-case and doesn't screw up the
tests that rely on caching sheets.

Bug: 887493
Change-Id: I7e5387487d403941ee6242393e3860bdef674b1f
Reviewed-on: https://chromium-review.googlesource.com/c/1275954
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598767}

This reverts commit 0dce4507.

Reason for revert: Fixed cronet issue

Original change's description:
> Revert "Android build: moved proguarding into dex() for most cases"
> 
> This reverts commit 93aa458f.
> 
> Reason for revert: Suspect for build failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel/2802
> 
> Original change's description:
> > Android build: moved proguarding into dex() for most cases
> > 
> > This is to allow R8 to proguard and dex in one call, since it has some
> > optimizations that only work when doing everything in one shot.
> > 
> > Bug: 872904
> > Change-Id: Id2c75dac4d9feecae461a0b1e279056253f1b71b
> > Reviewed-on: https://chromium-review.googlesource.com/c/1227142
> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Commit-Queue: Sam Maier <smaier@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#597257}
> 
> TBR=yfriedman@chromium.org,agrieve@chromium.org,smaier@chromium.org
> 
> Change-Id: Idf8f855094fb1bf4c4e1b47326b76166a158c1e8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 872904
> Reviewed-on: https://chromium-review.googlesource.com/c/1265559
> Reviewed-by: Kevin McNee <mcnee@chromium.org>
> Commit-Queue: Kevin McNee <mcnee@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597274}

TBR=yfriedman@chromium.org,agrieve@chromium.org,mcnee@chromium.org,smaier@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 872904
Change-Id: I1bebed520132e81b199c639690d36171ccb46ab6
Reviewed-on: https://chromium-review.googlesource.com/c/1271792
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598766}

When calling IsAdScriptInStack, return true if the current context is an ad frame's context.

This is a minor optimization in positive cases, and also covers more cases (e.g., inline script
in the ad frame).

BUG: 894080

Change-Id: I7b691c6746235bf4cc8be9860d81b7899c86e847
Reviewed-on: https://chromium-review.googlesource.com/c/1264955
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598765}

Android notifications are stored in Android logs. User data are removed
from WebRTC notifications in incognito mode to avoid leaking this data.
The change is behind a disabled by default switch.

    considering their translations, the size change cannot be avoided.

Bug: 629887
Change-Id: I80443ba0fbd463babc30c985a5cd4ef6781ae1a1
Binary-Size: This change doubles the media capture strings and
Reviewed-on: https://chromium-review.googlesource.com/c/1261023Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598764}

While solving crbug.com/878372 I ran into a case where
having two different locations for setting the fallback
caused it to go backwards. Add a DCHECK to prevent such
bugs.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If883bf03169135b3cbf0a5274a30a18ed149b08a
Reviewed-on: https://chromium-review.googlesource.com/c/1274610Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598763}

Incumbent realm was not designated for content attribute, so this CL
sets event target's realm to incumbent realm.

Bug: 893951
Change-Id: If7f526907dae803cd875d70ed79c9ee288df72a9
Reviewed-on: https://chromium-review.googlesource.com/c/1276406
Commit-Queue: Yuki Yamada <yukiy@google.com>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598762}

This CL adds rounded corners and elevation to DropdownPopupWindowImpl.
It also adds a small util function to ApiCompatibilityUtils to
facilitate elevation.

Screenshots: https://docs.google.com/presentation/d/1cSW-l62jY_6HB3UA-KDg8JlguNrVJlncse9HL7xIhuU/edit?usp=sharing

BUG: 874077
Change-Id: Icd01731c2f7292d3ea1397e6790525af00bfa71d
Reviewed-on: https://chromium-review.googlesource.com/c/1265595Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598761}

https://skia.googlesource.com/skia.git/+log/43a5497bf643..9c37cd96e4c8


git log 43a5497bf643..9c37cd96e4c8 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 brianosman@google.com Revert "Fix image info checking for always-opaque color types"
2018-10-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2018-10-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f955bdac1ce6..956ab4d9fab3 (3 commits)
2018-10-10 caryclark@skia.org undo what was done
2018-10-10 brianosman@google.com Fix image info checking for always-opaque color types
2018-10-10 caryclark@skia.org remove skirect makelargest from docs
2018-10-10 herb@google.com Small re-inline cleanup for GrGlyphCache
2018-10-10 reed@google.com Revert "remove unneeded flag SK_SUPPORT_LEGACY_RECTMAKELARGEST"
2018-10-10 mtklein@google.com Revert "SkTArray: clean up, no change to behaviour"
2018-10-10 reed@google.com remove unneeded flag SK_SUPPORT_LEGACY_RECTMAKELARGEST
2018-10-10 kjlubick@google.com Make CCPR optional
2018-10-10 halcanary@google.com SkPDF: more accurate (float) colors from paint
2018-10-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-10-10 halcanary@google.com SkTArray: clean up, no change to behaviour
2018-10-10 kjlubick@google.com Tweak to compile flags
2018-10-10 robertphillips@google.com Add --reduceOpListSplitting to a swath of bots
2018-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9d0bb3d4d5c0..f955bdac1ce6 (1 commits)
2018-10-10 mtklein@google.com consolidate SkBinaryWriteBuffers
2018-10-10 brianosman@google.com Use SkSurfaceValidateRasterInfo in some lesser-used canvas factories
2018-10-10 jvanverth@google.com Fix up SkImage_GpuYUVA MakePromiseYUVATexture
2018-10-10 robertphillips@google.com Fix yuv_to_rgb_effect GM
2018-10-10 csmartdalton@google.com ccpr: Use ceil/floor to round out path cover octagons
2018-10-10 kjlubick@google.com Remove old code size analysis
2018-10-10 kjlubick@google.com Track Skia's Code size in Flutter
2018-10-10 robertphillips@google.com Add reduceOpListSplitting flag
2018-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader aaaf93a38a83..d6126aea667e (1 commits)
2018-10-10 jvanverth@google.com Fix up degenerate quads


Created with:
  gclient setdep -r src/third_party/skia@9c37cd96e4c8

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel

BUG=chromium:891693,chromium:890698
TBR=stani@chromium.org

Change-Id: I550e140a0ef6050ef65c602263e4f0fc70544a78
Reviewed-on: https://chromium-review.googlesource.com/c/1275877Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598760}

Bug: 833764, 891721
Change-Id: I0a8f06b391765bcd911a4ccb4e1f0ba1a312b0c2
Reviewed-on: https://chromium-review.googlesource.com/c/1269706
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598759}

For a long time when setting a textBaseline on canvas we have been
rounding the returning values to always* use integers. This extra
round operation seems to be unnecessary now and it is actually
creating other alignment issues. This change fixes does alignment
problems with no noticeable regressions.

*For super tiny fonts (< 5px) we already returned floats.
(crbug.com/338908)

Bug: 890515
Change-Id: I099af9834aaf28bb2770e080bdb849eb729c18fd
Reviewed-on: https://chromium-review.googlesource.com/c/1260210Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598758}

Reports whether a parallel request successfully started, and its final
completion status.

Bug: 884751
Change-Id: Ic4c975bd22b7fca98c066970cb202b93e8c7ca8c
Reviewed-on: https://chromium-review.googlesource.com/c/1273150Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598757}

Disabling zoom and pan in this (odd special-)case leads to some weird
behavior, so just enable it instead to avoid confusion.

This takes care of one of the testcases mentioned in the referenced bug,
but does not address the real issue in any way.

Bug: 222786
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I25d9cbf9cd10c1631d64fddcd133014b9602bcba
Reviewed-on: https://chromium-review.googlesource.com/c/1275886Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#598756}

Bug: 892216
Change-Id: I728bde6f03e7896df093d1abb75027dba726fa47
Reviewed-on: https://chromium-review.googlesource.com/c/1269110Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598755}

This reverts commit 20990963.

Reason for revert: The revert did not fix crbug.com/883963.
Requested to re-run bisect.

Original change's description:
> Revert "Improve performance of PreviousBreakOpportunity"
> 
> This reverts commit 99d504fd.
> 
> Reason for revert:
> 
> crbug.com/883963 bisected to this CL. I'm not sure how this
> affects print preview, reverting to see the effect.
> 
> This revert may affect LayoutNG performance, but should not
> affect the currently shipping line breaker.
> 
> Original change's description:
> > Improve performance of PreviousBreakOpportunity
> >
> > In the current layout engine, PreviousBreakOpportunity is used
> > only when mid-word break (break-all or break-word), but it is
> > much more heavily used in LayoutNG.
> >
> > LazyLineBreakIterator is designed for forward only.
> > PreviousBreakOpportunity is implemented by repeatedly calling
> > NextBreakablePosition, but since NextBreakablePosition look
> > for the next break opportunity until the end of the string,
> > when a very long word without break opportunity is given,
> > PreviousBreakOpportunity is O(n!).
> >
> > This patch changes it to O(n) by limiting the end position
> > NextBreakablePosition can look for.
> >
> > blink/perf_tests/layout/word-break-break-word.html consumes
> > 78% of the total time in LayoutNG. The average run is:
> >   Current engine:    469ms
> >   LayoutNG:       26,644ms
> >   This patch:      2,250ms
> >
> > It's still 4-5 times slower, more improvements will be in
> > following patches.
> >
> > Bug: 636993
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
> > Change-Id: I814e2c45c8030aa682c7f5e3a3b785b3c0733c84
> > Reviewed-on: https://chromium-review.googlesource.com/1095894
> > Commit-Queue: Koji Ishii <kojii@chromium.org>
> > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#567133}
> 
> TBR=eae@chromium.org,kojii@chromium.org
> 
> Bug: 636993, 883963
> Change-Id: I2c453a011208b014e342d7b44646eb90b5b7bbd2
> Reviewed-on: https://chromium-review.googlesource.com/c/1270396
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#597876}

TBR=eae@chromium.org,kojii@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 636993, 883963
Change-Id: I8e9881deca736c5b574dc287d04f9c2fffe76680
Reviewed-on: https://chromium-review.googlesource.com/c/1275985Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598754}

Parsing of the form on saving may return empty result. For example
if all password fields are marked as credit card related fields.
In this case NewPasswordFormManager shouldn't be considered to be
submitted. Anyway it's not possible to save. This CL fixes a crash
on attempt to use parsed submitted form in OnLoginSuccessful.

Bug: 893672, 831123
Change-Id: Id0211f26ec1ba03d3659b41f815792e6a5d71a68
Reviewed-on: https://chromium-review.googlesource.com/c/1275888
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598753}

Bug: None
Change-Id: Ib0b805cd28e7e45f533d93f22d893e4298407b8a
Reviewed-on: https://chromium-review.googlesource.com/c/1273526
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598752}

Moving focus to/from a text field doesn't necessarily show/hide the
virtual keyboard.
For example, a hidden text field is automatically focused when opening
window switcher, but it should not cause the virtual keyboard show up.
This CL adds 2 new methods to ArcInputMethodManagerInstance interface to
control show/hide the virtual keyboard of ARC IMEs.
A caller of HideVirtualKeyboard() will be added later in a separate CL.

Bug: 845079
Test: Open window switcher, but ARC IME doesn't show up.
Change-Id: I538cf826d97a0d3bab49dd64075cde9b55494ac5
Reviewed-on: https://chromium-review.googlesource.com/c/1273395Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598751}

This CL removes the remaining voice bar support.

Bug: 800266
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I9b348cd4360ee692b228f972a6216ebcf8838350
Reviewed-on: https://chromium-review.googlesource.com/c/1251451Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598750}

https://boringssl.googlesource.com/boringssl/+log/ce00828c89df3d4c40de7d715b1a032eb03c525c..2d98d49cf712ca7dc6f4b23b9c5f5542385d8dbe

Bug: none
Change-Id: Ib79f15ec5c31b511551d4e87783dcda822fbfd28
Reviewed-on: https://chromium-review.googlesource.com/c/1274203
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598749}

This looks like it was hiding some sutble bugs, e.g. not running
microtasks, and not being able to create other objects correctly.

Change-Id: Ieb6ade2906aeedebdc6dc664470b38955c32811d
Reviewed-on: https://chromium-review.googlesource.com/c/1272438Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598748}

https://webrtc.googlesource.com/src.git/+log/e8d2b1be1a7c..2b1562632a02


git log e8d2b1be1a7c..2b1562632a02 --date=short --no-merges --format='%ad %ae %s'
2018-10-11 henrikg@webrtc.org Revert "Use unique_ptr and ArrayView in SSLFingerprint"
2018-10-11 saza@webrtc.org Don't CHECK when parsing AEC3 parameters from json
2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 24992897..f34485ff (598606:598711)
2018-10-11 danilchap@webrtc.org Use zero octets for rtp packet padding
2018-10-11 mbonadei@webrtc.org Reland "Export symbols needed by the Chromium component build (part 1)."
2018-10-11 sprang@webrtc.org Add ability to specify if rate controller of video encoder is trusted.
2018-10-11 nisse@webrtc.org Delete post_encode_callback
2018-10-11 peah@webrtc.org AEC3: Cleanup test code for platforms with clock-drift
2018-10-11 peah@webrtc.org AEC3: Ensure that the usage of stationary signal properties is not unset
2018-10-11 ilnik@webrtc.org Remove unlimited retransmission for screenshare experiment code
2018-10-11 steveanton@webrtc.org Use unique_ptr and ArrayView in SSLFingerprint


Created with:
  gclient setdep -r src/third_party/webrtc@2b1562632a02

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:894243
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Id36980209394996021f7bdff0bff127b39af7407
Reviewed-on: https://chromium-review.googlesource.com/c/1275876Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#598747}

This is a reland of f4c67a89

Original change's description:
> Elevation Service setup and COM registration.
> 
> Bug: 833687
> Change-Id: I1fef2e5ebac7ed44975996d67a43d1e26dc8ccb0
> Reviewed-on: https://chromium-review.googlesource.com/c/1244555
> Commit-Queue: S. Ganesh <ganesh@chromium.org>
> Reviewed-by: Greg Thompson <grt@chromium.org>
> Reviewed-by: Sorin Jianu <sorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598170}

Bug: 833687
Change-Id: I62ebfbc4a4992ddf0374a3be2432a7970ac4aaff
Reviewed-on: https://chromium-review.googlesource.com/c/1274835Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: S. Ganesh <ganesh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598746}

Bug: 801985
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia2dbd7056681a0dac843b4b55d03483f9e416923
Reviewed-on: https://chromium-review.googlesource.com/c/1270957Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598745}

This CL makes sure that iOS is correctly handling
AutocompleteProviderClientImpl::IsTabOpenWithURL for iOS, passing the
argument in the iOS AutocompleteSuggestion.

Bug: 893121
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia40621abf9a524c8531be8a268b71036fd1af6b7
Reviewed-on: https://chromium-review.googlesource.com/c/1268239Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598744}

The ClearCodeCache wasn't running earlier because the feature was
disabled. This cl uses ScopedFeatureList to enable it and also
also fix a bug in the implementation of the test.

Change-Id: Ia22abc84279271e2d093a617e787b34a80500efe
Reviewed-on: https://chromium-review.googlesource.com/c/1224440Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598743}

This allows us to skip touching the UI thread a couple of times when
creating a default audio output stream. This will save us a lot of
stream startup time in some cases (e.g. on Android the UI thread is
sometimes blocked for >100 ms).

To accomplish this, inner "Core" classes which are used on the IO
thread are extracted from RenderFrameAudio{Input,Output}Factory and
ForwardingAudioStreamFactory. The outer class is constructed from the
UI thread by RenderFrameHostImpl and WebContentsImpl, and the outer
class takes care of initializing the inner class.

This CL was reviewed in pieces at
https://chromium-review.googlesource.com/c/chromium/src/+/1225882
https://chromium-review.googlesource.com/c/chromium/src/+/1245797
https://chromium-review.googlesource.com/c/chromium/src/+/1251537
https://chromium-review.googlesource.com/c/chromium/src/+/1251608
and in this review (before PS 10).

Bug: 866440,852880,866442
Change-Id: I22117017b3cfa95ec6fb7895cabfc9e37a4f54b9
Reviewed-on: https://chromium-review.googlesource.com/c/1261978
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598742}

Use CTFont API to match by font descriptor using the
kCTFontNameAttribute key, which matches full font names as well as
postscript names. Return the the match result only if the font name
matches exactly either full font name or postscript name, to avoid
returning fallback fonts that CoreText may have given us.

Bug: 889503
Change-Id: I835725249a910c79e93bbe13db130d1950d0b49b
Reviewed-on: https://chromium-review.googlesource.com/c/1213090
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598741}

TBR=mgiuca@chromium.org

Bug: 876617
Change-Id: I096bf298978e9853b9e44471244523b97d50fcc1
Reviewed-on: https://chromium-review.googlesource.com/c/1275955Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598740}

This is a roll-back to V8 7.1.302. This is the most stable candidate out of the latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL before reverting it.

TBR=machenbach@chromium.org

Change-Id: I6c3ffe99cbd687bbef7b381ab4fdf38af2b58505
Reviewed-on: https://chromium-review.googlesource.com/c/1275952Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598739}

Bug: 668547
Change-Id: Iaba2654ae8f3940a803eede41b940f811e52c9ba
Reviewed-on: https://chromium-review.googlesource.com/c/1273990Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598738}

Bug: 806868
Change-Id: I6bc3696ea7f2a9d335c3163702b0b9f4b9314de6
Reviewed-on: https://chromium-review.googlesource.com/c/1268255
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598737}

Several layout test changes, but they're all minor and/or bug fixes
See: https://skia-review.googlesource.com/c/skia/+/161140

Change-Id: Iecd1436d46f0e6a0f44860f40ab3cf94ef9f6edc
Reviewed-on: https://chromium-review.googlesource.com/c/1273815
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598736}

This is a clean-up for previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1215512

Bug: 872138
Change-Id: I2be8ab98d9d42404936779bb55cba1a0c5f00742
Reviewed-on: https://chromium-review.googlesource.com/c/1275989Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@google.com>
Cr-Commit-Position: refs/heads/master@{#598735}

This reverts commit 07f45e13.

Reason for revert: broke compilation on Win
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/38615
../../chrome/browser/ui/views/policy/enterprise_startup_dialog_view.cc(171,15):  error: no member named 'SetTooltipText' in 'views::ImageView'; did you mean 'set_tooltip_text'?
  logo_image->SetTooltipText(
              ^~~~~~~~~~~~~~
              set_tooltip_text

Original change's description:
> Update GetAccessibleName() in view::ImageView and view::Button
> 
> This patch is updated duplicate code of tooltip text and accesible name
> 
> Bug: 890465
> Change-Id: I4ed08c50a91a216de5d647d0d137e8927129b6af
> Reviewed-on: https://chromium-review.googlesource.com/c/1256308
> Commit-Queue: Jongheon Kim <sapzape@gmail.com>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598729}

TBR=xiyuan@chromium.org,stevenjb@chromium.org,msw@chromium.org,jinho.bang@samsung.com,sapzape@gmail.com

Change-Id: Icd106f1c5e23a1a2f9322f867688f44809bd28b2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 890465
Reviewed-on: https://chromium-review.googlesource.com/c/1275856Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598734}

Assign corresponding crbugs to each separate test class.

BUG=841556

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iaa9a5f8f4499e3950332ac2c500073ae193f36e2
Reviewed-on: https://chromium-review.googlesource.com/c/1270940
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598733}

This CL is a sub-part of: [Don't delete subframes on CommitPending]
(https://chromium-review.googlesource.com/c/chromium/src/+/1122629/18)
RenderFrameHosts (subframes) are allowed to stay alive longer in the
background, the time needed for them to execute their unload handler.

The WebContentsTaskProvider needs to stop tracking all the frames in
pending deletion, not only the navigating one, but also its subframes.

Not doing it properly triggers a DCHECK:
---
// Whenever we have a task, we should have a main frame site instance.
DCHECK(tasks_by_frames_.empty() == (main_frame_site_instance_ == nullptr));
---
With tasks_by_frames_ not being empty, but main_frame_site_instance being
null after removing the old_frame in RenderFrameHostChanged.


Bug: 609963
Change-Id: I6e4ad45fb0d47ab378396e9ea1ad97bfc27c9c31
Reviewed-on: https://chromium-review.googlesource.com/c/1163502
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598732}

A new factory function, createCSSStyleSheetSync will allow synchronous
creation of CSSStyleSheet objects that have text but do not have
@import rules. If the sheet text turn out to have @import rules, an
exception will be thrown.

Draft spec at: https://wicg.github.io/construct-stylesheets/
Discussion: https://github.com/WICG/construct-stylesheets/issues/38#issuecomment-423355490

Bug: 807560
Change-Id: I9f8ef4151f616ecc343a12f3ddd0e5a31e1be363
Reviewed-on: https://chromium-review.googlesource.com/c/1237803
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598731}

In jumbo builds many cc files compile together in the same
translation unit, and thus share the same anonymous namespace.
That means that constants need to have unique names in the
whole build target, and not just unique in the file.

This renames two constants, one that was just added/copied and
one that already existed to give them more descriptive, and
unique, names.

TBR=maxlg@chromium.org,skobes@chromium.org

Bug: 893068
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I45ec9852370fb5572fd53e21136a21f1dd14e220
Reviewed-on: https://chromium-review.googlesource.com/c/1275891Reviewed-by: Daniel Bratell <bratell@opera.com>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#598730}

This patch is updated duplicate code of tooltip text and accesible name

Bug: 890465
Change-Id: I4ed08c50a91a216de5d647d0d137e8927129b6af
Reviewed-on: https://chromium-review.googlesource.com/c/1256308
Commit-Queue: Jongheon Kim <sapzape@gmail.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598729}